GitLab

rhythmbox-client: flush dbus connection to send the 'quit' message before process exit

See merge request !88

This was an issue in single core / uniprocessor / VMs, where
rhythmbox-client process exits due to 'exit()' call, before the 'quit'
message is sent to the rhythmbox instance.

Also refer: glib#2284

If the stream isn't currently linked, we won't get anything useful
by querying the pipeline position, instead query the stream.

If the stream doesn't even have a decoder pad yet, we can't try to
play it, so instead wait for preroll to finish.

If the stream is already buffered when preroll finishes, waiting
for buffering to finish after that won't get us anywhere.

In some situations this can be called concurrently on two threads,
so it needs more protection.

If we get a Requested Range Not Satisfiable response, we can't
resume a partial download, so we have to retry from the start.
Some podcast hosts do this despite advertising support for range
requests.

all: Update application ID to org.gnome.Rhythmbox3

See merge request !57

In 1.18, the identity element now provides a clock for the pipeline
based on the system clock, which screws up timing in the output
section of the xfade pipeline.  Switching to volume avoids this, and
since it's left in passthrough mode, doesn't cost us anything.

Some podcast hosts do not handle HEAD requests correctly, giving
incorrect filenames and sizes, so request the first byte of the file
instead.

Now the parser updates an existing RBPodcastChannel rather than filling out
a new one, which simplifies things a little bit for the podcast add dialog.

Switch to totem_pl_parser_parse_async so we don't have to manage
threads, and move mime type checking and other error handling out
to the podcast manager code to simplify the parser interface.

RhythmDBQueryResultList gives us a simpler way to do this.

This stops the search results jumping around as the images load, and
makes the layout consistent when non-square images appear.

Leaving the partial download lying around means we'll resume it on next
startup.  Deleting it seems like a better match for the intent.

This can race with the download task, so we should wait until the
task callback instead.

Song info ui fixes

See merge request !50

rating: emit 'rated' signal when rating is updated via keyboard too

Closes #1773

See merge request !49

lyrics: disable winampcn parser as its servers aren't talking

Closes #1829

See merge request !84

Prefix the rhythmbox-device .desktop file with the application ID so
that it gets exported when built via Flatpak.

No functional changes.

The D-Bus service and the Flathub Flatpak were already using
org.gnome.Rhythmbox as the application ID. Rename the appdata,
desktop and application icons to match that app-id.

Closes: #1822

Now that we do a HEAD request first, we can check for a partial download
even if the download location isn't set on the episode.

This lets us get the file size before we ask for a range from the server,
so if we have the full file already, we don't get a 'range not satisfiable'
error.

This was particularly annoying when selecting a property to show a
popup menu for it - the view would scroll so the property was in the
middle, but the menu would be shown next to the pointer.

Fixes: #1829