1. 14 Sep, 2008 1 commit
  2. 13 Sep, 2008 9 commits
  3. 12 Sep, 2008 1 commit
  4. 11 Sep, 2008 3 commits
    • Goran Rakic's avatar
      Updated Serbian translation (by Miloš Popović) · 2d793989
      Goran Rakic authored
      svn path=/trunk/; revision=5908
      2d793989
    • Bastien Nocera's avatar
      Change the default Podcast location to ~/Music (ie. the XDG user dir for · 8a6133a0
      Bastien Nocera authored
      2008-09-11  Bastien Nocera  <hadess@hadess.net>
      
      	* podcast/rb-podcast-manager.c
      	(rb_podcast_manager_get_podcast_dir):
      	Change the default Podcast location to ~/Music (ie. the XDG user dir
      	for music), or ~/ if it doesn't exist (Closes: #357768)
      
      
      svn path=/trunk/; revision=5907
      8a6133a0
    • Bastien Nocera's avatar
      Forbid podcasts from showing up in the main library, by using the local · e83cc207
      Bastien Nocera authored
      2008-09-11  Bastien Nocera  <hadess@hadess.net>
      
      	* podcast/rb-feed-podcast-properties-dialog.c
      	(rb_feed_podcast_properties_dialog_update_location):
      	* podcast/rb-podcast-manager.c (get_download_location),
      	(set_download_location), (get_remote_location),
      	(rb_podcast_manager_download_entry),
      	(rb_podcast_manager_entry_downloaded),
      	(rb_podcast_manager_head_query_cb), (download_error),
      	(rb_podcast_manager_next_file), (download_file_info_cb),
      	(rb_podcast_manager_save_metadata), (download_progress),
      	(podcast_download_thread), (end_job), (cancel_job),
      	(rb_podcast_manager_db_entry_deleted_cb),
      	(remove_if_not_downloaded):
      	* podcast/rb-podcast-properties-dialog.c
      	(rb_podcast_properties_dialog_update_location),
      	(rb_podcast_properties_dialog_update_download_location):
      	* rhythmdb/rhythmdb-tree.c (rhythmdb_tree_parser_start_element),
      	(rhythmdb_tree_parser_end_element):
      	* rhythmdb/rhythmdb.c (process_deleted_entries_cb):
      	Forbid podcasts from showing up in the main library, by using
      	the local download location to identify the file as soon as we start
      	downloading it (Closes: #323440)
      
      	* tests/podcast-upgrade.xml:
      	* tests/test-rhythmdb.c (START_TEST), (rhythmdb_suite), (main):
      	Add a test for the database upgrade code above
      
      
      svn path=/trunk/; revision=5906
      e83cc207
  5. 10 Sep, 2008 5 commits
    • Jorge Gonzalez Gonzalez's avatar
      Updated Spanish translation, fixes bug #551690 · c5db563c
      Jorge Gonzalez Gonzalez authored
      svn path=/trunk/; revision=5905
      c5db563c
    • Bastien Nocera's avatar
      Fix audiocd activation from nautilus · 181b1089
      Bastien Nocera authored
      2008-09-10  Bastien Nocera  <hadess@hadess.net>
      
      	* plugins/audiocd/rb-audiocd-source.c (impl_want_uri): Fix audiocd
      	activation from nautilus
      
      
      svn path=/trunk/; revision=5904
      181b1089
    • Bastien Nocera's avatar
      Fix impl_want_uri to detect roots of device properly (Closes: #551653) · 47d7e7ca
      Bastien Nocera authored
      2008-09-10  Bastien Nocera  <hadess@hadess.net>
      
      	* sources/rb-removable-media-source.c (impl_want_uri):
      	Fix impl_want_uri to detect roots of device properly (Closes: #551653)
      
      
      svn path=/trunk/; revision=5903
      47d7e7ca
    • Jonathan Matthew's avatar
      Our sanitize_path function(s) are used for building URIs, not paths, so we · 90715c7e
      Jonathan Matthew authored
      2008-09-10  Jonathan Matthew  <jonathan@d14n.org>
      
      	* plugins/generic-player/rb-generic-player-source.c:
      	(sanitize_path):
      	* sources/rb-library-source.c: (sanitize_path), (impl_paste):
      	Our sanitize_path function(s) are used for building URIs, not paths,
      	so we need to use g_uri_escape_string rather than
      	g_filename_from_utf8; also make library destination URIs safe for the
      	target filesystem.  Fixes #550117.
      
      svn path=/trunk/; revision=5902
      90715c7e
    • Jonathan Matthew's avatar
      If we get a generic 'failed' error here, continue with the download · 16d47b3e
      Jonathan Matthew authored
      2008-09-10  Jonathan Matthew  <jonathan@d14n.org>
      
      	* podcast/rb-podcast-manager.c: (download_file_info_cb):
      	If we get a generic 'failed' error here, continue with the download
      	anyway.  Things like 'file not found' and 'permission denied' will
      	still be reported correctly.  If the file info query fails, use the
      	basename from the original URI for the downloaded file.
      
      	(download_progress):
      	Make the debug output a bit less obnoxious.
      	
      	(podcast_download_thread):
      	If we didn't get it from the file info query, try to get the download
      	size from the stream.  This doesn't actually work yet.
      
      	Fixes #551540.
      
      svn path=/trunk/; revision=5901
      16d47b3e
  6. 09 Sep, 2008 3 commits
  7. 08 Sep, 2008 1 commit
    • Bastien Nocera's avatar
      Link against libgstcdda, and access the tags directly to get the duration · 0d756c0b
      Bastien Nocera authored
      2008-09-09  Bastien Nocera  <hadess@hadess.net>
      
      	* configure.ac:
      	* plugins/audiocd/Makefile.am:
      	* plugins/audiocd/rb-audiocd-source.c
      	(rb_audiocd_create_track_entry): Link against libgstcdda,
      	and access the tags directly to get the duration of the tracks,
      	avoids a lot of slow seeking on the CD, and makes loading CDs
      	awfully fast (Helps: #551011)
      
      
      svn path=/trunk/; revision=5897
      0d756c0b
  8. 07 Sep, 2008 6 commits
    • Jonathan Matthew's avatar
      Add 24x24 app icon for reasons no one seems to be able to explain. Icon · ee307dde
      Jonathan Matthew authored
      2008-09-07  Jonathan Matthew  <jonathan@d14n.org>
      
      	* configure.ac:
      	* data/icons/hicolor/24x24/Makefile.am:
      	* data/icons/hicolor/24x24/apps/Makefile.am:
      	* data/icons/hicolor/Makefile.am:
      	Add 24x24 app icon for reasons no one seems to be able to explain.
      	Icon apparently made by Jones Lee  <joneslee85@gmail.com>.
      	Fixes #524079.
      
      svn path=/trunk/; revision=5896
      ee307dde
    • Philip Withnall's avatar
      Updated British English translation and fixed a bad translation. (Closes: · c3f1756c
      Philip Withnall authored
      2008-09-07  Philip Withnall  <philip@tecnocode.co.uk>
      
      	* en_GB.po: Updated British English translation and fixed a bad
      	translation. (Closes: #540587)
      
      
      svn path=/trunk/; revision=5895
      c3f1756c
    • Jonathan Matthew's avatar
      Fail a bit less vigorously for badly formed URIs. · d244c7c0
      Jonathan Matthew authored
      2008-09-07  Jonathan Matthew  <jonathan@d14n.org>
      
      	* lib/rb-file-helpers.c: (rb_uri_create_parent_dirs):
      	Fail a bit less vigorously for badly formed URIs.
      
      svn path=/trunk/; revision=5894
      d244c7c0
    • Jonathan Matthew's avatar
      Construct podcast download locations as URIs rather than file paths. Use · 7c194c58
      Jonathan Matthew authored
      2008-09-07  Jonathan Matthew  <jonathan@d14n.org>
      
      	* podcast/rb-podcast-manager.c: (download_file_info_cb),
      	(rb_podcast_manager_db_entry_deleted_cb),
      	(rb_podcast_manager_get_podcast_dir):
      	Construct podcast download locations as URIs rather than file paths.
      	Use rb_sanitize_uri_for_filesystem in case the podcast download
      	location is on a FAT filesystem.
      
      	* sources/rb-podcast-source.c:
      	Don't convert the selected URI into a path before setting the gconf
      	key, just use it as-is.
      
      	(rb_podcast_source_btn_file_change_cb):
      	* data/rhythmbox.schemas:  Mention that the podcast download
      	key is supposed to be a URI.
      
      	Fixes #536500, #415641.
      
      svn path=/trunk/; revision=5893
      7c194c58
    • Jonathan Matthew's avatar
      Ignore RAR files. · 25c0dd70
      Jonathan Matthew authored
      2008-09-07  Jonathan Matthew  <jonathan@d14n.org>
      
      	* metadata/rb-metadata-gst.c:  Ignore RAR files.
      
      svn path=/trunk/; revision=5892
      25c0dd70
    • Bastien Nocera's avatar
      Don't print out warnings when a mount doesn't have a corresponding volume · e8ed3d7e
      Bastien Nocera authored
      2008-09-07  Bastien Nocera  <hadess@hadess.net>
      
      	* plugins/ipod/rb-ipod-source.c (rb_ipod_is_mount_ipod):
      	* shell/rb-removable-media-manager.c
      	(rb_removable_media_manager_add_mount):
      	* sources/rb-removable-media-source.c (impl_want_uri):
      	Don't print out warnings when a mount doesn't have a corresponding
      	volume (Closes: #551178)
      
      
      svn path=/trunk/; revision=5891
      e8ed3d7e
  9. 06 Sep, 2008 3 commits
    • Jonathan Matthew's avatar
      patch partly by: Colin Leroy <colin at colino.net> · 5ef06b2d
      Jonathan Matthew authored
      2008-09-06  Jonathan Matthew  <jonathan@d14n.org>
      
      	patch partly by: Colin Leroy <colin at colino.net>
      
      	* lib/rb-file-helpers.c: (rb_sanitize_uri_for_filesystem):
      	Treat 'msdos' like vfat and fat.
      
      	* lib/rb-util.c: (rb_uri_get_filesystem_type):
      	If the URI we're checking doesn't exist, walk up the hierarchy until
      	we find something that does.  From #550117.
      
      svn path=/trunk/; revision=5890
      5ef06b2d
    • Jonathan Matthew's avatar
      During sink startup, pass error messages from stream bins to the normal · 79e1a1c7
      Jonathan Matthew authored
      2008-09-06  Jonathan Matthew  <jonathan@d14n.org>
      
      	* backends/gstreamer/rb-player-gst-xfade.c: (start_sink):
      	During sink startup, pass error messages from stream bins to the
      	normal message handler rather than assuming that they indicate a
      	problem with the sink.  From #550271.
      
      svn path=/trunk/; revision=5889
      79e1a1c7
    • Jonathan Matthew's avatar
      patch by: Ernst Persson <ernstp@gmail.com> · 041b6595
      Jonathan Matthew authored
      2008-09-06  Jonathan Matthew  <jonathan@d14n.org>
      
      	patch by:  Ernst Persson <ernstp@gmail.com>
      
      	* sources/rb-source-group.h:
      	Move the device source group above the playlist group.
      	Fixes #487618.
      
      svn path=/trunk/; revision=5888
      041b6595
  10. 05 Sep, 2008 8 commits