3.4.4: build fails with latest check 1.5.x
Fedora rawhide.
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/rhythmbox-3.4.4/tests'
/bin/sh ../libtool --tag=CC --mode=link gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -flto=auto -flto-partition=none -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -flto=auto -flto-partition=none -fuse-linker-plugin -o bench-rhythmdb-load bench-rhythmdb-load.o -lcheck ../rhythmdb/librhythmdb.la ../metadata/librbmetadata.la ../widgets/librbwidgets.la ../podcast/librbpodcast.la ../lib/librb.la -lX11 -lsoup-2.4 -lglib-2.0 -lpeas-gtk-1.0 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lpeas-1.0 -Wl,--export-dynamic -lgmodule-2.0 -pthread -lglib-2.0 -lgirepository-1.0 -lxml2 -ltdb -ljson-glib-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lgstpbutils-1.0 -lgstaudio-1.0 -lgstvideo-1.0 -lgstbase-1.0 -lgsttag-1.0 -lgstreamer-1.0 -lgobject-2.0 -lglib-2.0 -lz
libtool: link: gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -flto=auto -flto-partition=none -Wl,-z -Wl,relro -Wl,--as-needed -Wl,-z -Wl,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -flto=auto -flto-partition=none -fuse-linker-plugin -o bench-rhythmdb-load bench-rhythmdb-load.o -Wl,--export-dynamic -pthread -lcheck ../rhythmdb/.libs/librhythmdb.a -lm ../metadata/.libs/librbmetadata.a ../widgets/.libs/librbwidgets.a -lnotify ../podcast/.libs/librbpodcast.a ../lib/.libs/librb.a -lX11 -lsoup-2.4 -lpeas-gtk-1.0 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lpeas-1.0 -lgmodule-2.0 -lgirepository-1.0 -lxml2 -ltdb -ljson-glib-1.0 -lgio-2.0 -lgstpbutils-1.0 -lgstaudio-1.0 -lgstvideo-1.0 -lgstbase-1.0 -lgsttag-1.0 -lgstreamer-1.0 -lgobject-2.0 -lglib-2.0 -lz -pthread
/bin/sh ../libtool --tag=CC --mode=link gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -flto=auto -flto-partition=none -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -flto=auto -flto-partition=none -fuse-linker-plugin -o test-rb-lib test-rb-lib.o test-utils.o -lcheck ../rhythmdb/librhythmdb.la ../metadata/librbmetadata.la ../widgets/librbwidgets.la ../podcast/librbpodcast.la ../lib/librb.la -lX11 -lsoup-2.4 -lglib-2.0 -lpeas-gtk-1.0 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lpeas-1.0 -Wl,--export-dynamic -lgmodule-2.0 -pthread -lglib-2.0 -lgirepository-1.0 -lxml2 -ltdb -ljson-glib-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lgstpbutils-1.0 -lgstaudio-1.0 -lgstvideo-1.0 -lgstbase-1.0 -lgsttag-1.0 -lgstreamer-1.0 -lgobject-2.0 -lglib-2.0 -lz
libtool: link: gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -flto=auto -flto-partition=none -Wl,-z -Wl,relro -Wl,--as-needed -Wl,-z -Wl,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -flto=auto -flto-partition=none -fuse-linker-plugin -o test-rb-lib test-rb-lib.o test-utils.o -Wl,--export-dynamic -pthread -lcheck ../rhythmdb/.libs/librhythmdb.a -lm ../metadata/.libs/librbmetadata.a ../widgets/.libs/librbwidgets.a -lnotify ../podcast/.libs/librbpodcast.a ../lib/.libs/librb.a -lX11 -lsoup-2.4 -lpeas-gtk-1.0 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lpeas-1.0 -lgmodule-2.0 -lgirepository-1.0 -lxml2 -ltdb -ljson-glib-1.0 -lgio-2.0 -lgstpbutils-1.0 -lgstaudio-1.0 -lgstvideo-1.0 -lgstbase-1.0 -lgsttag-1.0 -lgstreamer-1.0 -lgobject-2.0 -lglib-2.0 -lz -pthread
/bin/sh ../libtool --tag=CC --mode=link gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -flto=auto -flto-partition=none -Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -flto=auto -flto-partition=none -fuse-linker-plugin -o test-rhythmdb test-rhythmdb.o test-utils.o -lcheck ../rhythmdb/librhythmdb.la ../metadata/librbmetadata.la ../widgets/librbwidgets.la ../podcast/librbpodcast.la ../lib/librb.la -lX11 -lsoup-2.4 -lglib-2.0 -lpeas-gtk-1.0 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lpeas-1.0 -Wl,--export-dynamic -lgmodule-2.0 -pthread -lglib-2.0 -lgirepository-1.0 -lxml2 -ltdb -ljson-glib-1.0 -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lgstpbutils-1.0 -lgstaudio-1.0 -lgstvideo-1.0 -lgstbase-1.0 -lgsttag-1.0 -lgstreamer-1.0 -lgobject-2.0 -lglib-2.0 -lz
libtool: link: gcc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -flto=auto -flto-partition=none -Wl,-z -Wl,relro -Wl,--as-needed -Wl,-z -Wl,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -flto=auto -flto-partition=none -fuse-linker-plugin -o test-rhythmdb test-rhythmdb.o test-utils.o -Wl,--export-dynamic -pthread -lcheck ../rhythmdb/.libs/librhythmdb.a -lm ../metadata/.libs/librbmetadata.a ../widgets/.libs/librbwidgets.a -lnotify ../podcast/.libs/librbpodcast.a ../lib/.libs/librb.a -lX11 -lsoup-2.4 -lpeas-gtk-1.0 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lpeas-1.0 -lgmodule-2.0 -lgirepository-1.0 -lxml2 -ltdb -ljson-glib-1.0 -lgio-2.0 -lgstpbutils-1.0 -lgstaudio-1.0 -lgstvideo-1.0 -lgstbase-1.0 -lgsttag-1.0 -lgstreamer-1.0 -lgobject-2.0 -lglib-2.0 -lz -pthread
gcc -DHAVE_CONFIG_H -I. -I.. -DGNOMELOCALEDIR=\""/usr/share/locale"\" -DG_LOG_DOMAIN=\"Rhythmbox-tests\" -I.. -I/usr/include/gobject-introspection-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/atk-1.0 -I/usr/include/gio-unix-2.0 -I/usr/include/libsoup-2.4 -I/usr/include/libpeas-1.0 -pthread -I/usr/include/libxml2 -I/usr/include/json-glib-1.0 -I/usr/include/gstreamer-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/orc-0.4 -pthread -DGST_USE_UNSTABLE_API -I../lib -I../metadata -I../widgets -I../rhythmdb -I../podcast -I../plugins/audioscrobbler -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -flto=auto -flto-partition=none -c -o test-rhythmdb-query-model.o test-rhythmdb-query-model.c
test-rhythmdb-query-model.c: In function ‘test_query_eval’:
test-rhythmdb-query-model.c:50:2: error: format not a string literal and no format arguments [-Werror=format-security]
50 | fail_unless (rhythmdb_evaluate_query (db, processed, entry) == expected, what);
| ^~~~~~~~~~~
test-rhythmdb-query-model.c:56:2: error: format not a string literal and no format arguments [-Werror=format-security]
56 | fail_unless (rhythmdb_query_model_entry_to_iter (model, entry, &iter) == expected, what);
| ^~~~~~~~~~~
In file included from test-rhythmdb-query-model.c:30:
test-rhythmdb-query-model.c: In function ‘test_hidden_chain_filter_fn’:
test-rhythmdb-query-model.c:250:2: error: too few arguments to function ‘_ck_assert_failed’
250 | fail_unless (rhythmdb_query_model_entry_to_iter (base_model, entry, &iter));
| ^~~~~~~~~~~
/usr/include/check.h:502:27: note: declared here
502 | CK_DLL_EXP void CK_EXPORT _ck_assert_failed(const char *file, int line,
| ^~~~~~~~~~~~~~~~~
test-rhythmdb-query-model.c:251:2: error: too few arguments to function ‘_ck_assert_failed’
251 | fail_unless (rhythmdb_query_model_entry_to_iter (filter_model, entry, &iter));
| ^~~~~~~~~~~
/usr/include/check.h:502:27: note: declared here
502 | CK_DLL_EXP void CK_EXPORT _ck_assert_failed(const char *file, int line,
| ^~~~~~~~~~~~~~~~~
test-rhythmdb-query-model.c:262:2: error: too few arguments to function ‘_ck_assert_failed’
262 | fail_unless (rhythmdb_query_model_entry_to_iter (base_model, entry, &iter));
| ^~~~~~~~~~~
/usr/include/check.h:502:27: note: declared here
502 | CK_DLL_EXP void CK_EXPORT _ck_assert_failed(const char *file, int line,
| ^~~~~~~~~~~~~~~~~
test-rhythmdb-query-model.c:263:2: error: too few arguments to function ‘_ck_assert_failed’
263 | fail_if (rhythmdb_query_model_entry_to_iter (filter_model, entry, &iter));
| ^~~~~~~
/usr/include/check.h:502:27: note: declared here
502 | CK_DLL_EXP void CK_EXPORT _ck_assert_failed(const char *file, int line,
| ^~~~~~~~~~~~~~~~~
test-rhythmdb-query-model.c:274:2: error: too few arguments to function ‘_ck_assert_failed’
274 | fail_unless (rhythmdb_query_model_entry_to_iter (base_model, entry, &iter));
| ^~~~~~~~~~~
/usr/include/check.h:502:27: note: declared here
502 | CK_DLL_EXP void CK_EXPORT _ck_assert_failed(const char *file, int line,
| ^~~~~~~~~~~~~~~~~
test-rhythmdb-query-model.c:275:2: error: too few arguments to function ‘_ck_assert_failed’
275 | fail_unless (rhythmdb_query_model_entry_to_iter (filter_model, entry, &iter));
| ^~~~~~~~~~~
/usr/include/check.h:502:27: note: declared here
502 | CK_DLL_EXP void CK_EXPORT _ck_assert_failed(const char *file, int line,
| ^~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[2]: *** [Makefile:911: test-rhythmdb-query-model.o] Error 1
Edited by Tomasz Kłoczko