1. 27 Jun, 2012 1 commit
  2. 06 Apr, 2012 1 commit
  3. 29 Mar, 2012 1 commit
    • Jonathan Matthew's avatar
      header: degrade gracefully when reduced in size · 34fab57a
      Jonathan Matthew authored
      Rather than vanishing when the widgets within the header don't
      have enough space, hide things to make the remaining stuff fit.
      First the song info disappears, then the elapsed time, then the
      position slider.
      34fab57a
  4. 28 Mar, 2012 1 commit
    • Jonathan Matthew's avatar
      new more compact header layout · cc6633bb
      Jonathan Matthew authored
      Now we have the playback controls, the current track information
      (now including album art), the time display (which can be toggled
      between elapsed and remaining time), the position slider (much
      shorter than before) and the volume control on the same line.
      
      With this layout it makes no sense to hide the toolbar, so that
      option is no longer available.  It also makes no sense to use
      a toolbar style other than 'text below icons', so this option
      has been removed too.
      
      Small display mode is also gone.  It needs to be reimplemented
      as a separate window.
      
      This took me far too long land.
      cc6633bb
  5. 28 Feb, 2012 1 commit
  6. 09 Apr, 2011 1 commit
    • Jonathan Matthew's avatar
      port all core code to use GSettings · cf02733f
      Jonathan Matthew authored
      A couple of general notes, for future reference:
      - widgets don't know anything about GSettings, instead they expose
        properties that can be bound to settings keys
      - when a settings key is used to store a value controlled by a slider
        or pane widget, the key is only updated once the value has gone
        unchanged for 500ms (using rb_settings_delayed_sync); writing on
        each value notification is extremely slow.
      cf02733f
  7. 20 Mar, 2010 1 commit
  8. 07 Mar, 2010 1 commit
    • Uri Sivan's avatar
      header: fix display of mixed-direction text (bug #610753) · 05050be6
      Uri Sivan authored
      When the track details displayed in the header widget contain
      mixed-direction text, use Unicode text direction marks to get the text
      to display correctly, and use a direction-neutral separator rather than
      verbal ones.
      05050be6
  9. 21 Feb, 2010 1 commit
  10. 02 Jan, 2010 1 commit
  11. 04 Dec, 2009 1 commit
  12. 11 Nov, 2009 1 commit
  13. 08 Nov, 2009 1 commit
  14. 21 Jul, 2009 1 commit
  15. 05 Jun, 2009 1 commit
  16. 24 Feb, 2009 1 commit
    • Jonathan Matthew's avatar
      patch by: Neil Loknath <neil.loknath@gmail.com> · 92d9d1bf
      Jonathan Matthew authored
      2009-02-24  Jonathan Matthew  <jonathan@d14n.org>
      
      	patch by:  Neil Loknath  <neil.loknath@gmail.com>
      
      	* widgets/rb-header.c: (rb_header_init), (slider_scroll_callback):
      	Handle scroll events on the slider to make the seek direction
      	consistent with totem.  Fixes #164351.
      
      svn path=/trunk/; revision=6162
      92d9d1bf
  17. 01 Oct, 2008 1 commit
    • William Jon McCann's avatar
      Fix one of the grammatical errors in the license exception. From #513617 · 39fcb426
      William Jon McCann authored
      2008-10-01  William Jon McCann  <jmccann@redhat.com>
      
      	* backends/gstreamer/rb-encoder-gst.c:
      	* backends/gstreamer/rb-encoder-gst.h:
      	* backends/gstreamer/rb-player-gst-xfade.c:
      	* backends/gstreamer/rb-player-gst-xfade.h:
      	* backends/gstreamer/rb-player-gst.c:
      	* backends/gstreamer/rb-player-gst.h:
      	* backends/rb-encoder.c:
      	* backends/rb-encoder.h:
      	* backends/rb-player-gst-data-tee.c:
      	* backends/rb-player-gst-data-tee.h:
      	* backends/rb-player-gst-filter.c:
      	* backends/rb-player-gst-filter.h:
      	* backends/rb-player-gst-tee.c:
      	* backends/rb-player-gst-tee.h:
      	* backends/rb-player.c:
      	* backends/rb-player.h:
      	* bindings/python/override_common.c:
      	* bindings/python/override_common.h:
      	* lib/rb-async-queue-watch.c:
      	* lib/rb-async-queue-watch.h:
      	* lib/rb-debug.c:
      	* lib/rb-debug.h:
      	* lib/rb-file-helpers.c:
      	* lib/rb-file-helpers.h:
      	* lib/rb-glade-helpers.c:
      	* lib/rb-glade-helpers.h:
      	* lib/rb-preferences.h:
      	* lib/rb-proxy-config.c:
      	* lib/rb-proxy-config.h:
      	* lib/rb-stock-icons.c:
      	* lib/rb-stock-icons.h:
      	* lib/rb-string-value-map.c:
      	* lib/rb-string-value-map.h:
      	* lib/rb-thread.c:
      	* lib/rb-thread.h:
      	* lib/rb-util.c:
      	* lib/rb-util.h:
      	* metadata/rb-metadata-common.c:
      	* metadata/rb-metadata-dbus-client.c:
      	* metadata/rb-metadata-dbus-service.c:
      	* metadata/rb-metadata-dbus.c:
      	* metadata/rb-metadata-dbus.h:
      	* metadata/rb-metadata-gst.c:
      	* metadata/rb-metadata.h:
      	* metadata/test-metadata.c:
      	* plugins/artdisplay/artdisplay/AmazonCoverArtSearch.py:
      	* plugins/artdisplay/artdisplay/CoverArtDatabase.py:
      	* plugins/artdisplay/artdisplay/LocalCoverArtSearch.py:
      	* plugins/artdisplay/artdisplay/PodcastCoverArtSearch.py:
      	* plugins/artdisplay/artdisplay/__init__.py:
      	* plugins/audiocd/rb-audiocd-plugin.c:
      	* plugins/audiocd/rb-audiocd-source.c:
      	* plugins/audiocd/rb-audiocd-source.h:
      	* plugins/audioscrobbler/rb-audioscrobbler-entry.c:
      	* plugins/audioscrobbler/rb-audioscrobbler-entry.h:
      	* plugins/audioscrobbler/rb-audioscrobbler-plugin.c:
      	* plugins/audioscrobbler/rb-audioscrobbler.c:
      	* plugins/audioscrobbler/rb-audioscrobbler.h:
      	* plugins/audioscrobbler/rb-lastfm-source.c:
      	* plugins/audioscrobbler/rb-lastfm-source.h:
      	* plugins/cd-recorder/rb-cd-recorder-plugin.c:
      	* plugins/cd-recorder/rb-playlist-source-recorder.c:
      	* plugins/cd-recorder/rb-playlist-source-recorder.h:
      	* plugins/cd-recorder/rb-recorder-gst.c:
      	* plugins/cd-recorder/rb-recorder.h:
      	* plugins/daap/rb-daap-connection.c:
      	* plugins/daap/rb-daap-connection.h:
      	* plugins/daap/rb-daap-dialog.c:
      	* plugins/daap/rb-daap-dialog.h:
      	* plugins/daap/rb-daap-hash.c:
      	* plugins/daap/rb-daap-hash.h:
      	* plugins/daap/rb-daap-mdns-browser-avahi.c:
      	* plugins/daap/rb-daap-mdns-browser.h:
      	* plugins/daap/rb-daap-mdns-publisher-avahi.c:
      	* plugins/daap/rb-daap-mdns-publisher.h:
      	* plugins/daap/rb-daap-plugin.c:
      	* plugins/daap/rb-daap-plugin.h:
      	* plugins/daap/rb-daap-share.c:
      	* plugins/daap/rb-daap-share.h:
      	* plugins/daap/rb-daap-sharing.c:
      	* plugins/daap/rb-daap-sharing.h:
      	* plugins/daap/rb-daap-source.c:
      	* plugins/daap/rb-daap-source.h:
      	* plugins/daap/rb-daap-src.c:
      	* plugins/daap/rb-daap-src.h:
      	* plugins/daap/rb-daap-structure.c:
      	* plugins/daap/rb-daap-structure.h:
      	* plugins/fmradio/rb-fm-radio-gst-src.c:
      	* plugins/fmradio/rb-fm-radio-plugin.c:
      	* plugins/fmradio/rb-fm-radio-source.c:
      	* plugins/fmradio/rb-fm-radio-source.h:
      	* plugins/fmradio/rb-radio-tuner-v4l2.c:
      	* plugins/fmradio/rb-radio-tuner.h:
      	* plugins/generic-player/rb-generic-player-playlist-source.c:
      	* plugins/generic-player/rb-generic-player-playlist-source.h:
      	* plugins/generic-player/rb-generic-player-plugin.c:
      	* plugins/generic-player/rb-generic-player-source.c:
      	* plugins/generic-player/rb-generic-player-source.h:
      	* plugins/generic-player/rb-nokia770-source.c:
      	* plugins/generic-player/rb-nokia770-source.h:
      	* plugins/generic-player/rb-psp-source.c:
      	* plugins/generic-player/rb-psp-source.h:
      	* plugins/ipod/rb-ipod-db.c:
      	* plugins/ipod/rb-ipod-db.h:
      	* plugins/ipod/rb-ipod-plugin.c:
      	* plugins/ipod/rb-ipod-source.c:
      	* plugins/ipod/rb-ipod-source.h:
      	* plugins/iradio/rb-iradio-plugin.c:
      	* plugins/iradio/rb-iradio-source.c:
      	* plugins/iradio/rb-iradio-source.h:
      	* plugins/iradio/rb-station-properties-dialog.c:
      	* plugins/iradio/rb-station-properties-dialog.h:
      	* plugins/jamendo/jamendo/__init__.py:
      	* plugins/lirc/rb-lirc-plugin.c:
      	* plugins/lyrics/lyrics/AstrawebParser.py:
      	* plugins/lyrics/lyrics/LeoslyricsParser.py:
      	* plugins/lyrics/lyrics/LyrcParser.py:
      	* plugins/lyrics/lyrics/LyricWikiParser.py:
      	* plugins/lyrics/lyrics/LyricsConfigureDialog.py:
      	* plugins/lyrics/lyrics/LyricsParse.py:
      	* plugins/lyrics/lyrics/WinampcnParser.py:
      	* plugins/lyrics/lyrics/__init__.py:
      	* plugins/magnatune/magnatune/BuyAlbumHandler.py:
      	* plugins/magnatune/magnatune/MagnatuneSource.py:
      	* plugins/magnatune/magnatune/TrackListHandler.py:
      	* plugins/magnatune/magnatune/__init__.py:
      	* plugins/mmkeys/rb-mmkeys-plugin.c:
      	* plugins/mtpdevice/rb-mtp-plugin.c:
      	* plugins/mtpdevice/rb-mtp-source.c:
      	* plugins/mtpdevice/rb-mtp-source.h:
      	* plugins/power-manager/rb-power-manager-plugin.c:
      	* plugins/pythonconsole/pythonconsole.py:
      	* plugins/rb-module.c:
      	* plugins/rb-module.h:
      	* plugins/rb-plugin-manager.c:
      	* plugins/rb-plugin-manager.h:
      	* plugins/rb-plugin.c:
      	* plugins/rb-plugin.h:
      	* plugins/rb-plugins-engine.c:
      	* plugins/rb-plugins-engine.h:
      	* plugins/rb-python-module.c:
      	* plugins/rb-python-module.h:
      	* plugins/rb-python-plugin.c:
      	* plugins/rb-python-plugin.h:
      	* plugins/rb/Coroutine.py:
      	* plugins/rb/Loader.py:
      	* plugins/rb/__init__.py:
      	* plugins/sample/rb-sample-plugin.c:
      	* plugins/visualizer/rb-fake-visualizer.c:
      	* plugins/visualizer/rb-vis-widget.c:
      	* plugins/visualizer/rb-vis-widget.h:
      	* plugins/visualizer/rb-visualizer-plugin.c:
      	* podcast/rb-feed-podcast-properties-dialog.c:
      	* podcast/rb-feed-podcast-properties-dialog.h:
      	* podcast/rb-podcast-manager.c:
      	* podcast/rb-podcast-manager.h:
      	* podcast/rb-podcast-parse.c:
      	* podcast/rb-podcast-parse.h:
      	* podcast/rb-podcast-properties-dialog.c:
      	* podcast/rb-podcast-properties-dialog.h:
      	* podcast/test-podcast-parse.c:
      	* remote/dbus/rb-client.c:
      	* rhythmdb/rb-refstring.c:
      	* rhythmdb/rb-refstring.h:
      	* rhythmdb/rhythmdb-import-job.c:
      	* rhythmdb/rhythmdb-import-job.h:
      	* rhythmdb/rhythmdb-monitor.c:
      	* rhythmdb/rhythmdb-private.h:
      	* rhythmdb/rhythmdb-property-model.c:
      	* rhythmdb/rhythmdb-property-model.h:
      	* rhythmdb/rhythmdb-query-model.c:
      	* rhythmdb/rhythmdb-query-model.h:
      	* rhythmdb/rhythmdb-query-results.c:
      	* rhythmdb/rhythmdb-query-results.h:
      	* rhythmdb/rhythmdb-query.c:
      	* rhythmdb/rhythmdb-tree.c:
      	* rhythmdb/rhythmdb-tree.h:
      	* rhythmdb/rhythmdb.c:
      	* rhythmdb/rhythmdb.h:
      	* shell/main.c:
      	* shell/rb-history.c:
      	* shell/rb-history.h:
      	* shell/rb-play-order-linear-loop.c:
      	* shell/rb-play-order-linear-loop.h:
      	* shell/rb-play-order-linear.c:
      	* shell/rb-play-order-linear.h:
      	* shell/rb-play-order-queue.c:
      	* shell/rb-play-order-queue.h:
      	* shell/rb-play-order-random-by-age-and-rating.c:
      	* shell/rb-play-order-random-by-age-and-rating.h:
      	* shell/rb-play-order-random-by-age.c:
      	* shell/rb-play-order-random-by-age.h:
      	* shell/rb-play-order-random-by-rating.c:
      	* shell/rb-play-order-random-by-rating.h:
      	* shell/rb-play-order-random-equal-weights.c:
      	* shell/rb-play-order-random-equal-weights.h:
      	* shell/rb-play-order-random.c:
      	* shell/rb-play-order-random.h:
      	* shell/rb-play-order-shuffle.c:
      	* shell/rb-play-order-shuffle.h:
      	* shell/rb-play-order.c:
      	* shell/rb-play-order.h:
      	* shell/rb-playlist-manager.c:
      	* shell/rb-playlist-manager.h:
      	* shell/rb-removable-media-manager.c:
      	* shell/rb-removable-media-manager.h:
      	* shell/rb-shell-clipboard.c:
      	* shell/rb-shell-clipboard.h:
      	* shell/rb-shell-player.c:
      	* shell/rb-shell-player.h:
      	* shell/rb-shell-preferences.c:
      	* shell/rb-shell-preferences.h:
      	* shell/rb-shell.c:
      	* shell/rb-shell.h:
      	* shell/rb-source-header.c:
      	* shell/rb-source-header.h:
      	* shell/rb-statusbar.c:
      	* shell/rb-statusbar.h:
      	* shell/rb-tray-icon.c:
      	* shell/rb-tray-icon.h:
      	* sources/rb-auto-playlist-source.c:
      	* sources/rb-auto-playlist-source.h:
      	* sources/rb-browser-source.c:
      	* sources/rb-browser-source.h:
      	* sources/rb-import-errors-source.c:
      	* sources/rb-import-errors-source.h:
      	* sources/rb-library-source.c:
      	* sources/rb-library-source.h:
      	* sources/rb-missing-files-source.c:
      	* sources/rb-missing-files-source.h:
      	* sources/rb-play-queue-source.c:
      	* sources/rb-play-queue-source.h:
      	* sources/rb-playlist-source.c:
      	* sources/rb-playlist-source.h:
      	* sources/rb-playlist-xml.h:
      	* sources/rb-podcast-source.c:
      	* sources/rb-podcast-source.h:
      	* sources/rb-removable-media-source.c:
      	* sources/rb-removable-media-source.h:
      	* sources/rb-source-group.c:
      	* sources/rb-source-group.h:
      	* sources/rb-source.c:
      	* sources/rb-source.h:
      	* sources/rb-sourcelist-model.c:
      	* sources/rb-sourcelist-model.h:
      	* sources/rb-sourcelist.c:
      	* sources/rb-sourcelist.h:
      	* sources/rb-static-playlist-source.c:
      	* sources/rb-static-playlist-source.h:
      	* sources/rb-streaming-source.c:
      	* sources/rb-streaming-source.h:
      	* tests/bench-rhythmdb-load.c:
      	* tests/test-audioscrobbler.c:
      	* tests/test-file-helpers.c:
      	* tests/test-rb-lib.c:
      	* tests/test-rhythmdb-property-model.c:
      	* tests/test-rhythmdb-query-model.c:
      	* tests/test-rhythmdb-query.c:
      	* tests/test-rhythmdb-tree-serialization.c:
      	* tests/test-rhythmdb-view.c:
      	* tests/test-rhythmdb.c:
      	* tests/test-utils.c:
      	* tests/test-utils.h:
      	* widgets/gedit-message-area.c:
      	* widgets/gedit-message-area.h:
      	* widgets/rb-dialog.c:
      	* widgets/rb-dialog.h:
      	* widgets/rb-entry-view.c:
      	* widgets/rb-entry-view.h:
      	* widgets/rb-header.c:
      	* widgets/rb-header.h:
      	* widgets/rb-library-browser.c:
      	* widgets/rb-library-browser.h:
      	* widgets/rb-property-view.c:
      	* widgets/rb-property-view.h:
      	* widgets/rb-query-creator-private.h:
      	* widgets/rb-query-creator-properties.c:
      	* widgets/rb-query-creator.c:
      	* widgets/rb-query-creator.h:
      	* widgets/rb-rating-helper.c:
      	* widgets/rb-rating-helper.h:
      	* widgets/rb-rating.c:
      	* widgets/rb-rating.h:
      	* widgets/rb-search-entry.c:
      	* widgets/rb-search-entry.h:
      	* widgets/rb-song-info.c:
      	* widgets/rb-song-info.h:
      	* widgets/rb-uri-dialog.c:
      	* widgets/rb-uri-dialog.h:
      	Fix one of the grammatical errors in the license exception.
      	From #513617
      
      
      svn path=/trunk/; revision=5961
      39fcb426
  18. 28 Jun, 2008 1 commit
    • Jonathan Matthew's avatar
      If the seek slider is still being dragged when we reach EOS, wait until · 0b9135c2
      Jonathan Matthew authored
      2008-06-28  Jonathan Matthew  <jonathan@d14n.org>
      
      	* shell/rb-shell-player.c: (rb_shell_player_constructor),
      	(rb_shell_player_handle_eos_unlocked),
      	(rb_shell_player_slider_dragging_cb),
      	(rb_shell_player_set_playing_time), (tick_cb):
      	If the seek slider is still being dragged when we reach EOS, wait
      	until it's released; if a seek occurs before then, forget about it.
      	Fixes #140020.
      
      	* widgets/rb-header.c: (rb_header_class_init),
      	(rb_header_set_playing_entry_internal), (rb_header_set_property),
      	(rb_header_get_property), (rb_header_sync), (rb_header_sync_time),
      	(slider_press_callback), (slider_moved_timeout),
      	(slider_moved_callback), (apply_slider_position),
      	(slider_release_callback), (slider_changed_callback):
      	Add the 'slider-dragging' property used above.  Rearrange various
      	bits of code to behave a little bit better, most importantly removing
      	the idle handler that just screwed things up.  Set the upper bound on
      	the slider unconditionally when the playing entry changes, fixing
      	#496816.
      
      svn path=/trunk/; revision=5781
      0b9135c2
  19. 17 Apr, 2008 1 commit
  20. 22 Mar, 2008 1 commit
    • Jonathan Matthew's avatar
      Add gtk-doc for RBCellRendererPixbuf, RBEntryView, and RBHeader. · 6116cf99
      Jonathan Matthew authored
      2008-03-22  Jonathan Matthew  <jonathan@d14n.org>
      
      	* doc/reference/rhythmbox-sections.txt:
      	* widgets/rb-cell-renderer-pixbuf.c:
      	(rb_cell_renderer_pixbuf_class_init):
      	* widgets/rb-entry-view.c: (rb_entry_view_class_init),
      	(rb_entry_view_get_time_date_column_sample):
      	* widgets/rb-entry-view.h:
      	* widgets/rb-header.c: (rb_header_class_init),
      	(rb_header_sync_time):
      	* widgets/rb-header.h:
      	Add gtk-doc for RBCellRendererPixbuf, RBEntryView, and RBHeader.
      
      svn path=/trunk/; revision=5641
      6116cf99
  21. 21 Mar, 2008 1 commit
    • Jonathan Matthew's avatar
      Fix lots of gtk-doc warnings · efa6a7b8
      Jonathan Matthew authored
      2008-03-21  Jonathan Matthew  <jonathan@d14n.org>
      
      	* backends/rb-player.h:
      	* lib/rb-file-helpers.c:
      	* lib/rb-tree-dnd.c:
      	* lib/rb-util.c:
      	* plugins/audiocd/rb-audiocd-source.c:
      	* plugins/audiocd/sj-metadata-musicbrainz.c:
      	* plugins/daap/rb-daap-structure.h:
      	* remote/dbus/rb-client.c:
      	* rhythmdb/rhythmdb.c:
      	* rhythmdb/rhythmdb.h:
      	* shell/rb-history.c:
      	* shell/rb-history.h:
      	* shell/rb-play-order.h:
      	* shell/rb-playlist-manager.c:
      	* shell/rb-playlist-manager.h:
      	* sources/rb-library-source.c:
      	* tests/test-rhythmdb-query.c: (main):
      	* widgets/libsexy/sexy-icon-entry.c:
      	* widgets/rb-cell-renderer-rating.c:
      	* widgets/rb-cell-renderer-rating.h:
      	* widgets/rb-header.c: (rb_header_init):
      	* widgets/rb-library-browser.c: (rb_library_browser_class_init):
      	Fix lots of gtk-doc warnings
      	
      	* doc/reference/rhythmbox-sections.txt:
      	Massive update
      
      svn path=/trunk/; revision=5635
      efa6a7b8
  22. 13 Jan, 2008 1 commit
  23. 01 Jan, 2008 1 commit
    • Jonathan Matthew's avatar
      patch by: Jay Cornwall <jay@jcornwall.me.uk> · aba09291
      Jonathan Matthew authored
      2008-01-01  Jonathan Matthew  <jonathan@d14n.org>
      
      	patch by:  Jay Cornwall  <jay@jcornwall.me.uk>
      
      	* widgets/rb-header.c: (slider_release_callback):
      	Remove superfluous call to rb_header_sync_time that will mostly move
      	the slider to the wrong place.  Fixes #506641.
      
      svn path=/trunk/; revision=5522
      aba09291
  24. 17 Feb, 2007 1 commit
    • James Livingston's avatar
      display playing time of radio stations in the main UI as well as in the · 96d08dad
      James Livingston authored
      2007-02-17  James Livingston  <doclivingston@gmail.com>
      
      	* widgets/rb-header.c: (rb_header_init), (rb_header_set_property),
      	(rb_header_sync), (rb_header_set_show_timeline),
      	(rb_header_sync_time), (rb_header_update_elapsed): display playing
      	time of radio stations in the main UI as well as in the tooltip.
      	Fixes #402650
      
      svn path=/trunk/; revision=4821
      96d08dad
  25. 12 Jan, 2007 1 commit
    • Jonathan Matthew's avatar
      patch by: William Jon McCann <mccann@jhu.edu> · 960a1a64
      Jonathan Matthew authored
      2007-01-12  Jonathan Matthew  <jonathan@kaolin.wh9.net>
      
      	patch by:  William Jon McCann  <mccann@jhu.edu>
      
      	* widgets/rb-header.c: (rb_header_init):
      	Left-align the song info label.  Fixes #393974.
      
      svn path=/trunk/; revision=4735
      960a1a64
  26. 29 Oct, 2006 1 commit
    • Jonathan Matthew's avatar
      Revert dbus interface breakage introduced in the fix for #365908. · 3805f498
      Jonathan Matthew authored
      2006-10-30  Jonathan Matthew  <jonathan@kaolin.wh9.net>
      
      	* shell/rb-shell-player.c: (rb_shell_player_class_init),
      	(rb_shell_player_sync_with_source),
      	(rb_shell_player_get_playing_time_string), (tick_cb):
      	* widgets/rb-header.c: (rb_header_sync_time),
      	(slider_moved_callback), (rb_header_update_elapsed),
      	(rb_header_elapsed_changed_cb):
      	Revert dbus interface breakage introduced in the fix for #365908.
      3805f498
  27. 28 Oct, 2006 1 commit
    • Jonathan Matthew's avatar
      Treat elapsed time as signed, since rb_player_get_time returns a signed · d269c705
      Jonathan Matthew authored
      2006-10-28  Jonathan Matthew  <jonathan@kaolin.wh9.net>
      
      	* shell/rb-shell-player.c: (rb_shell_player_class_init),
      	(rb_shell_player_sync_with_source),
      	(rb_shell_player_get_playing_time_string), (rb_shell_player_seek),
      	(tick_cb):
      	* widgets/rb-header.c: (rb_header_sync_time),
      	(rb_header_elapsed_changed_cb):
      	Treat elapsed time as signed, since rb_player_get_time returns a
      	signed value.  When actually using the value, mostly treat negative
      	values as 0.  Fixes #365908.
      d269c705
  28. 06 Oct, 2006 1 commit
    • James Livingston's avatar
      patch from Matt N <fisxoj@gmail.com> · b38328c7
      James Livingston authored
      2006-10-06  James Livingston  <doclivingston@gmail.com>
      
      	patch from Matt N  <fisxoj@gmail.com>
      
      	* backends/gstreamer/rb-player-gst.c: (emit_signal_idle),
      	(rb_player_gst_bus_cb):
      	* backends/rb-player.c: (rb_player_interface_init),
      	(_rb_player_emit_tick), (_rb_player_emit_event):
      	* backends/rb-player.h: let the backend emit named "events", for
      	things that the core shouldn't know about.
      
      	* rhythmdb/rhythmdb.h:
      	* widgets/rb-header.c: (get_extra_metadata), (rb_header_sync): add
      	support for streams containing album metadata.
      
      	* plugins/audioscrobbler/Makefile.am:
      	* plugins/audioscrobbler/audioscrobbler.rb-plugin.desktop.in:
      	* plugins/audioscrobbler/rb-audioscrobbler-plugin.c:
      	(impl_activate), (impl_deactivate), (impl_create_configure_dialog):
      	* plugins/audioscrobbler/rb-lastfm-gst-src.c:
      	* plugins/audioscrobbler/rb-lastfm-source.c:
      	* plugins/audioscrobbler/rb-lastfm-source.h: Add support for playback
      	of last.fm streams. From #313049.
      b38328c7
  29. 02 Oct, 2006 1 commit
    • Jonathan Matthew's avatar
      Add definitions for some common extra-metadata fields, remove iradio entry · 8625e9cc
      Jonathan Matthew authored
      2006-10-02  Jonathan Matthew  <jonathan@kaolin.wh9.net>
      
      	* rhythmdb/rhythmdb.c: (rhythmdb_register_core_entry_types),
      	(rhythmdb_entry_podcast_post_get_type):
      	* rhythmdb/rhythmdb.h:
      	* tests/bench-rhythmdb-load.c: (main):
      	Add definitions for some common extra-metadata fields,
      	remove iradio entry type definition, add the concept of entry type
      	categories, define categories for the core entry types.
      	Categories are used to decide if an entry can be copied to a removable
      	device, if it should be reported to audioscrobbler, etc.
      
      	* shell/Makefile.am:
      	* shell/rb-shell-player.c: (rb_shell_player_class_init),
      	(rb_shell_player_constructor), (rb_shell_player_init),
      	(rb_shell_player_get_property), (open_location_thread),
      	(rb_shell_player_open_location),
      	(rb_shell_player_sync_with_source),
      	(rb_shell_player_set_playing_source_internal), (tick_cb):
      	* shell/rb-shell.c: (construct_widgets), (construct_sources),
      	(rb_shell_player_elapsed_changed_cb):
      	Remove iradio-specific code, use extra metadata fields for streaming
      	title and artist name.
      
      	* data/ui/rhythmbox-ui.xml:
      	Add a placeholder for 'new ...' menu items.
      
      	* Makefile.am:
      	* sources/Makefile.am:
      	* configure.ac:
      	* data/rhythmbox.schemas:
      	* plugins/Makefile.am:
      	* plugins/iradio/Makefile.am:
      	* plugins/iradio/iradio-ui.xml:
      	* plugins/iradio/iradio.rb-plugin.desktop.in:
      	* plugins/iradio/rb-iradio-plugin.c: (rb_iradio_plugin_init),
      	(rb_iradio_plugin_finalize), (impl_activate), (impl_deactivate),
      	(rb_iradio_plugin_class_init):
      	iradio plugin, enabled and hidden by default.
      
      	* plugins/audioscrobbler/rb-audioscrobbler.c:
      	(rb_audioscrobbler_song_changed_cb):
      	* sources/rb-audiocd-source.c: (rb_audiocd_source_new):
      	* sources/rb-daap-source.c: (rb_daap_source_new):
      	* sources/rb-ipod-source.c: (rb_ipod_source_new), (impl_paste):
      	Define entry type categories, and use them where appropriate.
      
      	* sources/rb-iradio-source.c: (rb_iradio_source_dispose),
      	(rb_iradio_source_constructor), (rb_iradio_source_new),
      	(impl_get_status), (impl_want_uri), (buffering_cb),
      	(check_entry_type), (streaming_title_request_cb),
      	(streaming_artist_request_cb), (extra_metadata_gather_cb),
      	(info_available_cb), (playing_entry_changed_cb),
      	(playing_source_changed_cb):
      	Move streaming metadata and buffering handling here from
      	rb-shell-player.c.  Emit extra-metadata notify signals when the streaming
      	title or artist changes, and handle request and gather signals for
      	those.
      
      	* widgets/rb-header.c: (rb_header_class_init),
      	(rb_header_set_property), (rb_header_get_property),
      	(rb_header_new), (append_and_free), (rb_header_sync):
      	* widgets/rb-header.h:
      	Rework to use streaming artist and title extra-metadata.
      	streaming-artist overrides entry artist, and streaming-title means
      	entry title is a stream name, displayed in brackets.
      
      	* doc/reference/Makefile.am:
      	* doc/reference/rhythmbox.types:
      	Remove iradio stuff from gtk-doc build.
      
      	Fixed #347097.
      8625e9cc
  30. 19 Aug, 2006 1 commit
    • Jonathan Matthew's avatar
      Add a 'seekable' property on RBHeader, and use it to make the seek bar · 14b4ffc5
      Jonathan Matthew authored
      2006-08-19  Jonathan Matthew  <jonathan@kaolin.wh9.net>
      
      	* shell/rb-shell-player.c: (rb_shell_player_sync_with_source):
      	* widgets/rb-header.c: (rb_header_class_init),
      	(rb_header_set_property), (rb_header_get_property),
      	(rb_header_set_playing_entry), (rb_header_sync),
      	(rb_header_sync_time):
      	* widgets/rb-header.h:
      	Add a 'seekable' property on RBHeader, and use it to make the seek bar
      	insensitive when the player backend tells us we can't seek in the
      	current song.  From #330410.
      14b4ffc5
  31. 23 Jul, 2006 1 commit
    • William Jon McCann's avatar
      Fix more leaks. Mostly RhythmDBEntry ref leaks. From #347446 · 41235602
      William Jon McCann authored
      2006-07-23  William Jon McCann  <mccann@jhu.edu>
      
      	* bindings/python/rb.override:
      	* daapsharing/rb-daap-share.c: (add_playlist_entry_to_mlcl):
      	* plugins/cd-recorder/rb-cd-recorder-plugin.c:
      	(playlist_row_inserted_cb):
      	* plugins/generic-player/rb-psp-source.c: (visit_playlist_dirs):
      	* plugins/rb-plugin-manager.c:
      	* podcast/rb-podcast-manager.c: (rb_podcast_manager_head_query_cb),
      	(rb_podcast_manager_copy_post),
      	(rb_podcast_manager_db_entry_deleted_cb),
      	(rb_podcast_manager_insert_feed):
      	* rhythmdb/rb-refstring.c: (rb_refstring_unref),
      	(rb_refstring_ref), (rb_refstring_get_sort_key):
      	* rhythmdb/rhythmdb-private.h:
      	* rhythmdb/rhythmdb-property-model.c:
      	(rhythmdb_property_model_set_property),
      	(rhythmdb_property_model_get_property),
      	(rhythmdb_property_model_finalize), (rhythmdb_property_model_new),
      	(rhythmdb_property_model_row_inserted_cb),
      	(rhythmdb_property_model_prop_changed_cb),
      	(rhythmdb_property_model_compare),
      	(rhythmdb_property_model_insert),
      	(rhythmdb_property_model_iter_from_string),
      	(rhythmdb_property_model_get_column_type),
      	(rhythmdb_property_model_get_iter),
      	(rhythmdb_property_model_get_value),
      	(rhythmdb_property_model_iter_nth_child), (query_model_cb),
      	(rhythmdb_property_model_enable_drag):
      	* rhythmdb/rhythmdb-query-model.c: (rhythmdb_query_model_init),
      	(rhythmdb_query_model_constructor), (rhythmdb_query_model_dispose),
      	(rhythmdb_query_model_finalize), (rhythmdb_query_model_new),
      	(rhythmdb_query_model_chain),
      	(rhythmdb_query_model_entry_added_cb),
      	(rhythmdb_query_model_entry_changed_cb),
      	(rhythmdb_query_model_entry_deleted_cb), (idle_process_update),
      	(rhythmdb_query_model_add_entry),
      	(rhythmdb_query_model_insert_into_main_list),
      	(rhythmdb_query_model_insert_into_limited_list),
      	(rhythmdb_query_model_remove_from_main_list),
      	(rhythmdb_query_model_remove_from_limited_list),
      	(rhythmdb_query_model_update_limited_entries),
      	(rhythmdb_query_model_emit_reorder),
      	(rhythmdb_query_model_do_reorder),
      	(rhythmdb_query_model_do_insert),
      	(rhythmdb_query_model_move_entry),
      	(rhythmdb_query_model_remove_entry),
      	(rhythmdb_query_model_entry_to_iter),
      	(rhythmdb_query_model_iter_to_entry),
      	(rhythmdb_query_model_get_previous_from_entry),
      	(rhythmdb_query_model_row_draggable),
      	(rhythmdb_query_model_drag_data_delete),
      	(rhythmdb_query_model_drag_data_get),
      	(rhythmdb_query_model_drag_data_received),
      	(rhythmdb_query_model_row_drop_possible),
      	(rhythmdb_query_model_row_drop_position),
      	(rhythmdb_query_model_add_results),
      	(rhythmdb_query_model_query_complete),
      	(rhythmdb_query_model_get_column_type),
      	(rhythmdb_query_model_get_iter), (rhythmdb_query_model_get_value),
      	(rhythmdb_query_model_iter_nth_child),
      	(apply_updated_entry_sequence),
      	(rhythmdb_query_model_child_index_to_base_index),
      	(rhythmdb_query_model_get_entry_index),
      	(rhythmdb_query_model_base_row_inserted),
      	(rhythmdb_query_model_base_row_deleted),
      	(rhythmdb_query_model_reapply_query), (_reverse_sorting_func),
      	(rhythmdb_query_model_location_sort_func),
      	(rhythmdb_query_model_title_sort_func),
      	(rhythmdb_query_model_album_sort_func),
      	(rhythmdb_query_model_artist_sort_func),
      	(rhythmdb_query_model_track_sort_func),
      	(rhythmdb_query_model_double_ceiling_sort_func),
      	(rhythmdb_query_model_ulong_sort_func),
      	(rhythmdb_query_model_date_sort_func),
      	(rhythmdb_query_model_string_sort_func),
      	(rhythmdb_query_model_within_limit):
      	* rhythmdb/rhythmdb-tree.c: (unparent_entries),
      	(rhythmdb_tree_parser_start_element),
      	(rhythmdb_tree_parser_end_element),
      	(rhythmdb_tree_parser_characters), (rhythmdb_tree_load),
      	(write_elt_name_open), (write_elt_name_close), (save_entry_string),
      	(save_entry_int), (save_entry_ulong), (save_entry_boolean),
      	(save_entry_uint64), (save_entry_double), (save_entry),
      	(set_entry_album), (rhythmdb_tree_entry_new),
      	(get_genres_hash_for_type), (get_or_create_genre),
      	(get_or_create_artist), (get_or_create_album), (remove_child),
      	(remove_entry_from_album), (rhythmdb_tree_entry_set),
      	(rhythmdb_tree_entry_delete), (remove_one_song),
      	(rhythmdb_tree_entry_delete_by_type),
      	(rhythmdb_tree_evaluate_query), (search_match_properties),
      	(evaluate_conjunctive_subquery), (do_conjunction),
      	(conjunctive_query_songs), (clone_remove_ptr_array_index),
      	(conjunctive_query_albums), (conjunctive_query_artists),
      	(conjunctive_query_genre), (conjunctive_query),
      	(split_query_by_disjunctions), (do_query_recurse),
      	(handle_entry_match), (rhythmdb_tree_entry_lookup_by_location),
      	(rhythmdb_tree_entry_foreach_func), (rhythmdb_tree_entry_foreach),
      	(hash_tree_entries_foreach), (hash_tree_albums_foreach),
      	(hash_tree_artists_foreach), (hash_tree_genres_foreach):
      	* rhythmdb/rhythmdb.c: (metadata_field_from_prop),
      	(extract_gtype_from_enum_entry),
      	(extract_nice_name_from_enum_entry), (rhythmdb_init),
      	(rhythmdb_execute_multi_stat_info_cb), (rhythmdb_action_free),
      	(rhythmdb_event_free), (rhythmdb_finalize),
      	(rhythmdb_set_property), (rhythmdb_get_property),
      	(rhythmdb_thread_create), (free_entry_changes),
      	(emit_entry_changed), (sync_entry_changed),
      	(process_added_entries_cb), (process_deleted_entries_cb),
      	(rhythmdb_commit_internal), (rhythmdb_add_timeout_commit),
      	(rhythmdb_entry_allocate), (rhythmdb_entry_get_type_data),
      	(rhythmdb_entry_insert), (rhythmdb_entry_new),
      	(rhythmdb_entry_example_new), (rhythmdb_entry_ref),
      	(rhythmdb_entry_finalize), (rhythmdb_entry_unref),
      	(rhythmdb_entry_is_editable), (set_props_from_metadata),
      	(rhythmdb_process_stat_event), (rhythmdb_add_import_error_entry),
      	(rhythmdb_process_metadata_load),
      	(rhythmdb_process_file_created_or_modified),
      	(rhythmdb_process_file_deleted), (rhythmdb_process_events),
      	(rhythmdb_execute_stat_info_cb), (rhythmdb_execute_stat),
      	(queue_stat_uri), (queue_stat_uri_tad), (rhythmdb_execute_load),
      	(rhythmdb_entry_get), (entry_to_rb_metadata), (rhythmdb_add_uri),
      	(rhythmdb_add_uri_with_type), (rhythmdb_entry_set),
      	(record_entry_change), (rhythmdb_entry_set_internal),
      	(rhythmdb_entry_sync_mirrored), (rhythmdb_entry_delete),
      	(rhythmdb_entry_move_to_trash_cb),
      	(rhythmdb_entry_move_to_trash_set_error),
      	(rhythmdb_entry_move_to_trash), (rhythmdb_entry_delete_by_type),
      	(rhythmdb_nice_elt_name_from_propid),
      	(rhythmdb_propid_from_nice_elt_name),
      	(rhythmdb_entry_lookup_by_location), (rhythmdb_entry_foreach),
      	(rhythmdb_evaluate_query), (rhythmdb_emit_entry_deleted),
      	(rhythmdb_compute_status_normal), (default_sync_metadata),
      	(rhythmdb_entry_register_type), (rhythmdb_entry_type_foreach),
      	(rhythmdb_entry_type_get_by_name), (song_can_sync_metadata),
      	(podcast_get_playback_uri), (podcast_data_destroy),
      	(rhythmdb_entry_set_mount_point), (rhythmdb_entry_set_visibility),
      	(rhythmdb_entry_dup_string), (rhythmdb_entry_get_string),
      	(rhythmdb_entry_get_boolean), (rhythmdb_entry_get_uint64),
      	(rhythmdb_entry_get_entry_type), (rhythmdb_entry_get_pointer),
      	(rhythmdb_entry_get_ulong), (rhythmdb_entry_get_double),
      	(rhythmdb_entry_get_playback_uri), (rhythmdb_get_property_type):
      	* rhythmdb/rhythmdb.h:
      	* shell/rb-play-order-linear-loop.c:
      	(rb_linear_play_order_loop_get_next),
      	(rb_linear_play_order_loop_get_previous):
      	* shell/rb-play-order-linear.c: (rb_linear_play_order_get_next),
      	(rb_linear_play_order_get_previous):
      	* shell/rb-play-order-queue.c: (rb_queue_play_order_get_previous):
      	* shell/rb-play-order-random.c: (get_query_model_contents):
      	* shell/rb-play-order-shuffle.c: (handle_query_model_changed),
      	(get_query_model_contents):
      	* shell/rb-play-order.c: (rb_play_order_constructor),
      	(rb_play_order_finalize),
      	(rb_play_order_set_playing_entry_internal),
      	(rb_play_order_set_property), (rb_play_order_new),
      	(rb_play_order_get_player), (rb_play_order_get_source),
      	(rb_play_order_get_db), (rb_play_order_get_query_model),
      	(rb_play_order_player_is_playing),
      	(rb_play_order_set_playing_entry),
      	(rb_play_order_get_playing_entry),
      	(rb_play_order_playing_source_changed),
      	(rb_play_order_query_model_changed),
      	(rb_play_order_entry_added_cb), (rb_play_order_row_deleted_cb),
      	(default_has_next), (default_has_previous),
      	(sync_playing_entry_cb), (default_playing_entry_removed),
      	(rb_play_order_has_next), (rb_play_order_get_next),
      	(rb_play_order_go_next), (rb_play_order_has_previous),
      	(rb_play_order_get_previous), (rb_play_order_go_previous),
      	(rb_play_order_model_not_empty),
      	(rb_play_order_update_have_next_previous):
      	* shell/rb-playlist-manager.c: (rb_playlist_manager_is_dirty),
      	(rb_playlist_manager_save_playlists),
      	(rb_playlist_manager_set_automatic_playlist),
      	(rb_playlist_manager_cmd_edit_automatic_playlist),
      	(_queue_track_cb), (rb_playlist_manager_get_playlists),
      	(rb_playlist_manager_get_playlist_names), (_get_playlist_by_name):
      	* shell/rb-shell-clipboard.c: (add_playlist_to_menu):
      	* shell/rb-shell-player.c: (rb_shell_player_constructor),
      	(volume_pre_unmount_cb), (reemit_playing_signal),
      	(notify_playing_idle), (rb_shell_player_open_playlist_url),
      	(rb_shell_player_handle_eos_unlocked),
      	(rb_shell_player_handle_eos), (rb_shell_player_init),
      	(rb_shell_player_new), (rb_shell_player_get_playing_entry),
      	(playlist_entry_cb), (rb_shell_player_open_entry),
      	(rb_shell_player_play), (do_next_idle), (gconf_play_order_changed),
      	(rb_shell_player_set_play_order),
      	(rb_shell_player_set_playback_state),
      	(rb_shell_player_sync_play_order),
      	(rb_shell_player_play_order_update_cb),
      	(rb_shell_player_jump_to_current), (swap_playing_source),
      	(rb_shell_player_do_previous), (rb_shell_player_do_next),
      	(rb_shell_player_do_previous_or_seek), (rb_shell_player_playpause),
      	(rb_shell_player_sync_volume), (rb_shell_player_sync_replaygain),
      	(rb_shell_player_entry_activated_cb),
      	(rb_shell_player_property_row_activated_cb),
      	(rb_shell_player_entry_changed_cb),
      	(rb_shell_player_sync_with_source), (rb_shell_player_sync_buttons),
      	(rb_shell_player_pause),
      	(rb_shell_player_get_playing_song_duration),
      	(rb_shell_player_error), (error_cb), (tick_cb),
      	(info_available_cb), (buffering_cb),
      	(rb_shell_player_get_playing_path), (grab_mmkey), (filter_mmkeys):
      	* shell/rb-shell.c: (rb_shell_playing_from_queue_cb),
      	(rb_shell_jump_to_current):
      	* sources/rb-auto-playlist-source.c:
      	(rb_auto_playlist_source_finalize), (impl_receive_drag),
      	(impl_save_contents_to_xml), (rb_auto_playlist_source_set_query),
      	(rb_auto_playlist_source_get_query):
      	* sources/rb-auto-playlist-source.h:
      	* sources/rb-browser-source.c: (rb_browser_source_do_query):
      	* sources/rb-import-errors-source.c:
      	(rb_import_errors_source_constructor):
      	* sources/rb-iradio-source.c: (rb_iradio_source_do_query):
      	* sources/rb-library-source.c: (filepath_parse_pattern):
      	* sources/rb-missing-files-source.c:
      	(rb_missing_files_source_constructor):
      	* sources/rb-play-queue-source.c:
      	(rb_play_queue_source_clear_queue),
      	(rb_play_queue_source_track_info_cell_data_func):
      	* sources/rb-playlist-source.c: (rb_playlist_source_set_property),
      	(rb_playlist_source_get_property), (playlist_iter_func),
      	(rb_playlist_source_save_to_xml), (rb_playlist_source_row_deleted),
      	(rb_playlist_source_track_cell_data_func):
      	* sources/rb-podcast-source.c: (construct_query_from_selection),
      	(rb_podcast_source_post_status_cell_data_func),
      	(rb_podcast_source_post_feed_cell_data_func),
      	(rb_podcast_source_feed_title_search_func),
      	(rb_podcast_source_post_date_cell_data_func):
      	* sources/rb-source.c: (default_get_status),
      	(rb_source_get_status), (rb_source_browser_toggled),
      	(rb_source_update_play_statistics), (rb_source_search),
      	(rb_source_get_config_widget), (default_add_to_queue),
      	(rb_source_add_to_queue), (rb_source_receive_drag),
      	(rb_source_gather_hash_keys):
      	* sources/rb-sourcelist-model.c: (rb_sourcelist_model_new),
      	(rb_sourcelist_model_is_row_visible),
      	(rb_sourcelist_model_row_is_separator),
      	(rb_sourcelist_model_drag_data_received), (path_is_droppable),
      	(path_is_reorderable), (rb_sourcelist_model_row_draggable),
      	(rb_sourcelist_model_drag_data_get):
      	* sources/rb-sourcelist.c: (rb_sourcelist_append),
      	(match_source_to_iter), (rb_sourcelist_source_to_iter),
      	(rb_sourcelist_visible_source_to_iter),
      	(rb_sourcelist_edit_source_name), (set_source_playing),
      	(rb_sourcelist_set_playing_source), (rb_sourcelist_remove),
      	(rb_sourcelist_select), (rb_sourcelist_selection_changed_cb),
      	(drop_received_cb), (row_activated_cb), (emit_show_popup),
      	(key_release_cb), (name_notify_cb), (visibility_notify_cb),
      	(rb_sourcelist_title_cell_data_func), (source_name_edited_cb):
      	* sources/rb-static-playlist-source.c: (impl_save_contents_to_xml),
      	(rb_static_playlist_source_add_location_internal),
      	(rb_static_playlist_source_row_inserted):
      	* widgets/rb-entry-view.c: (type_ahead_search_func),
      	(rb_entry_view_finalize), (rb_entry_view_set_model),
      	(rb_entry_view_playing_cell_data_func),
      	(rb_entry_view_rating_cell_data_func),
      	(rb_entry_view_long_cell_data_func),
      	(rb_entry_view_play_count_cell_data_func),
      	(rb_entry_view_duration_cell_data_func),
      	(rb_entry_view_year_cell_data_func),
      	(rb_entry_view_quality_cell_data_func),
      	(rb_entry_view_location_cell_data_func),
      	(rb_entry_view_string_cell_data_func),
      	(rb_entry_view_sync_sorting), (rb_entry_view_set_sorting_type),
      	(rb_entry_view_get_sorting_order),
      	(rb_entry_view_set_sorting_order), (rb_entry_view_append_column),
      	(rb_entry_view_set_columns_clickable), (rb_entry_view_constructor),
      	(rb_entry_view_rated_cb), (rb_entry_view_pixbuf_clicked_cb),
      	(rb_entry_view_playing_song_changed), (harvest_entries),
      	(rb_entry_view_button_press_cb), (rb_entry_view_row_activated_cb),
      	(rb_entry_view_row_inserted_cb), (rb_entry_view_row_deleted_cb),
      	(set_column_visibility):
      	* widgets/rb-entry-view.h:
      	* widgets/rb-header.c: (rb_header_new),
      	(rb_header_set_playing_entry), (rb_header_set_title):
      	* widgets/rb-library-browser.c: (rebuild_child_model),
      	(rb_library_browser_set_model):
      	* widgets/rb-property-view.c:
      	(rb_property_view_set_model_internal), (rb_property_view_finalize),
      	(rb_property_view_set_property), (rb_property_view_get_property),
      	(rb_property_view_reset), (rb_property_view_get_model),
      	(rb_property_view_set_model), (rb_property_view_row_activated_cb),
      	(rb_property_view_button_press_cb):
      	* widgets/rb-query-creator.c: (rb_query_creator_constructor),
      	(rb_query_creator_get_property), (rb_query_creator_load_query),
      	(rb_query_creator_set_sorting), (rb_query_creator_new_from_query),
      	(rb_query_creator_get_query), (rb_query_creator_get_limit),
      	(rb_query_creator_get_sort_order), (limit_toggled_cb),
      	(lookup_row_by_widget), (remove_button_click_cb),
      	(add_button_click_cb), (create_property_option_menu):
      	* widgets/rb-song-info.c: (rb_song_info_constructor),
      	(rb_song_info_finalize), (rb_song_info_backward_clicked_cb),
      	(rb_song_info_forward_clicked_cb), (rb_song_info_update_buttons),
      	(rb_song_info_update_rating), (rb_song_info_sync_entry_single):
      	Fix more leaks.  Mostly RhythmDBEntry ref leaks.  From #347446
      41235602
  32. 14 Jul, 2006 1 commit
    • William Jon McCann's avatar
      Strip all trailing whitespace. Fixes #344293. · e1101445
      William Jon McCann authored
      2006-07-14  William Jon McCann  <mccann@jhu.edu>
      
      	* backends/gstreamer/rb-encoder-gst.c: (rb_encoder_gst_finalize),
      	(rb_encoder_gst_emit_completed), (bus_watch_cb), (gst_error_cb),
      	(start_pipeline), (add_encoding_pipeline), (add_tags_from_entry),
      	(gnomevfs_allow_overwrite_cb), (new_decoded_pad_cb),
      	(add_decoding_pipeline), (profile_bin_find_encoder),
      	(get_profile_from_mime_type), (extract_track), (transcode_track),
      	(rb_encoder_gst_encode):
      	* backends/gstreamer/rb-encoder-gst.h:
      	* backends/gstreamer/rb-player-gst.c: (rb_player_gst_init),
      	(rb_player_gst_finalize), (rb_player_gst_gst_free_playbin),
      	(destroy_idle_signal), (process_tag), (rb_player_gst_bus_cb),
      	(rb_player_gst_construct):
      	* backends/gstreamer/rb-player-gst.h:
      	* backends/rb-encoder.c: (rb_encoder_encode), (rb_encoder_cancel):
      	* backends/rb-encoder.h:
      	* backends/rb-player.c: (_rb_player_emit_tick):
      	* backends/rb-player.h:
      	* daapsharing/rb-daap-connection.c: (build_message),
      	(actual_http_response_handler), (http_response_handler),
      	(http_get), (entry_set_string_prop), (emit_progress_idle),
      	(handle_server_info), (handle_database_info),
      	(handle_song_listing), (handle_playlists),
      	(handle_playlist_entries), (rb_daap_connection_new),
      	(connected_cb), (rb_daap_connection_do_something),
      	(rb_daap_connection_get_headers), (rb_daap_connection_dispose),
      	(rb_daap_connection_get_property):
      	* daapsharing/rb-daap-connection.h:
      	* daapsharing/rb-daap-dialog.c: (rb_daap_password_dialog_new_run),
      	(rb_daap_collision_dialog_new_run):
      	* daapsharing/rb-daap-dialog.h:
      	* daapsharing/rb-daap-hash.c: (byteReverse), (OpenDaap_MD5Init),
      	(OpenDaap_MD5Update), (OpenDaap_MD5Final), (MD5Transform),
      	(DigestToString), (rb_daap_hash_generate):
      	* daapsharing/rb-daap-hash.h:
      	* daapsharing/rb-daap-mdns-browser-avahi.c: (client_cb),
      	(resolve_cb), (browse_cb):
      	* daapsharing/rb-daap-mdns-browser-howl.c: (howl_in_cb),
      	(resolve_cb), (rb_daap_mdns_browser_resolve),
      	(rb_daap_mdns_browser_start), (resolver_free):
      	* daapsharing/rb-daap-mdns-browser.h:
      	* daapsharing/rb-daap-mdns-publisher-avahi.c: (client_cb):
      	* daapsharing/rb-daap-mdns-publisher-howl.c: (howl_in_cb),
      	(publish_cb):
      	* daapsharing/rb-daap-mdns-publisher.h:
      	* daapsharing/rb-daap-share.c: (name_collision_cb),
      	(rb_daap_share_process_playlist), (rb_daap_share_dispose),
      	(message_set_from_rb_daap_structure), (content_codes_cb),
      	(session_id_validate), (logout_cb), (update_cb),
      	(add_entry_to_mlcl), (add_playlist_to_mlcl),
      	(add_playlist_entry_to_mlcl), (parse_meta), (databases_cb),
      	(rb_daap_share_server_start), (rb_daap_share_server_stop),
      	(rb_daap_share_publish_start):
      	* daapsharing/rb-daap-share.h:
      	* daapsharing/rb-daap-sharing.c: (share_name_changed_cb),
      	(share_password_changed_cb), (rb_daap_sharing_shutdown):
      	* daapsharing/rb-daap-sharing.h:
      	* daapsharing/rb-daap-src.c: (_do_init), (rb_daap_src_class_init),
      	(rb_daap_src_finalize), (_split_uri), (rb_daap_src_getcaps),
      	(rb_daap_src_open):
      	* daapsharing/rb-daap-structure.c: (rb_daap_structure_add),
      	(rb_daap_structure_node_serialize), (rb_daap_structure_serialize),
      	(rb_daap_structure_parse_container_buffer),
      	(rb_daap_structure_parse), (gnode_find_node),
      	(rb_daap_structure_find_item), (rb_daap_structure_find_node),
      	(print_rb_daap_item):
      	* daapsharing/rb-daap-structure.h:
      	* iradio/rb-new-station-dialog.c:
      	(rb_new_station_dialog_class_init), (rb_new_station_dialog_init),
      	(rb_new_station_dialog_new), (rb_new_station_dialog_response_cb),
      	(rb_new_station_dialog_text_changed):
      	* iradio/rb-station-properties-dialog.c:
      	(rb_station_properties_dialog_init),
      	(rb_station_properties_dialog_new),
      	(rb_station_properties_dialog_response_cb),
      	(rb_station_properties_dialog_get_current_entry),
      	(rb_station_properties_dialog_rated_cb),
      	(rb_station_properties_dialog_update_rating),
      	(rb_station_properties_dialog_update_playback_error),
      	(rb_station_properties_dialog_sync_entries):
      	* metadata/rb-metadata-common.c: (rb_metadata_error_quark):
      	* metadata/rb-metadata-dbus-client.c: (ping_metadata_service),
      	(start_metadata_service), (rb_metadata_load), (rb_metadata_set),
      	(rb_metadata_can_save), (rb_metadata_save):
      	* metadata/rb-metadata-dbus-service.c: (rb_metadata_dbus_load),
      	(rb_metadata_dbus_can_save), (rb_metadata_dbus_save),
      	(_handle_message), (_new_connection), (main):
      	* metadata/rb-metadata-dbus.c: (rb_metadata_dbus_add_to_message),
      	(rb_metadata_dbus_read_from_message):
      	* metadata/rb-metadata-dbus.h:
      	* metadata/rb-metadata-gst.c: (ogg_pad_added_cb),
      	(rb_add_id3_tagger), (rb_metadata_init),
      	(rb_metadata_gst_tag_to_field), (make_undecodable_error),
      	(rb_metadata_gst_load_tag), (rb_metadata_gst_fakesink_handoff_cb),
      	(rb_metadata_gst_new_decoded_pad_cb),
      	(rb_metadata_gst_unknown_type_cb), (rb_metadata_bus_handler):
      	* metadata/sj-error.c: (sj_error_quark):
      	* metadata/sj-error.h:
      	* metadata/sj-metadata-musicbrainz.c:
      	(sj_metadata_musicbrainz_instance_init),
      	(get_offline_track_listing), (cache_rdf), (get_cached_rdf),
      	(get_rdf), (lookup_cd):
      	* metadata/sj-metadata.c: (sj_metadata_get_type):
      	* metadata/sj-structures.c:
      	* metadata/sj-structures.h:
      	* metadata/test-metadata.c: (load_metadata_cb), (main):
      	* podcast/rb-feed-podcast-properties-dialog.c:
      	(rb_feed_podcast_properties_dialog_init),
      	(rb_feed_podcast_properties_dialog_update_title):
      	* podcast/rb-feed-podcast-properties-dialog.h:
      	* podcast/rb-new-podcast-dialog.c: (rb_new_podcast_dialog_init),
      	(rb_new_podcast_dialog_new), (rb_new_podcast_dialog_response_cb),
      	(rb_new_podcast_dialog_text_changed):
      	* podcast/rb-podcast-manager.c: (rb_podcast_manager_class_init),
      	(rb_podcast_manager_constructor), (rb_podcast_manager_finalize),
      	(rb_podcast_manager_set_property),
      	(rb_podcast_manager_get_property), (rb_podcast_manager_new),
      	(rb_podcast_manager_download_entry),
      	(rb_podcast_manager_update_feeds),
      	(rb_podcast_manager_head_query_cb), (rb_podcast_manager_next_file),
      	(rb_podcast_manager_copy_post),
      	(rb_podcast_manager_thread_parse_feed),
      	(rb_podcast_manager_add_post), (rb_podcast_manager_save_metadata),
      	(rb_podcast_manager_db_entry_added_cb), (write_job_data),
      	(download_info_free), (download_info_new), (start_job),
      	(rb_podcast_manager_cancel_all), (end_job), (cancel_job),
      	(download_progress_cb), (download_progress_update_cb),
      	(rb_podcast_manager_remove_feed),
      	(rb_podcast_manager_db_entry_deleted_cb),
      	(rb_podcast_manager_cancel_download),
      	(rb_podcast_manager_update_synctime),
      	(rb_podcast_manager_set_remove_files),
      	(rb_podcast_manager_insert_feed), (rb_podcast_manager_event_loop),
      	(rb_podcast_manager_abort_subscribe),
      	(rb_podcast_manager_get_podcast_dir):
      	* podcast/rb-podcast-manager.h:
      	* podcast/rb-podcast-parse.c: (rb_set_channel_value),
      	(rb_validate_channel_propert), (rb_validate_item_propert),
      	(rb_podcast_parser_start_element), (rb_podcast_parser_end_element),
      	(rb_podcast_parser_characters), (rb_podcast_parse_load_feed),
      	(rb_podcast_parse_date), (rb_podcast_parse_time),
      	(rb_podcast_parse_channel_free), (rb_podcast_parse_item_free):
      	* podcast/rb-podcast-parse.h:
      	* podcast/rb-podcast-properties-dialog.c:
      	(rb_podcast_properties_dialog_init),
      	(rb_podcast_properties_dialog_get_current_entry),
      	(rb_podcast_properties_dialog_update_title),
      	(rb_podcast_properties_dialog_update_duration),
      	(rb_podcast_properties_dialog_update_date):
      	* podcast/rb-podcast-properties-dialog.h:
      	* rhythmdb/gsequence.c: (g_sequence_new), (g_sequence_prepend),
      	(g_sequence_insert), (g_sequence_remove), (g_sequence_concatenate),
      	(g_sequence_remove_range), (g_sequence_get_ptr_at_pos),
      	(g_sequence_ptr_move), (g_sequence_ptr_sort_changed),
      	(g_sequence_search), (g_sequence_set_aggregate_data),
      	(g_sequence_node_update_fields), (g_sequence_node_rotate),
      	(find_min), (g_sequence_node_find_by_pos),
      	(g_sequence_node_find_closest), (g_sequence_node_free),
      	(g_sequence_node_split), (g_sequence_node_insert_before),
      	(g_sequence_node_get_length), (g_sequence_node_remove),
      	(g_sequence_node_calc_height), (g_sequence_node_insert_sorted),
      	(g_sequence_calc_tree_height):
      	* rhythmdb/rb-refstring.c: (rb_refstring_system_shutdown),
      	(rb_refstring_get):
      	* rhythmdb/rb-refstring.h:
      	* rhythmdb/rhythmdb-gda.c: (rhythmdb_gda_class_init),
      	(rhythmdb_gda_init), (dump_model), (execute_query),
      	(execute_nonquery), (ensure_table_exists), (collect_value_for_sql),
      	(collect_value_from_sql), (_initialize), (rhythmdb_gda_new),
      	(rhythmdb_gda_load), (rhythmdb_gda_entry_new),
      	(rhythmdb_gda_entry_set), (rhythmdb_gda_entry_get),
      	(rhythmdb_gda_ref), (rhythmdb_gda_entry_lookup_by_location),
      	(translate_query), (do_query), (rhythmdb_gda_do_full_query):
      	* rhythmdb/rhythmdb-gda.h:
      	* rhythmdb/rhythmdb-monitor.c: (rhythmdb_init_monitoring),
      	(rhythmdb_finalize_monitoring), (monitor_entry_file),
      	(monitor_library_directory), (rhythmdb_check_changed_file),
      	(rhythmdb_start_monitoring), (rhythmdb_directory_change_cb),
      	(rhythmdb_monitor_uri_path), (entry_volume_mounted_or_unmounted),
      	(rhythmdb_volume_mounted_cb), (rhythmdb_volume_unmounted_cb):
      	* rhythmdb/rhythmdb-private.h:
      	* rhythmdb/rhythmdb-property-model.c:
      	(rhythmdb_property_model_set_property),
      	(rhythmdb_property_model_row_inserted_cb),
      	(rhythmdb_property_model_prop_changed_cb),
      	(rhythmdb_property_model_compare),
      	(rhythmdb_property_model_get_value),
      	(rhythmdb_property_model_iter_nth_child),
      	(rhythmdb_property_model_drag_data_delete), (query_model_cb),
      	(rhythmdb_property_model_drag_data_get),
      	(rhythmdb_property_model_enable_drag),
      	(rhythmdb_property_model_column_get_type):
      	* rhythmdb/rhythmdb-property-model.h:
      	* rhythmdb/rhythmdb-query-model.c:
      	(rhythmdb_query_model_class_init),
      	(rhythmdb_query_model_set_property),
      	(rhythmdb_query_model_dispose), (rhythmdb_query_model_chain),
      	(rhythmdb_query_model_has_pending_changes),
      	(rhythmdb_query_model_entry_changed_cb),
      	(rhythmdb_query_model_entry_deleted_cb), (idle_process_update),
      	(rhythmdb_query_model_add_entry),
      	(rhythmdb_query_model_remove_from_main_list),
      	(rhythmdb_query_model_remove_entry),
      	(rhythmdb_query_model_drag_data_received),
      	(rhythmdb_query_model_row_drop_possible),
      	(rhythmdb_query_model_compute_status_normal),
      	(rhythmdb_query_model_set_sort_order),
      	(rhythmdb_query_model_get_entry_index),
      	(rhythmdb_query_model_base_row_inserted),
      	(rhythmdb_query_model_base_row_deleted),
      	(rhythmdb_query_model_reapply_query), (_reverse_sorting_func),
      	(rhythmdb_query_model_date_sort_func),
      	(rhythmdb_query_model_within_limit):
      	* rhythmdb/rhythmdb-query-model.h:
      	* rhythmdb/rhythmdb-query-results.c:
      	(rhythmdb_query_results_query_complete):
      	* rhythmdb/rhythmdb-query-results.h:
      	* rhythmdb/rhythmdb-query.c: (rhythmdb_query_copy),
      	(rhythmdb_query_concatenate), (rhythmdb_query_parse_valist),
      	(rhythmdb_query_free), (rhythmdb_read_encoded_property),
      	(rhythmdb_query_serialize), (rhythmdb_query_deserialize),
      	(rhythmdb_query_preprocess), (rhythmdb_query_get_type):
      	* rhythmdb/rhythmdb-tree.c: (rhythmdb_tree_finalize),
      	(rhythmdb_tree_parser_start_element),
      	(rhythmdb_tree_parser_end_element), (rhythmdb_tree_load),
      	(save_entry), (save_entry_type), (save_unknown_entry_type),
      	(rhythmdb_tree_save), (rhythmdb_tree_entry_new),
      	(rhythmdb_tree_property_new), (get_genres_hash_for_type),
      	(get_or_create_genre), (remove_entry_from_album),
      	(rhythmdb_tree_entry_set), (rhythmdb_tree_entry_delete),
      	(remove_one_song), (rhythmdb_tree_entry_delete_by_type),
      	(search_match_properties), (evaluate_conjunctive_subquery),
      	(clone_remove_ptr_array_index), (conjunctive_query_albums),
      	(conjunctive_query_artists), (conjunctive_query_genre),
      	(conjunctive_query), (split_query_by_disjunctions),
      	(do_query_recurse), (rhythmdb_tree_entry_foreach),
      	(hash_tree_entries_foreach), (hash_tree_albums_foreach),
      	(hash_tree_artists_foreach), (hash_tree_genres_foreach),
      	(rhythmdb_hash_tree_foreach),
      	(rhythmdb_tree_entry_type_registered):
      	* rhythmdb/rhythmdb.c: (rhythmdb_class_init),
      	(metadata_field_from_prop), (extract_gtype_from_enum_entry),
      	(extract_nice_name_from_enum_entry), (rhythmdb_init),
      	(rhythmdb_execute_multi_stat_info_cb), (rhythmdb_event_free),
      	(rhythmdb_shutdown), (rhythmdb_finalize),
      	(rhythmdb_emit_entry_signals_idle), (process_added_entries_cb),
      	(rhythmdb_entry_insert), (rhythmdb_entry_new),
      	(rhythmdb_entry_example_new),
      	(set_metadata_string_default_unknown), (is_ghost_entry),
      	(rhythmdb_process_stat_event), (rhythmdb_add_import_error_entry),
      	(rhythmdb_process_metadata_load),
      	(rhythmdb_process_queued_entry_set_event),
      	(rhythmdb_process_events), (rhythmdb_execute_stat_info_cb),
      	(queue_stat_uri), (rhythmdb_entry_get), (entry_to_rb_metadata),
      	(rhythmdb_add_uri_with_type), (rhythmdb_load_thread_main),
      	(rhythmdb_load), (rhythmdb_save_thread_main), (rhythmdb_save),
      	(rhythmdb_entry_set), (rhythmdb_entry_set_internal),
      	(rhythmdb_entry_sync_mirrored), (rhythmdb_entry_delete),
      	(rhythmdb_entry_delete_by_type),
      	(rhythmdb_propid_from_nice_elt_name),
      	(rhythmdb_do_full_query_async_parsed), (rhythmdb_do_full_query),
      	(rhythmdb_compute_status_normal),
      	(rhythmdb_entry_register_type_alias),
      	(rhythmdb_entry_type_foreach), (song_can_sync_metadata),
      	(rhythmdb_entry_song_get_type), (rhythmdb_entry_ignore_get_type),
      	(rhythmdb_entry_import_error_get_type),
      	(rhythmdb_entry_podcast_post_get_type),
      	(rhythmdb_entry_podcast_feed_get_type),
      	(rhythmdb_entry_set_mount_point), (rhythmdb_entry_set_visibility),
      	(rhythmdb_sync_library_location), (rhythmdb_entry_get_string),
      	(rhythmdb_entry_get_ulong), (rhythmdb_entry_type_get_type):
      	* rhythmdb/rhythmdb.h:
      	* shell/main.c: (main), (load_uri_args), (handle_dbus_message):
      	* shell/rb-history.c: (rb_history_new), (rb_history_set_playing),
      	(rb_history_limit_size):
      	* shell/rb-history.h:
      	* shell/rb-play-order-linear-loop.c:
      	(rb_linear_play_order_loop_get_next):
      	* shell/rb-play-order-linear-loop.h:
      	* shell/rb-play-order-linear.c:
      	* shell/rb-play-order-linear.h:
      	* shell/rb-play-order-queue.c:
      	(rb_queue_play_order_playing_entry_removed):
      	* shell/rb-play-order-queue.h:
      	* shell/rb-play-order-random-by-age-and-rating.c:
      	* shell/rb-play-order-random-by-age-and-rating.h:
      	* shell/rb-play-order-random-by-age.c:
      	(rb_random_by_age_get_entry_weight):
      	* shell/rb-play-order-random-by-age.h:
      	* shell/rb-play-order-random-by-rating.c:
      	* shell/rb-play-order-random-by-rating.h:
      	* shell/rb-play-order-random-equal-weights.c:
      	* shell/rb-play-order-random-equal-weights.h:
      	* shell/rb-play-order-random.c: (rb_random_filter_history),
      	(rb_random_get_total_weight), (rb_random_play_order_get_next),
      	(rb_random_db_changed), (rb_random_playing_entry_changed),
      	(rb_random_db_entry_deleted):
      	* shell/rb-play-order-shuffle.c: (remove_from_history),
      	(add_randomly_to_history), (get_query_model_contents),
      	(rb_shuffle_playing_entry_changed):
      	* shell/rb-play-order-shuffle.h:
      	* shell/rb-play-order.c: (rb_play_order_class_init),
      	(rb_play_order_set_property),
      	(rb_play_order_playing_source_changed),
      	(rb_play_order_query_model_changed_cb),
      	(rb_play_order_query_model_changed),
      	(rb_play_order_entry_added_cb), (default_playing_entry_removed):
      	* shell/rb-play-order.h:
      	* shell/rb-playlist-manager.c: (rb_playlist_manager_class_init),
      	(rb_playlist_manager_init), (rb_playlist_manager_set_uimanager),
      	(rb_playlist_manager_set_property),
      	(rb_playlist_manager_parse_file),
      	(rb_playlist_manager_load_playlists),
      	(rb_playlist_manager_is_dirty), (rb_playlist_manager_save_data),
      	(rb_playlist_manager_save_playlists),
      	(rb_playlist_manager_new_playlist),
      	(rb_playlist_manager_new_playlist_from_selection_data),
      	(rb_playlist_manager_cmd_new_automatic_playlist),
      	(rb_playlist_manager_cmd_edit_automatic_playlist),
      	(_queue_track_cb), (rb_playlist_manager_cmd_delete_playlist),
      	(save_playlist_response_cb), (export_set_extension_cb),
      	(filter_get_export_filter_label), (setup_format_menu),
      	(rb_playlist_manager_cmd_save_playlist),
      	(rb_playlist_manager_get_playlists),
      	(rb_playlist_manager_get_playlist_names), (_get_playlist_by_name),
      	(rb_playlist_manager_delete_playlist),
      	(rb_playlist_manager_export_playlist):
      	* shell/rb-playlist-manager.h:
      	* shell/rb-removable-media-manager.c:
      	(rb_removable_media_manager_class_init),
      	(rb_removable_media_manager_dispose),
      	(rb_removable_media_manager_finalize),
      	(rb_removable_media_manager_set_property),
      	(split_drive_from_cdda_uri),
      	(rb_removable_media_manager_playing_uri_changed_cb),
      	(rb_removable_media_manager_load_media),
      	(rb_removable_media_manager_volume_mounted_cb),
      	(remove_volume_by_source),
      	(rb_removable_media_manager_source_deleted_cb),
      	(rb_removable_media_manager_volume_unmounted_cb),
      	(rb_removable_media_manager_mount_volume),
      	(rb_removable_media_manager_set_uimanager),
      	(rb_removable_media_manager_scan), (do_transfer),
      	(rb_removable_media_manager_cmd_copy_tracks):
      	* shell/rb-removable-media-manager.h:
      	* shell/rb-shell-clipboard.c: (rb_shell_clipboard_init),
      	(rb_shell_clipboard_finalize), (rb_shell_clipboard_constructor),
      	(rb_shell_clipboard_sync),
      	(rb_shell_clipboard_idle_poll_deletions),
      	(rb_shell_clipboard_cmd_add_to_playlist_new),
      	(rb_shell_clipboard_playlist_add_cb),
      	(rb_shell_clipboard_playlist_deleted_cb),
      	(rb_shell_clipboard_playlist_renamed_cb),
      	(rb_shell_clipboard_playlist_visible_cb),
      	(rb_shell_clipboard_playlist_added_cb):
      	* shell/rb-shell-player.c: (rb_shell_player_class_init),
      	(rb_shell_player_constructor), (volume_pre_unmount_cb),
      	(rb_shell_player_init), (rb_shell_player_set_property),
      	(rb_shell_player_new), (rb_shell_player_open_playlist_url),
      	(rb_shell_player_open_location),
      	(rb_shell_player_set_playing_entry),
      	(rb_shell_player_play_order_update_cb),
      	(rb_shell_player_jump_to_current), (rb_shell_player_do_previous),
      	(rb_shell_player_do_next), (rb_shell_player_do_previous_or_seek),
      	(rb_shell_player_cmd_previous), (rb_shell_player_cmd_next),
      	(rb_shell_player_cmd_play), (rb_shell_player_playpause),
      	(rb_shell_player_sync_volume), (rb_shell_player_sync_replaygain),
      	(gconf_song_position_slider_visibility_changed),
      	(rb_shell_player_entry_activated_cb),
      	(rb_shell_player_property_row_activated_cb),
      	(rb_shell_player_entry_changed_cb),
      	(rb_shell_player_sync_with_source), (rb_shell_player_sync_buttons),
      	(actually_set_playing_source),
      	(rb_shell_player_set_playing_source_internal),
      	(rb_shell_player_get_playing_song_duration), (eos_cb),
      	(rb_shell_player_error), (error_cb), (info_available_cb),
      	(grab_mmkey), (filter_mmkeys), (_idle_unblock_signal_cb),
      	(rb_shell_player_error_get_type):
      	* shell/rb-shell-player.h:
      	* shell/rb-shell-preferences.c: (rb_shell_preferences_init),
      	(rb_shell_preferences_append_page),
      	(share_check_button_toggled_cb),
      	(password_check_button_toggled_cb), (add_daap_preferences),
      	(rb_shell_preferences_column_check_changed_cb),
      	(rb_shell_preferences_sync_column_button),
      	(rb_shell_preferences_sync),
      	(rb_shell_preferences_browser_views_activated_cb):
      	* shell/rb-shell.c: (rb_shell_class_init), (rb_shell_init),
      	(rb_shell_set_property), (rb_shell_get_property),
      	(rb_shell_sync_state), (idle_save_rhythmdb), (rb_shell_finalize),
      	(construct_widgets), (construct_load_ui), (rb_shell_constructor),
      	(rb_shell_get_visibility), (rb_shell_set_visibility),
      	(rb_shell_sync_window_state), (rb_shell_db_entry_added_cb),
      	(rb_shell_register_entry_type_for_source),
      	(rb_shell_transfer_progress_cb), (rb_shell_playing_from_queue_cb),
      	(rb_shell_playing_entry_changed_cb), (rb_shell_select_source),
      	(rb_shell_player_stream_song_changed_cb),
      	(rb_shell_set_window_title),
      	(rb_shell_view_smalldisplay_changed_cb),
      	(rb_shell_view_queue_as_sidebar_changed_cb),
      	(rb_shell_cmd_plugins), (add_to_library_response_cb),
      	(rb_shell_cmd_add_folder_to_library),
      	(rb_shell_cmd_add_file_to_library),
      	(rb_shell_sync_pane_visibility), (rb_shell_sync_smalldisplay),
      	(sidepane_visibility_changed_cb), (toolbar_state_changed_cb),
      	(rb_shell_jump_to_entry_with_source), (tray_embedded_cb),
      	(session_die_cb), (save_yourself_cb), (rb_shell_session_init),
      	(handle_playlist_entry_cb), (rb_shell_load_uri),
      	(rb_shell_add_to_queue), (rb_shell_present),
      	(rb_shell_get_song_properties), (rb_shell_set_song_property),
      	(rb_shell_volume_widget_changed_cb),
      	(rb_shell_player_volume_changed_cb),
      	(rb_shell_ui_location_get_type):
      	* shell/rb-shell.h:
      	* shell/rb-source-header.c: (ui_manager_add_widget_cb),
      	(rb_source_header_init), (rb_source_header_set_source_internal),
      	(rb_source_state_sync), (rb_source_header_clear_search),
      	(rb_source_header_view_browser_changed_cb):
      	* shell/rb-source-header.h:
      	* shell/rb-statusbar.c: (rb_statusbar_construct),
      	(rb_statusbar_init), (rb_statusbar_finalize),
      	(rb_statusbar_set_property), (rb_statusbar_set_progress),
      	(rb_statusbar_source_status_changed_cb):
      	* shell/rb-statusbar.h:
      	* shell/rb-tray-icon.c: (rb_tray_icon_init),
      	(rb_tray_icon_constructor), (rb_tray_icon_finalize),
      	(rb_tray_icon_set_property), (rb_tray_icon_show_window_changed_cb),
      	(rb_tray_icon_get_geom), (rb_tray_icon_notify):
      	* sources/rb-audiocd-source.c: (rb_audiocd_source_constructor),
      	(rb_audiocd_create_track_entry):
      	* sources/rb-auto-playlist-source.c:
      	(rb_auto_playlist_source_class_init),
      	(rb_auto_playlist_source_constructor),
      	(rb_auto_playlist_source_new_from_xml), (impl_reset_filters),
      	(impl_search), (impl_receive_drag), (impl_save_contents_to_xml),
      	(rb_auto_playlist_source_query_complete_cb),
      	(rb_auto_playlist_source_do_query),
      	(rb_auto_playlist_source_set_query),
      	(rb_auto_playlist_source_browser_changed_cb),
      	(search_action_to_prop):
      	* sources/rb-auto-playlist-source.h:
      	* sources/rb-browser-source.c: (rb_browser_source_init),
      	(rb_browser_source_dispose), (search_action_to_prop),
      	(rb_browser_source_constructor),
      	(rb_browser_source_cmd_choose_genre),
      	(rb_browser_source_cmd_choose_artist),
      	(rb_browser_source_cmd_choose_album), (impl_search),
      	(rb_browser_source_browser_changed_cb),
      	(rb_browser_source_do_query):
      	* sources/rb-browser-source.h:
      	* sources/rb-daap-source.c: (rb_daap_source_class_init),
      	(rb_daap_source_init), (rb_daap_source_dispose),
      	(rb_daap_source_set_property), (start_browsing),
      	(rb_daap_sources_init), (rb_daap_sources_shutdown),
      	(rb_daap_source_connection_cb), (rb_daap_source_activate),
      	(rb_daap_source_cmd_disconnect), (rb_daap_source_find_for_uri),
      	(rb_daap_source_get_headers), (rb_daap_source_get_status):
      	* sources/rb-daap-source.h:
      	* sources/rb-import-errors-source.h:
      	* sources/rb-ipod-source.c: (rb_ipod_source_name_changed_cb),
      	(rb_ipod_source_init), (ipod_path_to_uri), (add_rb_playlist),
      	(add_ipod_song_to_db), (load_ipod_db_idle_cb),
      	(rb_ipod_load_songs), (rb_ipod_get_itunesdb_path),
      	(rb_ipod_is_volume_ipod), (hal_udi_is_ipod), (impl_get_ui_actions),
      	(impl_move_to_trash), (impl_receive_drag), (test_dir_on_ipod),
      	(ipod_mkdir_with_parents), (build_ipod_dir_name),
      	(generate_ipod_filename), (ipod_path_from_unix_path),
      	(impl_delete_thyself):
      	* sources/rb-iradio-source.c: (rb_iradio_source_class_init),
      	(rb_iradio_source_init), (rb_iradio_source_constructor),
      	(rb_iradio_source_new), (guess_uri_scheme),
      	(rb_iradio_source_add_station),
      	(rb_iradio_source_async_update_play_statistics),
      	(genre_selection_reset_cb), (rb_iradio_source_do_query),
      	(stations_view_drag_data_received_cb),
      	(rb_iradio_source_cmd_new_station):
      	* sources/rb-iradio-source.h:
      	* sources/rb-library-source.c: (rb_library_source_dispose),
      	(rb_library_source_constructor),
      	(rb_library_source_location_button_clicked_cb),
      	(impl_get_config_widget), (rb_library_source_library_location_cb),
      	(sanitize_path), (filepath_parse_pattern),
      	(layout_example_label_update),
      	(rb_library_source_layout_filename_changed), (build_filename),
      	(impl_can_paste), (impl_paste),
      	(rb_library_source_add_child_source),
      	(rb_library_source_sync_child_sources):
      	* sources/rb-library-source.h:
      	* sources/rb-missing-files-source.h:
      	* sources/rb-play-queue-source.c:
      	(rb_play_queue_source_constructor), (impl_show_entry_view_popup):
      	* sources/rb-play-queue-source.h:
      	* sources/rb-playlist-source-recorder.c:
      	(rb_playlist_source_recorder_class_init), (update_speed_combobox),
      	(_nautilus_burn_drive_eject), (burn_cd), (ask_rewrite_disc),
      	(rb_playlist_source_recorder_init),
      	(rb_playlist_source_recorder_new):
      	* sources/rb-playlist-source.c: (rb_playlist_source_constructor),
      	(rb_playlist_source_save_playlist),
      	(rb_playlist_source_entry_added_cb),
      	(rb_playlist_source_set_query_model),
      	(rb_playlist_source_add_to_map):
      	* sources/rb-podcast-source.c: (rb_podcast_source_class_init),
      	(rb_podcast_source_init), (rb_podcast_source_dispose),
      	(rb_podcast_source_finalize), (search_action_to_prop),
      	(rb_podcast_source_constructor), (rb_podcast_source_set_property),
      	(rb_podcast_source_get_property), (rb_podcast_source_new),
      	(impl_delete), (rb_podcast_source_songs_show_popup_cb),
      	(rb_podcast_source_feeds_show_popup_cb), (feed_select_change_cb),
      	(rb_podcast_source_show_browser), (construct_query_from_selection),
      	(rb_podcast_source_do_query), (impl_get_config_widget),
      	(rb_podcast_source_btn_file_change_cb),
      	(posts_view_drag_data_received_cb),
      	(rb_podcast_source_cmd_download_post),
      	(rb_podcast_source_cmd_cancel_download),
      	(rb_podcast_source_cmd_delete_feed),
      	(rb_podcast_source_cmd_properties_feed),
      	(rb_podcast_source_cmd_update_feed),
      	(rb_podcast_source_post_status_cell_data_func),
      	(rb_podcast_source_post_feed_cell_data_func),
      	(rb_podcast_source_post_date_cell_data_func),
      	(rb_podcast_source_load_finish_cb), (impl_receive_drag),
      	(rb_podcast_source_entry_activated_cb), (impl_can_add_to_queue),
      	(impl_add_to_queue), (rb_podcast_source_cmd_new_podcast),
      	(impl_get_status):
      	* sources/rb-podcast-source.h:
      	* sources/rb-removable-media-source.c:
      	(rb_removable_media_source_constructor):
      	* sources/rb-removable-media-source.h:
      	* sources/rb-source.h:
      	* sources/rb-sourcelist-model.c: (rb_sourcelist_model_class_init),
      	(rb_sourcelist_model_new), (rb_sourcelist_model_is_row_visible),
      	(rb_sourcelist_model_row_is_separator),
      	(rb_sourcelist_model_drag_data_received),
      	(rb_sourcelist_model_row_drop_possible), (path_is_droppable),
      	(rb_sourcelist_model_row_drop_position),
      	(rb_sourcelist_model_get_drag_target),
      	(rb_sourcelist_model_row_draggable),
      	(rb_sourcelist_model_drag_data_get),
      	(rb_sourcelist_model_row_inserted_cb),
      	(rb_sourcelist_model_get_group_path):
      	* sources/rb-sourcelist.c: (rb_sourcelist_append),
      	(match_source_to_iter), (rb_sourcelist_source_to_iter),
      	(rb_sourcelist_visible_source_to_iter),
      	(rb_sourcelist_edit_source_name),
      	(rb_sourcelist_selection_changed_cb), (button_press_cb),
      	(key_release_cb), (name_notify_cb), (icon_notify_cb),
      	(rb_sourcelist_title_cell_data_func), (source_name_edited_cb):
      	* sources/rb-static-playlist-source.c:
      	(rb_static_playlist_source_class_init),
      	(rb_static_playlist_source_constructor),
      	(rb_static_playlist_source_load_from_xml), (impl_reset_filters),
      	(impl_search), (rb_static_playlist_source_do_query),
      	(rb_static_playlist_source_browser_changed_cb),
      	(impl_receive_drag), (impl_save_contents_to_xml),
      	(rb_static_playlist_source_add_location_swapped),
      	(search_action_to_prop):
      	* sources/rb-static-playlist-source.h:
      	* widgets/bacon-volume.c: (bacon_volume_button_get_type):
      	* widgets/eggtrayicon.c: (egg_tray_icon_init),
      	(egg_tray_icon_get_orientation_property),
      	(egg_tray_icon_send_manager_message),
      	(egg_tray_icon_update_manager_window),
      	(egg_tray_icon_manager_window_destroyed), (egg_tray_icon_realize),
      	(egg_tray_icon_send_message), (egg_tray_icon_notify):
      	* widgets/eggtrayicon.h:
      	* widgets/rb-cell-renderer-pixbuf.c:
      	(rb_cell_renderer_pixbuf_get_property),
      	(rb_cell_renderer_pixbuf_set_property),
      	(rb_cell_renderer_pixbuf_get_size),
      	(rb_cell_renderer_pixbuf_render),
      	(rb_cell_renderer_pixbuf_activate):
      	* widgets/rb-cell-renderer-rating.c:
      	(rb_cell_renderer_rating_class_init),
      	(rb_cell_renderer_rating_get_property),
      	(rb_cell_renderer_rating_set_property),
      	(rb_cell_renderer_rating_get_size),
      	(rb_cell_renderer_rating_render),
      	(rb_cell_renderer_rating_activate):
      	* widgets/rb-dialog.c:
      	* widgets/rb-dialog.h:
      	* widgets/rb-druid.c: (rb_druid_init_widgets), (rb_druid_new),
      	(path_dialog_response_cb), (idle_set_sensitive), (do_response),
      	(rb_druid_page3_finish_cb):
      	* widgets/rb-entry-view.c: (rb_entry_view_class_init),
      	(rb_entry_view_init), (rb_entry_view_set_property),
      	(rb_entry_view_new), (rb_entry_view_play_count_cell_data_func),
      	(rb_entry_view_year_cell_data_func), (rb_entry_view_sync_sorting),
      	(rb_entry_view_get_sorting_type), (rb_entry_view_set_sorting_type),
      	(rb_entry_view_set_sorting_order),
      	(rb_entry_view_column_clicked_cb), (rb_entry_view_append_column),
      	(rb_entry_view_set_columns_clickable), (rb_entry_view_constructor),
      	(rb_entry_view_playing_song_changed),
      	(rb_entry_view_button_press_cb), (rb_entry_view_rows_reordered_cb),
      	(rb_entry_view_scroll_to_entry), (set_column_visibility),
      	(rb_entry_view_set_fixed_column_width),
      	(rb_entry_view_get_time_date_column_sample),
      	(rb_entry_view_state_get_type):
      	* widgets/rb-entry-view.h:
      	* widgets/rb-header.c: (rb_header_init), (rb_header_set_property),
      	(rb_header_sync), (slider_moved_timeout), (slider_moved_callback),
      	(changed_idle_callback), (rb_header_elapsed_changed_cb):
      	* widgets/rb-library-browser.c: (rb_library_browser_constructor),
      	(update_browser_property_visibilty),
      	(rb_library_browser_construct_query), (restore_selection),
      	(rebuild_child_model), (rb_library_browser_set_selection),
      	(rb_library_browser_set_model):
      	* widgets/rb-library-browser.h:
      	* widgets/rb-property-view.c: (rb_property_view_class_init),
      	(rb_property_view_set_property), (rb_property_view_reset),
      	(rb_property_view_get_model), (rb_property_view_constructor),
      	(rb_property_view_set_selection),
      	(rb_property_view_selection_changed_cb),
      	(rb_property_view_button_press_cb),
      	(rb_property_view_set_search_func):
      	* widgets/rb-query-creator-private.h:
      	* widgets/rb-query-creator-properties.c:
      	(integerCriteriaSetWidgetData), (yearCriteriaSetWidgetData),
      	(durationCriteriaCreateWidget), (durationCriteriaSetWidgetData),
      	(durationCriteriaGetWidgetData), (create_time_unit_option_menu),
      	(relativeTimeCriteriaCreateWidget),
      	(relativeTimeCriteriaSetWidgetData):
      	* widgets/rb-query-creator.c: (rb_query_creator_constructor),
      	(rb_query_creator_dispose), (rb_query_creator_load_query),
      	(rb_query_creator_new_from_query), (rb_query_creator_get_query),
      	(get_property_index_from_proptype), (select_criteria_from_value),
      	(create_property_option_menu), (create_criteria_option_menu),
      	(sort_option_menu_changed), (setup_sort_option_menu):
      	* widgets/rb-query-creator.h:
      	* widgets/rb-rating-helper.c: (rb_rating_install_rating_property),
      	(rb_rating_render_stars):
      	* widgets/rb-rating-helper.h:
      	* widgets/rb-rating.c: (rb_rating_expose):
      	* widgets/rb-rating.h:
      	* widgets/rb-search-entry.c: (rb_search_entry_clear),
      	(rb_search_entry_timeout_cb):
      	* widgets/rb-search-entry.h:
      	* widgets/rb-song-info.c: (rb_song_info_construct_single),
      	(rb_song_info_constructor), (rb_song_info_new),
      	(rb_song_info_set_entry_rating), (rb_song_info_populate_dialog),
      	(rb_song_info_update_location), (rb_song_info_backward_clicked_cb),
      	(rb_song_info_forward_clicked_cb), (rb_song_info_update_buttons),
      	(rb_song_info_query_model_changed_cb),
      	(rb_song_info_sync_entries_multiple),
      	(rb_song_info_sync_entry_single):
      	Strip all trailing whitespace.  Fixes #344293.
      e1101445
  33. 19 Jun, 2006 1 commit
    • James Livingston's avatar
      add a function that returns the same pointer it was passed. · 2cc507a5
      James Livingston authored
      2006-06-19  James Livingston  <doclivingston@gmail.com>
      
      	* lib/rb-util.c: (rb_copy_function):
      	* lib/rb-util.h: add a function that returns the same pointer it was
      	passed.
      
      	* rhythmdb/rhythmdb.h:
      	* rhythmdb/rhythmdb.c: (rhythmdb_entry_ref), (rhythmdb_entry_unref),
      	(rhythmdb_entry_get_type), (rhythmdb_entry_type_get_type): drop the
      	"db" parameter to rhythmdb_entry_{ref,unref}, and change RhythmDBEntry
      	and RhythmDBEntryType into boxed types. This allows them to be used
      	from python. Note that entry-types aren't actually reference counted
      	(yet).
      
      	* bindings/python/rb.defs:
      	* bindings/python/rhythmdb.defs:
      	* bindings/python/rhythmdb.override: Adapt to the above, and fix the
      	return types of some bindings.
      
      	* rhythmdb/rhythmdb.c: (rhythmdb_emit_entry_signals_idle),
      	(process_added_entries_cb), (rhythmdb_entry_finalize),
      	(rhythmdb_entry_delete):
      	* daapsharing/rb-daap-connection.c:
      	(rb_daap_connection_class_init), (rb_daap_connection_set_property),
      	(rb_daap_connection_get_property):
      	* plugins/generic-player/rb-generic-player-source.c:
      	(rb_generic_player_source_load_songs), (load_playlist_file):
      	* podcast/rb-podcast-manager.c: (rb_podcast_manager_class_init):
      	* rhythmdb/rhythmdb-property-model.c: (query_model_cb):
      	* rhythmdb/rhythmdb-query-model.c: (rhythmdb_query_model_finalize),
      	(idle_process_update), (rhythmdb_query_model_add_entry),
      	(rhythmdb_query_model_insert_into_main_list),
      	(rhythmdb_query_model_insert_into_limited_list),
      	(rhythmdb_query_model_remove_from_main_list),
      	(rhythmdb_query_model_remove_from_limited_list),
      	(rhythmdb_query_model_drag_data_received),
      	(rhythmdb_query_model_add_results),
      	(rhythmdb_query_model_get_column_type),
      	(rhythmdb_query_model_get_value):
      	* rhythmdb/rhythmdb-tree.c: (rhythmdb_tree_parser_end_element),
      	(rhythmdb_tree_entry_delete), (remove_one_song):
      	* shell/rb-play-order-linear-loop.c:
      	(rb_linear_play_order_loop_get_next),
      	(rb_linear_play_order_loop_get_previous):
      	* shell/rb-play-order-linear.c: (rb_linear_play_order_get_next),
      	(rb_linear_play_order_get_previous):
      	* shell/rb-play-order-queue.c: (rb_queue_play_order_get_next),
      	(rb_queue_play_order_get_previous):
      	* shell/rb-play-order-random.c: (rb_random_play_order_init),
      	(rb_random_filter_history), (rb_random_play_order_get_next),
      	(rb_random_play_order_go_next), (rb_random_db_changed),
      	(rb_random_playing_entry_changed):
      	* shell/rb-play-order-shuffle.c: (rb_shuffle_play_order_init),
      	(remove_from_history), (add_randomly_to_history),
      	(rb_shuffle_db_changed), (rb_shuffle_playing_entry_changed):
      	* shell/rb-play-order.c: (rb_play_order_class_init),
      	(rb_play_order_set_property), (rb_play_order_get_property),
      	(rb_play_order_update_have_next_previous):
      	* shell/rb-play-order.h:
      	* shell/rb-shell-clipboard.c:
      	(rb_shell_clipboard_process_deletions),
      	(rb_shell_clipboard_entry_deleted_cb), (add_playlist_to_menu):
      	* sources/rb-audiocd-source.c: (rb_audiocd_create_track_entry):
      	* sources/rb-auto-playlist-source.c:
      	(rb_auto_playlist_source_constructor):
      	* sources/rb-browser-source.c: (rb_browser_source_class_init),
      	(rb_browser_source_set_property), (rb_browser_source_get_property),
      	(rb_browser_source_do_query):
      	* sources/rb-daap-source.c: (rb_daap_source_connection_cb):
      	* sources/rb-import-errors-source.c: (rb_import_errors_source_new):
      	* sources/rb-ipod-source.c: (add_rb_playlist),
      	(add_ipod_song_to_db), (impl_paste):
      	* sources/rb-iradio-source.c: (rb_iradio_source_class_init),
      	(rb_iradio_source_set_property), (rb_iradio_source_get_property):
      	* sources/rb-library-source.c: (layout_example_label_update):
      	* sources/rb-missing-files-source.c:
      	(rb_missing_files_source_class_init),
      	(rb_missing_files_source_set_property),
      	(rb_missing_files_source_get_property),
      	(rb_missing_files_source_new):
      	* sources/rb-playlist-source.c: (rb_playlist_source_class_init),
      	(rb_playlist_source_set_property),
      	(rb_playlist_source_get_property):
      	* sources/rb-podcast-source.c: (rb_podcast_source_class_init),
      	(rb_podcast_source_set_property), (rb_podcast_source_get_property),
      	(construct_query_from_selection):
      	* sources/rb-removable-media-source.c: (impl_delete_thyself):
      	* sources/rb-static-playlist-source.c:
      	(rb_static_playlist_source_constructor),
      	(rb_static_playlist_source_add_location_internal):
      	* widgets/rb-entry-view.c: (rb_entry_view_class_init):
      	* widgets/rb-header.c: (rb_header_class_init),
      	(rb_header_set_property), (rb_header_get_property):
      	* widgets/rb-library-browser.c: (rb_library_browser_class_init),
      	(rb_library_browser_set_property),
      	(rb_library_browser_get_property):
      	* widgets/rb-song-info.c: (rb_song_info_class_init),
      	(rb_song_info_get_property): Adjust for the _ref/_unref prototype
      	change, do s/pointer/boxed/ in many places and free entry-types
      	properly.
      2cc507a5
  34. 16 May, 2006 1 commit
    • Jonathan Matthew's avatar
      Add a function for formatting an elapsed time string. · 7c0fa51e
      Jonathan Matthew authored
      2006-05-16  Jonathan Matthew  <jonathan@kaolin.wh9.net>
      
      	* lib/rb-util.c: (rb_make_duration_string),
      	(rb_make_elapsed_time_string):
      	* lib/rb-util.h:
      	Add a function for formatting an elapsed time string.
      
      	* shell/rb-shell-player.c: (rb_shell_player_init),
      	(rb_shell_player_sync_with_source),
      	(rb_shell_player_get_playing_time_string), (tick_cb):
      	Store elapsed time in the private data structure, and use the above
      	function.
      
      	* widgets/rb-header.c:
      	* widgets/rb-header.h:
      	Make RBHeader use the RBShellPlayer object, rather than the RBPlayer
      	object, so everything has the same idea of the elapsed time.
      	Fixes #339693.
      7c0fa51e
  35. 15 May, 2006 1 commit
  36. 26 Apr, 2006 1 commit
    • James Livingston's avatar
      Turn RBPlayer into a full gobject interface, with RBPlayerGst as an · a415f8e3
      James Livingston authored
      2006-04-26  James Livingston  <doclivingston@gmail.com>
      
              Turn RBPlayer into a full gobject interface, with RBPlayerGst as an
              implementing class. In theory allows alternate player implementations
              to be selected at run-time rather than compile-time. Fixes bug 338667.
      
              * Makefile.am:
              * backends/Makefile.am:
              * backends/gstreamer/Makefile.am:
              * backends/gstreamer/rb-player-gst.h:
              * backends/rb-player.c: (rb_player_interface_init),
              (rb_player_get_type), (rb_player_open), (rb_player_opened),
              (rb_player_close), (rb_player_play), (rb_player_pause),
              (rb_player_playing), (rb_player_set_volume),
              (rb_player_get_volume), (rb_player_set_replaygain),
              (rb_player_seekable), (rb_player_set_time), (rb_player_get_time),
              (rb_player_new), (_rb_player_emit_eos), (_rb_player_emit_info),
              (_rb_player_emit_buffering), (_rb_player_emit_error),
              (_rb_player_emit_tick), (rb_player_error_quark):
              * player/Makefile.am:
              * player/rb-player-gst.c: (rb_player_gst_class_init),
              (rb_player_init), (tick_timeout), (rb_player_gst_init),
              (rb_player_gst_finalize), (rb_player_gst_gst_free_playbin),
              (destroy_idle_signal), (emit_signal_idle), (eos_cb), (error_cb),
              (process_tag), (found_tag_cb), (buffering_cb),
              (rb_player_gst_bus_cb), (rb_player_gst_construct),
              (rb_player_gst_new):
              * player/rb-player.h:
              * shell/Makefile.am:
              * sources/rb-audiocd-source.c:
              * widgets/Makefile.am:
              * widgets/rb-header.c: (rb_header_class_init):
      a415f8e3
  37. 20 Apr, 2006 1 commit
  38. 10 Apr, 2006 1 commit
  39. 18 Mar, 2006 1 commit
    • James Livingston's avatar
      fix type-punning warnings. Closes bug 332992. · 62b85bf7
      James Livingston authored
      * rhythmdb/rb-refstring.c: (rb_refstring_get_folded),
        (rb_refstring_get_sort_key): fix type-punning warnings. Closes bug
        332992.
      
      * widgets/rb-header.c: don't make artist/album info in the header the
        small size, since it's hard to read.
      62b85bf7
  40. 14 Mar, 2006 1 commit