Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pygobject pygobject
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 302
    • Issues 302
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 31
    • Merge requests 31
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • pygobjectpygobject
  • Merge requests
  • !214

pygi-closure: Use new girepository closure api

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Michel Fodje requested to merge michel4j/pygobject:master into master Oct 29, 2022
  • Overview 3
  • Commits 2
  • Pipelines 0
  • Changes 2

Fixes #556 and probably also #535

Replaced deprecated g_callable_info_prepare_closure and g_callable_info_free_closure with new APIs g_callable_info_create_closure and g_callable_info_destroy_closure. The pointer from to g_callable_info_create_closure is passed to g_callable_info_get_closure_native_address to obtain another pointer equivalent to the return value from the old prepare_closure API and then is saved to a new field in PyGICClosure. The value of the new field is used for freeing with g_callable_info_destroy_closure. The previous code called g_callable_info_free_closure which does nothing and leaks memory resulting in issue #556.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master