1. 14 Feb, 2019 1 commit
    • Florian Müllner's avatar
      ci: Check for issue/MR URLs in commit messages · d5880a11
      Florian Müllner authored
      Commit messages should include the full URL to an issue or merge
      request to keep associated information easily available in future
      log digging.
      
      Jonas came up with a script to enforce that policy for mutter and
      gnome-shell. It's an excellent idea, so adopt it here as well.
      
      !89
      d5880a11
  2. 07 Feb, 2019 4 commits
  3. 05 Feb, 2019 1 commit
  4. 03 Feb, 2019 1 commit
  5. 28 Jan, 2019 2 commits
  6. 24 Jan, 2019 4 commits
    • Florian Müllner's avatar
      mainWindow: Never show fallback app menu · f8ce0078
      Florian Müllner authored
      Now that the app menu's action have been moved inside the window and
      the menu is only kept around to have GNOME's fallback work correctly,
      there is no need for GTK's fallback menu under shells that don't
      show the app menu, so filter it out from the decoration layout.
      
      !53
      f8ce0078
    • Florian Müllner's avatar
      ui: Move app menu into window · 140369fd
      Florian Müllner authored
      GNOME is phasing out the app menu[0], so move its actions into a
      hamburger menu inside the headerbar. Eventually we will remove
      the app menu altogether, but for now we keep the 'quit' action
      to mimic GNOME Shell's fallback menu, so that the action behaves
      as expected (namely, quit the application instead of sending it
      to the background if the corresponding option is set).
      
      [0] https://wiki.gnome.org/Design/Whiteboards/AppMenuMigration
      
      !53
      140369fd
    • Florian Müllner's avatar
      mainWindow: Remove close confirmation dialog · 2b866707
      Florian Müllner authored
      Now that the run-in-background setting no longer affects autostart,
      the checkbox in the menu is self-explanatory enough and we no longer
      need a one-time dialog to explain the feature.
      
      As an added benefit the feature becomes less intrusive, as users
      can discover it at their own pace rather than having a choice
      forced upon them when using the app for the first time.
      
      #89
      2b866707
    • Florian Müllner's avatar
      app: Do not auto-enable autostart when running in background · 334c635f
      Florian Müllner authored
      Polari is a user application rather than a service, so whether it should
      be started at login is better left to the user than tied to the desire
      to get its window out of the way.
      
      We also never put the hacks and sandbox holes in place that would have
      made it work with flatpak, so this also removes an inconsistency between
      distribution channels.
      
      #89
      334c635f
  7. 21 Jan, 2019 1 commit
  8. 20 Jan, 2019 2 commits
  9. 10 Jan, 2019 1 commit
  10. 03 Dec, 2018 6 commits
    • Florian Müllner's avatar
      application: Avoid duplicated ::prepare-shutdown emissions · 725a41a5
      Florian Müllner authored
      Since commit 00ab02ca added the ability to run in the background,
      the ::prepare-shutdown signal is emitted either when the main window
      is closed (and the app shouldn't keep running), or when explicitly
      quitting the app. But as the quit action also closes all windows, it
      is possible for the signal to be emitted twice, resulting in a warning
      when the telepathy client releases an additional app reference (it
      doesn't hold).
      
      Avoid this by making sure the signal handler which emits the signal
      when closing the main window is disconnected from the quit action.
      
      !79
      725a41a5
    • Florian Müllner's avatar
      mainWindow: Don't destroy notification queues with window · 53939f8f
      Florian Müllner authored
      Both queues are owned by the application, which may outlive the main
      window. It probably makes sense to rethink the ownership in the future,
      but for now avoid warnings from follow-up main windows by not destroying
      them with the previous window.
      
      !79
      53939f8f
    • Florian Müllner's avatar
      mainWindow: Disconnect roomManager signals on destroy · a99b5f5d
      Florian Müllner authored
      The room mananager is a singleton whose lifecycle is tied to the
      application, while any widget's lifecycle is tied to the window.
      App- and window lifecycle are different when Polari is set up to
      keep running in the background, so disconnect the signals to avoid
      warnings.
      
      !79
      a99b5f5d
    • Florian Müllner's avatar
      roomStack: Disconnect roomManager signals on destroy · bf7d2366
      Florian Müllner authored
      The room mananager is a singleton whose lifecycle is tied to the
      application, while any widget's lifecycle is tied to the window.
      App- and window lifecycle are different when Polari is set up to
      keep running in the background, so disconnect the signals to avoid
      warnings.
      
      !79
      bf7d2366
    • Florian Müllner's avatar
      chatView: Fix warning on shutdown · 1605f61a
      Florian Müllner authored
      One reason for a nick status change is that we disconnect the account.
      If we also close the corresponding room at the same time (for example
      on shutdown), there's a good chance that the room's channel property
      is unset after we send the request to ack all pending messages, but
      before the operation's callback is called. Avoid accessing an undefined
      property in that case by using the callback parameter, which will still
      be alive under all circumstances at that point.
      
      !79
      1605f61a
    • Florian Müllner's avatar
      chatView: Remove left-over code · 0743025d
      Florian Müllner authored
      The "early" return became pointless when commit d557dfef removed all
      the code that followed it.
      
      !79
      0743025d
  11. 10 Nov, 2018 2 commits
  12. 01 Nov, 2018 1 commit
  13. 28 Oct, 2018 1 commit
  14. 27 Oct, 2018 1 commit
  15. 26 Oct, 2018 1 commit
  16. 24 Oct, 2018 1 commit
  17. 22 Oct, 2018 1 commit
  18. 15 Oct, 2018 3 commits
  19. 14 Oct, 2018 1 commit
  20. 06 Oct, 2018 3 commits
  21. 04 Oct, 2018 1 commit
  22. 03 Oct, 2018 1 commit