1. 19 Apr, 2019 1 commit
    • Florian Müllner's avatar
      Update .gitignore · 3a4729b3
      Florian Müllner authored
      The autotools compatibility stuff added in commit d71ed111 is long
      gone, so no need to account for Makefile.
      Exclude gnome-builder's .buildconfig and the generated po template.
  2. 18 Apr, 2019 1 commit
  3. 17 Apr, 2019 4 commits
  4. 11 Apr, 2019 1 commit
  5. 08 Apr, 2019 2 commits
  6. 07 Apr, 2019 1 commit
  7. 04 Apr, 2019 8 commits
    • Florian Müllner's avatar
      cleanup: Use find/findIndex over loops · c1176056
      Florian Müllner authored
      Now that gjs was updated to a SpiderMonkey version that supports the
      more idiomatic methods, use those instead of implementing lookups as
    • Florian Müllner's avatar
      cleanup: Simplify signal disconnections · 2c4d6647
      Florian Müllner authored
      Use forEach instead of explicit loops for a more concise and
      idiomatic style.
    • Florian Müllner's avatar
      roomList: Clarify a helper function · fafe095e
      Florian Müllner authored
      for-loops with multiple variables are hard to read, come up with
      an easier (and more concise) alternative.
    • Florian Müllner's avatar
      joinDialog: Remove obsolete comment · 509a0ceb
      Florian Müllner authored
      There used to be a vague idea about sorting networks by recency,
      frequency or similar, mostly to make it more likely that the
      desired network is selected when the dialog is opened.
      This was addressed differently by remembering the last used network,
      so this is no longer an issue. And the predictable alphabetical order
      used now likely makes most sense.
    • Florian Müllner's avatar
      lint: Enforce consistent brace style of blocks · 20fd0a8e
      Florian Müllner authored
      Now that we have tweaked the existing use of braces to what's possible
      with eslint, turn on a corresponding rule to enforce the style auto-
    • Florian Müllner's avatar
      style: Only omit braces for single-line statements · df41fc06
      Florian Müllner authored
      We currently omit braces if all blocks consist of a single statement,
      but the statement itself may still be spread over multiple lines.
      In some places we are stretching it, but in general it's fine. Except
      that if we want to automate the rule, eslint forces us to pick between
      single-statement without, and single-line with nested handling.
    • Florian Müllner's avatar
      style: Always use braces when nesting blocks · aebfebf5
      Florian Müllner authored
      We usually avoid braces if the outer block contains a single statement,
      except when that would result in ambiguity or worse legibility.
      Unfortunately that's a matter of taste that cannot be expressed in an
      automated rule. As removing the braces in the cases where we have them
      would be worse than adding them where they are avoided, settle
      on the latter.
    • Florian Müllner's avatar
      style: Omit braces if all blocks are single lines · 5c13b55f
      Florian Müllner authored
      This has always been the coding style (inherited from gjs/gnome-shell),
      but some violations have sneaked in over time.
  8. 03 Apr, 2019 1 commit
    • Daronion's avatar
      telepathyClient: Change notification title for private chats · ceb76423
      Daronion authored
      The notification title made sense for normal rooms, but it is weird
      for private chats since nick and room.display_name are the same.
      (Example: Daronion in daronion)
      This change makes it so that the titles is set to the sender's nickname
      only for private rooms.
  9. 02 Apr, 2019 3 commits
    • Daronion's avatar
      telepathyClient: Use normal notifications on non-GNOME desktops · f4a54f34
      Daronion authored
      Notifications are currently only used for highlights in chat rooms,
      as we assume that GNOME's builtin chat integration will handle private
      conversation notifications. This is not available on other desktops, so
      we should notify in that case as well.
    • Daronion's avatar
      room: Change highlighting behavior of private chats · a8f51362
      Daronion authored
      We never highlight any messages in private chats, not least
      because we assume that the desktop handles notifications for
      them. That assumption isn't necessarily true (not even for
      GNOME anymore), so this is a good opportunity to reflect what
      behavior we actually want for private chats:
       - show notifications for any message (either by the desktop or
       - highlight any unread message in the sidebar
       - don't highlight any message in the chat log (because a bold
         font weight isn't effective when used for everything)
      Only the last point matches what should_highlight() currently does,
      however as conceptually *all* private messages are important, it
      makes more sense reflect that in the method and special-case the
      caller in chatView.
    • Florian Müllner's avatar
      telepathyClient: Monitor gnome-shell's built-in chat client · 2cd26e82
      Florian Müllner authored
      We currently assume that notifications for private chats are handled
      by gnome-shell's chat integration, but that
       - is obviously only available on the GNOME desktop
       - has been optional for some time
      Before we can start handling notifications for private chats as well, we
      need to know when should do that. So as a first step, monitor the session
      bus for gnome-shell's built-in chat client.
  10. 28 Mar, 2019 1 commit
  11. 12 Mar, 2019 6 commits
    • Florian Müllner's avatar
      ci: Bump the warning-level · a1844773
      Florian Müllner authored
      With the previous fixes, we can now build with an increased warning
      level to catch more errors. Unfortunately we cannot use the highest
      level, as the platform itself relies on some features that -Wpedantic
      complains about.
    • Florian Müllner's avatar
      lib: Mark unused parameters · 24a50216
      Florian Müllner authored
      For signal handlers and callbacks, we have to obey the method signature
      of the API, so any unused parameters have a legitimate reason there and
      we don't want -Wunused-parameter to warn about them.
    • Florian Müllner's avatar
      main: Fix signedness error · e14f5312
      Florian Müllner authored
      The G_N_ELEMENTS() macro is implemented with sizeof, which yields
      a value of (the unsigned) type size_t. It is always better to use
      types with matching signedness in comparisons instead of relying
      on integer promotion, so make the corresponding variables unsigned
      as well.
    • Florian Müllner's avatar
      lib: Use more g_auto() · c1dfde27
      Florian Müllner authored
    • Florian Müllner's avatar
      mainWindow: Avoid warning when no room was selected previously · dbb428c0
      Florian Müllner authored
      On startup we first load the previously joined rooms, then select
      the last selected one. However the setting for the latter may return
      an empty object (when there were no rooms to restore), resulting in
      a JS warning about accessing an undefined property.
      Add a check to avoid that warning.
    • Florian Müllner's avatar
      flatpak: Update telepathy repositories · 992a98dd
      Florian Müllner authored
      As freedesktop migrates to gitlab, telepathy moved to github.
  12. 11 Mar, 2019 1 commit
  13. 07 Mar, 2019 1 commit
  14. 06 Mar, 2019 1 commit
  15. 05 Mar, 2019 1 commit
  16. 04 Mar, 2019 1 commit
  17. 03 Mar, 2019 2 commits
  18. 28 Feb, 2019 4 commits