1. 21 May, 2019 1 commit
    • Florian Müllner's avatar
      room: Add :channel-error property · 0f0a6024
      Florian Müllner authored
      While we have TpAccount:connection-error to indicate problems with
      a network connection as a whole, we don't have any indication for
      errors that happen during channel creation (for example a full or
      invite-only room).
      
      Add a new :channel-error property that can be used to pass around
      such an error condition.
      
      #17
      0f0a6024
  2. 02 Apr, 2019 1 commit
    • Daronion's avatar
      room: Change highlighting behavior of private chats · a8f51362
      Daronion authored
      We never highlight any messages in private chats, not least
      because we assume that the desktop handles notifications for
      them. That assumption isn't necessarily true (not even for
      GNOME anymore), so this is a good opportunity to reflect what
      behavior we actually want for private chats:
      
       - show notifications for any message (either by the desktop or
         ourselves)
      
       - highlight any unread message in the sidebar
      
       - don't highlight any message in the chat log (because a bold
         font weight isn't effective when used for everything)
      
      Only the last point matches what should_highlight() currently does,
      however as conceptually *all* private messages are important, it
      makes more sense reflect that in the method and special-case the
      caller in chatView.
      
      #18
      a8f51362
  3. 12 Mar, 2019 2 commits
  4. 29 Aug, 2018 2 commits
    • Florian Müllner's avatar
      room: Consider account nick for highlighting · 4ecc88a3
      Florian Müllner authored
      Using the basenick to group nicks that refer to the same identity works
      fairly well for most nicks. A notable exceptions are multi-word nicks
      that use dashes or underscores as separator. We can't do much in that
      case for other contacts where all we have is the nickname, but in case
      of the user's own nick we have more data points we can use to get a
      better result - namely the nickname that has been configured for the
      account.
      
      Use that to improve the accuracy of message highlighting, which
      constitutes the main annoyance for affected users.
      
      #69
      4ecc88a3
    • Florian Müllner's avatar
      room: Plug a leak · 3b663758
      Florian Müllner authored
      We currently only free the string on nick updates, but not when
      disposing the room object itself.
      
      #69
      3b663758
  5. 13 Jul, 2018 1 commit
    • Florian Müllner's avatar
      room: Split out nick matching into a utility function · 1bde9e94
      Florian Müllner authored
      Nick highlighting is important to get right, which is why we try to
      be smarter than simply matching for the current nick. As that makes
      the code more complex and thus more prune to bugs, it is worth cove-
      ring in unit testing. Splitting out the matching logic into a utility
      function will allow us to do so without setting up a telepathy test
      environment.
      
      #53
      1bde9e94
  6. 08 Dec, 2017 2 commits
    • Florian Müllner's avatar
      lib: Move to autofree/autoptr · 48fa1c7d
      Florian Müllner authored
      Modern compilers allow to clean up variables automatically when they go
      out of scope; we don't really care about other compilers, so simplify
      the code by stop doing manual memory management of local variables.
      48fa1c7d
    • Florian Müllner's avatar
      lib: Bulk-connect channel signals · 356186ef
      Florian Müllner authored
      GObject has some convenience functions to connect/disconnect multiple
      signals at once, which comes handy for the various TpChannel signals
      we use.
      356186ef
  7. 21 Jun, 2017 1 commit
  8. 24 Apr, 2017 1 commit
  9. 04 Mar, 2017 1 commit
  10. 09 Oct, 2016 1 commit
  11. 23 Sep, 2016 1 commit
  12. 29 Aug, 2016 2 commits
    • Florian Müllner's avatar
      room: Add method to send "identify" messages · fcff3a7b
      Florian Müllner authored
      The method is a thin wrapper around tp_text_channel_send_message_async()
      which doesn't add much convenience, but it allows us to differentiate
      between the "identify" messages sent by the user and the ones we send
      automatically, so that we don't ask the user whether to save the saved
      password again ...
      
      https://bugzilla.gnome.org/show_bug.cgi?id=709982
      fcff3a7b
    • Florian Müllner's avatar
      room: Emit ::identify-sent signal when detecting authbot identification · c1918ee3
      Florian Müllner authored
      We want to offer users that have their nickname registered with an
      authbot like NickServ the option to store the password and handle
      the identification automatically when connecting. For that we need
      to detect the "identify" command sent to a bot first - asking the
      user whether the password should be saved will be done differently
      depending on whether the command is actually send from the room's
      view or via a /msg command (or GNOME Shell's chat integration) instead,
      so handling the detection in a shared component as the room itself
      makes sense.
      In the future we might want to hide authbot channels entirely from the
      UI unless the user explicitly initiates the communication, in which
      case the detection/signal would be better off in the channel. However
      that would be more involved as it involves implementing a custom client
      factor, so this should do for now ...
      
      https://bugzilla.gnome.org/show_bug.cgi?id=709982
      c1918ee3
  13. 10 Jul, 2016 5 commits
  14. 27 Feb, 2016 1 commit
  15. 17 Feb, 2016 1 commit
  16. 10 Feb, 2016 1 commit
  17. 09 Feb, 2016 1 commit
    • Florian Müllner's avatar
      room: Fix callback signatures · 87e0b515
      Florian Müllner authored
      The GError in the get_all() callback should be const, and the
      properties_changed() callback's 'invalidated' parameter is an
      array of strings, not a string - whoops ...
      87e0b515
  18. 29 Jan, 2016 1 commit
  19. 18 Oct, 2015 1 commit
  20. 01 Oct, 2015 4 commits
  21. 21 Sep, 2015 3 commits
  22. 17 Sep, 2015 5 commits
  23. 04 Sep, 2015 1 commit