Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
pitivi
pitivi
  • Project
    • Project
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 186
    • Issues 186
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 9
    • Merge Requests 9
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Registry
    • Registry
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GNOME
  • pitivipitivi
  • Merge Requests
  • !99

Closed
Opened Dec 06, 2018 by Christopher Davis@BrainBlasted
  • Report abuse
Report abuse

menu: Use GtkPopoverMenu instead of GtkMenu for primary menu

Popovers are recommended for primary menus; In addition, the migration from the app menu introduced new conventions like using "About [App]" instead of "About", and grouping Preferences with About, Help, and Keyboard Shortcuts.

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.gnome.org/BrainBlasted/pitivi.git use-popover-instead-of-menu
git checkout -b BrainBlasted/pitivi-use-popover-instead-of-menu FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff BrainBlasted/pitivi-use-popover-instead-of-menu

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 10
  • Commits 1
  • Pipelines 1
  • Changes 2
Assignee
No assignee
Assign to
1.0
Milestone
1.0
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: GNOME/pitivi!99