Tests pass when they should fail if .py files are broken
Add some garbage to a .py
file, such as importing a non-existing class, notice tests pass:
$ ptvtests
Running in sandbox: gst-validate-launcher /home/aleb/dev/pitivi/pitivi/tests/ptv_testsuite.py
flatpak build --socket=x11 --socket=wayland --talk-name=org.freedesktop.Flatpak --socket=session-bus --socket=pulseaudio --share=network --env=PITIVI_DEVELOPMENT=1 --env=PYTHONUSERBASE=/app/ --env=CC=ccache gcc --env=CXX=ccache g++ --device=dri --env=LANG=en_US.utf8 --env=DISPLAY=:1 --env=PITIVI_REPO_DIR=/home/aleb/dev/pitivi/pitivi --env=GST_ENCODING_TARGET_PATH=/app/share/gstreamer-1.0/encoding-profiles/:/app/share/pitivi/encoding-profiles/: --env=GST_PLUGIN_SYSTEM_PATH=/app/lib/gstreamer-1.0/: --env=FREI0R_PATH=/app/lib/frei0r-1/: --env=GST_PRESET_PATH=/app/share/gstreamer-1.0/presets/:/app/share/pitivi/gstpresets/: /home/aleb/dev/pitivi/pitivi-prefix gst-validate-launcher /home/aleb/dev/pitivi/pitivi/tests/ptv_testsuite.py
fatal: not a git repository (or any of the parent directories): .git
Failed to import test module: test_application
Traceback (most recent call last):
File "/usr/lib/python3.7/unittest/loader.py", line 436, in _find_test_path
module = self._get_module_from_name(name)
File "/usr/lib/python3.7/unittest/loader.py", line 377, in _get_module_from_name
__import__(name)
File "/home/aleb/dev/pitivi/pitivi/tests/test_application.py", line 26, in <module>
from pitivi import application
File "/home/aleb/dev/pitivi/pitivi/pitivi/application.py", line 34, in <module>
from pitivi.mainwindow import MainWindow
File "/home/aleb/dev/pitivi/pitivi/pitivi/mainwindow.py", line 31, in <module>
from pitivi.editorperspective import EditorPerspective
File "/home/aleb/dev/pitivi/pitivi/pitivi/editorperspective.py", line 41, in <module>
from pitivi.timeline.timeline import TimelineContainer
File "/home/aleb/dev/pitivi/pitivi/pitivi/timeline/timeline.py", line 29, in <module>
from pitivi.autoaligner import AlignmentProgressDialog
File "/home/aleb/dev/pitivi/pitivi/pitivi/autoaligner.py", line 38, in <module>
from pitivi.utils.ui import beautify_ETA
ImportError: cannot import name 'beautify_ETA' from 'pitivi.utils.ui' (/home/aleb/dev/pitivi/pitivi/pitivi/utils/ui.py)
[...]
Running 16 tests...
[16 / 16] ptv_testsuite.tests.test_log.TestOwnLogHandler.testOwnLogHandlerLimited: Passed
Statistics:
-----------
Total time spent: 0:00:13.729221 seconds
Passed: 16
Failed: 0
---------
Total: 16