Enhance the way we handle clip scaling when changing project video size.
Testing out the 1.0 RC through flatpak, I opened up this previous very simple test project with only one clip in it:
And when I open it, it shows up with the viewer having the wrong aspect ratio (it looks like 4:3), which kinda makes sense because for some reason that existing xges file had properties of 720x576 instead of 1280x720.
But from here it gets weird: if you try to apply the clip's properties (using the tool for that in the media library) to the project settings, you get this:
...the clip has become the result of a clip transformation! And this is the resulting xges file:
Additionally, you see this in the terminal:
ERROR 10:09:37 pipeline pitivi+utils+pipeline+pipeline0 _handleErrorMessage: error from <__gi__.GstVideoTestSrc object at 0x7f16a8112d80 (GstVideoTestSrc at 0x5563af9202c0)>: gst-stream-error-quark: Internal data stream error. (1) (../libs/gst/base/gstbasesrc.c(3072): gst_base_src_loop (): /pitivi+utils+pipeline+Pipeline:pitivi+utils+pipeline+pipeline0/GESTimeline:gestimeline0/GESVideoTrack:gesvideotrack0/NleComposition:video_nlecomposition0/GstBin:current-bin/NleSource:nlesource6/GstBin:bin5/GstVideoTestSrc:src: streaming stopped, reason not-negotiated (-4)) (../../app/lib/pitivi/python/pitivi/utils/pipeline.py:485) ERROR 10:09:37 pipeline pitivi+utils+pipeline+pipeline0 _recover: Resetting pipeline because error detected during playback. Try 1 (../../app/lib/pitivi/python/pitivi/utils/pipeline.py:472)
Interestingly enough, if you edit by hand the original .xges file to set the resolution to 1280x720 and open it with Pitivi, it shows up with the same weird "clip transformation" going on.