Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • pitivi pitivi
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 196
    • Issues 196
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 32
    • Merge requests 32
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • pitivipitivi
  • Merge requests
  • !94

effects: Remove properties values cache

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Alexandru Băluț requested to merge aleb/pitivi:complex-effects into 1.0 Nov 22, 2018
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

Fixes the backtraces seen in #2259 (closed).

In case of the aspectratiocrop effect, changing the aspect ratio value leads to other props being automatically changed. The UI was automatically updated and then the widget change triggered the same mechanism used when the user changes a property. This consists of a new toplevel undoable operation being created, when one was already being recorded.

There was already a mechanism to prevent this, starting the toplevel operation only if the value from the widget and the current property value actually differ, but it was broken:

  • It was using a cache which was not kept up to date
  • The cache was holding (bool, value) instead of just value

I removed the cache as we don't see any usefulness for it.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: complex-effects