Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • pitivi pitivi
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 193
    • Issues 193
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 26
    • Merge requests 26
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOME
  • pitivipitivi
  • Merge requests
  • !402

Merged
Created Aug 07, 2021 by Piotrek Brzeziński@thewildtreeContributor

timeline: Add clip markers display and management

  • Overview 85
  • Commits 6
  • Pipelines 22
  • Changes 20

This lays ground for implementing the beat detection feature, which will heavily utilize elements implemented here.

Mostly finished. Looking for feedback, both UX- and code-quality wise, as I know there are lots of things to possibly improve in that regard.

Important: depends on changes coming in the 1.20 GES release.

Short description:

  • Adds ClipMarkersBox, inheriting from the already existing (timeline)MarkersBox, which makes it possible to display and manage (add / move / remove) markers on each clip (or more precisely - source).
  • Clips are displayed per-source, so audio markers are separate from the video ones, for example.
  • MarkerListManager is introduced to act as central point of handling marker lists on a given element - initializes a default list on the source it's attached to, exposes methods for adding / removing lists, changing their snappability, as well as takes care of changing the active one (turning off snapppability when a list is not visible, for example)
  • Adds necessary settings (MarkerProperties, leveraging MarkerListManager) to manage which list we want to display (or hide, if we don't need any markers), change whether we want them to be snappable, etc.
  • Moves marker-seeking / adding keyboard shortcut actions to the TimelineContainer, which takes into account all selected clips when performing an action, or focuses on the timeline markers if no clips are selected.
Edited Aug 17, 2021 by Piotrek Brzeziński
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: add-clip-markers