From 0d363a6aac85b463cd5ee5382ed2cd21038c5afb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexandru=20B=C4=83lu=C8=9B?= Date: Mon, 31 Aug 2020 21:30:24 +0200 Subject: [PATCH 1/4] transitions: Reuse the logic in _update_ui --- pitivi/transitions.py | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/pitivi/transitions.py b/pitivi/transitions.py index 09907b569..1df39afaa 100644 --- a/pitivi/transitions.py +++ b/pitivi/transitions.py @@ -187,17 +187,14 @@ class TransitionsListWidget(Gtk.Box, Loggable): def _transition_selected_cb(self, unused_widget): transition_asset = self.get_selected_item() if not transition_asset: - # The user clicked between icons + # Nothing to apply. The user clicked between icons. return False - self.debug( - "New transition type selected: %s", transition_asset.get_id()) - if transition_asset.get_id() == "crossfade": - self.props_widgets.set_sensitive(False) - else: - self.props_widgets.set_sensitive(True) + self.debug("New transition type selected: %s", transition_asset.get_id()) self.element.get_parent().set_asset(transition_asset) + self._update_ui() + self.app.write_action("element-set-asset", asset_id=transition_asset.get_id(), element_name=self.element.get_name()) -- GitLab From 01828a88fe7536bb4e37e78810cea4138b13b4ef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexandru=20B=C4=83lu=C8=9B?= Date: Mon, 31 Aug 2020 21:32:06 +0200 Subject: [PATCH 2/4] render: Make return statement easier to see --- pitivi/render.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/pitivi/render.py b/pitivi/render.py index 6772babe2..bec8cdc79 100644 --- a/pitivi/render.py +++ b/pitivi/render.py @@ -1429,11 +1429,10 @@ class RenderDialog(Loggable): # Use HQ Proxy (or equivalent) only for unsupported assets if self.__automatically_use_proxies.get_active(): - if self.app.proxy_manager.is_asset_format_well_supported( - asset_target): + if self.app.proxy_manager.is_asset_format_well_supported(asset_target): return asset_target - else: - proxy_unsupported = True + + proxy_unsupported = True # Use HQ Proxy (or equivalent) whenever available if self.__always_use_proxies.get_active() or proxy_unsupported: -- GitLab From bddab245a4aa805a31ba6262ec585d6569b74b8b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexandru=20B=C4=83lu=C8=9B?= Date: Sat, 1 Apr 2017 15:11:57 +0200 Subject: [PATCH 3/4] undo: Nicer debug display for MetaChangedAtions --- pitivi/undo/undo.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pitivi/undo/undo.py b/pitivi/undo/undo.py index 8e7ec0f19..000ef1bdd 100644 --- a/pitivi/undo/undo.py +++ b/pitivi/undo/undo.py @@ -438,6 +438,9 @@ class MetaChangedAction(UndoableAutomaticObjectAction): self.old_value = current_value self.new_value = new_value + def __repr__(self): + return " %s>" % (self.auto_object, self.item, self.old_value, self.new_value) + def do(self): self.auto_object.set_meta(self.item, self.new_value) -- GitLab From b3fd4f52e9a8025e63283ff19e00e8eb9377cbe3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexandru=20B=C4=83lu=C8=9B?= Date: Fri, 5 Mar 2021 21:20:23 +0100 Subject: [PATCH 4/4] timeline: Fix add effect keyboard shortcut --- pitivi/timeline/timeline.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pitivi/timeline/timeline.py b/pitivi/timeline/timeline.py index c9983464d..5da067ecd 100644 --- a/pitivi/timeline/timeline.py +++ b/pitivi/timeline/timeline.py @@ -2065,7 +2065,7 @@ class TimelineContainer(Gtk.Grid, Zoomable, Loggable): self.timeline.scroll_to_playhead(align=Gtk.Align.CENTER, when_not_in_view=True) def __add_effect_cb(self, unused_action, unused_parameter): - clip = self.timeline.selection.getSingleClip() + clip = self.timeline.selection.get_single_clip() if clip: self.effects_popover.set_relative_to(clip.ui) self.effects_popover.popup() -- GitLab