Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • pitivi pitivi
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 193
    • Issues 193
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 31
    • Merge requests 31
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • pitivipitivi
  • Issues
  • #2305
Closed
Open
Issue created Apr 10, 2019 by Alexandru Băluț@alebMaintainer

Detached tabs appear when the Greeter perspective is active

Steps to reproduce:

  • Create a new project,
  • Drag the Effects Library tab to create a new window
  • Reopen Pitivi, notice the Effects Library tab window is visible when the GreeterPerspective is active. It should be hidden.

The MainWindow switches between perspectives using the show_perspective method: mainwindow.py. This method should get the list of BaseTabs widgets used by the perspective and tell them to hide/show the detached tabs. A new Perspective.find_base_tabs methods in perspective.py iterates the widgets hierarchy in the perspective's self.toplevel_widget and return the BaseTabs widgets. The BaseTabs class in tabsmanager.py could have a new set_detached_tabs_visibility method to be used by show_perspective. Also, BaseTabs should probably create the detached tabs hidden by default, meaning it should not window.show_all() in _create_window, but instead it should notebook.show_all().

Edited Feb 18, 2020 by Alexandru Băluț
Assignee
Assign to
Time tracking