1. 14 Jul, 2020 1 commit
  2. 09 May, 2020 1 commit
  3. 08 May, 2020 1 commit
    • Joanmarie Diggs's avatar
      Make presentation of the status bar fully generator-based · 761aa5f4
      Joanmarie Diggs authored
      * When the command to speak the status bar is given, also generate
        and display braille
      * When a status bar claims focus (which it now can in, at least,
        VSCode) present the status bar items in speech and braille
      * Generate end-of-line indicators for braille labels, if the user
        has that setting enabled. This causes status bar labels in apps
        like LibreOffice Writer to not be a bunch of disjointed text.
        And we normally display the end-of-line indicator for text
        objects anyway.
      * Harmonize link presentation between speech and braille. This
        not only makes presentation consistent, but it eliminates things
        like non-printable / private-use-area characters from showing
        up in the braille of the status bar of (at least) VSCode.
      761aa5f4
  4. 04 May, 2020 1 commit
    • Joanmarie Diggs's avatar
      Ensure we announce role and content of elements with ARIA's separator role · 384ae576
      Joanmarie Diggs authored
      In the case of Chromium, we were announcing the role, but not checking
      for text content; in the case of Firefox, we were finding a child of the
      separator with text but not then presenting the ancestor separator. This
      fix causes us to handle both cases.
      
      Also, don't present values for non-focused separators. Non-focusable
      separators are not supposed to implement the value interface. But if an
      author slaps a tabindex value of -1 on them, then user agents seem to
      treat them as focusable and expose the value interface on them, complete
      with default values which are likely useless noise given the object is
      not serving as a widget.
      384ae576
  5. 27 Apr, 2020 1 commit
    • Joanmarie Diggs's avatar
      Work around Qt failing to use correct role and/or state · fa7afa3c
      Joanmarie Diggs authored
      Checkable menu items should have STATE_CHECKABLE and/or the role of
      ROLE_CHECK_MENU_ITEM. Apparently this is not always the case for Qt
      apps. This workaround should cause Orca to announce the checked state
      when present, but not announce "not checked." In order for the latter
      to occur, Qt apps should fix the aforementioned bug.
      fa7afa3c
  6. 24 Apr, 2020 1 commit
  7. 12 Apr, 2020 1 commit
    • Joanmarie Diggs's avatar
      Fix regression in the combobox generation code · a6d740f9
      Joanmarie Diggs authored
      Some comboboxes have a name based on its value rather than on the
      associated label. So don't check for that condition in the generator
      and instead try to identify when the name is not based on the value
      in the script utilities.
      a6d740f9
  8. 10 Apr, 2020 1 commit
    • Joanmarie Diggs's avatar
      Clean up combobox generation code · 932526f4
      Joanmarie Diggs authored
      * Move calculation of combobox value out of generator for name and
        into script utility
      * Handle calculation of combobox value in generator for value
      * Also check for valuetext object attribute in web content to save
        on calculation time
      * Make braille generation more consistent with speech generation
      * Have displayedText get strings even for objects we normally wish
        to treat as textless (such as select-only comboboxes)
      932526f4
  9. 07 Apr, 2020 1 commit
  10. 09 Mar, 2020 1 commit
  11. 02 Mar, 2020 1 commit
  12. 28 Feb, 2020 1 commit
  13. 27 Feb, 2020 1 commit
  14. 26 Feb, 2020 1 commit
  15. 25 Feb, 2020 1 commit
  16. 10 Feb, 2020 1 commit
  17. 06 Feb, 2020 1 commit
    • Joanmarie Diggs's avatar
      Cache object attribute for web contents · e405c0d6
      Joanmarie Diggs authored
      Sadly we're having to check object attributes more and more for web
      content and applications. All those calls to getAttributes() adds up.
      Therefore cache them. Testing will be needed to ensure our cached
      attributes are not stale, but so far this change seems to be a win
      for performance.
      e405c0d6
  18. 03 Feb, 2020 1 commit
  19. 29 Jan, 2020 3 commits
    • Joanmarie Diggs's avatar
      Try to improve filtering out of redundant names · cb7e1a07
      Joanmarie Diggs authored
      We're seeing instances where the name is a subset of the label:
        * label: "Leading space:" name: "Leading space"
        * name: "Stacking order (Z)" name: "Stacking order"
      
      In this instance, when generating the label and name for the widget,
      we don't want to append the name to the label. Therefore if the label
      text starts with the name text, don't append the name.
      cb7e1a07
    • Joanmarie Diggs's avatar
      More work on the name/displayed-text mess · aa9028b0
      Joanmarie Diggs authored
      1. Don't even fall back on displayed text for the name. When and if
         that proves necessary, we can fix it either in the formatting
         string or make a role-specific tweak in the generator(s)
      
      2. Fix presentation of spin button, presenting the displayed text
         and falling back on the value reported by AtspiValue
      aa9028b0
    • Joanmarie Diggs's avatar
      Fix _generateName() to prefer the name (duh) · a1170e5b
      Joanmarie Diggs authored
      Long, long ago the decision was made to prefer the displayedText over the
      accessible name. To be honest, I'm not sure why. I've subsequently not
      changed that for fear of breaking something unexpected. But bugs keep
      coming up because of this old decision. We'll fix them based on reports
      before this is included in stable.
      a1170e5b
  20. 23 Jan, 2020 3 commits
  21. 21 Jan, 2020 1 commit
  22. 18 Jan, 2020 1 commit
    • Joanmarie Diggs's avatar
      Chromium: Update support for list item marker change · 097cdc8b
      Joanmarie Diggs authored
      Chromium used to expose list item markers to us as static text leaf
      nodes; now they appear in a container. This makes it possible to
      simplify our support, but we also need to eliminate presentation of
      the new panel role we're seeing.
      
      Also improve logic regarding what is a list item marker so we do
      not double-present text in an inline list.
      097cdc8b
  23. 07 Jan, 2020 1 commit
    • Joanmarie Diggs's avatar
      Continued work on support for aria-details · 8dcd93c3
      Joanmarie Diggs authored
      * Announce when entering and exiting details container via caret
        navigation. When entering, announce the name and type of object
        the details apply to.
      * Announce the name and type of object when an object has details.
      8dcd93c3
  24. 06 Jan, 2020 1 commit
  25. 16 Oct, 2019 1 commit
  26. 09 Oct, 2019 1 commit
    • Joanmarie Diggs's avatar
      Explicitly announce the popup type when aria-haspopup is used · 25c64254
      Joanmarie Diggs authored
      Notes:
      * This will not be presented if the verbosity is set to brief.
      * At the present time, no filtering of obvious or default types is
        taking place. (Example: The default popup of an ARIA combo box is
        "listbox". Rather than filtering it out, Orca will present it.
      * The information is being tacked on to the very end of presentation
        so it can be interrupted by users who don't find it meaningful.
      * What gets spoken when is subject to change based on user feedback.
      25c64254
  27. 12 Aug, 2019 1 commit
  28. 19 Jun, 2019 1 commit
  29. 07 Jun, 2019 1 commit
  30. 05 Jun, 2019 1 commit
  31. 05 May, 2019 1 commit
  32. 15 Apr, 2019 1 commit
  33. 18 Oct, 2018 3 commits
  34. 17 Oct, 2018 1 commit