1. 11 Sep, 2015 2 commits
    • Thomas Haller's avatar
      c-e: forward the validation error to print more sensible error message to stdout · e01de575
      Thomas Haller authored
      When a connection doesn't verify, the "Save" dialog stays desensitized.
      Even for an advanced user it's not immediately clear what causes the
      valdation failure.
      
      We already print a message like "Invalid setting Ethernet" to stdout.
      Extend the message to also print an more detailed error that gets propagated
      from the validation.
      
      This later should be improved further to indicating the failure reason
      in the UI too.
      e01de575
    • Thomas Haller's avatar
      c-e/trivial: rename virtual method validate() · 97954684
      Thomas Haller authored
      There are other function names with the same name.
      This makes it hard to grep the source code to find
      all type implementations of ce_page_validate().
      97954684
  2. 18 May, 2015 1 commit
    • Jiří Klimeš's avatar
      editor: let users edit connection.interface-name property (rh #1139536) · 28616812
      Jiří Klimeš authored
      "Device MAC address" has been changed to "Device" that now accepts both
      interface name and MAC. Either of the two data can be set, or both:
      "em1 (3C:97:0E:18:4C:C7)", "3C:97:0E:18:4C:C7 (em1)", "em1", "3C:97:0E:18:4C:C7".
      This lets user also lock connection to an interface name for Ethernet, Wi-Fi,
      WiMAX, PPPoE, InfiniBand and mobile broadband connections. It is more useful
      than MAC address now that interface names are stable.
      
      For virtual connections, interface name entry is on the corresponding
      page (like bond, bridge, etc.) because it is mandatory.
      
      https://bugzilla.redhat.com/show_bug.cgi?id=1139536
      28616812
  3. 07 Apr, 2015 1 commit
  4. 25 Feb, 2015 1 commit
  5. 10 Oct, 2014 1 commit
  6. 20 Feb, 2014 1 commit
    • Dan Williams's avatar
      editor: generalize ce_spin_output_with_default() · 55e34f33
      Dan Williams authored
      We may want to use this for default value strings other than
      "automatic" in the future, so change the name to "automatic" and
      pass the string to the generic helper that does the actual work.
      
      Also, the return value for the "output" signal for the spinbutton
      should be 'gboolean' not 'gint'.
      55e34f33
  7. 02 Sep, 2013 1 commit
  8. 12 Mar, 2013 1 commit
  9. 11 Mar, 2013 1 commit
  10. 19 Feb, 2013 1 commit
  11. 11 Jan, 2013 1 commit
  12. 16 Oct, 2012 1 commit
  13. 04 Oct, 2012 3 commits
  14. 30 Aug, 2012 2 commits
  15. 20 Aug, 2012 1 commit
  16. 09 Aug, 2012 2 commits
  17. 07 Aug, 2012 4 commits
  18. 13 Mar, 2012 2 commits
  19. 09 Feb, 2012 1 commit
  20. 17 Aug, 2011 1 commit
    • Dan Williams's avatar
      editor: fix compat with GTK+ <= 2.22 · 8e75c5f2
      Dan Williams authored
      Which doesn't have GtkComboBoxText, so we have to use the old way.
      It gets a bit complicated because we can't use the GtkBuilder file
      to store the widget (since that can't change programmatically) so
      we replace the widget in the Builder file with an alignment that
      we stick the programmatically created combo box into.
      8e75c5f2
  21. 21 Jul, 2011 1 commit
  22. 14 Mar, 2011 1 commit
  23. 04 Mar, 2011 1 commit
  24. 23 Feb, 2011 1 commit
  25. 05 Dec, 2010 1 commit
    • Dan Williams's avatar
      core: fix GtkBuilder-related performance issues · 0f4fedc5
      Dan Williams authored
      GtkBuilder isn't as quick as libglade when building the widget
      tree from the XML file, so the previous handling of wireless
      security and EAP methods caused connection editor display times
      of 4 seconds or more on slower machines (like 1.7GHz Pentium M).
      
      Previously, all security and EAP UI was stored in one glade/builder
      file which was re-read from multiple places.  With glade that was
      fine, but GtkBuilder's gtk_builder_add_from_file() takes quite a
      bit longer than glade did.
      
      So split each piece security and EAP UI description out into a
      separate file, and consolidated handling of UI building into the
      EAPMethod and WirelessSecurity classes instead of doing it in
      the subclasses.
      0f4fedc5
  26. 28 Nov, 2010 1 commit
  27. 22 Jun, 2010 1 commit
  28. 31 May, 2010 1 commit
  29. 02 Oct, 2009 1 commit
    • Dan Williams's avatar
      editor: fix secrets requests after 78b7101d · 6878f634
      Dan Williams authored
      After 78b7101d, the page's connection
      would of course be the duplicated connection which is a plain
      NMConnection that user edits are done on.  THat of course doesn't
      implement NMSettingsConnectionInterface, and thus can't respond to
      requests for secrets.
      
      Instead, we have the CEPage subclasses for each setting type pass back
      the name of the setting they want secrets for, if they need secrets,
      and let the editor ask for the secrets since it has the original
      connection which usually implements NMSettingsConnectionInterface.
      
      By moving the addition of the page's GtkWidget to after page
      initialization, we also fix system VPN connections, which were broken
      because the VPN page's plugin-provided widget is only valid after
      the page is initialized, but the editor expected it to be valid
      right after requesting secrets.  In the case of system secrets, the
      request is over D-Bus and is async, which meant that the call would
      complete and the page would initalize long after the connection editor
      had tried to add the page to the UI.
      6878f634
  30. 02 Jun, 2009 1 commit
  31. 03 Apr, 2009 1 commit
    • Dan Williams's avatar
      Ensure PolicyKit autorization before editing system connections, and · 90e6e250
      Dan Williams authored
      2009-04-03  Dan Williams  <dcbw@redhat.com>
      
      	* Ensure PolicyKit autorization before editing system connections, and
      		request secrets from the system settings service for system connections.
      		This requires splitting each CEPage subclass's *_new() method into
      		two parts, the first doing minimal setup, and the second filling in
      		the UI with details from the backing NMConnection.  Between the first
      		and second parts, if required, secrets are requested from the system
      		settings service using PolicyKit.  As a bonus, actually handle errors
      		instead of dropping them on the floor.
      
      
      svn path=/trunk/; revision=1244
      90e6e250