1. 11 Sep, 2015 2 commits
    • Thomas Haller's avatar
      c-e: forward the validation error to print more sensible error message to stdout · e01de575
      Thomas Haller authored
      When a connection doesn't verify, the "Save" dialog stays desensitized.
      Even for an advanced user it's not immediately clear what causes the
      valdation failure.
      
      We already print a message like "Invalid setting Ethernet" to stdout.
      Extend the message to also print an more detailed error that gets propagated
      from the validation.
      
      This later should be improved further to indicating the failure reason
      in the UI too.
      e01de575
    • Thomas Haller's avatar
      c-e/trivial: rename virtual method validate() · 97954684
      Thomas Haller authored
      There are other function names with the same name.
      This makes it hard to grep the source code to find
      all type implementations of ce_page_validate().
      97954684
  2. 25 Feb, 2015 1 commit
  3. 24 Feb, 2015 1 commit
  4. 10 Oct, 2014 2 commits
  5. 13 Sep, 2013 1 commit
    • Jiří Klimeš's avatar
      eap: use G_DEFINE_BOXED_TYPE to simplify code and be thread-safe (rh #979123) · 36a316be
      Jiří Klimeš authored
      inner_auth_combo_changed_cb():
        model = gtk_combo_box_get_model (GTK_COMBO_BOX (combo));
        gtk_combo_box_get_active_iter (GTK_COMBO_BOX (combo), &iter);
        gtk_tree_model_get (model, &iter, I_METHOD_COLUMN, &eap, -1);
        g_assert (eap);
      
      gtk_combo_box_get_model() failed and thus g_assert (eap) failed as well.
      
      On some circumstances type_id resets to 0 in eap_method_get_g_type(). It makes
      g_boxed_type_register_static() be called again, which results in failing
      assertion 'g_type_form_name (name) == 0' and thus eap_method_get_g_type()
      returns 0 instead of proper GType. Later using 0 make gtk_list_store_new()
      fail to get proper GListStore:
      inner_auth_combo_init:
      auth_model = gtk_list_store_new (2, G_TYPE_STRING, eap_method_get_type ())
      
      Even if this patch is right, the problem is not solved, because instead of
      the crash a deadlock may occur. It might be the same issue as described in
      https://bugzilla.gnome.org/show_bug.cgi?id=674885.
      
      https://bugzilla.redhat.com/show_bug.cgi?id=979123
      36a316be
  6. 02 Sep, 2013 1 commit
  7. 27 Aug, 2013 1 commit
  8. 19 Feb, 2013 1 commit
  9. 04 Oct, 2012 1 commit
  10. 20 Aug, 2012 1 commit
  11. 09 Aug, 2012 2 commits
  12. 07 Aug, 2012 1 commit
  13. 17 Mar, 2012 1 commit
    • Dan Williams's avatar
      editor: disable Ad-Hoc WPA connections (lp:905748) · 4e815512
      Dan Williams authored
      The kernel has long been broken for Ad-Hoc WPA, so don't let that
      combination of options be used when creating network configuration.
      When the kernel starts working again we can re-enable it, or better
      yet, just use real AP mode.
      4e815512
  14. 13 Mar, 2012 4 commits
  15. 21 Jul, 2011 1 commit
  16. 20 Jun, 2011 2 commits
  17. 14 Mar, 2011 1 commit
  18. 23 Dec, 2010 1 commit
  19. 05 Dec, 2010 1 commit
    • Dan Williams's avatar
      core: fix GtkBuilder-related performance issues · 0f4fedc5
      Dan Williams authored
      GtkBuilder isn't as quick as libglade when building the widget
      tree from the XML file, so the previous handling of wireless
      security and EAP methods caused connection editor display times
      of 4 seconds or more on slower machines (like 1.7GHz Pentium M).
      
      Previously, all security and EAP UI was stored in one glade/builder
      file which was re-read from multiple places.  With glade that was
      fine, but GtkBuilder's gtk_builder_add_from_file() takes quite a
      bit longer than glade did.
      
      So split each piece security and EAP UI description out into a
      separate file, and consolidated handling of UI building into the
      EAPMethod and WirelessSecurity classes instead of doing it in
      the subclasses.
      0f4fedc5
  20. 28 Nov, 2010 1 commit
  21. 24 Aug, 2010 1 commit
  22. 18 Jun, 2010 1 commit
  23. 08 May, 2010 1 commit
  24. 06 Apr, 2010 1 commit
    • Dan Williams's avatar
      core: fix "Always ask for this password" behavior · 28e9f5b0
      Dan Williams authored
      The bug is that for 802.1x connections using simple EAP methods
      (like TTLS or PEAP) the applet would continually ask for the
      password even though "Always ask" was not checked.
      
      The applet still needs the password to pass back to NM when NM
      needs it to make a connection, so we only want to desensitize the
      password entry and clear out the password in nm-connection-editor
      when "Always ask" is checked.
      
      On the applet side, when the connection is an 'always ask' connection,
      store the "always ask" state, but still accept password entry and
      send it along to NM in the GetSecrets response when the user hits OK.
      28e9f5b0
  25. 02 Oct, 2009 1 commit
    • Dan Williams's avatar
      editor: fix secrets requests after 78b7101d · 6878f634
      Dan Williams authored
      After 78b7101d, the page's connection
      would of course be the duplicated connection which is a plain
      NMConnection that user edits are done on.  THat of course doesn't
      implement NMSettingsConnectionInterface, and thus can't respond to
      requests for secrets.
      
      Instead, we have the CEPage subclasses for each setting type pass back
      the name of the setting they want secrets for, if they need secrets,
      and let the editor ask for the secrets since it has the original
      connection which usually implements NMSettingsConnectionInterface.
      
      By moving the addition of the page's GtkWidget to after page
      initialization, we also fix system VPN connections, which were broken
      because the VPN page's plugin-provided widget is only valid after
      the page is initialized, but the editor expected it to be valid
      right after requesting secrets.  In the case of system secrets, the
      request is over D-Bus and is async, which meant that the call would
      complete and the page would initalize long after the connection editor
      had tried to add the page to the UI.
      6878f634
  26. 16 Sep, 2009 1 commit
    • Dan Williams's avatar
      core: update to work with certificate paths · b16d8aca
      Dan Williams authored
      Don't store the certificate/key paths in lookaside variables, just use
      the normal key/value pairs in the 802.1x setting.
      
      Since (for backwards compat) NM treats the private key as a secret, we
      need to do a few odd things like retrieving the private key paths from
      GConf when getting secrets from the keyring.
      
      Also, since the private keys and certificate properties are byte arrays,
      it's a slight bit more complicated to load/store them to GConf, requiring
      a bit of indirection in read_one_setting_value_from_gconf() and
      copy_one_setting_value_to_gconf().  Especially for
      copy_one_setting_value_to_gconf() since the incoming certificate may
      just be a byte array of the cert/key data from some older plugin or
      settings service, and thus we need to copy that cert data to a file
      on-disk and possibly re-encrypt a decrypted private key too.
      b16d8aca
  27. 10 Aug, 2009 1 commit
    • Dan Williams's avatar
      wifi: only show WEP index & auth method in connection editor · 5b98fac8
      Dan Williams authored
      Almost nobody uses these options, and since those people that do use
      them already need that additional configuration, they might was well
      set that up in the connection editor.  This fixes the reported issues
      with users being confused by the options that almost nobody needs to
      change, while preserving the ability to set these options for users
      that need them.  In the future we could put some sort of disclosure
      triangle or something in standalone WEP dialog that would expose
      the index & auth method combos if people really seem to want them
      there.
      5b98fac8
  28. 10 May, 2009 1 commit
  29. 04 Apr, 2009 1 commit
  30. 03 Apr, 2009 1 commit
    • Dan Williams's avatar
      Ensure PolicyKit autorization before editing system connections, and · 90e6e250
      Dan Williams authored
      2009-04-03  Dan Williams  <dcbw@redhat.com>
      
      	* Ensure PolicyKit autorization before editing system connections, and
      		request secrets from the system settings service for system connections.
      		This requires splitting each CEPage subclass's *_new() method into
      		two parts, the first doing minimal setup, and the second filling in
      		the UI with details from the backing NMConnection.  Between the first
      		and second parts, if required, secrets are requested from the system
      		settings service using PolicyKit.  As a bonus, actually handle errors
      		instead of dropping them on the floor.
      
      
      svn path=/trunk/; revision=1244
      90e6e250
  31. 05 Dec, 2008 1 commit
    • Dan Williams's avatar
      src/gconf-helpers/gconf-helpers.c src/gconf-helpers/gconf-helpers.h - · de2215e7
      Dan Williams authored
      2008-12-05  Dan Williams  <dcbw@redhat.com>
      
      	* src/gconf-helpers/gconf-helpers.c
      	  src/gconf-helpers/gconf-helpers.h
      		- (nm_gconf_clear_private_connection_values): new function to clear
      			applet private values from a connection
      
      	* src/connection-editor/page-wired-security.c
      		- (ce_page_wired_security_new): ensure setting gets updated when
      			security is changed
      		- (validate): copy applet private values to the real connection when
      			using 802.1x security; clear applet private values when there's no
      			security
      
      	* src/connection-editor/page-wireless-security.c
      		- (validate): clear applet private values when there's no security
      
      
      svn path=/trunk/; revision=1054
      de2215e7
  32. 30 Oct, 2008 1 commit
    • Dan Williams's avatar
      src/applet-device-wifi.c src/applet-dialogs.c · 26930f27
      Dan Williams authored
      2008-10-30  Dan Williams  <dcbw@redhat.com>
      
      	* src/applet-device-wifi.c
      	  src/applet-dialogs.c
      	  src/connection-editor/page-wireless-security.c
      	  src/gconf-helpers/gconf-upgrade.c
      	  src/utils/utils.c
      	  src/wireless-dialog.c
      	  src/wireless-security/wireless-security.c
      	  src/wireless-security/ws-dynamic-wep.c
      	  src/wireless-security/ws-leap.c
      	  src/wireless-security/ws-wep-key.c
      	  src/wireless-security/ws-wpa-eap.c
      	  src/wireless-security/ws-wpa-psk.c
      		- Use wireless security setting accessors
      
      
      svn path=/trunk/; revision=992
      26930f27
  33. 28 Oct, 2008 1 commit
    • Dan Williams's avatar
      Patch from Tambet Ingo <tambet@gmail.com> · 9ec5a4ba
      Dan Williams authored
      2008-10-28  Dan Williams  <dcbw@redhat.com>
      
      	Patch from Tambet Ingo <tambet@gmail.com>
      
      	* src/applet-device-wifi.c
      	  src/applet-dialogs.c
      	  src/connection-editor/page-wireless-security.c
      	  src/connection-editor/page-wireless.c
      	  src/gconf-helpers/gconf-upgrade.c
      	  src/utils/utils.c
      	  src/wireless-dialog.c
      	  src/wireless-security/wireless-security.c
      	  src/wireless-security/ws-leap.c
      	  src/wireless-security/ws-wep-key.c
      	  src/wireless-security/ws-wpa-psk.c
      		- Use wireless setting accessors
      
      
      svn path=/trunk/; revision=987
      9ec5a4ba