GitLab

When a connection doesn't verify, the "Save" dialog stays desensitized.
Even for an advanced user it's not immediately clear what causes the
valdation failure.

We already print a message like "Invalid setting Ethernet" to stdout.
Extend the message to also print an more detailed error that gets propagated
from the validation.

This later should be improved further to indicating the failure reason
in the UI too.

There are other function names with the same name.
This makes it hard to grep the source code to find
all type implementations of ce_page_validate().

CEPolkitButton has two different icons/tooltips, depending
on whether you can perform the action right away or are asked
for further polkit authorization.

We need three states regarding the icon/tooltip:

  - NO authorization: Button is disabled
  - NM_CLIENT_PERMISSION_RESULT_AUTH: user can get
    authorization after authenticating with polkit.
  - NM_CLIENT_PERMISSION_RESULT_YES: user has
    permission right away.

Regardless of that, the check in update_button() was very wrong.
It would set priv->auth_tooltip when priv->authorized while it should
set priv->tooltip (if it doesn't consider the three states above).

The mnemonics of radio buttons *inside* the pop-up menu don't work
with respect to the whole window. They only work, if you already
opened the pop-up menu, and then press the mnemonic key.
But since you cannot open the pop-up menu with a shortcut,
this becomes moot and the user has to click anyway.

But more importantly, we are using the same string as tooltip
for the icon, which wrongly showed the underscore of the mnemonic.
Fix that by just removing the the mnemonics.

https://bugzilla.gnome.org/show_bug.cgi?id=754726

Fixes: 50b9650c

https://bugzilla.gnome.org/show_bug.cgi?id=754349

If the connection is invalid, the "Connect" button in the Wi-Fi password
dialog stays disabled and makes it hard for the user to understand the
reason.

Especially when connecting to certain EAP-typed Wi-Fi connections, the
connection might have no CA certificate set. However, if the connection
was not previously edited with nm-connection-editor, the connection is
considered invalid by nm-applet because "No CA certificate is required"
is unchecked.
As this flag is only stored in the gsetting of the user, NetworkManager
and nm-applet disagree about whether the connection is valid.

Add a tooltip to the connect button to indicate to the user that the
connection must be modified first.

Steps to reproduce:

  - create a Wi-Fi connection of type EAP (PEAP, TLS, or TTLS) outside
    of nm-applet/nm-connection-editor. Or alternatively, clear the
    gsettings entry with:
       dconf reset -f /org/gnome/nm-applet/eap/
  - try to connect to the Wi-Fi. Note that the "Connect" button of the
    password dialog is diabled (just like the "Save" button in nm-ce).

https://bugzilla.gnome.org/show_bug.cgi?id=754172
https://bugzilla.redhat.com/show_bug.cgi?id=1247885

https://bugzilla.redhat.com/show_bug.cgi?id=1254043

https://bugzilla.redhat.com/show_bug.cgi?id=1177860

MTU is the 802-3-ethernet.mtu key, make sure wired setting exists.

The same change as for bond in commit b1c5b409,
but fixed saving MTU = 0.

https://bugzilla.redhat.com/show_bug.cgi?id=1255927

GPOINTER_TO_UINT may truncate the GType (actually gsize, i.e. unsigned long).
Use rather GPOINTER_TO_SIZE() to be safe. And GSIZE_TO_POINTER() for the
opposite conversion.

VPN plugins are usually split into separate package, thus
it might not be an error that a .name file mentions a
plugin file that does not exist (because it isn't installed).

Only print an info message about this.

GNOME release tooling repacks the bz2 to a xz anyway. This makes it easier for
packagers to use tarballs created with "make dist" in place of distribution
tarballs.

At one point we thought people would want/need to control their
"enterprisey" devices via nm-applet, but nmcli (or static
autoconnect=true configuration) turns out to be a better answer
generally.

Additionally, probably the most common case of bridges currently is
when you are using virtualization or containers, and in that case the
bridge is handled entirely by the virt/container system, and showing
it in nm-applet just clutters things up, pushing Wi-Fi and VPN down to
the bottom of the menu.

So drop support for those devices.

https://bugzilla.gnome.org/show_bug.cgi?id=753369

It's actually supposed to be handled through gettext and not
put into the XML.  A lot of projects are doing it wrong, and now
glib-compile-schemas will yell at you.

https://bugzilla.gnome.org/show_bug.cgi?id=747209

https://bugzilla.gnome.org/show_bug.cgi?id=752621

Fixes: 5158105c

This detects the current git commit id and embeds it in the
generated "configure" script. As the configure script is included
in the dist-tarball, we can detect the original git commit from
a tarball.

https://bugzilla.gnome.org/show_bug.cgi?id=749877

It causes an extraneous RPM dependency to be generated even when there are no
symbols that actually use it.