1. 22 Apr, 2020 2 commits
  2. 05 Mar, 2020 1 commit
  3. 14 Feb, 2020 2 commits
    • nightsky30's avatar
      c-e: fix ce-ppp-auth-methods.ui as well · 8fbcbcec
      nightsky30 authored
      Fix ce-ppp-auth-methods.ui as well per Mikhail's comment
      
      !75 (comment 685501)
      
      Fixes: 5fbf69f2 ('glade: get rid of GtkContainer.border-width')
      8fbcbcec
    • nightsky30's avatar
      c-e: fixes transparent border on ipv4/ipv6 route and new connection dialogs · 2ebefe25
      nightsky30 authored
      This fixes a transparent border issue that appears to have been introduced
      with commit 5fbf69f2:
      
      With commit 5fbf69f2, ipv4/ipv6 route and new connection dialog boxes
      were modified to use margin properties due to the deprecation of border
      properties. Margin properties were placed under GtkDialog instead of the
      immediate child GtkBox. Margin properties were also placed under another
      GtkBox further below. This seemed to have the effect of margins not
      being recognized on the top or left of the dialogs, but also creating a
      transparent margin on the bottom and right. This was visible on the
      ipv4/ipv6 route dialogs, but somehow also affected the new connection
      dialog despite that file not having margin properties listed under
      GtkDialog. Fixing properties in ce-ip4-routes.ui and ce-ip6-routes.ui
      also fixed the new connection dialog.
      
      Fixes: 5fbf69f2 ('glade: get rid of GtkContainer.border-width')
      2ebefe25
  4. 09 Oct, 2019 1 commit
  5. 04 Oct, 2019 1 commit
  6. 13 Sep, 2019 2 commits
  7. 10 Sep, 2019 3 commits
  8. 26 Jun, 2019 3 commits
  9. 24 Jun, 2019 2 commits
  10. 18 Feb, 2019 1 commit
    • Lubomir Rintel's avatar
      meson: drop unuseful -Wl,--version-script check · 720fbeec
      Lubomir Rintel authored
      Meson complains that it doesn't work:
      
        WARNING: -Wl,--version-script looks like a linker argument, but
        has_argument and other similar methods only support checking compiler
        arguments. Using them to check linker arguments are never supported, and
        results are likely to be wrong regardless of the compiler you are using.
        has_link_argument or other similar method can be used instead.
      
      The has_link_argument() function requires meson 0.46 (we depend on 0.43)
      and it can't check for options without argument.
      
      Let's drop the check instead. It complicates things for no good reason:
      we don't want to build on platforms that don't support symbol versioning
      anyways.
      720fbeec
  11. 26 Nov, 2018 1 commit
    • Andrew Zaborowski's avatar
      all: pass 'hints' from secret agent to ws_wpa_eap_new · 89331ca0
      Andrew Zaborowski authored
      The secret agent requests contain two parameters that aren't currently
      used when handling Wifi network connections: the setting name and hints.
      Those parameters turned out useful with 802.1X / EAP authentication with
      NM's IWD backend where it passes a specific 802_1x setting key name that
      is being requested in the 'hints' array, one of: identity, password or
      private_key_password.
      nmcli already gained support for handling such agent requests in
      1a6e53808db8bb8e75317fd5feacd74a9a98860f (which was obviously much
      easier) so this is an attempt to let the src/wireless-security/* classes
      in nm-applet also handle these requests as intended.
      
      A new libnma function nma_wifi_dialog_new_for_secrets is added to
      receive the values from setting name and hints without changing existing
      API.
      89331ca0
  12. 21 Sep, 2018 2 commits
  13. 19 Sep, 2018 1 commit
  14. 27 Aug, 2018 3 commits
    • Lubomir Rintel's avatar
      8021x-security: don't show_all() the widgets · 546539e3
      Lubomir Rintel authored
      This ends up showing widgets that are to be visible only conditionally. The
      widgets to be visible should be created with visible=true in the first place.
      
      Fixes: 07d900c0
      
      !22
      546539e3
    • Alexandru-Sever Horin's avatar
      editor/vpn: don't show_all() the widgets · ba8df364
      Alexandru-Sever Horin authored
      This ends up showing widgets that are to be visible only conditionally. The
      widgets to be visible should be created with visible=true in the first place.
      
      [lkundrak@v3.sk: reworded the commit messsage.]
      
      Fixes: 07d900c0
      
      !22
      ba8df364
    • Bastien Nocera's avatar
      glade: fix Wi-Fi secrets dialogue being partly untranslated · f7dd115d
      Bastien Nocera authored
      There was no gettext "domain" property defined for the wifi.ui files,
      nor was there a call to gtk_builder_set_translation_domain() before
      adding the .ui to the GtkBuilder object, so those strings used the
      default project gettext.
      
      Except that when the dialogue is used in another project such as
      gnome-control-center, that the default project isn't where the
      translations live.
      
      Set the "domain" property on the top-level interface tag, so that
      GtkBuilder knows where to find the translations.
      
      [lkundrak@v3.sk: The Wi-Fi dialog is actually composed of widgets from
      multiple GtkBuilder files -- set the domain in all of them.]
      
      !23
      https://bugzilla.gnome.org/show_bug.cgi?id=792285
      f7dd115d
  15. 26 Jul, 2018 5 commits
  16. 24 Jul, 2018 3 commits
    • Lubomir Rintel's avatar
      bluetooth: fix an assert failure on creation cancellation · 516f3f6c
      Lubomir Rintel authored
        $ nm-connection-editor --create --type bluetooth
        <ESC>
        GLib-GObject-CRITICAL: g_object_unref: assertion 'G_IS_OBJECT (object)' failed
      516f3f6c
    • Lubomir Rintel's avatar
      connection-list: attempt a VPN import first · 9d79ffdb
      Lubomir Rintel authored
      On nm-connection-editor --import, nm_connection_list_create() is called
      with an empty ctype (G_TYPE_INVALID). This is not good -- on a
      successful import the first known type (which happens to be Bluetooth)
      would match.
      
      Let's treat this as "any connection type" -- attempt a VPN import
      opportunistically and if it succeeds, continute with a ctype of
      NM_TYPE_SETTING_VPN. Otherwise just bail out.
      9d79ffdb
    • Lubomir Rintel's avatar
      connection-editor: hold GApplication while the import dialog is running · 419c459e
      Lubomir Rintel authored
      This is done from new callbacks of nm_connection_list_create() and
      nm_connection_list_add().
      
      In order for this to work, import_vpn_from_file_cb() had to be fixed to
      always invoke its callback. In turn, vpn_connection_from_file() had to
      be changed to pass its error result up to its callers instead of
      presenting a potentially redundant error message itself.
      419c459e
  17. 12 Jul, 2018 2 commits
    • Lubomir Rintel's avatar
      connection-editor: don't defer creation of vpn connection to idle · d9215e1a
      Lubomir Rintel authored
      Now that GtkApplication makes good decisions about when to quit (when no
      windows are present), the magic that deferred creation of vpn type
      selector is useless. Worse even, it makes GtkApplication believe that
      we're done and shuts it down before an editor window is added to it.
      
      #9
      
      Reported-by: Jan Tojnar
      d9215e1a
    • Lubomir Rintel's avatar
      connection-editor: ignore --help in main() option context · 346630de
      Lubomir Rintel authored
      It's solely used for parsing --keep-above and doesn't know anything
      about actual options and thus prints irrelevant help. Skip that and let
      the GtkApplication::command-line signal handler parse it and print help
      instead.
      346630de
  18. 26 Jun, 2018 1 commit
  19. 21 Jun, 2018 1 commit
  20. 19 Jun, 2018 3 commits