1. 22 Apr, 2020 2 commits
  2. 06 Apr, 2020 4 commits
  3. 06 Mar, 2020 1 commit
  4. 05 Mar, 2020 2 commits
  5. 03 Mar, 2020 1 commit
    • Beniamino Galvani's avatar
      applet: fix reference count for secret request result · c2c3e25e
      Beniamino Galvani authored
      Don't pass a floating variant to the callback function but convert it
      into a full one so that we can guarantee that the callback function
      will not assume ownership.
      
        (nm-applet:691510): GLib-CRITICAL **: 18:02:29.581: g_atomic_ref_count_dec: assertion 'g_atomic_int_get (arc) > 0' failed
      
        _g_log_abort () at /lib64/libglib-2.0.so.0
        g_logv () at /lib64/libglib-2.0.so.0
        g_log () at /lib64/libglib-2.0.so.0
        g_atomic_ref_count_dec () at /lib64/libglib-2.0.so.0
        g_variant_unref () at /lib64/libglib-2.0.so.0
        gs_local_variant_unref (v=<synthetic pointer>) at ./shared/nm-utils/gsystem-local-alloc.h:73
        complete_request (info=info@entry=0xaaf340) at src/applet-vpn-request.c:273
        external_ui_from_child_response (error=0x7fffffffd380, info=<optimized out>) at src/applet-vpn-request.c:261
        process_child_response (info=<optimized out>) at src/applet-vpn-request.c:298
        g_child_watch_dispatch () at /lib64/libglib-2.0.so.0
        g_main_context_dispatch () at /lib64/libglib-2.0.so.0
        ...
      
      !77
      c2c3e25e
  6. 14 Feb, 2020 7 commits
  7. 19 Nov, 2019 1 commit
  8. 04 Nov, 2019 3 commits
  9. 09 Oct, 2019 4 commits
  10. 04 Oct, 2019 2 commits
  11. 03 Oct, 2019 2 commits
    • Beniamino Galvani's avatar
      libnma: focus first empty field in the VPN dialog · f70c827e
      Beniamino Galvani authored
      Previously the secondary field would be focused even if the first was
      empty.
      f70c827e
    • Beniamino Galvani's avatar
      applet/vpn-request: fix external UI mode · dee77447
      Beniamino Galvani authored
      When a connection is opened for editing in nm-c-e, secrets are asked
      to NM. NM in turn asks them to registered agents, including the applet
      if available; the applet now supports an external-ui-mode in which it
      spawns a VPN-specific authentication dialog binary that doesn't have a
      graphical component and contains the knowledge about which secrets are
      missing, how to retrieve them from keyrings and how to ask them to
      users; the binary then returns through stdout a keyfile that describes
      the known secrets, their values returned from keyrings and the labels
      to present to users. The applet uses this information to show a GTK
      dialog (only when necessary) and returns the secrets to NM.
      
      Currently when using the external-ui-mode and the auth-dialog binary
      returns secrets with the ShouldAsk key set to false, the applet
      doesn't show a GTK dialog and returns an empty response. This breaks
      when the auth-dialog returns secrets from keyrings as they are
      dropped.
      
      This commit changes the handling of secrets in external-ui-mode: now
      we first build a list of known secrets and, if necessary, populate the
      dialog with the ones that must be asked. After the dialog quits we
      update the secret values in the list from the dialog and return all
      secrets, including ones not asked.
      
      #59
      https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/193
      
      Fixes: bce8d0a7 ("applet/vpn-request: add external UI mode")
      dee77447
  12. 27 Sep, 2019 2 commits
  13. 23 Sep, 2019 1 commit
  14. 20 Sep, 2019 8 commits
    • Beniamino Galvani's avatar
      meson: drop 'install' argument from configure_file() · d929a309
      Beniamino Galvani authored
      It was added in meson 0.50 while we require 0.46. Furthermore it
      defaults to true when a install directory is specified and so it can
      be omitted.
      
      #70
      d929a309
    • Lubomir Rintel's avatar
      build: allow building a GTK4 flavor of libnma · 56156563
      Lubomir Rintel authored
      This is EXPERIMENTAL EXPERIMENTAL EXPERIMENTAL. GTK4 is not released yet
      and things will change in incompatible ways.
      
      A new library called "libnma-gtk4" is added. The non-libnma parts
      (applet, editor) are not ported.
      
      There are few reasons for merging this early and none of them is
      shipping the library to the users at this point:
      
      * To allow bringup of GTK4-enabled VPN plugins
      * Do not block GTK4 enablement of GNOME Control Center
      * Help avoid using features that will be difficult to port from GTK3
      
      All the test programs work, they emit a fair amount of warnings about
      properties that were removed in GTK4. To deal with those, we'd need to
      build different GResources for GTK3 and GTK4. The differencies seem
      small enough to the point the conversion could be automated. TODO,
      doesn't block testing.
      
      Tested to build with gtk+-4.0 = 3.94.0, but even the pkg-config name
      changed since in GTK4 git master. Did I say this is EXPERIMENTAL and
      there will be incompatible changes?
      56156563
    • Lubomir Rintel's avatar
      utils: support GTK4 · 2ded57d9
      Lubomir Rintel authored
      Cover a trivial difference with an ifdef.
      2ded57d9
    • Lubomir Rintel's avatar
      nma/tests: add GTK4 support · 17136e26
      Lubomir Rintel authored
      Just paint over the differencies with a few ifdefs.
      17136e26
    • Lubomir Rintel's avatar
      nma/mobile-wizard: drop use of GtkWidget.no-show-all property · 9c4cafd4
      Lubomir Rintel authored
      It's going away in Gtk4. We don't do show_all() anyway -- just hide the
      widgets by default.
      9c4cafd4
    • Lubomir Rintel's avatar
      nma/wifi-dialog: paint over the GTK4 incompatibilities · 08cd414e
      Lubomir Rintel authored
      Essentially to get the thing to compile for now.
      08cd414e
    • Lubomir Rintel's avatar
      nma/vpn-password-dialog: deal with the GTK4 gtk_widget_activate_default · af58de61
      Lubomir Rintel authored
      Replaces Gtk4's gtk_window_activate_default. This probably deserves a
      better solution, but it will have to do for now.
      af58de61
    • Lubomir Rintel's avatar
      nma/file-cert-chooser: add GTK4 support · 6d3ad853
      Lubomir Rintel authored
      There's no no-show-all in GTK4. Using it in GTK3 is perhaps also a bad
      idea, but we can't change that now without potentially breaking things
      at this point.
      6d3ad853