The mnemonics of radio buttons *inside* the pop-up menu don't work
with respect to the whole window. They only work, if you already
opened the pop-up menu, and then press the mnemonic key.
But since you cannot open the pop-up menu with a shortcut,
this becomes moot and the user has to click anyway.

But more importantly, we are using the same string as tooltip
for the icon, which wrongly showed the underscore of the mnemonic.
Fix that by just removing the the mnemonics.

https://bugzilla.gnome.org/show_bug.cgi?id=754726

Fixes: 50b9650c
(cherry picked from commit d888f571)

https://bugzilla.gnome.org/show_bug.cgi?id=754349

(cherry picked from commit 807cbdf2)

If the connection is invalid, the "Connect" button in the Wi-Fi password
dialog stays disabled and makes it hard for the user to understand the
reason.

Especially when connecting to certain EAP-typed Wi-Fi connections, the
connection might have no CA certificate set. However, if the connection
was not previously edited with nm-connection-editor, the connection is
considered invalid by nm-applet because "No CA certificate is required"
is unchecked.
As this flag is only stored in the gsetting of the user, NetworkManager
and nm-applet disagree about whether the connection is valid.

Add a tooltip to the connect button to indicate to the user that the
connection must be modified first.

Steps to reproduce:

  - create a Wi-Fi connection of type EAP (PEAP, TLS, or TTLS) outside
    of nm-applet/nm-connection-editor. Or alternatively, clear the
    gsettings entry with:
       dconf reset -f /org/gnome/nm-applet/eap/
  - try to connect to the Wi-Fi. Note that the "Connect" button of the
    password dialog is diabled (just like the "Save" button in nm-ce).

https://bugzilla.gnome.org/show_bug.cgi?id=754172
https://bugzilla.redhat.com/show_bug.cgi?id=1247885
(cherry picked from commit 53e801f3)

https://bugzilla.redhat.com/show_bug.cgi?id=1254043

(cherry picked from commit 0d0e8431)

Fixes commit 9c3aa50c.

(cherry picked from commit 2ca7ec24)

https://bugzilla.redhat.com/show_bug.cgi?id=1177860

(cherry picked from commit d66258a6)

MTU is the 802-3-ethernet.mtu key, make sure wired setting exists.

The same change as for bond in commit b1c5b409,
but fixed saving MTU = 0.

https://bugzilla.redhat.com/show_bug.cgi?id=1255927

(cherry picked from commit f6fdb2a2)

Some connection types may require other connections. For example, when creating
a VLAN connection, we add other connections to "Parent interface" list.
$ nm-connection-editor -t vlan -c

https://bugzilla.redhat.com/show_bug.cgi?id=1255735

GPOINTER_TO_UINT may truncate the GType (actually gsize, i.e. unsigned long).
Use rather GPOINTER_TO_SIZE() to be safe. And GSIZE_TO_POINTER() for the
opposite conversion.

(cherry picked from commit ca9bed77)

It causes an extraneous RPM dependency to be generated even when there are no
symbols that actually use it.

(cherry picked from commit 1cf50026)

This reverts commit aca6a3a7.

Intended for master.

GNOME release tooling repacks the bz2 to a xz anyway. This makes it easier for
packagers to use tarballs created with "make dist" in place of distribution
tarballs.

It's actually supposed to be handled through gettext and not
put into the XML.  A lot of projects are doing it wrong, and now
glib-compile-schemas will yell at you.

https://bugzilla.gnome.org/show_bug.cgi?id=747209
(cherry picked from commit 21319f4e)

Ethirajan D authored Aug 03, 2015 and Dan Williams committed Aug 12, 2015

https://bugzilla.gnome.org/show_bug.cgi?id=752621
(cherry picked from commit 80937b63)

Fixes: 5158105c
(cherry picked from commit 815bf64a)

This detects the current git commit id and embeds it in the
generated "configure" script. As the configure script is included
in the dist-tarball, we can detect the original git commit from
a tarball.

(cherry picked from commit 5158105c)

Update m4/compiler_warnings.m4 with what we have on NetworkManager
master. With this I can build nm-applet on Fedora 21 with clang.

Also fix two bugs that were found by clang warnings.

(cherry picked from commit c531937f)

This makes m4/compiler_warnings.m4 more similar to what we have
currently in NetworkManager master.

(cherry picked from commit a090f5df)

Lubomir Rintel authored Mar 19, 2015 and Thomas Haller committed Aug 10, 2015

Known glib issue. Fixes Fedora 22 build.

Taken from NetworkManager, commit 5206a9b28d1fed252f80bc241a481780fee556e1.

(cherry picked from commit 63dce578)

Lubomir Rintel authored Mar 18, 2015 and Thomas Haller committed Aug 10, 2015

Fixes build with clang 3.5 on Fedora 21.

Taken from NetworkManager, commit f0740aff88a83c228aa22cfd4c567e31e36bb504.

(cherry picked from commit 440e8f59)

Since GCC 4.4, gcc does not warn about unknown -Wno-* flags. At
least, it does not warning unless another warning is raised as well
(https://gcc.gnu.org/wiki/FAQ#wnowarning).

We didn't notice up to now, because we only tested flags that GCC
actually supports.

Hack around this, by checking for the -W* counterpart instead.

Taken from NetworkManager, commit 0462104317bfc097a90707a13590248707324846.

(cherry picked from commit c090c3a3)

NM_COMPILER_WARNINGS still works the same, but
rename variables to have a CFLAGS_* prefix.

Also cleanup the construction of CFLAGS by appending
to CFLAGS_MORE_WARNINGS variable instead of appending
to CFLAGS, and resetting to SAVE_CFLAGS.

Taken from NetworkManager, commit dd243ceefe998be36b5f0bea014d007ba30ec3fb.

(cherry picked from commit 0d107804)

Copied over from NetworkManager, added a whitelist of symbols that were
unversioned in 1.0.0 and we want to keep them unversioned.

(cherry picked from commit 2a1a35f9)

We've added new ABI. Nevertheless, we still want to leave the rest unversioned,
so that linking against it won't add a versioned symbol dependency.

(cherry picked from commit 7ae3f7ab)

The functions handling password icon/menu moved to libnm-gtk so that they are
available outside nm-connection-editor, in VPN plugins for example.
New menu entries have been added for "always ask" and for "not required"
(optional).
VPN password dialog has been added an entry for ternary password.

https://bugzilla.gnome.org/show_bug.cgi?id=731891

and use the parameter properly when nm-applet asks for a password.