GitLab

When a connection is added the editor adds a new empty item to the
tree store with gtk_tree_store_append() and then populates
it. Therefore, has_visible_children() must be prepared to deal with
missing values.

Fixes: 4645c9ae

https://bugzilla.redhat.com/show_bug.cgi?id=1543958

This was a misunderstanding of what it does on my part.

!51

The XEmbed backed GtkStatusIcon wouldn't work without X11.

!46

The library is no more.

!50

!47

This adds support for GNOME Shell style external UI mode of VPN auth dialog
helpers. This makes it possible for the VPN plugins to ship auth dialog
herlpers that are not linked with Gtk at all.

This changes the auth-dialog communication in two important ways:

1.) It reworks how is the end of input determined. Previously \n\n whould
    signal a successful end of input, now it checks for EOF instead.

2.) It now no longer reads and processes the input line by line, but
    accumulates the whole thing and only splits it into lines afterwards.

Both changes are done so that external UI mode is easier to add, while
sharing as input handling as possible. The external UI mode uses a GKeyFile
formatted description of the connection secrets. It is parsed as a
whole, not on a line-by-line basis and it is not terminated with a \n\n.

It is functionally requivalent.

!47

This adds support for GNOME Shell style external UI mode of VPN auth dialog
helpers. This makes it possible for the VPN plugins to ship auth dialog
herlpers that are not linked with Gtk at all.

This changes the auth-dialog communication in two important ways:

1.) It reworks how is the end of input determined. Previously \n\n whould
    signal a successful end of input, now it checks for EOF instead.

2.) It now no longer reads and processes the input line by line, but
    accumulates the whole thing and only splits it into lines afterwards.

Both changes are done so that external UI mode is easier to add, while
sharing as input handling as possible. The external UI mode uses a GKeyFile
formatted description of the connection secrets. It is parsed as a
whole, not on a line-by-line basis and it is not terminated with a \n\n.

It is functionally requivalent.

It seems more logical than having the VPN section in between

!49

!44

A slight usability improvement.

The label is confusing and the tree view header is redundant. Fix the
label and remove the header.

It's just not nice.

!45

Draws a QR code exposing the connection details for a NMConnection. Can
print a business-card with the code too.

A MIT-licensed library [1] wrapped in a simple GObject that is able to
draw to a Cairo surface. Will be accompanied with a Gtk widget.

[1] https://www.nayuki.io/page/qr-code-generator-library

This partially reverts commit 24c5f40e.

nm-connection-editor is used by gnome-control-center to configure mobile
broadband connections. This means that nm-connection-editor is installed
by default by GNOME based distributions.
So, the nm-connection-editor icon will be there by default and may
confuse the average user looking for the default/basic UI to configure
networking (gnome-control-center).
Moreover, nm-connection-editor icon does not follow the current GNOME
icon design guidelines (yet).
Let's disable the application visibility for now.

#54
#55

Convenient if we have a saved password and a non-saved OTP.