GitLab

The secret agent requests contain two parameters that aren't currently
used when handling Wifi network connections: the setting name and hints.
Those parameters turned out useful with 802.1X / EAP authentication with
NM's IWD backend where it passes a specific 802_1x setting key name that
is being requested in the 'hints' array, one of: identity, password or
private_key_password.
nmcli already gained support for handling such agent requests in
1a6e53808db8bb8e75317fd5feacd74a9a98860f (which was obviously much
easier) so this is an attempt to let the src/wireless-security/* classes
in nm-applet also handle these requests as intended.

A new libnma function nma_wifi_dialog_new_for_secrets is added to
receive the values from setting name and hints without changing existing
API.

!30

The user chose not to use a CA certificate when creating the connection,
when we ask for secrets there's no way for them to reconsider.

It's not actually ignored.

...similarly to what we do in the editor windows. It provides some clue
about why is the "Connect" button greyed out.

For the GTK_RESPONSE_CANCEL, just plain gtk_dialog_set_response_sensitive()
is good enough.

Let's keep the wrapper function for GTK_RESPONSE_OK because apart from
changing sensitivity we do also change the tooltip.

If we're asking for secrets only, hide the entry boxes that are greyed
out because the key/cert doesn't actually need a password.

If both password entries are hidden then also remove the "show
passwords" checkbox.

It makes no sense and Gtk+ dislikes this:

  (lt-wifi-dialog:791007): Gtk-CRITICAL **: 17:16:55.127: gtk_widget_event:
    assertion 'WIDGET_REALIZED_FOR_EVENT (widget, event)' failed

It's going away in Gtk4. We don't do show_all() anyway -- just hide the
widgets by default.

This commit brings back parts of 07d900c0 ("libnma: drop use of
GtkWidget.no-show-all property") that was unnecessarily reverted in
f56334c3 ("Revert "libnma: drop use of GtkWidget.no-show-all
property"") with another fix folded in.

!24

These make it easy to quickly check the widgets provided by the
libnma libary.

!21

The icon misaligns things too much to the right. Replace the HBox+VBox
pair with a Grid that is more flexible.

!20

!25

Since there is no longer a field for provider name, the string does
not make much sense – the user is not entering a provider, she is only
setting the APN.

This avoids some useless casting while keeping the type information more
accurate.

We don't need it. All we need is the access technology and possibly an
APN name.

It's the APN entry box. Make the name less confusing.

They just clutter the list unnecessarily -- the user shall select "My
country is not listed" to fill in the access method and eventyally the APN
manually.

Move the "My country is not listed" entry to the providers database,
with an empty country code. Add the providers from unrecognized
countries to this.

This is essentially a robustness improvement. It also makes broken
installations (no iso-codes, etc.) less hopeless.

https://bugzilla.redhat.com/show_bug.cgi?id=1608325

By now nobody should be using this. Keep the code around for a little
longer just in case anybody still uses this.

!29

This broke gnome-control-center and nm-connection-editor,
which call gtk_widget_show_all().

Two offending gtk_widget_show_all() calls by nm-connection-editor
were removed in response to the issue for nm-openvpn's certificate
password ([1], [2], [3], [4]). Of course, older versions of nm-c-e
and all versions of gnome-control-center are still broken by the change.

However, there are other issues like missing 802-1x tabs [5].

It's not acceptable to break existing users of libnma. Even if they
possibly should be fixed.

For the moment, revert the patches.

[1] NetworkManager-openvpn#6
[2] NetworkManager-openvpn#7
[3] #20
[4] https://bugzilla.redhat.com/show_bug.cgi?id=1626397
[5] #25

!27

Fixes: 07d900c0

This reverts commit 07d900c0.

This reverts commit ba8df364.