GitLab

It's gone from Gtk4. We mostly use it to pad out the pages in the editor
and on a couple other places (where the use is probably incorrect).

The migration manual suggests that a margin of a child should be used
instead. This indeed works for us.

However, we need to set four properties from each side, which is not
nice. An alternative would be to use a CSS class, butthere's no sensible
class in the default theme for the job and it's perhaps not worth adding
a custom style sheet for us.

It's long deprecated and gone from Gtk4.

It's long deprecated and gone from Gtk4.

Valign does the same thing while not being deprecated and dropped in Gtk4.

The latter is deprecated in favor of the former. The difference in
behavior is that they have opposite meanings in RTL scripts, which is
probaby good (well, at least for the labels).

Notably, this future-proofs us for Gtk4 that drops the deprecated
properties.

connection_combo_init() is also called when the device combo is changed.
Don't assume the connection is NULL; it is not going to be.

The property will be gone in Gtk4. Instead set marigins on the child
widgets.

The SSIDs with [<>] in it would mess up with the markup.

It's going away in Gtk4. We don't do show_all() anyway -- just hide the
widgets by default.

This never worked for the file picker, since it tripped an assertion on
setting NULL to the GtkEntry. Don't do that and guard the PKCS#11 picker
too.

There were some ommissions in the commits below:

Fixes: 004ac2a2
Fixes: e1a0b880

The password labels as specified in the .ui file have "use_underline"
property set. However it gets reset upon gtk_label_set_text().
Let's preserve it.

This fixes an ugliness with VPNC plugin and perhaps more.

!13

  $ nm-connection-editor --create --type bluetooth
  <ESC>
  GLib-GObject-CRITICAL: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

On nm-connection-editor --import, nm_connection_list_create() is called
with an empty ctype (G_TYPE_INVALID). This is not good -- on a
successful import the first known type (which happens to be Bluetooth)
would match.

Let's treat this as "any connection type" -- attempt a VPN import
opportunistically and if it succeeds, continute with a ctype of
NM_TYPE_SETTING_VPN. Otherwise just bail out.

This is done from new callbacks of nm_connection_list_create() and
nm_connection_list_add().

In order for this to work, import_vpn_from_file_cb() had to be fixed to
always invoke its callback. In turn, vpn_connection_from_file() had to
be changed to pass its error result up to its callers instead of
presenting a potentially redundant error message itself.

Some warnings depends on others: -Wformat-security won't work without
-Wformat. With -Wall we're confident enough that we have important
warnings enabled and in any case we're going to enable it anyway.

This is the same as NetworkManager does. Allows us to catch bugs earlier.

!12

Now that GtkApplication makes good decisions about when to quit (when no
windows are present), the magic that deferred creation of vpn type
selector is useless. Worse even, it makes GtkApplication believe that
we're done and shuts it down before an editor window is added to it.

#9

Reported-by: Jan Tojnar

It's solely used for parsing --keep-above and doesn't know anything
about actual options and thus prints irrelevant help. Skip that and let
the GtkApplication::command-line signal handler parse it and print help
instead.

The current AppStream specification prefers /usr/share/metainfo eveyone
who relies on this (that's distros, not the end users) already supports
the new location.

#2

https://bugzilla.redhat.com/show_bug.cgi?id=1390638

!5

The other options should be ignored when we look for --keep-above.
g_option_context_parse() removes it from argv[], thus we can also
revert 88e4dcab.

It's of no use anymore now that GtkApplication decides when to quit.

Tracking all windows as application windows makes it possible for the
GtkApplication to terminate at the correct point -- when no windows are
present.

This indicates that a new editor window has been opened, for the
purposes of tracking the windows as GtkApplication windows.