https://bugzilla.redhat.com/show_bug.cgi?id=1665653
!34

We need to connect to "changed" signal only when the widget is
displayed. Also, connection_combo_init() can be called multiple times
and so we need to clear previous handlers registration or the
function can be called multiple times.

The specific_connection parameter is passed to
connection_combo_init(), which stores the connection in
priv->connection. When the user changes device, device_combo_changed()
calls again connection_combo_init() passing a NULL argument and so the
specific connection gets lost.

Store the specific_connection in the dialog private data and use it
when the connection combo is re-initialized.

https://bugzilla.redhat.com/show_bug.cgi?id=1665653

Gnome and KDE do not allow to start nm-connection-editor from the GUI, nor
provide a graphical way to manage more specialized connections, like
Bridge, Team and Bond ones: re-enable desktop launcher visibility.
Change the displayed name to hint users that the tool should be used for
specialized networking configurations.

https://bugzilla.redhat.com/show_bug.cgi?id=1493508

This is essentially "master" and "lr/test-programs" branches from
https://github.com/balrog-kun/network-manager-applet.git with a couple
of simple fixups and rebase on top of master.

https://github.com/NetworkManager/network-manager-applet/pull/2

Andrew Zaborowski authored Oct 26, 2018 and Lubomir Rintel committed Nov 26, 2018

[lkundrak@v3.sk: split this into a separate executable]

Andrew Zaborowski authored Oct 06, 2018 and Lubomir Rintel committed Nov 26, 2018

For AP mode connections add options to the security combo box based on
what nm_utils_ap_mode_security_valid thinks is valid instead of treating
them same as AdHoc (i.e. using nm_utils_security_valid).  This brings
the set of allowed methods at least on par with what connection-editor
allows.  The function security_valid is copied from there.

Andrew Zaborowski authored Sep 16, 2018 and Lubomir Rintel committed Nov 26, 2018

The "external" EAP method string is used in connections automatically
created by NM to mirror IWD-configured networks where we only know
they use EAP authentication but not what method or other 802-1x
setting values, and the values are not even needed by NM.  So still
don't allow manually setting a connection's EAP method to "external" but
if that value is already set for the connection then reflect that in the
security combo.  We abuse the EAPMethodSimple class to produce an empty
GtkGrid basically.

Andrew Zaborowski authored Sep 03, 2018 and Lubomir Rintel committed Nov 26, 2018

Use the hints passed down from the secret agent request, if any, to
select the EAPMethodSimple UI and show or hide GtkEntry widgets
according to which secrets are being requested.  This unfortunately
touches all the places that use EAPMethodSimple.  I used this specific
class because it is already kind of handling a bunch of different
actual EAP methods but I could also have created a new UI separate
EAPMethodSimple.

Since I'm abusing EAPMethodSimple for this, I also needed to add a new
eap method type "unknown", first because where this code is useful NM
does not know what specific EAP method is used and secondly the UI
doesn't really need to know that.

Note that hints being non-NULL implies secrets_only.  Since with
secrets_only the password storage flags can't be changed, I didn't
bother adding the storage flags to the GtkEntry for the private key
passphrase so it doesn't get the secondary icon thing even though the
plain password field does still have the icon.  Only the three hint
strings are supported which are actually in use in the NM tree in the
IWD wifi backend.

[lkundrak@v3.sk: fix up error handling in
eap-method-simple.c:validate()]

Andrew Zaborowski authored Sep 03, 2018 and Lubomir Rintel committed Nov 26, 2018

Use the setting name given by NM in the agent request to request current
values of secrets we will be letting the user edit in the wifi dialogs,
if provided.

Andrew Zaborowski authored Sep 03, 2018 and Lubomir Rintel committed Nov 26, 2018

The secret agent requests contain two parameters that aren't currently
used when handling Wifi network connections: the setting name and hints.
Those parameters turned out useful with 802.1X / EAP authentication with
NM's IWD backend where it passes a specific 802_1x setting key name that
is being requested in the 'hints' array, one of: identity, password or
private_key_password.
nmcli already gained support for handling such agent requests in
1a6e53808db8bb8e75317fd5feacd74a9a98860f (which was obviously much
easier) so this is an attempt to let the src/wireless-security/* classes
in nm-applet also handle these requests as intended.

A new libnma function nma_wifi_dialog_new_for_secrets is added to
receive the values from setting name and hints without changing existing
API.

!30

The user chose not to use a CA certificate when creating the connection,
when we ask for secrets there's no way for them to reconsider.

It's not actually ignored.

...similarly to what we do in the editor windows. It provides some clue
about why is the "Connect" button greyed out.

For the GTK_RESPONSE_CANCEL, just plain gtk_dialog_set_response_sensitive()
is good enough.

Let's keep the wrapper function for GTK_RESPONSE_OK because apart from
changing sensitivity we do also change the tooltip.

If we're asking for secrets only, hide the entry boxes that are greyed
out because the key/cert doesn't actually need a password.

If both password entries are hidden then also remove the "show
passwords" checkbox.

It makes no sense and Gtk+ dislikes this:

  (lt-wifi-dialog:791007): Gtk-CRITICAL **: 17:16:55.127: gtk_widget_event:
    assertion 'WIDGET_REALIZED_FOR_EVENT (widget, event)' failed

It's going away in Gtk4. We don't do show_all() anyway -- just hide the
widgets by default.

This commit brings back parts of 07d900c0 ("libnma: drop use of
GtkWidget.no-show-all property") that was unnecessarily reverted in
f56334c3 ("Revert "libnma: drop use of GtkWidget.no-show-all
property"") with another fix folded in.

!24

These make it easy to quickly check the widgets provided by the
libnma libary.

!21

The icon misaligns things too much to the right. Replace the HBox+VBox
pair with a Grid that is more flexible.

!20

!25

Jan Tojnar authored Aug 28, 2018 and Lubomir Rintel committed Oct 26, 2018

Since there is no longer a field for provider name, the string does
not make much sense – the user is not entering a provider, she is only
setting the APN.