1. 24 Jul, 2018 5 commits
    • Lubomir Rintel's avatar
      bluetooth: fix an assert failure on creation cancellation · 516f3f6c
      Lubomir Rintel authored
        $ nm-connection-editor --create --type bluetooth
        <ESC>
        GLib-GObject-CRITICAL: g_object_unref: assertion 'G_IS_OBJECT (object)' failed
      516f3f6c
    • Lubomir Rintel's avatar
      connection-list: attempt a VPN import first · 9d79ffdb
      Lubomir Rintel authored
      On nm-connection-editor --import, nm_connection_list_create() is called
      with an empty ctype (G_TYPE_INVALID). This is not good -- on a
      successful import the first known type (which happens to be Bluetooth)
      would match.
      
      Let's treat this as "any connection type" -- attempt a VPN import
      opportunistically and if it succeeds, continute with a ctype of
      NM_TYPE_SETTING_VPN. Otherwise just bail out.
      9d79ffdb
    • Lubomir Rintel's avatar
      connection-editor: hold GApplication while the import dialog is running · 419c459e
      Lubomir Rintel authored
      This is done from new callbacks of nm_connection_list_create() and
      nm_connection_list_add().
      
      In order for this to work, import_vpn_from_file_cb() had to be fixed to
      always invoke its callback. In turn, vpn_connection_from_file() had to
      be changed to pass its error result up to its callers instead of
      presenting a potentially redundant error message itself.
      419c459e
    • Lubomir Rintel's avatar
      build: set -Wall before we start probing the extra warning options · 1f92eb17
      Lubomir Rintel authored
      Some warnings depends on others: -Wformat-security won't work without
      -Wformat. With -Wall we're confident enough that we have important
      warnings enabled and in any case we're going to enable it anyway.
      1f92eb17
    • Lubomir Rintel's avatar
      build: enable more warnings on autogen · 728232c2
      Lubomir Rintel authored
      This is the same as NetworkManager does. Allows us to catch bugs earlier.
      728232c2
  2. 23 Jul, 2018 1 commit
  3. 20 Jul, 2018 2 commits
  4. 13 Jul, 2018 1 commit
  5. 12 Jul, 2018 2 commits
    • Lubomir Rintel's avatar
      connection-editor: don't defer creation of vpn connection to idle · d9215e1a
      Lubomir Rintel authored
      Now that GtkApplication makes good decisions about when to quit (when no
      windows are present), the magic that deferred creation of vpn type
      selector is useless. Worse even, it makes GtkApplication believe that
      we're done and shuts it down before an editor window is added to it.
      
      #9
      
      Reported-by: Jan Tojnar
      d9215e1a
    • Lubomir Rintel's avatar
      connection-editor: ignore --help in main() option context · 346630de
      Lubomir Rintel authored
      It's solely used for parsing --keep-above and doesn't know anything
      about actual options and thus prints irrelevant help. Skip that and let
      the GtkApplication::command-line signal handler parse it and print help
      instead.
      346630de
  6. 05 Jul, 2018 2 commits
  7. 26 Jun, 2018 1 commit
  8. 25 Jun, 2018 5 commits
  9. 24 Jun, 2018 1 commit
  10. 21 Jun, 2018 1 commit
  11. 19 Jun, 2018 19 commits