1. 09 Aug, 2012 1 commit
  2. 07 Aug, 2012 3 commits
  3. 14 Jun, 2012 1 commit
  4. 17 Mar, 2012 1 commit
    • Dan Williams's avatar
      editor: disable Ad-Hoc WPA connections (lp:905748) · 4e815512
      Dan Williams authored
      The kernel has long been broken for Ad-Hoc WPA, so don't let that
      combination of options be used when creating network configuration.
      When the kernel starts working again we can re-enable it, or better
      yet, just use real AP mode.
  5. 13 Mar, 2012 4 commits
  6. 03 Nov, 2011 1 commit
  7. 21 Jul, 2011 1 commit
  8. 18 Jun, 2011 1 commit
    • Dan Williams's avatar
      editor: update secret flags when updating visibility · 13288e3b
      Dan Williams authored
      Previously only the visibility got changed when changing the
      "Available to all users" toggle.  When making a connection private,
      then public, then private again, secrets would be moved to system
      settings when making the connection public, but would not be removed
      when making the connection private again.
      Reported by Michael Biebl
  9. 29 Mar, 2011 2 commits
    • Dan Williams's avatar
      editor: fix widget refcounting by cleanup up .ui toplevel widgets · 95169d88
      Dan Williams authored
      Since GtkBuilder constructs all the widgets in the .ui file when
      using gtk_builder_load_from_file(), every toplevel gets constructed
      and then added to the 'toplevel_list' internally in GTK.  If you
      don't then explicitly destroy every toplevel that got constructed
      by the builder, the toplevel you forgot about still exists and
      is still part of the "toplevel_list" leading to possible crashes
      later on GTK issues grabs for eg list scrolling.
      The editor and applet made heavy use of Glade's "root" argument when
      loading .glade files to only construct a part of the widget
      hierarchy, but those child widgets were always embedded in a toplevel
      due to previous limitations of Glade 2.x.  But when converting over
      to GtkBuilder, the code still kept ignoring the toplevel the child
      was embedded in, even though we now need to track and destroy that
      toplevel.  Thus, when the code was done with its child widget and
      destroyed that child widget, the ignored toplevel still thought it
      had children, and when GTK issued grabs due to scrolling the
      live-but-hidden toplevel tried to execute operations on its
      long-dead children.
      We can of course use gtk_builder_add_objects_from_file() to emulate
      the 'root' argument of Glade, but that's somewhat cumbersome, and
      performance is better if we just split out toplevel widgets into
      their own .ui files anyway, and get rid of toplevels from .ui files
      where they aren't needed.
    • Dan Williams's avatar
      editor: initialize pages after all pages have been created · f60260df
      Dan Williams authored
      Otherwise, due to signals emitted as a result of get_secrets_for_page()
      we may end up calling recheck_initialization() with
      editor->initializing_pages empty, thus setting editor->init_run to
      TRUE, and skipping any further calls to recheck_initialization()
      when other pages initialize later.  Basically, just separate the
      creation step from the page initialization/setup step to make sure
      we correctly track which pages are initializing at any given point.
  10. 12 Mar, 2011 1 commit
  11. 24 Feb, 2011 1 commit
  12. 13 Feb, 2011 1 commit
  13. 03 Feb, 2011 1 commit
  14. 27 Jan, 2011 1 commit
  15. 23 Dec, 2010 1 commit
  16. 05 Dec, 2010 1 commit
    • Dan Williams's avatar
      core: fix GtkBuilder-related performance issues · 0f4fedc5
      Dan Williams authored
      GtkBuilder isn't as quick as libglade when building the widget
      tree from the XML file, so the previous handling of wireless
      security and EAP methods caused connection editor display times
      of 4 seconds or more on slower machines (like 1.7GHz Pentium M).
      Previously, all security and EAP UI was stored in one glade/builder
      file which was re-read from multiple places.  With glade that was
      fine, but GtkBuilder's gtk_builder_add_from_file() takes quite a
      bit longer than glade did.
      So split each piece security and EAP UI description out into a
      separate file, and consolidated handling of UI building into the
      EAPMethod and WirelessSecurity classes instead of doing it in
      the subclasses.
  17. 28 Nov, 2010 1 commit
  18. 12 Oct, 2010 2 commits
  19. 28 Jun, 2010 1 commit
    • Dan Williams's avatar
      editor: make sure editor windows are destroyed (rh #572466) · 246b8937
      Dan Williams authored
      The GladeXML object we get a top-level window or dialog from
      doesn't actually keep the reference to the object, we own it
      after the glade_xml_get_widget() call.  So we need to destroy
      it, otherwise we'll keep getting signals from the CEPolkitButton
      in the editor window after we've already destroyed it's controlling
      NMConnectionEditor object, leading to badness.
  20. 24 May, 2010 1 commit
  21. 26 Apr, 2010 1 commit
    • Dan Williams's avatar
      editor: fix issues with multiple concurrent operations (rh #585405) · 64ff90de
      Dan Williams authored
      The editor was allowing itself to be closed while it was awaiting
      authorization for updates.  That's bad since (as yet) we don't
      have a way to cancel an ongoing operation that's blocked for
      authorization; that would require API changes to libnm-glib. So
      instead, just don't allow interaction with the editor until the
      user has completed or canceled authorization.
      Also fixes a small bug where the connection's scope would not be
      reset if the user canceled authorization.
  22. 23 Apr, 2010 1 commit
  23. 05 Dec, 2009 3 commits
  24. 02 Oct, 2009 1 commit
    • Dan Williams's avatar
      editor: fix secrets requests after 78b7101d · 6878f634
      Dan Williams authored
      After 78b7101d, the page's connection
      would of course be the duplicated connection which is a plain
      NMConnection that user edits are done on.  THat of course doesn't
      implement NMSettingsConnectionInterface, and thus can't respond to
      requests for secrets.
      Instead, we have the CEPage subclasses for each setting type pass back
      the name of the setting they want secrets for, if they need secrets,
      and let the editor ask for the secrets since it has the original
      connection which usually implements NMSettingsConnectionInterface.
      By moving the addition of the page's GtkWidget to after page
      initialization, we also fix system VPN connections, which were broken
      because the VPN page's plugin-provided widget is only valid after
      the page is initialized, but the editor expected it to be valid
      right after requesting secrets.  In the case of system secrets, the
      request is over D-Bus and is async, which meant that the call would
      complete and the page would initalize long after the connection editor
      had tried to add the page to the UI.
  25. 29 Sep, 2009 3 commits
  26. 21 Sep, 2009 3 commits
  27. 19 Sep, 2009 1 commit