1. 09 Aug, 2012 7 commits
    • Dan Winship's avatar
      connection-editor: rename "wired" and "wireless" in files/classes/functions · 44fc72f5
      Dan Winship authored
      Update internal names to match the UI.
      44fc72f5
    • Dan Winship's avatar
      applet: rename "wired" and "wireless" in files/classes/functions · 3a18b5a9
      Dan Winship authored
      Update internal names to match the UI (except for the "wireless
      security" stuff, which is already a misnomer since it's used for both
      Wi-Fi and 802.1x, and can be revisited later.)
      3a18b5a9
    • Dan Winship's avatar
      applet, connection-editor: Use "Ethernet" and "Wi-Fi" in the UI · 89bf7c0a
      Dan Winship authored
      Change "Wired" to "Ethernet" and "Wireless" to "Wi-Fi" everywhere in
      the UI, to more clearly reflect what they mean. (ie, "Wired" did not
      include DSL or InfiniBand, and "Wireless" did not include mobile
      broadband or WiMAX.)
      
      Also, fix some places that used "wifi"/"Wifi"/"WiFi" instead of
      "Wi-Fi".
      89bf7c0a
    • Dan Winship's avatar
      applet: Update top-of-file comments · 307b3a70
      Dan Winship authored
      "NetworkManager Wireless Applet" is no longer very accurate. Update to
      say:
      
        NetworkManager Applet -- allow user control over networking
      307b3a70
    • Dan Williams's avatar
      mobile: consolidate creation of mobile broadband connection IDs · 999fff8a
      Dan Williams authored
      Instead of doing the same thing in three places, lets do it in one.
      999fff8a
    • Dan Williams's avatar
      applet: remove usage of GNOME keyring from utils bits · 32b610d5
      Dan Williams authored
      The only user of this code was src/applet-agent.c; the control center
      doesn't use it and the GConf compat code has it's own version.
      32b610d5
    • Dan Williams's avatar
      bluetooth: fix GNOME Bluetooth plugin when used from the control center · 56d0e933
      Dan Williams authored
      Since the control center added support for showing the "extra configuration
      widgets" (gnome-bluetooth commit 3b5d7dee45cf8b9c8ce91e65aa9004f784a29b34)
      the NM BT plugin has been broken for DUN.  During the DUN setup process,
      the plugin calls bluez to connect to the phone to start the rfcomm port,
      which changes the bluez device's properties.  That triggers a call to
      cc_bluetooth_panel_update_properties(), which removes all the extra
      configuration widgets and re-adds them.  Unfortunately, that caused all
      the NM BT plugin's data to be freed, while the DUN inspect operation
      was ongoing, eventually resulting in access of freed data when various
      operations finally completed.
      
      To fix that, break out the actual work code into a model, called
      NmaBtDevice, that lives longer than the GtkWidget that's embedded in
      the control panel, and that handles all the necessary PAN/DUN tasks.
      The panel widget is then reworked to simply listen to device signals
      so that it can die and a new instance be created, while the work goes
      on in the background in NmaBtDevice.
      56d0e933
  2. 08 Aug, 2012 4 commits
  3. 07 Aug, 2012 17 commits
  4. 03 Aug, 2012 1 commit
    • Dan Williams's avatar
      applet: only handle VPN secrets with GNOME Shell < 3.4 · 43c61d4d
      Dan Williams authored
      GNOME Shell 3.2 and lower don't handle VPN secrets, so the applet
      still needs to do that.  But they do handle other secrets, so instead
      of having the applet and the Shell fight over who gets to handle
      secrets, defer non-VPN secrets to the Shell.
      43c61d4d
  5. 02 Aug, 2012 1 commit
  6. 27 Jul, 2012 1 commit
  7. 25 Jul, 2012 2 commits
  8. 24 Jul, 2012 1 commit
  9. 23 Jul, 2012 1 commit
  10. 20 Jul, 2012 2 commits
    • Jiří Klimeš's avatar
    • Jiří Klimeš's avatar
      libnm-gtk: fix crash when internal_init() fails · 24084a4a
      Jiří Klimeš authored
      While destroying widget with g_object_unref(), the object was unrefed twice, once
      in gtk_widget_dispose() and second time in g_object_unref() where sigsegv happened.
      gtk_widget_destroy() fixes that.
      
      This was the stacktrace:
      -------------------------------------------------------------------------------
       ** Message: No keyring secrets found for abcd/802-11-wireless-security; asking user.
       ** (nm-applet:29260): WARNING **: No wireless devices available.
       ** (nm-applet:29260): WARNING **: Couldn't create wireless security dialog.
       (nm-applet:29260): GLib-GObject-WARNING **: instance with invalid (NULL) class pointer
       (nm-applet:29260): GLib-GObject-CRITICAL **: g_signal_handlers_destroy: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed
       (nm-applet:29260): GLib-GObject-WARNING **: instance with invalid (NULL) class pointer
       (nm-applet:29260): GLib-GObject-CRITICAL **: g_signal_handlers_destroy: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed
      
       Program received signal SIGSEGV, Segmentation fault.
       0x0000003d91411469 in g_object_unref (_object=0xd3f010) at gobject.c:2740
       2740          TRACE (GOBJECT_OBJECT_UNREF(object,G_TYPE_FROM_INSTANCE(object),old_ref));
       (gdb) bt
       #0  0x0000003d91411469 in g_object_unref (_object=0xd3f010) at gobject.c:2740
       #1  0x00007ffff7da7a63 in nma_wireless_dialog_new (client=0x736310 [NMClient], settings=0x72fd30 [NMRemoteSettings], connection=0xafb2a0 [NMConnection], device=0x0, ap=0x0, secrets_only=1)
           at nm-wireless-dialog.c:1313
       #2  0x0000000000429063 in wireless_get_secrets (req=0x97f600, error=0x7fffffffd6a8) at applet-device-wifi.c:1674
       #3  0x0000000000419179 in get_existing_secrets_cb (agent=0x72fdb0 [AppletAgent], connection=0xafb2a0 [NMConnection], secrets=0xd33640, secrets_error=0x0, user_data=0x97f600) at applet.c:2834
       #4  0x000000000041bea7 in keyring_find_secrets_cb (result=GNOME_KEYRING_RESULT_NO_MATCH, list=0x0, user_data=0x8068a0) at applet-agent.c:426
       #5  0x00000037c2208b66 in on_complete (op=0xd38860) at gkr-operation.c:239
       #6  0x00000037c2210a1d in find_items_1_reply (data=0x8706c0, reply=0xaf8af0, op=0xd38860) at gnome-keyring.c:2370
       #7  find_items_1_reply (op=0xd38860, reply=0xaf8af0, data=0x8706c0) at gnome-keyring.c:2348
       #8  0x00000037c2209aa1 in on_pending_call_notify (pending=<optimized out>, user_data=0xd38860) at gkr-operation.c:400
       #9  0x00000037c160c3ea in ?? () from /lib64/libdbus-1.so.3
       #10 0x00000037c160f67a in dbus_connection_dispatch () from /lib64/libdbus-1.so.3
       #11 0x00000037c2214af5 in message_queue_dispatch (source=<optimized out>, callback=<optimized out>, user_data=<optimized out>) at egg-dbus.c:75
       #12 0x0000003d8f044f3d in g_main_dispatch (context=0x6adaa0) at gmain.c:2441
       #13 g_main_context_dispatch (context=0x6adaa0) at gmain.c:3011
       #14 0x0000003d8f045738 in g_main_context_iterate (context=0x6adaa0, block=<optimized out>, dispatch=1, self=<optimized out>) at gmain.c:3089
       #15 0x0000003d8f045c85 in g_main_loop_run (loop=0x6b18d0) at gmain.c:3297
       #16 0x0000000000411c06 in main (argc=1, argv=0x7fffffffdb68) at main.c:106
       (gdb)
      -------------------------------------------------------------------------------
      24084a4a
  11. 19 Jul, 2012 1 commit
  12. 18 Jul, 2012 2 commits