1. 29 Sep, 2009 1 commit
  2. 21 Sep, 2009 2 commits
    • Dan Williams's avatar
      editor: fix PolicyKit button refcounting · ae143e81
      Dan Williams authored
      When creating GTK widgets manually, they start with a floating
      reference not a real reference, so we need to convert that
      floating ref into a real ref before really using it, or we'll get
      duplicate calls to the dispose method.  glade usually handles
      this behind-the-scenes for us, but when making our own widgets we
      have to do that manually.
      ae143e81
    • Dan Williams's avatar
      editor: small cleanup · f3e3c6b1
      Dan Williams authored
      f3e3c6b1
  3. 19 Sep, 2009 1 commit
  4. 16 Sep, 2009 1 commit
    • Dan Williams's avatar
      core: update to work with certificate paths · b16d8aca
      Dan Williams authored
      Don't store the certificate/key paths in lookaside variables, just use
      the normal key/value pairs in the 802.1x setting.
      
      Since (for backwards compat) NM treats the private key as a secret, we
      need to do a few odd things like retrieving the private key paths from
      GConf when getting secrets from the keyring.
      
      Also, since the private keys and certificate properties are byte arrays,
      it's a slight bit more complicated to load/store them to GConf, requiring
      a bit of indirection in read_one_setting_value_from_gconf() and
      copy_one_setting_value_to_gconf().  Especially for
      copy_one_setting_value_to_gconf() since the incoming certificate may
      just be a byte array of the cert/key data from some older plugin or
      settings service, and thus we need to copy that cert data to a file
      on-disk and possibly re-encrypt a decrypted private key too.
      b16d8aca
  5. 25 Aug, 2009 3 commits
    • Dan Williams's avatar
      editor: fix editor/connection lifetimes · 968616ca
      Dan Williams authored
      The NMConnectionEditor instance refs the NMConnection so we don't
      need to unref when removing the connection (which is also the key to
      the hash) from list->editors.  Make sure the editor gets properly
      cleaned up everwhere too.
      968616ca
    • Dan Williams's avatar
      editor: fix retrieval of 802.1x private key passwords · 6c32fdcd
      Dan Williams authored
      Use NMSettingsConnectionInterface to get secrets instead of two
      different codepaths for system and user secrets.  But since
      returning secrets to NM via D-Bus requires decrypting the private
      key (and thus the password isn't required), we still need a way
      to get the actual private key password out of the generic GetSecrets
      handler for NMAGConfConnection.  Hijack the "include_private_passwords"
      argument of nm_gconf_get_keyring_items() to do this for us.
      6c32fdcd
    • Dan Williams's avatar
      editor: re-add UI authorization/permissions hints · d1707fb1
      Dan Williams authored
      polkit 0.92 and later got rid of the GtkAction subclass that
      provided these hints through button sensitivity and icon changes.
      Roll our own so that the user knows what they can and cannot do
      before clicking on a button that may well just deny their action
      if they aren't authorized.
      d1707fb1
  6. 22 Aug, 2009 1 commit
  7. 11 Aug, 2009 2 commits
  8. 23 Jul, 2009 1 commit
  9. 08 Jul, 2009 1 commit
  10. 02 Jun, 2009 1 commit
  11. 15 Apr, 2009 1 commit
  12. 08 Apr, 2009 1 commit
  13. 04 Apr, 2009 1 commit
    • Dan Williams's avatar
      src/connection-editor/nm-connection-list.c - Send the clicked signal to · 28e6d3e8
      Dan Williams authored
      2009-04-04  Dan Williams  <dcbw@redhat.com>
      
      	* src/connection-editor/nm-connection-list.c
      		- Send the clicked signal to the button instead of calling do_edit()
      			explicitly so that the PolKitAction's code gets run; ensures
      			the same codepath gets taken for double-click as for clicking
      			the edit button
      
      
      svn path=/trunk/; revision=1246
      28e6d3e8
  14. 03 Apr, 2009 1 commit
    • Dan Williams's avatar
      Ensure PolicyKit autorization before editing system connections, and · 90e6e250
      Dan Williams authored
      2009-04-03  Dan Williams  <dcbw@redhat.com>
      
      	* Ensure PolicyKit autorization before editing system connections, and
      		request secrets from the system settings service for system connections.
      		This requires splitting each CEPage subclass's *_new() method into
      		two parts, the first doing minimal setup, and the second filling in
      		the UI with details from the backing NMConnection.  Between the first
      		and second parts, if required, secrets are requested from the system
      		settings service using PolicyKit.  As a bonus, actually handle errors
      		instead of dropping them on the floor.
      
      
      svn path=/trunk/; revision=1244
      90e6e250
  15. 31 Mar, 2009 1 commit
  16. 17 Feb, 2009 1 commit
    • Dan Williams's avatar
      src/gconf-helpers/gconf-helpers.c src/gconf-helpers/gconf-helpers.h - · 138b41e3
      Dan Williams authored
      2009-02-17  Dan Williams  <dcbw@redhat.com>
      
      	* src/gconf-helpers/gconf-helpers.c
      	  src/gconf-helpers/gconf-helpers.h
      		- (nm_gconf_clear_keyring_items): clear keyring items for a
      			connection
      
      	* src/connection-editor/nm-connection-list.c
      		- (remove_connection): clear keyring items when removing a user connection
      
      
      svn path=/trunk/; revision=1176
      138b41e3
  17. 19 Jan, 2009 1 commit
    • Przemysław Grzegorczyk's avatar
      Cleared up gtk and glib includes to use only toplevel headers. Bug · 2bf575f2
      Przemysław Grzegorczyk authored
      2009-01-19  Przemysław Grzegorczyk  <pgrzegorczyk@gmail.com>
      
      	* src/wireless-security/eap-method.h:
      	* src/wireless-security/wireless-security.h:
      	* src/polkit-helpers/polkit-gnome-action.c:
      	* src/connection-editor/ce-page.h:
      	* src/connection-editor/main.c:
      	* src/connection-editor/mobile-wizard.c:
      	* src/connection-editor/nm-connection-editor.c:
      	* src/connection-editor/nm-connection-list.c:
      	* src/connection-editor/nm-connection-list.h:
      	* src/connection-editor/page-dsl.h:
      	* src/connection-editor/page-ip4.h:
      	* src/connection-editor/page-mobile.h:
      	* src/connection-editor/page-ppp.h:
      	* src/connection-editor/page-vpn.h:
      	* src/connection-editor/page-wired-security.h:
      	* src/connection-editor/page-wired.h:
      	* src/connection-editor/page-wireless-security.h:
      	* src/connection-editor/page-wireless.h:
      	* src/ap-menu-item.h:
      	* src/applet-device-cdma.c:
      	* src/applet-device-gsm.c:
      	* src/applet-device-wifi.c:
      	* src/applet-device-wifi.h:
      	* src/applet-device-wired.c:
      	* src/applet-dialogs.c:
      	* src/applet-dialogs.h:
      	* src/applet.h:
      	* src/wireless-dialog.c:
      	* src/wireless-dialog.h: Cleared up gtk and glib includes
      	to use only toplevel headers. Bug #564379.
      
      
      svn path=/trunk/; revision=1106
      2bf575f2
  18. 16 Jan, 2009 1 commit
    • Dan Williams's avatar
      nm-connection-editor.c nm-connection-editor.h - · 979d9dc1
      Dan Williams authored
      2008-01-16  Dan Williams  <dcbw@redhat.com>
      
      	* nm-connection-editor.c
      	  nm-connection-editor.h
      		- (nm_connection_editor_get_window): add accessor to editor GtkWindow
      
      	* nm-connection-list.c
      	  nm-connection-list.h
      		- Pass XID of parent window to PolicyKit to ensure authorization windows
      			are transient for their parent
      		- Make error dialogs transient for the parent window
      
      
      svn path=/trunk/; revision=1094
      979d9dc1
  19. 09 Dec, 2008 1 commit
    • Dan Williams's avatar
      src/connection-editor/main.c - (impl_start): bring connection editor · 213c5a16
      Dan Williams authored
      2008-12-09  Dan Williams  <dcbw@redhat.com>
      
      	* src/connection-editor/main.c
      		- (impl_start): bring connection editor window to front when it's
      			launched again, if it's already started
      
      	* src/connection-editor/nm-connection-list.c
      	  src/connection-editor/nm-connection-list.h
      		- (nm_connection_list_present): no longer static
      
      
      svn path=/trunk/; revision=1059
      213c5a16
  20. 16 Nov, 2008 1 commit
    • Dan Williams's avatar
      configure.ac src/Makefile.am src/polkit-helpers/Makefile.am · 8809b7ad
      Dan Williams authored
      2008-11-15  Dan Williams  <dcbw@redhat.com>
      
      	* configure.ac
      	  src/Makefile.am
      	  src/polkit-helpers/Makefile.am
      	  src/polkit-helpers/README
      	  src/polkit-helpers/polkit-gnome-action.c
      	  src/polkit-helpers/polkit-gnome-action.h
      	  src/polkit-helpers/polkit-gnome-auth.c
      	  src/polkit-helpers/polkit-gnome-auth.h
      	  src/polkit-helpers/polkit-gnome-context.c
      	  src/polkit-helpers/polkit-gnome-context.h
      	  src/polkit-helpers/polkit-gnome.h
      		- Partial backport of PolicyKit-gnome 0.8 to PolicyKit 0.6
      
      	* src/connection-editor/Makefile.am
      	  src/connection-editor/nm-connection-editor.c
      	  src/connection-editor/nm-connection-editor.h
      	  src/connection-editor/nm-connection-list.c
      		- Use polkit-helpers
      
      	* src/connection-editor/polkit-06-helpers.c
      	  src/connection-editor/polkit-06-helpers.h
      		- Remove
      
      
      svn path=/trunk/; revision=1029
      8809b7ad
  21. 14 Nov, 2008 1 commit
    • Dan Williams's avatar
      src/connection-editor/nm-connection-list.c - Pass system settings · b978c773
      Dan Williams authored
      2008-11-14  Dan Williams  <dcbw@redhat.com>
      
      	* src/connection-editor/nm-connection-list.c
      		- Pass system settings 'CanModify' property along to the connection
      			editor window
      
      	* src/connection-editor/nm-connection-editor.c
      	  src/connection-editor/nm-connection-editor.h
      		- (nm_connection_editor_new): track whether system settings can actually
      			add conenctions or not
      		- (populate_connection_ui, set_editor_sensitivity): don't enable the
      			system settings checkbox if system settings can't be modified
      
      
      svn path=/trunk/; revision=1020
      b978c773
  22. 31 Oct, 2008 2 commits
    • Dan Williams's avatar
      src/gconf-helpers/nma-gconf-connection.c - (update): actually save private · cec8bbe5
      Dan Williams authored
      2008-10-31  Dan Williams  <dcbw@redhat.com>
      
      	* src/gconf-helpers/nma-gconf-connection.c
      		- (update): actually save private values like cert and key paths
      
      	* src/connection-editor/nm-connection-list.c
      		- (add_connection): fill certificate and private key items before adding
      			so that cert data actually gets to the system settings service
      		- (update_connection): copy private values before trying to update the
      			connection so that they actually get saved
      
      
      svn path=/trunk/; revision=996
      cec8bbe5
    • Dan Williams's avatar
      src/gconf-helpers/gconf-helpers.c src/gconf-helpers/gconf-helpers.h - · 32ba49e8
      Dan Williams authored
      2008-10-31  Dan Williams  <dcbw@redhat.com>
      
      	* src/gconf-helpers/gconf-helpers.c
      	  src/gconf-helpers/gconf-helpers.h
      		- (nm_gconf_copy_private_connection_values): copy private values (like
      			certificate paths and such) between connections
      		- (nm_gconf_connection_duplicate): use nm_gconf_copy_private_connection_values()
      
      	* src/connection-editor/nm-connection-list.c
      		- (update_connection): make sure to copy private values when updating
      			the connection
      
      
      svn path=/trunk/; revision=995
      32ba49e8
  23. 29 Oct, 2008 1 commit
    • Tambet Ingo's avatar
      src/connection-editor/nm-connection-list.c · ec8dbe27
      Tambet Ingo authored
      2008-10-29  Tambet Ingo  <tambet@gmail.com>
      
      	* src/connection-editor/nm-connection-list.c
      	src/connection-editor/page-vpn.c
      	src/connection-editor/vpn-helpers.c
      	src/gconf-helpers/gconf-upgrade.c
      	src/gconf-helpers/nma-gconf-connection.c
      	src/vpn-password-dialog.c
      		- Use VPN setting accessors.
      
      svn path=/trunk/; revision=988
      ec8dbe27
  24. 27 Oct, 2008 2 commits
    • Dan Williams's avatar
      Patch from Jaap A. Haitsma <jaap@haitsma.org> · c80abf48
      Dan Williams authored
      2008-10-26  Dan Williams  <dcbw@redhat.com>
      
      	Patch from Jaap A. Haitsma <jaap@haitsma.org>
      
      	* src/connection-editor/nm-connection-editor.c
      	  src/connection-editor/nm-connection-list.c
      		- Make default window icons actually work (bgo #553170)
      
      
      svn path=/trunk/; revision=981
      c80abf48
    • Dan Williams's avatar
      Patch from Tambet Ingo <tambet@gmail.com> · 8ab77ddf
      Dan Williams authored
      2008-10-26  Dan Williams  <dcbw@redhat.com>
      
      	Patch from Tambet Ingo <tambet@gmail.com>
      
      	* src/applet-device-cdma.c
      	  src/applet-device-gsm.c
      	  src/applet-device-wifi.c
      	  src/applet-device-wired.c
      	  src/applet-dialogs.c
      	  src/applet.c
      	  src/connection-editor/nm-connection-editor.c
      	  src/connection-editor/nm-connection-list.c
      	  src/connection-editor/page-ip4.c
      	  src/connection-editor/vpn-helpers.c
      	  src/gconf-helpers/gconf-helpers.c
      	  src/gconf-helpers/gconf-upgrade.c
      	  src/gconf-helpers/nma-gconf-connection.c
      	  src/utils/utils.c
      	  src/vpn-password-dialog.c
      	  src/wired-dialog.c
      	  src/wireless-dialog.c
      	  src/wireless-security/wireless-security.c
      		- Update connection setting accessors
      
      
      svn path=/trunk/; revision=980
      8ab77ddf
  25. 26 Oct, 2008 3 commits
    • Dan Williams's avatar
      Patch from Tambet Ingo <tambet@gmail.com> · 39d6d199
      Dan Williams authored
      2008-10-26  Dan Williams  <dcbw@redhat.com>
      
      	Patch from Tambet Ingo <tambet@gmail.com>
      
      	* src/applet-device-gsm.c
      	  src/connection-editor/nm-connection-list.c
      	  src/connection-editor/page-mobile.c
      		- Use gsm setting accessors
      
      
      svn path=/trunk/; revision=979
      39d6d199
    • Dan Williams's avatar
      Patch from Tambet Ingo <tambet@gmail.com> · 2e233f1d
      Dan Williams authored
      2008-10-26  Dan Williams  <dcbw@redhat.com>
      
      	Patch from Tambet Ingo <tambet@gmail.com>
      
      	* src/applet-device-cdma.c
      	  src/connection-editor/nm-connection-list.c
      	  src/connection-editor/page-mobile.c
      		- Use cdma setting accessors
      
      
      svn path=/trunk/; revision=978
      2e233f1d
    • Dan Williams's avatar
      Patch from Tambet Ingo <tambet@gmail.com> · b4efd289
      Dan Williams authored
      2008-10-26  Dan Williams  <dcbw@redhat.com>
      
      	Patch from Tambet Ingo <tambet@gmail.com>
      
      	* src/applet-device-cdma.c
      	  src/applet-device-gsm.c
      	  src/connection-editor/nm-connection-list.c
      		- Use setting object accessors
      
      
      svn path=/trunk/; revision=975
      b4efd289
  26. 23 Oct, 2008 1 commit
    • Dan Williams's avatar
      src/connection-editor/nm-connection-list.c - · 59e4f7a1
      Dan Williams authored
      2008-10-23  Dan Williams  <dcbw@redhat.com>
      
      	* src/connection-editor/nm-connection-list.c
      		- (create_new_connection_for_type): set initial connection scope
      
      	* src/connection-editor/nm-connection-editor.h
      		- Change the editor window from a dialog to a window to allow the
      			action area to be more fully customized; move the system settting
      			checkbox down there
      
      	* src/connection-editor/nm-connection-editor.c
      	  src/connection-editor/nm-connection-editor.h
      		- (nm_connection_editor_init): hook the system connection checkbox up
      			to PolicyKit authorizations
      		- (populate_connection_ui): set the system connection checkbox elsewhere
      		- (nm_connection_editor_set_connection): set initial value of system
      			connection checkbox based on the connection's scope
      		- (nm_connection_editor_run): fix up signal handling since the editor
      			window is no longer a dialog
      
      
      svn path=/trunk/; revision=965
      59e4f7a1
  27. 09 Sep, 2008 1 commit
    • Dan Williams's avatar
      src/connection-editor/nm-connection-list.c - (remove_connection): clean up · 4d43e2ac
      Dan Williams authored
      2008-09-09  Dan Williams  <dcbw@redhat.com>
      
      	* src/connection-editor/nm-connection-list.c
      		- (remove_connection): clean up left-over VPN secrets when removing the
      			connection
      		- (add_connection, update_connection): save VPN secrets for user-scope
      			connections
      
      	* src/connection-editor/nm-connection-editor.c
      		- (ui_to_setting, connection_editor_validate): validate and update the
      			'connection' setting just like any other setting
      		- (populate_connection_ui): hook up signals for notification of when
      			'connection' setting properties change; connection scope needs to be
      			up-to-date before any other settings are validated
      		- (nm_connection_editor_save_vpn_secrets): ask the VPN page to ask the
      			plugin to save its secrets
      
      	* src/connection-editor/page-vpn.c
      		- (ce_page_vpn_save_secrets): call VPN UI plugin's hook to save secrets
      
      
      svn path=/trunk/; revision=881
      4d43e2ac
  28. 27 Aug, 2008 1 commit
    • Dan Williams's avatar
      UUID updates. Requires NM svn 4013 or later, and VPN plugins 4018 or · f3c05a95
      Dan Williams authored
      2008-08-26  Dan Williams  <dcbw@redhat.com>
      
      	UUID updates.  Requires NM svn 4013 or later, and VPN plugins 4018 or later.
      
      	* src/applet-device-gsm.c
      	  src/applet-device-wifi.c
      	  src/applet-device-cdma.c
      	  src/applet-device-wired.c
      		- (*_new_auto_connection): add UUID
      
      	* src/gconf-helpers/gconf-upgrade.c
      	  src/gconf-helpers/gconf-upgrade.h
      		- (nm_gconf_read_0_6_wireless_connection,
      		   nm_gconf_read_0_6_vpn_connection): add UUID
      		- (nm_gconf_migrate_0_7_vpn_connections,
      		   nm_gconf_migrate_0_7_connection_names): remove; anybody using an NM
      			this old should be shot
      		- (try_convert_leap, copy_keyring_to_8021x,
      		   nm_gconf_migrate_0_7_wireless_security): UUIDs all around
      		- (nm_gconf_migrate_0_7_connection_uuid): add UUIDs to connections
      		- (nm_gconf_migrate_0_7_keyring_items): migrate keyring items from
      			'connection-name' or 'connection-id' to 'connection-uuid'
      
      	* src/gconf-helpers/nma-gconf-connection.c
      		- (get_id, constructor, dispose, finalize, get_secrets, update,
      		   nma_gconf_connection_class_init, nma_gconf_connection_save): remove
      			id-related stuff
      
      	* src/gconf-helpers/gconf-helpers.c
      	  src/gconf-helpers/gconf-helpers.h
      		- (nm_gconf_get_all_connections): add UUIDs to all connections, and
      			remove obsolete migration operations
      		- (nm_gconf_add_keyring_item, nm_gconf_write_connection,
      		   nm_gconf_get_keyring_items): remove 'id' argument since the
      			connection now provides the UUID
      
      	* src/wireless-security/eap-method-leap.c
      	  src/wireless-security/wireless-security.c
      	  src/wireless-security/ws-dynamic-wep.c
      	  src/wireless-security/eap-method-peap.c
      	  src/wireless-security/eap-method-ttls.c
      	  src/wireless-security/ws-leap.c
      	  src/wireless-security/ws-wep-key.c
      	  src/wireless-security/ws-wpa-psk.c
      	  src/wireless-security/eap-method-simple.c
      	  src/wireless-security/ws-wpa-eap.c
      	  src/wireless-security/eap-method-tls.c
      	  src/wireless-dialog.c
      	  src/connection-editor/page-wireless-security.c
      	  src/connection-editor/page-mobile.c
      	  src/connection-editor/page-wired-security.c
      	  src/connection-editor/page-dsl.c
      	  src/wired-dialog.c
      		- Use UUIDs from the connection, not a separate 'id'
      
      	* src/connection-editor/nm-connection-list.c
      		- (create_new_connection_for_type, import_success_cb): add UUIDs for
      			newly created or imported connections
      
      	* src/vpn-password-dialog.c
      		- (nma_vpn_request_password): pass 'uuid' to auth dialog, not 'id'
      
      
      svn path=/trunk/; revision=867
      f3c05a95
  29. 11 Aug, 2008 1 commit
    • Dan Williams's avatar
      Update to match NM svn3924 vpn setting changes (consolidated vpn and · 4ac2442d
      Dan Williams authored
      2008-08-11  Dan Williams  <dcbw@redhat.com>
      
      	Update to match NM svn3924 vpn setting changes (consolidated vpn and
      	vpn-properties settings; vpn-specific data now a hash of string:string
      	instead of string:variant); convert old GConf entries to new format
      
      
      svn path=/trunk/; revision=835
      4ac2442d
  30. 27 Jul, 2008 1 commit
    • Dan Williams's avatar
      src/connection-editor/Makefile.am · bf5965a9
      Dan Williams authored
      2008-07-27  Dan Williams  <dcbw@redhat.com>
      
      	* src/connection-editor/Makefile.am
      	  src/connection-editor/nm-connection-editor-service.xml
      		- Add service definition for single-app-instance D-Bus API
      
      	* src/connection-editor/nm-connection-list.c
      	  src/connection-editor/nm-connection-list.h
      		- (add_connection_tab): keep connection type list around for later
      		- (add_connection_tabs): don't free connection type lists since they
      			are now kept around by add_connection_tab()
      		- (nm_connection_list_set_type): new function; given a connection type
      			select that type's tab in the connection list and bring the
      			connection list window to the front
      
      	* src/connection-editor/main.c
      		- Implement a single-app-instance object that exports a D-Bus API to
      			accept the same args that the connection editor does on the command
      			line
      		- (main, try_existing_instance): if a connection editor is already open
      			in the current session, just send the command-line arguments to that
      			existing editor over D-Bus instead of spawning a second editor
      
      
      svn path=/trunk/; revision=801
      bf5965a9
  31. 17 Jul, 2008 1 commit
    • Tambet Ingo's avatar
      Fix connection editor's wireless security handling. · 16427033
      Tambet Ingo authored
      2008-07-17  Tambet Ingo  <tambet@gmail.com>
      
      	Fix connection editor's wireless security handling.
      
      	* src/gconf-helpers/gconf-helpers.c (nm_gconf_connection_duplicate):
      	Implement. Just using nm_connection_duplicate() does not add the applet
      	specific object data.
      
      	* src/connection-editor/nm-connection-list.c (do_edit): When duplicating the
      	connection, use a helper function to get all the associated data as well.
      
      	* src/connection-editor/nm-connection-editor.c (connection_editor_validate):
      	Add some debug output for now to make it easier to see which page fails.
      
      svn path=/trunk/; revision=792
      16427033
  32. 02 Jul, 2008 1 commit
    • Tambet Ingo's avatar
      Patch from André Lemos <alemos@criticalsoftware.com> · 8b5c2283
      Tambet Ingo authored
      2008-07-02  Tambet Ingo  <tambet@gmail.com>
      
      	Patch from André Lemos <alemos@criticalsoftware.com>
      
      	* src/gconf-helpers/nma-gconf-settings.c
      	(nma_gconf_settings_add_connection):
      	* src/connection-editor/nm-connection-list.c (show_error_dialog):
      	* src/applet.c (applet_settings_new_secrets_requested_cb):
      	* src/applet-device-wired.c (get_pppoe_secrets_cb)
      	(get_8021x_secrets_cb):
      	* src/applet-device-wifi.c (get_secrets_dialog_response_cb):
      	* src/applet-device-gsm.c (get_gsm_secrets_cb): Always send a format
      	string to vararg message functions.
      
      svn path=/trunk/; revision=774
      8b5c2283