Commit 2ebefe25 authored by nightsky30's avatar nightsky30 Committed by Thomas Haller

c-e: fixes transparent border on ipv4/ipv6 route and new connection dialogs

This fixes a transparent border issue that appears to have been introduced
with commit 5fbf69f2:

With commit 5fbf69f2, ipv4/ipv6 route and new connection dialog boxes
were modified to use margin properties due to the deprecation of border
properties. Margin properties were placed under GtkDialog instead of the
immediate child GtkBox. Margin properties were also placed under another
GtkBox further below. This seemed to have the effect of margins not
being recognized on the top or left of the dialogs, but also creating a
transparent margin on the bottom and right. This was visible on the
ipv4/ipv6 route dialogs, but somehow also affected the new connection
dialog despite that file not having margin properties listed under
GtkDialog. Fixing properties in ce-ip4-routes.ui and ce-ip6-routes.ui
also fixed the new connection dialog.

Fixes: 5fbf69f2 ('glade: get rid of GtkContainer.border-width')
parent 212b5acc
......@@ -6,10 +6,6 @@
<property name="width_request">450</property>
<property name="height_request">250</property>
<property name="can_focus">False</property>
<property name="margin_start">5</property>
<property name="margin_end">5</property>
<property name="margin_top">5</property>
<property name="margin_bottom">5</property>
<property name="modal">True</property>
<property name="window_position">center-on-parent</property>
<property name="icon_name">stock-peferences</property>
......@@ -19,6 +15,10 @@
<property name="visible">True</property>
<property name="can_focus">False</property>
<property name="orientation">vertical</property>
<property name="margin_start">5</property>
<property name="margin_end">5</property>
<property name="margin_top">5</property>
<property name="margin_bottom">5</property>
<property name="spacing">2</property>
<child internal-child="action_area">
<object class="GtkButtonBox" id="dialog-action_area1">
......@@ -66,10 +66,6 @@
<property name="orientation">vertical</property>
<property name="visible">True</property>
<property name="can_focus">False</property>
<property name="margin_start">5</property>
<property name="margin_end">5</property>
<property name="margin_top">5</property>
<property name="margin_bottom">5</property>
<property name="spacing">6</property>
<child>
<object class="GtkBox" id="hbox5">
......
......@@ -6,10 +6,6 @@
<property name="width_request">450</property>
<property name="height_request">250</property>
<property name="can_focus">False</property>
<property name="margin_start">5</property>
<property name="margin_end">5</property>
<property name="margin_top">5</property>
<property name="margin_bottom">5</property>
<property name="modal">True</property>
<property name="window_position">center-on-parent</property>
<property name="icon_name">stock-peferences</property>
......@@ -19,6 +15,10 @@
<property name="visible">True</property>
<property name="can_focus">False</property>
<property name="orientation">vertical</property>
<property name="margin_start">5</property>
<property name="margin_end">5</property>
<property name="margin_top">5</property>
<property name="margin_bottom">5</property>
<property name="spacing">2</property>
<child internal-child="action_area">
<object class="GtkButtonBox" id="dialog-action_area1">
......@@ -66,10 +66,6 @@
<property name="orientation">vertical</property>
<property name="visible">True</property>
<property name="can_focus">False</property>
<property name="margin_start">5</property>
<property name="margin_end">5</property>
<property name="margin_top">5</property>
<property name="margin_bottom">5</property>
<property name="spacing">6</property>
<child>
<object class="GtkBox" id="hbox5">
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment