Documentation+implementation bugs
issue no.1
void (* move_copy_items) (NautilusCanvasContainer *container,
const GList *item_uris,
const char *target_uri,
GdkDragAction action,
int x,
int y);
while implementation actually has only 3 parameters (no coordinates):
signals[MOVE_COPY_ITEMS]
= g_signal_new ("move-copy-items",
G_TYPE_FROM_CLASS (class),
G_SIGNAL_RUN_LAST,
G_STRUCT_OFFSET (NautilusCanvasContainerClass,
move_copy_items),
NULL, NULL,
g_cclosure_marshal_generic,
G_TYPE_NONE, 3,
G_TYPE_POINTER,
G_TYPE_POINTER,
GDK_TYPE_DRAG_ACTION);
issue no..2
the header nautilus-canvas-container.h states:
void (* icon_removed) (NautilusCanvasContainer *container,
NautilusCanvasIconData *data);
while implementation actually uses the icon itself, instead of data as described.
icon_destroy (container, icon);
schedule_redo_layout (container);
g_signal_emit (container, signals[ICON_REMOVED], 0, icon);
Yet another weird thing here. The signal is being emitted after icon destruction, that is data that are being transmitted are no longer valid.
and BTW, still no any reaction on #787 (closed), is this particular case of memory leak bug not [such an] important?