1. 24 Sep, 2020 1 commit
  2. 22 Sep, 2020 2 commits
  3. 21 Sep, 2020 3 commits
    • António Fernandes's avatar
      file-utilities: Don't block main thread to restore from trash · 553e59f6
      António Fernandes authored
      The sync variants of file operations have been introduced for use in
      integration tests. The async operations have been suffixed _async().
      
      However, likely by mistake, in the restore from trash operation, the
      call has been appended _sync rather than _async. [1]
      
      This blocks the main thread until the operation task finishes, causing
      a dead lock when the operation thread needs the main thread to show a
      conflict dialog. This happens when restoring a file from trash if a new
      file with the same name already exists in the original location.
      
      Fixes #790
      
      [1] commit ab31018c
      553e59f6
    • Ondrej Holy's avatar
      file-operation: Prevent recursion to speed up emptying trash · 36e505c1
      Ondrej Holy authored
      Emptying trash within Nautilus is a bit slow in comparison to plain
      `rm -r`. On my system, it took about 3 min to empty the trash with a
      folder containing 600 000 files, which is not ideal as `rm -r` call
      took just a few seconds. I found that `g_file_delete` is implemented
      differently for locations provided by the trash backend. The trash
      backend prevents modifications of trashed content thus the delete
      operation is allowed only for the top-level files and folders. So it
      is not necessary to recursive delete all files as the permission
      denied error is returned anyway. Let's call `g_file_delete` only for
      top-level items, which reduces the time necessary for emptying trash
      from minutes to seconds...
      
      Fixes: #1589
      36e505c1
    • Jwtiyar Neriman's avatar
      Update Central Kurdish translation · 9f344bfc
      Jwtiyar Neriman authored
      9f344bfc
  4. 19 Sep, 2020 2 commits
    • António Fernandes's avatar
      4ef15187
    • António Fernandes's avatar
      starred-directory: Actually implement ::force_reload · f2237185
      António Fernandes authored
      The code created to handle the NautilusTagManager::files-changed signal
      has been reused for implemeting the NautilusDirectory::force_reload
      virtual function.
      
      This is conceptually wrong, because the update_files function doesn't
      actually reload the file list. Also, as a side effect, it causes gone
      files to reappear as "ghost files" (files without any attributes).
      
      Instead, let's follow what NautilusSearchDirectory does: clear the
      current file list after unmonitoring the files, and set the file list
      anew the same way it's done on ::init.
      
      Fixes:
      #162
      #167
      f2237185
  5. 18 Sep, 2020 2 commits
  6. 16 Sep, 2020 1 commit
  7. 14 Sep, 2020 1 commit
  8. 12 Sep, 2020 1 commit
  9. 11 Sep, 2020 1 commit
  10. 10 Sep, 2020 1 commit
  11. 08 Sep, 2020 1 commit
    • António Fernandes's avatar
      files-view: Add Extract/Compress menu section · 0b65c9d2
      António Fernandes authored
      "Extract Here", "Extract To…" and "Compress…" menu items are contained
      by the extensions menu section, despite not being an extension.
      
      This has worked fine until the extensions menu handling has been
      reworked in commit bd81bd89
      
      This commit introduced a regressions which causes the Extract/Compress
      items to disappear if actual extension menu items are added.
      
      Since it was already conceptually wrong to have them in this section,
      let's move these items into their own menu section to fix the bug.
      
      Fixes #1472
      0b65c9d2
  12. 07 Sep, 2020 2 commits
    • Ondrej Holy's avatar
      ci: Hardcode image version for style check job · 831203e9
      Ondrej Holy authored
      The style check job currently fails as uncrustify from rawhide obviously
      changed its behavior. It tries to change function pointer the following
      way:
      
      - gboolean (*each_function)(NautilusCanvasIcon *, gpointer),
      + gboolean ( *each_function )(NautilusCanvasIcon *, gpointer),
      
      I don't think this is right, but don't know how to fix that ellegantly.
      Note that this is because of "sp_before_ptr_star = false". Let's
      hardcode the previous image varsion to avoid this change for now.
      831203e9
    • Ondrej Holy's avatar
      ci: Add missing git dependency · a9d25626
      Ondrej Holy authored
      The style check job currently fails due to the missing git command, which
      disappeared after the image update. Let's add the git command explicitely.
      a9d25626
  13. 06 Sep, 2020 2 commits
  14. 05 Sep, 2020 1 commit
  15. 04 Sep, 2020 3 commits
  16. 02 Sep, 2020 13 commits
    • Sam Thursfield's avatar
      Import starred files data from Tracker 2.x · 7cf268ab
      Sam Thursfield authored
      Starred files data is now migrated from the Tracker 2.x database if
      found. This depends on the `tracker3` CLI tool, which should be
      present anywhere that we find libtracker-sparql 3.0. The --2to3
      export functionality was added in
      tracker!308
      
      If/when the migration completes successfully, a stamp file named
      `~/.local/share/nautilus/tracker2-migration-complete` is created.
      7cf268ab
    • Sam Thursfield's avatar
      Limit starred files to within user's home directory · bd30a21a
      Sam Thursfield authored
      Previously starred files were limited to directories indexed by Tracker.
      Since the 'Port to Tracker 3' commit this is no longer the case.
      However, to avoid unbounded growth in the starred files database we
      want to prevent starring of network locations and removable devices
      for now as these entries might go stale and we don't have any way
      to clean them up.
      bd30a21a
    • Sam Thursfield's avatar
      tag-manager: Track files rather than contents · 29105fc9
      Sam Thursfield authored
      Nautilus is a file manager, so we should star files.
      
      Previously we starred the content resources extracted by Tracker Miner
      FS, instead. This had the advantage that the stars would follow file
      renames. It had the downside of being more complex and limited in
      which files can be starred. In Tracker 2.x, the feature only worked
      in folders indexed by Tracker Miner FS. With Tracker 3.x, it was
      additionally limited to files where Tracker had extracted metadata
      -- mainly just documents and media files.
      
      This commit takes the simpler approach of storing the star against
      the file URL. All files can now be starred, and stars will no longer
      persist when a file is moved or renamed.
      
      Fixes #160
      29105fc9
    • Sam Thursfield's avatar
      Use Tracker Miners inside Flatpak when not available on the host · f9c79fce
      Sam Thursfield authored
      This means the Nautilus flatpak will be able to use Tracker on systems
      which don't have Tracker 3 available on the host. It comes at a cost of
      increased resource consumption inside the Flatpak due running an extra
      indexer process there.
      f9c79fce
    • Sam Thursfield's avatar
      flatpak: Update for Tracker Miners 3 · 034a6a33
      Sam Thursfield authored
      Tracker 3 is provided in the Flatpak SDK, see
      gnome-build-meta!630.
      
      We still build tracker-miners inside the Flatpak bundle, so that the
      org.freedesktop.Tracker3.Miner.Files settings schema is available, and
      so that the tests that depend on Tracker can pass as part of the CI
      build.
      
      Access to the host's miners is controlled by the new
      org.freedesktop.Tracker.portal process provided in Tracker 3.
      034a6a33
    • Sam Thursfield's avatar
      search: Remove special characters from FTS searches · e3031953
      Sam Thursfield authored
      This fixes warnings that would appear of this form:
      
          ** (org.gnome.Nautilus:662563): WARNING **: 17:11:13.712: Provider NautilusSearchEngineTracker failed with error fts5: syntax error near "."
      e3031953
    • Sam Thursfield's avatar
      Port to Tracker 3 · 7712c2c7
      Sam Thursfield authored
      Mostly the port is straightforward, we connect to tracker-miner-fs
      explicitly over D-Bus instead of the centralized tracker-store daemon
      we connected to previously.
      
      The search-engine-tracker test is now isolated from the user's real
      Tracker index using the `tracker-sandbox` script provided by Tracker,
      and it lets tracker-miner-fs index the test file rather than trying
      to synthesize the expected database contents.
      
      There are more changes in nautilus-tag-manager.c.  Until now, starred
      file information was stored in the tracker-miner-fs database. This has
      some downsides, firstly the data is deleted if someone runs `tracker
      reset --hard`, secondly it isn't possible to do this from inside a
      Flatpak sandbox with Tracker 3.0.  because the
      
      This commit changes the NautilusTagManager to set up a private
      database inside XDG_DATA_HOME/nautilus/tags. This stores the starred
      file information. The database is managed with Tracker, which allows us
      to continue using the rename-tracking that tracker-miner-fs provides.
      The same limitations apply as before that only files in indexed
      locations can be starred.
      7712c2c7
    • Sam Thursfield's avatar
      Use STRSTARTS in preference to tracker:uri-is-descendant() function · ae2669dc
      Sam Thursfield authored
      In current versions of Tracker, using STRSTARTS to compare URIs is
      faster than using Tracker's custom tracker:uri-is-descendant() function.
      The former allows SQLite to use an index while the latter does not.
      ae2669dc
    • Sam Thursfield's avatar
      Add NAUTILUS_DEBUG=TagManager flag · 793d8da8
      Sam Thursfield authored
      793d8da8
    • Sam Thursfield's avatar
      tests: Make search tests return error codes on failure · 1321a349
      Sam Thursfield authored
      Previously the tests could appear to succeed even if the search
      didn't work as expected.
      1321a349
    • Sam Thursfield's avatar
      build: Set NAUTILUS_DATADIR correctly · 452c25e3
      Sam Thursfield authored
      452c25e3
    • Sam Thursfield's avatar
      tag-manager: Fix checks for cancellation · 102efff0
      Sam Thursfield authored
      Only process query results if there's no error.
      
      Fix some checks so that we report errors except for
      G_IO_ERROR_CANCELLED, which happens normally as part of
      nautilus_application_finalize().
      102efff0
    • Dušan Kazik's avatar
      Update Slovak translation · ccd11822
      Dušan Kazik authored
      ccd11822
  17. 30 Aug, 2020 2 commits
  18. 29 Aug, 2020 1 commit