1. 13 May, 2015 4 commits
  2. 07 May, 2015 1 commit
  3. 05 May, 2015 1 commit
  4. 30 Apr, 2015 1 commit
    • Georges Basile Stavracas Neto's avatar
      canvas-view: change action states only when the value differs · 0ff112a5
      Georges Basile Stavracas Neto authored
      Commit bb884cb6 introduced the faulty behavior where
      NautilusCanvasView keeps scrolling back to the first
      selected item when selecting multiple items.
      
      Backtracing it, it was found out that the icon view
      was changing the "sort" state when selecting items,
      even if nothing actually changed, which triggers the
      sort action changed handler. The handler by itself
      was doing the right job by revealing the selection,
      and the issue was caused by calling it unnecessarily.
      
      Since we may have to update the action states for other
      reasons besidse real sort change, we must change the
      action state only when it makes sense, i.e. only when
      the states really change.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=748265
      0ff112a5
  5. 29 Apr, 2015 1 commit
  6. 24 Apr, 2015 1 commit
  7. 23 Apr, 2015 1 commit
  8. 22 Apr, 2015 16 commits
  9. 20 Apr, 2015 1 commit
  10. 17 Apr, 2015 1 commit
  11. 15 Apr, 2015 2 commits
  12. 09 Apr, 2015 3 commits
    • Carlos Soriano Sánchez's avatar
      application: handle command line only in main instance · aedc98cf
      Carlos Soriano Sánchez authored
      So, this came trying to fix a little issue.
      Christian Hegert pointed to me that nautilus -s was not working
      all the times. It was working only when the application was already
      running.
      
      That's because there was a race condition in the dbus.
      We were starting nautilus, owning the FileManager1 dbus path
      and inside application_select we were calling the dbus method
      to select the items. Then that instance died and the dbus path
      became unown by Nautilus again, but we were in the middle of a call
      to the dbus method. So that created a race somewhere and Nautilus
      was not responding to that call.
      When there was an instance already alive this was working fine since the
      dbus path was owned by Nautilus already.
      
      So one solution was to instead of calling nautilus by a dbus call for
      that use case, directly do the need operations there. But then it was
      happening the opposite, it was working for the first instance, since the
      startup is called an everything is in place, but when created a second
      instance with the -s option it was crashing because the second instance
      was not initialized and nothing was set up for it.
      
      So finally, the solution I though is better for this is always handle
      the command line options on the main instance.
      A way to do this is connecting to the command-line signal of
      GApplication and drop handle_local_options and application_open.
      
      Doing this actually make things easier for everything, like the problem
      we had some months ago about nautilus creating one window when icons on
      desktop was activated. That was happening because depending on the
      return value on handle_local_options it called the activate signal or
      not.
      Now instead we manage everything as we want in the handler of the
      command-line signal, so we don't have to worry about those things
      anymore and the code becomes clearer and simpler.
      aedc98cf
    • Carlos Soriano Sánchez's avatar
      nautilus-application: don't set startup_id · 396022b3
      Carlos Soriano Sánchez authored
      It's causing some issues when setting it to NULL when the
      functions is called inside nautilus and it doesn't know the
      startup_id.
      
      Focus management is working as expected in my testings, and
      docs recommend to not use it... so remove it.
      396022b3
    • Michael Catanzaro's avatar
      Tweak punctuation in delete-shortcut-changed.ui · 3fa83fae
      Michael Catanzaro authored
      Hyphens don't work this way; use an em dash instead.
      
      (We have no agreement on whether to use spaced or unspaced em dash.
      I pick unspaced, because spaced requires a lot of space.)
      3fa83fae
  13. 08 Apr, 2015 3 commits
  14. 23 Mar, 2015 1 commit
  15. 16 Mar, 2015 1 commit
  16. 11 Mar, 2015 2 commits