1. 29 Aug, 2016 2 commits
    • Carlos Soriano Sánchez's avatar
      general: run uncrustify · 52d96054
      Carlos Soriano Sánchez authored
      And make the style of Nautilus the same for all files.
      Hopefully we can fix all the style issues we can find in the next days,
      so expect a little of movement on this.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=770564
      52d96054
    • Carlos Soriano Sánchez's avatar
      general: add uncrustify script · 4cafccd8
      Carlos Soriano Sánchez authored
      The current style of nautilus is rather poor and mixes at least 3
      different code styles.
      
      Specific issues that affect the most common contributors to Nautilus
      performance are:
      - tabs for multiline alignment.
      - mix of tabs and spaces.
      - errors on no braced one liners conditionals.
      - errors on non braced case statements with variable declarations.
      
      So I would say requirements for the style is to address the previous
      issues and also be a well known style. I don't want new contributors
      to see a new style completely different from C books authors.
      
      So far, I found Allman (aka BSD) style which seems the choice of most C
      books authors as far as I can see on internet, and it address the
      previous mentioned issues.
      
      Since uncrustify doesn't support the aligment of parameters we do for
      multiple stars "**", we also added a script made by Sebastian Wilmet
      to align those.
      
      As a matter of practicity I'm going to convert all Nautilus style to
      this one, and if the next person who contributes most on Nautilus has
      a different choice, please feel free to change it to whatever makes your
      performance and your contributors performance the best.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=770564
      4cafccd8
  2. 10 Jul, 2016 2 commits
    • Emmanuele Bassi's avatar
      tests: Fix build failure caused by C99 use · 9b674dc6
      Emmanuele Bassi authored
      Build failure in Continuous:
      
      ../../test/test-file-utilities-get-common-filename-prefix.c: In function
      'test_many_strings':
      ../../test/test-file-utilities-get-common-filename-prefix.c:366:9:
      error: 'for' loop initial declarations are only allowed in C99 or C11
      mode
               for (int i = 0; i < 500; ++i) {
      9b674dc6
    • Neil Herald's avatar
      files-view: change "New Folder /w Selection" to offer a name · ca0e00b6
      Neil Herald authored
      New Folder with Selection currently doesn't offer a folder name. It
      would be better if it suggested a folder name based on the files that
      are selected.
      
      With this change, it now looks for a common filename prefix of the
      selected files, and pre-populates the folder name entry with that. If no
      common prefix is found that is greater than 3 characters long, the
      folder name entry will be left blank.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=747907
      ca0e00b6
  3. 25 Apr, 2016 1 commit
    • Carlos Soriano Sánchez's avatar
      general: merge libnautilus-private to src · 7e24f1b2
      Carlos Soriano Sánchez authored
      And fix make distcheck.
      
      Although libnautilus-private seem self contained, it was actually
      depending on the files on src/ for dnd.
      Not only that, but files in libnautilus-private also were depending on
      dnd files, which you can guess it's wrong.
      
      Before the desktop split, this was working because the files were
      distributed, but now was a problem since we reestructured the code, and
      now nautilus being a library make distcheck stop working.
      
      First solution was try to fix this inter dependency of files, but at
      some point I realized that there was no real point on splitting some of
      those files, because for example, is perfectly fine for dnd to need to
      access the window functions, and it's perfectly fine for the widgets
      in the private library to need to access to all dnd functions.
      
      So seems to me the private library of nautilus is somehow an artificial
      split, which provides more problems than solutions.
      
      We needed libnautilus-private to have a private library that we could
      isolate from extensions, but I don't think it worth given the problems
      it provides, and also, this not so good logical split.
      Right now, since with the desktop split we created a libnautilus to be
      used by the desktop part of nautilus, extensions have access to all
      the API of nautilus. We will think in future how this can be handled if
      we want.
      
      So for now, merge the libnautilus-private into src, and let's rethink
      a better logic to split the code and the private parts of nautilus than
      what we had.
      
      Thanks a lot to Rafael Fonseca for helping in get this done.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=765543
      7e24f1b2
  4. 22 Jul, 2015 1 commit
    • Carlos Soriano Sánchez's avatar
      search: done loading signal only if not restarting engine · ff6ccbaf
      Carlos Soriano Sánchez authored
      It was working as:
      - Search directory starts a new search
      - Search engine starts all search providers, each one in its
      own thread.
      - User changes query
      - Search engine stops all search providers
      - Searchs providers, since they are in its own thread, cancel
      in a unknown time.
      - Search directory starts a new search, even before all providers
      are finished.
      - Search engine is marked as need to restart.
      - Search providers finished.
      - Search engine emits finished signal, since all search providers
      now are stopped.
      - Clients doesn't have a way to know if the engine
      actually finished searching the current search, or the previous
      search that the client asked to stop. That might confuse clients
      if they ask for results.
      - Search engine restart the search providers without noticing the
      client, that thinks that the latest search it started was finished
      already.
      
      So to fix this confusion, only report that the engine actually finished
      if the engine is not going to restart the search providers.
      In this way a client can start a batch of consecutive searches without
      the risk of getting search finished signals from previous searches.
      Clients now will always get the search-finished signal of the
      latest search they started.
      ff6ccbaf
  5. 16 Jul, 2015 1 commit
    • Carlos Soriano Sánchez's avatar
      operations: implement new design · 192d2e2f
      Carlos Soriano Sánchez authored
      Now operations reside in the toolbar, in form of a button with
      a popover. In this way we avoid to have a nautilus window hanging
      around for it.
      When no nautilus window is open, the persistence handlers of nautilus
      are enough. This use a notification if the server supports it or
      a systray icon in case it doesn't.
      192d2e2f
  6. 23 May, 2015 1 commit
  7. 17 Feb, 2014 1 commit
  8. 31 Jan, 2014 1 commit
  9. 18 Jun, 2013 1 commit
    • Andrés G. Aragoneses's avatar
      build: stop using INCLUDES, deprecated by automake 1.7 · 9473dd41
      Andrés G. Aragoneses authored
      We already depend on automake 1.9, so using the replacement of
      INCLUDES (AM_CPPFLAGS) won't hurt, especially now that it is
      a warning shown by default since automake 1.13, as evidenced by
      this build log of mine:
      
      Makefile.am: installing './INSTALL'
      eel/Makefile.am:5: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
      eel/Makefile.am: installing './depcomp'
      parallel-tests: installing './test-driver'
      libnautilus-extension/Makefile.am:7: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
      libnautilus-private/Makefile.am:5: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
      nautilus-sendto-extension/Makefile.am:3: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
      src/Makefile.am:13: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
      test/Makefile.am:3: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
      Signed-off-by: Alexander Larsson's avatarAlexander Larsson <alexl@redhat.com>
      9473dd41
  10. 18 Oct, 2012 1 commit
  11. 15 Oct, 2012 1 commit
  12. 17 Sep, 2012 1 commit
  13. 08 Aug, 2012 1 commit
  14. 18 Jul, 2012 1 commit
  15. 21 Jan, 2012 1 commit
  16. 18 Oct, 2011 2 commits
  17. 04 Feb, 2011 1 commit
  18. 30 Oct, 2010 1 commit
  19. 09 Oct, 2010 1 commit
  20. 19 Aug, 2010 2 commits
  21. 25 Jul, 2010 3 commits
  22. 23 Jul, 2010 2 commits
  23. 11 Jun, 2010 1 commit
  24. 20 May, 2010 1 commit
  25. 23 Jun, 2009 1 commit
  26. 21 Apr, 2009 2 commits
  27. 24 Feb, 2009 1 commit
    • Cosimo Cecchi's avatar
      remove obsolete test. · 27e3e640
      Cosimo Cecchi authored
      2009-02-24  Cosimo Cecchi  <cosimoc@gnome.org>
      
      	* test/test-eel-widgets.c: remove obsolete test.
      
      svn path=/trunk/; revision=15016
      27e3e640
  28. 21 Feb, 2009 1 commit
  29. 15 Dec, 2008 1 commit
    • Alexander Larsson's avatar
      Added. Added. Added. Added. Added. Added. Added. Import eel tests · 77deda90
      Alexander Larsson authored
      2008-12-15  Alexander Larsson  <alexl@redhat.com>
      
              * test/Makefile.am:
              * test/test-eel-background.c: Added.
              * test/test-eel-editable-label.c: Added.
              * test/test-eel-image-scrolled.c: Added.
              * test/test-eel-image-table.c: Added.
              * test/test-eel-labeled-image.c: Added.
              * test/test-eel-pixbuf-scale.c: Added.
              * test/test-eel-widgets.c: Added.
              * test/test.h:
      	Import eel tests
      
      
      svn path=/trunk/; revision=14816
      77deda90
  30. 07 Oct, 2008 1 commit
    • Alexander Larsson's avatar
      Require trunk eel. Drop libgnome* and librsvg deps. · cf740f7f
      Alexander Larsson authored
      2008-10-07  Alexander Larsson  <alexl@redhat.com>
      
              * configure.in:
      	Require trunk eel.
      	Drop libgnome* and librsvg deps.
      	
              * libnautilus-private/nautilus-customization-data.c:
              (nautilus_customization_data_get_next_element_for_display):
              * libnautilus-private/nautilus-icon-canvas-item.c:
              (real_map_pixbuf):
              * src/nautilus-property-browser.c:
              (make_drag_image):
      	Use librsvg indirectly via gdk-pixbuf loader.
      	
              * libnautilus-private/nautilus-thumbnails.c:
      	Use thumbnail factory from gnome-desktop.
      	
              * libnautilus-private/nautilus-undo.c:
              (nautilus_undo_get_undo_manager):
      	Kill references to gnome canvas.
      	
              * libnautilus-private/nautilus-vfs-file.c:
      	Don't include removed eel-mount-operation.h header
      
              * src/file-manager/fm-properties-window.c:
              (update_preview_callback):
      	Use thumbnail utils from gnome-desktop.
      
              * src/Makefile.am:
              * src/nautilus-bookmarks-window.c:
              * src/nautilus-bookmarks-window.glade: Removed.
              * src/nautilus-bookmarks-window.ui: Added.
              * src/nautilus-file-management-properties.c:
              * src/nautilus-file-management-properties.glade: Removed.
              * src/nautilus-file-management-properties.ui: Added.
      	Switch from libglade to gtkbuilder.
      
              * libnautilus-private/nautilus-file-operations.c:
              * src/nautilus-emblem-sidebar.c:
              * src/nautilus-navigation-window.h:
              * test/test-nautilus-wrap-table.c:
              * test/test.c:
              * test/test.h:
      	Drop old unused libgnome/librsvg includes
      
      
      
      svn path=/trunk/; revision=14704
      cf740f7f
  31. 06 Oct, 2008 1 commit
    • Cosimo Cecchi's avatar
      Use gtk_show_uri instead of gnome_help · 0dcbcb73
      Cosimo Cecchi authored
      2008-10-06  Cosimo Cecchi  <cosimoc@gnome.org>
      
              * src/nautilus-window-menus.c:
              (action_nautilus_manual_callback):
      	Use gtk_show_uri instead of gnome_help
      	
              * src/nautilus-file-management-properties-main.c:
              * src/nautilus-connect-server-dialog-main.c:
              * src/nautilus-autorun-software.c:
              * test/test-nautilus-mime-actions-set.c:
              * test/test-nautilus-mime-actions.c:
      	Use GOption instead of GnomeProgram
      	
              * src/nautilus-property-browser.c:
      	Use GtkColorButton instead of GnomeColorPicker
      	Use gtk_show_uri instead of gnome_help
      
      
      svn path=/trunk/; revision=14683
      0dcbcb73
  32. 01 Sep, 2008 1 commit
    • Christian Neumair's avatar
      Strip extensions using eel_filename_strip_extension(). Fixes #309510. · 974ad6ae
      Christian Neumair authored
      2008-09-01  Christian Neumair  <cneumair@gnome.org>
      
      	* libnautilus-private/nautilus-customization-data.c
      	(format_name_for_display), (load_name_map_hash_table):
      	* src/file-manager/fm-directory-view.c
      	(add_template_to_templates_menus):
      	* src/nautilus-property-browser.c
      	(nautilus_property_browser_drag_data_get),
      	(make_properties_from_directories):
      	* test/test-nautilus-wrap-table.c (main):
      	Strip extensions using eel_filename_strip_extension(). Fixes #309510.
      	Thanks to Paolo Borelli <pborelli@katamail.com> and Jared Moore
      	<jaredm@gmx.com>.
      
      svn path=/trunk/; revision=14555
      974ad6ae