1. 09 Feb, 2018 2 commits
    • Ernestas Kulik's avatar
      general: refactor extension library · 7e2605c6
      Ernestas Kulik authored
      The changes include:
      
        * adding a single-include header and deprecating
          nautilus-extension-types.h and direct inclusions of individual
          headers;
      
        * type definition simplifications - this causes some breakages in
          nautilus-file, because NautilusFile used to be typedefed to
          NautilusFileInfo, and that is no longer possible, so the interface
          implementation was moved to static functions and the public
          NautilusFile API provides thin wrappers for them to maintain
          compatibility;
      
        * documentation cleanups and reorganization;
      
        * general build rule and code cleanups: mostly g_auto* sprinkled
          around and style changes (sorry)
      7e2605c6
    • Ernestas Kulik's avatar
      nautilus-extension: use Meson to generate pkgconfig file · 2128efcc
      Ernestas Kulik authored
      Currently, the pkgconfig file for nautilus-extension is generated by
      substituting variables in a template file. That is prone to mistakes and
      requires manual tracking of dependencies. Using the pkgconfig module
      from Meson helps automate much of the process.
      2128efcc
  2. 08 Feb, 2018 3 commits
  3. 06 Feb, 2018 4 commits
  4. 04 Feb, 2018 3 commits
  5. 03 Feb, 2018 1 commit
  6. 01 Feb, 2018 1 commit
  7. 30 Jan, 2018 12 commits
    • Jeremy Bicha's avatar
      build: Install appstream metadata to non-deprecated location · dbb8bd60
      Jeremy Bicha authored
      This was already done in 5d75a4a5
      but accidentally reverted in 983892a6
      dbb8bd60
    • Carlos Soriano Sánchez's avatar
      Release: Prepare for 3.27.4 · 4cece761
      Carlos Soriano Sánchez authored
      4cece761
    • Carlos Soriano Sánchez's avatar
      build: Set graphical tests off by default · c2da3680
      Carlos Soriano Sánchez authored
      When nautilus is automatically tests we cannot assume there is a
      display, if we do and we run inside a displayless scenario nautilus
      cannot run the application and the tests fail.
      
      Graphical tests were enabled by default, but this breaks most common
      automatic tests scenarios, so let's disable it by default and let the
      developers enable if required.
      
      We should focus more in unit testing and integration tests without an
      actual display, and let tools like OpenQA, etc. to handle actual display
      testing. Alternatively we can use Xvfb to simulate a graphical env.
      c2da3680
    • Carlos Soriano Sánchez's avatar
      Flatpak: Remove disabling Selinux · 690d7924
      Carlos Soriano Sánchez authored
      Since now we have it off by default.
      690d7924
    • Carlos Soriano Sánchez's avatar
      build: Turn Selinux support off by default · 1f8f8313
      Carlos Soriano Sánchez authored
      We were enabling Selinux support by default, which is just to show the
      Selinux labels in the properties dialog.
      
      However, this gives problem when trying to create a release since
      Flatpak Sdk doesn't have Selinux I guess to be able to work in most
      distros.
      
      So with the purpose of having a proper default that works in different
      distributions, let set it off by default.
      1f8f8313
    • António Fernandes's avatar
      canvas-container: Drop get_selected_icons_bounding_box API · 42e86583
      António Fernandes authored
      This is not used anymore.
      
      We only need one bounding box, which is provided by the new
      nautilus_canvas_container_get_icon_bounding_box().
      
      So remove unused API. We can always revert this if we need it.
      42e86583
    • António Fernandes's avatar
      files-view: Avoid futile casting · f164cb6d
      António Fernandes authored
      We are casting (cost GdkEvent *) to (GdkEvent *)
      back and forth, all because some files-view functions
      don't take a pointer to const GdkEvent as argument.
      
      But those functions don't actually change the event,
      so, make them take a pointer to const GdkEvent instead
      and drop unnecessary casting.
      f164cb6d
    • Jan-Michael Brummer's avatar
      files-view: Open context menu on longpress · 5d89ec58
      Jan-Michael Brummer authored
      An important portion of file management functionality
      is exclusively available through context menus.
      
      Currently, when using a touchscreen, there is no way
      to open a context menu.
      
      Fix this adding a longpress gesture to popup context
      menus on canvas view and list view.
      
      Closes: #178
      5d89ec58
    • António Fernandes's avatar
      view-icon-controller: Share common code for revealing and rectangle computation · e20a05ba
      António Fernandes authored
      Make internal function for both _reveal_rectangle_for_context_menu()
      and _compute_rename_popover_pointing_to() to deduplicate the code for
      rectangle computation.
      
      Also, make internal function for both _reveal_selection() and
      _reveal_rectangle_context_menu() to deduplicate the code for revealing.
      
      Also, make internal function for both _reveal_selection() and
       _compute_rename_popover_pointing_to() to deduplicate the code for
      getting the first selected item_ui.
      e20a05ba
    • António Fernandes's avatar
      canvas-view: Share common code for rectangle computation · 08732ade
      António Fernandes authored
      Make internal function for both _reveal_rectangle_for_context_menu()
      and _compute_rename_popover_pointing_to() to avoid code duplication.
      08732ade
    • António Fernandes's avatar
      list-view: Share common code for rectangle computation · dd672624
      António Fernandes authored
      Make internal function for both _reveal_rectangle_for_context_menu()
      and _compute_rename_popover_pointing_to() to avoid code duplication.
      dd672624
    • António Fernandes's avatar
      files-view: Pop up context menu near selection · 29cf64bd
      António Fernandes authored
      Context menus pop up where the pointer is, which is at the
      selection if the pointing device is used to open the menu.
      
      However, if the <Menu> key or <Shift>+<F10> keyboard shortcut
      are used, context menus still shows up wherever the pointer is,
      which may not be near the selected item at all.
      
      Instead, when the context menu is activated from the keyboard,
      show it next to the selected item. If multiple items are selected,
      show it next to the focused item. If the focus is not on a selected
      item, show it next to the selected item which is sorted the lowest.
      In all cases, scroll as necessary to make sure the whole item is
      visible.
      
      Fixes: https://bugzilla.gnome.org/show_bug.cgi?id=102666
      29cf64bd
  8. 29 Jan, 2018 7 commits
    • António Fernandes's avatar
      files-view: Always pop up background menu in view · 489d4d09
      António Fernandes authored
      Background context menu pops up from the pointer's position, which
      is good when using a poiting device to open it.
      
      When using keyboard shortcuts to open the background context menu,
      the pointer may be outside the view, so the background context menu
      will pop up out of context.
      
      Instead, when triggered from the keyboard, pop up from the center
      of the view.
      489d4d09
    • António Fernandes's avatar
      files-view: Unify keyboard context menu logic · 72fc5a45
      António Fernandes authored
      When the user presses the <Menu> key or the <Shift>+<F10> combo, we
      need to pop up a selection context menu or background context menu,
      respectively if something is selected or not.
      
      Currently, this logic is duplicated in list and canvas views, in
      different ways, and not implemented in the new icon view at all.
      
      Instead, handle the "popup-menu" signal in files-view. This way,
      the new views get the feature for free.
      72fc5a45
    • António Fernandes's avatar
      ui-utilities: Rename and simplify pop_up_context_menu() · 44e00507
      António Fernandes authored
      nautilus_pop_up_context_menu() was implemented in bb884cb6 when it was
      a wrapper for gtk_menu_popup(). But gtk_menu_popup() has since
      deprecated, so it was ported to gtk_menu_popup_at_pointer() in 1f57c5b1.
      
      However, _popup_at_pointer() is not enough for our context menu needs.
      We will use _popup_at_rect() and _popup_at_widget in future commits.
      
      Rename to nautilus_pop_up_context_menu_at_pointer() to reflect this
      specific use. Also, simplify the code, as GtkMenu's API already
      interprets event=NULL as the current event.
      44e00507
    • António Fernandes's avatar
      files-vies: Drop context_menu_position cache · 53f552e3
      António Fernandes authored
      This was used when creating new folders with manual layout,
      to position them where the user had clicked.
      
      Manual layout was removed along with nautilus-desktop, so
      this cache has no use anymore. Remove it.
      53f552e3
    • António Fernandes's avatar
      view-icon-controller: Scroll only as necessary to reveal · e26de897
      António Fernandes authored
      Currently we always scroll the item to reveal to the top.
      
      This will scroll the item even if it is already visible
      but not in the first row.
      
      Instead, scroll as little as necessary to reveal the whole
      item, matching the behavior of list view and canvas view.
      e26de897
    • António Fernandes's avatar
      files-view: Reveal file to be renamed · f48fe970
      António Fernandes authored
      When renaming, if the item is out of view, the popover may pop up
      outside of the window or even outside of the screen.
      
      It is conveninent to see the whole item to be renamed and provide
      a visible target for the popover.
      
      So, reveal selection before popping up a rename popover.
      
      Fixes: #5
      f48fe970
    • António Fernandes's avatar
      list-view: Simplify rectangle for rename popovers · 27593c5a
      António Fernandes authored
      We force a rectangle with width=40 to avoid pointy popover
      arrows, then we center it to the file name column.
      
      This will not work well when reusing this for context menus.
      
      Instead, use the file name cell's area as rectangle. It should
      have enough width anyway.
      27593c5a
  9. 28 Jan, 2018 1 commit
  10. 27 Jan, 2018 1 commit
  11. 25 Jan, 2018 1 commit
  12. 24 Jan, 2018 4 commits