1. 19 Mar, 2018 1 commit
    • Alexandru Fazakas's avatar
      general: Remove include guards in favor of pragma once · 95ecfc8e
      Alexandru Fazakas authored
      The traditional include guards are not as easy to handle
      and require extra thought into the names.
      Pragma once is an easier, more contributor friendly approach.
      Closes #294
      general: Remove include guards in favor of pragma once
      The traditional include guards are not as easy to handle
      and require extra thought into the names.
      Pragma once is an easier, more contributor friendly approach.
      Closes #294
  2. 25 Apr, 2016 1 commit
    • Carlos Soriano Sánchez's avatar
      general: merge libnautilus-private to src · 7e24f1b2
      Carlos Soriano Sánchez authored
      And fix make distcheck.
      Although libnautilus-private seem self contained, it was actually
      depending on the files on src/ for dnd.
      Not only that, but files in libnautilus-private also were depending on
      dnd files, which you can guess it's wrong.
      Before the desktop split, this was working because the files were
      distributed, but now was a problem since we reestructured the code, and
      now nautilus being a library make distcheck stop working.
      First solution was try to fix this inter dependency of files, but at
      some point I realized that there was no real point on splitting some of
      those files, because for example, is perfectly fine for dnd to need to
      access the window functions, and it's perfectly fine for the widgets
      in the private library to need to access to all dnd functions.
      So seems to me the private library of nautilus is somehow an artificial
      split, which provides more problems than solutions.
      We needed libnautilus-private to have a private library that we could
      isolate from extensions, but I don't think it worth given the problems
      it provides, and also, this not so good logical split.
      Right now, since with the desktop split we created a libnautilus to be
      used by the desktop part of nautilus, extensions have access to all
      the API of nautilus. We will think in future how this can be handled if
      we want.
      So for now, merge the libnautilus-private into src, and let's rethink
      a better logic to split the code and the private parts of nautilus than
      what we had.
      Thanks a lot to Rafael Fonseca for helping in get this done.
  3. 04 Apr, 2016 1 commit
    • Carlos Soriano Sánchez's avatar
      general: remove vim modelines · 1ffb8ca5
      Carlos Soriano Sánchez authored
      Vim and emacs modelines are used to specify some of the code style in the code.
      However, this is misleading and poorly supported since nautilus had a mix of
      code style for some time.
      Also, the mode lines doesn't specify the whole code style, so we will need to
      use a different tool as well to specify the whole code style.
      For that, we can just use a different tool for everything.
      So remove the mode lines, and in a short future we will reestyle the nautilus
      code to have a single code style, and use a tool like editorconfig to specify
      the whole code style.
  4. 31 Jan, 2014 1 commit
  5. 09 Jan, 2013 1 commit
  6. 21 Apr, 2009 1 commit
    • Cosimo Cecchi's avatar
      Remove deprecated GDK/GTK+ symbols · b695c970
      Cosimo Cecchi authored
      Remove all uses of deprecated GDK and GTK+ symbols, replacing them
      with the currently supported equivalents.
      Based on a patch from Tal Benavidor (#565038).
  7. 21 May, 2008 1 commit
  8. 14 Dec, 2007 1 commit
    • Alexander Larsson's avatar
      Only use <gio/gio.h> include · 6559286c
      Alexander Larsson authored
      2007-12-14  Alexander Larsson  <alexl@redhat.com>
              * libnautilus-private/nautilus-bookmark.c:
              * libnautilus-private/nautilus-bookmark.h:
              * libnautilus-private/nautilus-desktop-icon-file.c:
              * libnautilus-private/nautilus-desktop-link-monitor.c:
              * libnautilus-private/nautilus-desktop-link.c:
              * libnautilus-private/nautilus-desktop-link.h:
              * libnautilus-private/nautilus-directory-private.h:
              * libnautilus-private/nautilus-directory.h:
              * libnautilus-private/nautilus-emblem-utils.h:
              * libnautilus-private/nautilus-file-changes-queue.h:
              * libnautilus-private/nautilus-file-operations.c:
              * libnautilus-private/nautilus-file-operations.h:
              * libnautilus-private/nautilus-file-utilities.c:
              * libnautilus-private/nautilus-file-utilities.h:
              * libnautilus-private/nautilus-file.c:
              * libnautilus-private/nautilus-file.h:
              * libnautilus-private/nautilus-icon-info.c:
              * libnautilus-private/nautilus-icon-info.h:
              * libnautilus-private/nautilus-link.c:
              * libnautilus-private/nautilus-mime-actions.h:
              * libnautilus-private/nautilus-mime-application-chooser.c:
              * libnautilus-private/nautilus-monitor.c:
              * libnautilus-private/nautilus-monitor.h:
              * libnautilus-private/nautilus-open-with-dialog.c:
              * libnautilus-private/nautilus-open-with-dialog.h:
              * libnautilus-private/nautilus-program-choosing.c:
              * libnautilus-private/nautilus-program-choosing.h:
              * libnautilus-private/nautilus-progress-info.h:
              * libnautilus-private/nautilus-recent.h:
              * libnautilus-private/nautilus-search-directory.c:
              * libnautilus-private/nautilus-search-engine-simple.c:
              * libnautilus-private/nautilus-trash-monitor.c:
              * libnautilus-private/nautilus-trash-monitor.h:
              * libnautilus-private/nautilus-ui-utilities.c:
              * libnautilus-private/nautilus-view-factory.h:
              * src/file-manager/fm-directory-view.c:
              * src/file-manager/fm-directory-view.h:
              * src/file-manager/fm-icon-container.c:
              * src/file-manager/fm-icon-view.c:
              * src/file-manager/fm-tree-model.h:
              * src/file-manager/fm-tree-view.c:
              * src/nautilus-application.c:
              * src/nautilus-application.h:
              * src/nautilus-bookmark-list.c:
              * src/nautilus-bookmark-list.h:
              * src/nautilus-desktop-window.c:
              * src/nautilus-image-properties-page.c:
              * src/nautilus-location-entry.c:
              * src/nautilus-navigation-window.c:
              * src/nautilus-pathbar.c:
              * src/nautilus-pathbar.h:
              * src/nautilus-places-sidebar.c:
              * src/nautilus-property-browser.c:
              * src/nautilus-query-editor.c:
              * src/nautilus-window-menus.c:
      	Only use <gio/gio.h> include 
      svn path=/trunk/; revision=13529
  9. 30 Nov, 2007 1 commit
  10. 05 Nov, 2003 1 commit
    • Alexander Larsson's avatar
      Require new gnome-vfs · 3613a86b
      Alexander Larsson authored
      2003-11-05  Alexander Larsson  <alexl@redhat.com>
      	* configure.in:
      	Require new gnome-vfs
      	* components/tree/nautilus-tree-view.c:
      	* libnautilus-private/nautilus-desktop-link-monitor.c:
      	* libnautilus-private/nautilus-desktop-link.[ch]:
      	* libnautilus-private/nautilus-monitor.c:
      	* libnautilus-private/nautilus-trash-directory.c:
      	* libnautilus-private/nautilus-trash-monitor.[ch]:
      	* src/nautilus-application.c:
      	Use gnome-vfs-volume-manager instead of nautilus-volume-manager.c
      	* libnautilus-private/nautilus-desktop-icon-file.c:
      	Set the volume on the nautilusfile
      	* libnautilus-private/nautilus-directory-async.c:
      	Load volume info from link
      	* libnautilus-private/nautilus-file-attributes.h:
      	* libnautilus-private/nautilus-mime-actions.c:
      	Add new VOLUMES attribute
      	* libnautilus-private/nautilus-file-private.h:
      	Add has_volume and has_drive to NautilusFile
      	* libnautilus-private/nautilus-file.[ch]:
      	Add has_volume and has_drive to NautilusFile
      	Volumes/drives are sorted separately
      	* libnautilus-private/nautilus-link-desktop-file.[ch]:
      	* libnautilus-private/nautilus-link.[ch]:
      	Read drive and volume id from links
      	* src/file-manager/fm-desktop-icon-view.c:
      	* src/file-manager/nautilus-desktop-icon-view-ui.xml:
      	Remove volume ops. Remove disks menu
      	* src/file-manager/fm-directory-view.c:
      	* src/file-manager/nautilus-directory-view-ui.xml:
      	Implement volume ops using gnome-vfs
      	* src/file-manager/fm-properties-window.c:
      	Handle drives/volumes
      	* src/nautilus-window.c:
      	Make a nicer title for some specific locations
      	* libnautilus-private/nautilus-volume-monitor.[ch]:
      	* libnautilus-private/Makefile.am
      	remove this old crap
  11. 21 Feb, 2002 1 commit
    • Darin Adler's avatar
      Remove nautilus-desktop-file-loader.[ch]. Remove. Remove. · e4615d84
      Darin Adler authored
      	* libnautilus-private/Makefile.am: Remove nautilus-desktop-file-loader.[ch].
      	* libnautilus-private/nautilus-desktop-file-loader.c: Remove.
      	* libnautilus-private/nautilus-desktop-file-loader.h: Remove.
      	* libnautilus-private/nautilus-directory-async.c:
      	(link_info_nautilus_link_read_callback): Pass in NULL for the new
      	optional URI parameter for parsing existing link files.
      	* libnautilus-private/nautilus-link-desktop-file.h:
      	* libnautilus-private/nautilus-link-desktop-file.c:
      	Change to use GnomeDesktopItem instead of NautilusDesktopFile.
      	* libnautilus-private/nautilus-link.h:
      	* libnautilus-private/nautilus-link.c:
      	Add optional URI parameter for parsing existing link files. This
      	is passed down to the GnomeDesktopItem level, which can sometimes
      	do a better job if it knows the URI.
      	* src/file-manager/fm-directory-view.c: (activate_callback):
      	Change to use GnomeDesktopItem instead of NautilusDesktopFile. Also,
      	simplify error handling.
      	* Many files:
      	Fix includes to use <> style in headers more consistently, and remove
      	unnecessarily includes.
  12. 01 May, 2001 1 commit
    • Pavel Cisler's avatar
      reviewed by: Darin Adler <darin@eazel.com> · a9e16f06
      Pavel Cisler authored
      2001-04-30  Pavel Cisler  <pavel@eazel.com>
      	reviewed by: Darin Adler  <darin@eazel.com>
      	Fixed 4964 (Files dragged to Trash from floppy don't
      		    appear in Trash Can)
      	Fixed 7406 (Trash doesn't work until first restart of Nautilus)
      	Fixed 7976 (some files that you can't leave in the Trash just
      		    silently go away instead of showing the dialog as
      		    they should)
      	New trash directories are created lazily, when someone tries to
      	delete an item on the respective disk for the first time. The
      	problem was that these new trash directories do not get integrated
      	into the unified trash directory. Added logic to do that.
      	* libnautilus-extensions/nautilus-file-operations.c:
      	Before a move to trash operation is started check for any new
      	trash directories and integrate them if needed.
      	* libnautilus-extensions/nautilus-trash-directory.c:
      	(check_trash_created), (check_trash_directory_added_callback),
      	Add calls to allow adding a new physical trash directory to the
      	unified trash.
      	* libnautilus-extensions/nautilus-trash-directory.h:
      	* libnautilus-extensions/nautilus-trash-monitor.c:
      	* libnautilus-extensions/nautilus-trash-directory.c:
      	Rearrange to allow initializing the nautilus trash directory and
      	nautilus trash monitor properly, dodging a cyclic dependency.
      	* libnautilus-extensions/nautilus-trash-monitor.c:
      	* libnautilus-extensions/nautilus-trash-monitor.h:
      	Add a new signal to allow clients get notified when a new
      	trash directory might get added to the unified trash.
  13. 13 Dec, 2000 1 commit
    • Pavel Cisler's avatar
      reviewed by: Darin Adler <darin@eazel.com> · a085188c
      Pavel Cisler authored
      2000-12-12  Pavel Cisler <pavel@eazel.com>
      	reviewed by: Darin Adler <darin@eazel.com>
      	Fixed 4954 Nautilus crashes attempting to empty a .Trash
      	containing undeletable files
      	* libnautilus-extensions/nautilus-file-operations.c:
      	(build_error_string), (handle_xfer_vfs_error)
      	Reworked the error message building logic. Split up
      	the routine into a part that decides what the interesting
      	input for building the error message is and a part that
      	actually builds the error message. Fixed a number
      	of cases where a wrong error message would be used. The
      	actual bug in the bug report was one of the cases -- an assert
      	catching a case that was not handled properly.
      	part of -- 638 When a new volume gets mounted, integrate its Trash
      	part of -- 4143 Files dragged to trash icon on desktop seem to
      	part of -- 4963 Files dragged to Trash from floppy don't appear
      	in Trash,
      	* libnautilus-extensions/nautilus-trash-monitor.c:
      	* libnautilus-extensions/nautilus-trash-monitor.h:
      	Added a new call that returns a list of all the Trash directories
      	on all the mouted volumes.
      	* libnautilus-extensions/nautilus-trash-directory.c: (add_volume):
      	Got rid of get_volume_vfs_uri_if_writable.
      	Used the new nautilus_volume_monitor_should_integrate_trash instead
      	to pick the volumes that can support trash.
      	* libnautilus-extensions/nautilus-volume-monitor.c:
      	* libnautilus-extensions/nautilus-volume-monitor.h:
      	Add new helper calls used by the routine that collects all the
      	trash uris from all mouted volumes.
      	* libnautilus-extensions/nautilus-file-operations.c:
      	Pass in a list of Trash directories instead of just the
      	single trash in the user's home directory.
      	2443 Trash is only found on EXT2 volumes
      	2444 Trash on read-only volumes is not displayed
      	remaining part of -- 4143 Files dragged to trash icon on desktop
      	seem to vanish,
      	remaining part of -- 4963 Files dragged to Trash from floppy
      	don't appear in Trash,
      	* libnautilus-extensions/nautilus-volume-monitor.c:
      	Removed the old logic from get_volume_vfs_uri_if_writable
      	that only displayed trash from writable ext2 volumes.
      	Enumerated all the file system types that we know can
      	support trash.
  14. 09 Dec, 2000 1 commit
    • Darin Adler's avatar
      reviewed by: John Sullivan <sullivan@eazel.com> · 134e132a
      Darin Adler authored
      	Fixed bug 2244 (trash window sidebar should have trash icon).
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(nautilus_icon_factory_get_icon_name_for_directory): Added code to
      	give the trash its own icon.
      	(nautilus_icon_factory_get_icon_for_file): Rearranged to simplify
      	it a bit.
      	* libnautilus-extensions/Makefile.am:
      	* libnautilus-extensions/nautilus-trash-monitor.h:
      	* libnautilus-extensions/nautilus-trash-monitor.c:
      	Moved trash monitor to here.
      	(nautilus_trash_files_changed_callback): Do nautilus_file_changed
      	on the trash NautilusFile object when the state changes from full
      	to empty or from empty to full.
      	* src/file-manager/Makefile.am:
      	* src/file-manager/nautilus-trash-monitor.h:
      	* src/file-manager/nautilus-trash-monitor.c:
      	Moved trash monitor from here.
      	* src/file-manager/fm-desktop-icon-view.c:
      	* src/file-manager/fm-directory-view.c:
      	Changed includes to include trash monitor from new location.
      	* libnautilus-extensions/nautilus-directory-metafile.c:
      	(set_metadata_string_in_metafile), (set_metadata_list_in_metafile):
      	Remove some dead code left over from handling of directory metadata.
      	We don't have directory metadata any more, only file metadata.
  15. 15 Aug, 2000 1 commit
    • Pavel Cisler's avatar
      Fix bugzilla 1855 - nautilus_trash_monitor_async_get_trash_directories · 4a683bd0
      Pavel Cisler authored
      2000-08-14  Pavel Cisler  <pavel@eazel.com>
      	* src/file-manager/fm-desktop-icon-view.c:
      	* src/file-manager/nautilus-trash-monitor.c:
      	(add_one_writable_device), (get_trashable_volume_uris),
      	* src/file-manager/nautilus-trash-monitor.h:
      	Fix bugzilla 1855 - nautilus_trash_monitor_async_get_trash_directories
      	returns the list of URIs of all the available trash directories, finding
      	and creating them as needed.
      	* libnautilus-extensions/nautilus-volume-monitor.c: (floppy_sort),
      	(mount_device_check_change), (mount_devices_update_is_mounted),
      	(check_permissions), (mount_device_iso9660_add),
      	(mount_device_add_aliases), (add_mount_device),
      	* libnautilus-extensions/nautilus-volume-monitor.h:
      	Made nautilus_volume_monitor_find_mount_device call
      	mount_devices_check_status explicitly so that the mounted volume state
      	is correct when the call returns.
      	Add nautilus_volume_monitor_each_device and
      	Moved NautilusVolumeMonitorDetails into nautilus-volume-monitor.c,
      	away from prying eyes.
      	Tweak some string matching code.
  16. 09 Aug, 2000 1 commit
    • Darin Adler's avatar
      After this change, you will get a warning each time you exit · 39d0bf45
      Darin Adler authored
      	unless you get the new Bonobo with my destroy-notify bug fix.
      	Fixed the "metafile read fails" bug. Fixed a bunch of memory
      	leaks that I found because I added a new function to get rid
      	of hash tables at quit time and there's a hash table with all
      	the NautilusDirectory objects in there. I'm only 1/2 done
      	with what I'm working on, but people need the "read fails"
      	bug fix.
      	* components/help/help-method.c: (escape_for_shell),
      	(help_uri_to_string): Improve code that constructs URIs so it
      	doesn't to excessive escaping.
      	* libnautilus-extensions/nautilus-directory-async.c:
      	(metafile_read_failed): Fixed a bug that caused it to fail to
      	read "public" metafiles.
      	(new_files_callback): Redid the fix for "NULL names" to check
      	the result from the call instead of checking the name for NULL.
      	* libnautilus-extensions/nautilus-directory-background.c:
      	Got rid of the dummy callback so the NautilusDirectory code
      	knows that only the metadata needs to be monitored.
      	* libnautilus-extensions/nautilus-directory.c:
      	(nautilus_directory_get): Got rid of silly ref and sink code.
      	We don't use the floating feature, so we should just ignore it.
      	Use the new function that creates a hash table that should be
      	empty and freed on exit. This helps us detect leaks.
      	(nautilus_directory_file_monitor_add): Got rid of incorrect
      	code that would reject a caller that didn't supply a callback.
      	Callers might want to monitor metadata only, not files.
      	* libnautilus-extensions/nautilus-file.c:
      	(nautilus_file_new_from_name): Got rid of silly ref and sink code.
      	We don't use the floating feature, so we should just ignore it.
      	(modify_link_hash_table), (add_to_link_hash_table_list),
      	(add_to_link_hash_table), (remove_from_link_hash_table_list),
      	(remove_from_link_hash_table): Maintain a hash table to map from
      	a URI to links to that URI.
      	(nautilus_file_new_from_info): Got rid of silly ref and sink code.
      	We don't use the floating feature, so we should just ignore it.
      	To share more code, call nautilus_file_update_info as part of
      	the implementation here.
      	(nautilus_file_update_info): Maintain the hash table entries as
      	the symlink_name field changes.
      	* libnautilus-extensions/nautilus-glib-extensions.h:
      	* libnautilus-extensions/nautilus-glib-extensions.c:
      	Added new function to create a hash table that should be empty on
      	exit, check that is is empty, and free it at exit time.
      	* libnautilus-extensions/nautilus-global-preferences.c:
      	Got rid of some function-pointer casting.
      	* libnautilus-extensions/nautilus-icon-container.h:
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(call_icon_callback), (nautilus_icon_container_for_each):
      	Added a new call to iterate all the icons in the container.
      	Needed so we can unref all the files when we empty it.
      	* libnautilus-extensions/nautilus-glib-extensions.h:
      	* libnautilus-extensions/nautilus-mime-actions.c:
      	Updated for name change: NautilusGPredicateFunc ->
      	* src/file-manager/fm-directory-view.c:
      	(fm_directory_view_destroy), (done_loading):
      	Added code to stop and clear when destroying the directory view.
      	* src/file-manager/fm-icon-view.c: (unref_cover),
      	(fm_icon_view_clear): Added code to get rid of the refs on all
      	the files when the icon view is cleared.
      	* src/file-manager/fm-list-view.c: (fm_list_view_clear): Added
      	code to get rid of the refs on all the files when the icon view is
      	* src/file-manager/nautilus-trash-monitor.h:
      	* src/file-manager/nautilus-trash-monitor.c:
      	(nautilus_trash_monitor_initialize_class), (destroy),
      	(unref_trash_monitor), (nautilus_trash_monitor_get),
      	Added code to destroy the trash monitor on exit.
      	* src/nautilus-bookmark-list.c:
      	(nautilus_bookmark_list_initialize_class), (stop_monitoring_one),
      	(clear), (destroy), (nautilus_bookmark_list_load_file): Added code
      	to clear out the list at destroy time the same way we already did
      	before loading a file.
      	* src/nautilus-window-menus.c: (free_bookmark_list),
      	(get_bookmark_list): Add code to free the global bookmark list
      	on exit to help with leak checking.
      	(refresh_go_menu): Changed to use GList instead of GSList.
      	* src/nautilus-window-private.h:
      	* src/nautilus-window.c: (nautilus_window_destroy):
      	Unref the current_location_bookmark and last_location_bookmark
      	to fix a leak.
      	(free_history_list), (nautilus_add_to_history_list): Free the
      	history list at exit time to make it easier to spot leaks.
      	(nautilus_window_get_history_list_callback): Change the history
      	list to be a GList instead of GSList.
  17. 02 Aug, 2000 2 commits
    • Pavel Cisler's avatar
      Move the desktop icon updating call here from fm_directory_view.c. Since · fd1bde5e
      Pavel Cisler authored
      2000-08-02  Pavel Cisler  <pavel@eazel.com>
      	* src/file-manager/fm-desktop-icon-view.c:
      	Move the desktop icon updating call here from fm_directory_view.c.
      	Since there is only one desktop, we will only try to update the
      	Trash icon once this way, rather than once for every open window.
      	Hook up the trash trash_state_changed properly.
      	* src/file-manager/fm-directory-view.c:
      	(fm_directory_view_initialize), (compute_menu_item_info),
      	Fix bugzilla 656: Empty Trash menu item is enabled even when Trash
      	is empty.
      	Hook up to the trash_state_changed signal and trigger a menu update for
      	the change.
      	* src/file-manager/nautilus-trash-monitor.c:
      	* src/file-manager/nautilus-trash-monitor.h:
      	Forgot to implement this one in my last checkin and it's needed for the
      	above call.
    • Pavel Cisler's avatar
      Bugzilla bug 1400 · 21c6cffa
      Pavel Cisler authored
      2000-08-02  Pavel Cisler  <pavel@eazel.com>
      	Bugzilla bug 1400
      	* libnautilus-extensions/nautilus-directory.c:
      	* libnautilus-extensions/nautilus-directory.h:
      	Added a call I needed to check a directory empty state.
      	* src/file-manager/Makefile.am:
      	* src/file-manager/nautilus-trash-monitor.h:
      	* src/file-manager/nautilus-trash-monitor.c:
      	(nautilus_trash_monitor_initialize), (nautilus_trash_monitor_get),
      	New trash state monitoring class, used to update the Trash icon, etc.
      	* src/file-manager/fm-directory-view.c:
      	(bonobo_menu_empty_trash_callback), (fm_directory_view_initialize),
      	Hook up to the Trash monitor change signal.
      	Tweak the callback Gene prepared for me earlier that updates the
      	Trash icon to use the new signal.
      	* src/file-manager/fm-directory-view.c:
      	Tiny tweak - use a cover call instead of emitting a signal directly.