1. 19 Mar, 2018 1 commit
    • Alexandru Fazakas's avatar
      general: Remove include guards in favor of pragma once · 95ecfc8e
      Alexandru Fazakas authored
      The traditional include guards are not as easy to handle
      and require extra thought into the names.
      
      Pragma once is an easier, more contributor friendly approach.
      
      Closes #294
      
      general: Remove include guards in favor of pragma once
      
      The traditional include guards are not as easy to handle
      and require extra thought into the names.
      
      Pragma once is an easier, more contributor friendly approach.
      
      Closes #294
      95ecfc8e
  2. 25 Apr, 2016 1 commit
    • Carlos Soriano Sánchez's avatar
      general: merge libnautilus-private to src · 7e24f1b2
      Carlos Soriano Sánchez authored
      And fix make distcheck.
      
      Although libnautilus-private seem self contained, it was actually
      depending on the files on src/ for dnd.
      Not only that, but files in libnautilus-private also were depending on
      dnd files, which you can guess it's wrong.
      
      Before the desktop split, this was working because the files were
      distributed, but now was a problem since we reestructured the code, and
      now nautilus being a library make distcheck stop working.
      
      First solution was try to fix this inter dependency of files, but at
      some point I realized that there was no real point on splitting some of
      those files, because for example, is perfectly fine for dnd to need to
      access the window functions, and it's perfectly fine for the widgets
      in the private library to need to access to all dnd functions.
      
      So seems to me the private library of nautilus is somehow an artificial
      split, which provides more problems than solutions.
      
      We needed libnautilus-private to have a private library that we could
      isolate from extensions, but I don't think it worth given the problems
      it provides, and also, this not so good logical split.
      Right now, since with the desktop split we created a libnautilus to be
      used by the desktop part of nautilus, extensions have access to all
      the API of nautilus. We will think in future how this can be handled if
      we want.
      
      So for now, merge the libnautilus-private into src, and let's rethink
      a better logic to split the code and the private parts of nautilus than
      what we had.
      
      Thanks a lot to Rafael Fonseca for helping in get this done.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=765543
      7e24f1b2
  3. 04 Apr, 2016 1 commit
    • Carlos Soriano Sánchez's avatar
      general: remove vim modelines · 1ffb8ca5
      Carlos Soriano Sánchez authored
      Vim and emacs modelines are used to specify some of the code style in the code.
      However, this is misleading and poorly supported since nautilus had a mix of
      code style for some time.
      Also, the mode lines doesn't specify the whole code style, so we will need to
      use a different tool as well to specify the whole code style.
      For that, we can just use a different tool for everything.
      
      So remove the mode lines, and in a short future we will reestyle the nautilus
      code to have a single code style, and use a tool like editorconfig to specify
      the whole code style.
      1ffb8ca5
  4. 17 Feb, 2014 1 commit
  5. 16 Jun, 2006 1 commit
    • Alexander Larsson's avatar
      Add items_updated signal · 1a7f1da1
      Alexander Larsson authored
      2006-06-16  Alexander Larsson  <alexl@redhat.com>
      
      	* libnautilus-extension/nautilus-menu-provider.[ch]:
      	Add items_updated signal
      
      	* libnautilus-private/Makefile.am:
      	* libnautilus-private/nautilus-signaller.[ch]:
      	* src/nautilus-signaller.[ch]:
      	* src/Makefile.am:
      	Move NautilusSignaller to libnautilus-private.
      	Add popup_menu_changed signal.
      
      	* src/nautilus-application.c:
      	Signal popup_menu_changed when a menu provider emits items_updated.
      
      	* src/file-manager/fm-directory-view.c:
      	* src/nautilus-window.c:
      	Handle popup_menu_changed.
      
      	* src/nautilus-emblem-sidebar.c:
      	* src/nautilus-history-sidebar.c:
      	* src/nautilus-navigation-window-menus.c:
      	* src/nautilus-navigation-window.c:
      	* src/nautilus-property-browser.c:
      	* src/nautilus-spatial-window.c:
      	* src/nautilus-window-menus.c:
      	Update includes.
      
      	Patch from RUAUDEL Frédéric <ruaudel@embl.fr>
      1a7f1da1
  6. 19 Jan, 2002 1 commit
    • Darin Adler's avatar
      Remove nautilus-launch-icon.png. · 074ed7a0
      Darin Adler authored
      	* Makefile.am: Remove nautilus-launch-icon.png.
      
      	* components/hardware/nautilus-hardware-view.c: (setup_form_title),
      	(setup_overview_form): Port from EelImage to GtkImage.
      
      	* components/music/nautilus-music-view.c: Remove unused include.
      	* src/nautilus-theme-selector.c: Remove unused includes.
      
      	* libnautilus-private/nautilus-bonobo-extensions.c:
      	(bonobo_activation_activation_callback): Add warning message so we
      	get to see the error from bonobo-activation.
      
      	* libnautilus-private/nautilus-directory-metafile.c: (get_factory):
      	* libnautilus-private/nautilus-icon-factory.c: (get_icon_factory),
      	(load_icon_for_scaling), (embed_text):
      	* libnautilus-private/nautilus-metafile-factory.c:
      	(nautilus_metafile_factory_get_instance):
      	* libnautilus-private/nautilus-theme.c:
      	(nautilus_theme_get_theme_data_from_theme):
      	* libnautilus-private/nautilus-trash-monitor.c:
      	(nautilus_trash_monitor_get):
      	* libnautilus-private/nautilus-volume-monitor.c:
      	(nautilus_volume_monitor_get):
      	* src/file-manager/nautilus-indexing-info.c:
      	(show_indexing_info_dialog):
      	* src/nautilus-preferences-dialog.c:
      	(global_preferences_get_dialog):
      	* src/nautilus-window.c: (nautilus_window_class_init),
      	(add_to_history_list):
      	Use eel_debug_call_at_shutdown instead of g_atexit.
      
      	* libnautilus-private/nautilus-file.c:
      	(nautilus_file_get_display_name): Add G_BROKEN_FILENAMES support.
      
      	* libnautilus-private/nautilus-global-preferences.c:
      	(nautilus_global_preferences_init): Remove eel_smooth_widget code.
      
      	* libnautilus/Makefile.am: Add missing ORBIT_IDL dependency.
      
      	* libnautilus/nautilus-view-standard-main.c:
      	(nautilus_view_standard_main_multi): Remove
      	bonobo_ui_debug_shutdown for now. It does us no good unless we
      	also do eel_debug_shut_down, but libnautilus can't depend on eel.
      
      	* nautilus-launch-icon.png: Remove.
      
      	* src/file-manager/fm-properties-window.c:
      	(update_properties_window_icon),
      	(fm_properties_window_drag_data_received),
      	(create_image_widget_for_file): Port from EelImage to GtkImage.
      
      	* src/nautilus-component-adapter-factory.c:
      	(nautilus_component_adapter_factory_get): Use
      	eel_debug_call_at_shutdown instead of g_atexit.
      	(nautilus_component_adapter_factory_create_adapter): Look at
      	exceptions before looking at return values from CORBA calls.
      
      	* src/nautilus-main.c: (main): Add a call to eel_debug_shut_down.
      
      	* src/nautilus-property-browser.c:
      	(nautilus_property_browser_init), (element_clicked_callback),
      	(nautilus_property_browser_update_contents): Port from EelViewport
      	to GtkViewport.
      
      	* src/nautilus-search-bar-criterion.c:
      	(nautilus_search_bar_criterion_destroy),
      	(nautilus_search_bar_criterion_new_from_values): Fix for change
      	that made NautilusSignaller no longer a GtkObject.
      
      	* src/nautilus-sidebar-title.c: (nautilus_sidebar_title_init),
      	(update_icon), (add_emblem): Port from EelImage to GtkImage.
      
      	* src/nautilus-signaller.h:
      	* src/nautilus-signaller.c: (nautilus_signaller_get_current): Use
      	eel_debug_call_at_shutdown instead of g_atexit.
      	(nautilus_signaller_instance_init),
      	(nautilus_signaller_class_init): Change to GObject, not GtkObject.
      
      	* src/nautilus-window-menus.c: (get_bookmark_list): Use
      	eel_debug_call_at_shutdown instead of g_atexit.
      	(nautilus_window_initialize_go_menu): Fix for change that made
      	NautilusSignaller no longer a GtkObject.
      
      	* test/test-nautilus-preferences-change.c: Remove unused include.
      	* test/test-nautilus-preferences-display.c: Remove unused includes.
      	* test/test-nautilus-wrap-table.c: Remove unused includes.
      	* test/test.c: Remove unused function.
      	* test/test.h: Remove unused function.
      074ed7a0
  7. 04 Jan, 2001 1 commit
    • Darin Adler's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · f683ed79
      Darin Adler authored
      	Fix bug 5235 ("Forget History" eliminates history from Go menu,
      	not History sidebar panel).
      
      	* components/history/nautilus-history-view.c:
      	(install_icons): Fix leak of pixmap and bitmap.
      	(update_history): Replaced dual lock system with a single one.
      	(button_press_callback): Only respect button 1, ignore others.
      	(button_release_callback): Only respect button 1, ignore others,
      	(history_changed_callback): A new single callback for when the
      	history list changes to replace the multiple callbacks before.
      	(nautilus_history_view_initialize_class),
      	(nautilus_history_view_initialize),
      	(nautilus_history_view_destroy), (main): Change the history view
      	to use nautilus_view_standard_main which requires a subclass. This
      	gets rid of a lot of boilerplate code.
      
      	* libnautilus/nautilus-view-component.idl: Make every NautilusView
      	get an explicit history_changed call instead of requiring them to
      	guess when to get history. Removed the old get_history_list call
      	and also renamed the HistoryList sequence to History.
      	* libnautilus/nautilus-view.h:
      	* libnautilus/nautilus-view.c:
      	(impl_Nautilus_View_history_changed),
      	(nautilus_view_initialize_class): Added the necessary stuff to
      	cover the new history_changed call.
      
      	* src/nautilus-view-frame.h:
      	* src/nautilus-view-frame.c: (nautilus_view_frame_initialize):
      	Connect handlers so we can send history_changed calls to the
      	NautilusView when either the history or the icons change.
      	(nautilus_view_frame_destroy): Change state to EMPTY so the
      	history signal won't be sent once the frame is destroyed.
      	(view_frame_activated): Send a history_changed to every
      	newly-activated view.
      	(get_CORBA_object): Helper function to make code that makes CORBA
      	calls simpler.
      	(check_if_view_is_gone): Use get_CORBA_object.
      	(attach_client): Gave a nicer name, removed the code that makes
      	the Nautilus_HistoryFrame interface.
      	(nautilus_view_frame_load_client): Do the attach_client (formerly
      	nautilus_view_frame_set_to_component) before calling
      	view_frame_activated. This is needed since view_frame_activated
      	now sends a history_changed to the view.
      	(nautilus_view_frame_load_location),
      	(nautilus_view_frame_stop_loading),
      	(nautilus_view_frame_selection_changed),
      	(nautilus_view_frame_title_changed): Use get_CORBA_object.
      	(get_history_list): Made this private.
      	(send_history): Helper function that sends history to the view if
      	it's in the appropriate state.
      
      	* src/Makefile.am:
      	* src/nautilus-history-frame.c:
      	* src/nautilus-history-frame.h:
      	Removed the old NautilusHistoryFrame, which is no longer needed
      	since we put the history call right in the NautilusView class.
      
      	* src/nautilus-window-manage-views.c: (get_history_list_callback):
      	Updated for Nautilus_HistoryList -> Nautilus_History change.
      
      	Fix bug 5391 ("Esc" Canceling of an icon stretch doesn't restore
      	icon position.).
      
      	* libnautilus-extensions/nautilus-icon-private.h:
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(clear_drag_state): Add a single bottleneck function to make sure
      	the context menu timeout always gets canceled.
      	(continue_stretching): Remove the unused "update_position" parameter.
      	(undo_stretching): Consolidate the cancel_stretching function and
      	restore the icon's position as well as its size. Also use the new
      	bottleneck to clear the drag state.
      	(button_release_event): Use the new bottleneck to clear the drag
      	state.
      	(show_context_menu_callback): Use the new bottleneck to clear the
      	drag state.
      	(nautilus_icon_container_set_selection),
      	(nautilus_icon_container_select_list_unselect_others): Take
      	advantage of the defaults in g_hash_table_new and use NULL, NULL
      	instead of g_direct_hash, g_direct_equal.
      	(nautilus_icon_container_show_stretch_handles): Save the position
      	as well as the size.
      	(compute_stretch): Add a FIXME with a bug number.
      
      	Fix bug 5407 (Make "Hardware Overview" title translatable).
      
      	* components/hardware/nautilus-hardware-view.c:
      	(nautilus_hardware_view_destroy): Remove unused uri field.
      	(extract_info): Fix storage leak.
      	(get_RAM_description): Get rid of code that non-portably relies on
      	long long. Mark strings for translation.
      	(get_IDE_description): Get rid of code that non-portably relies on
      	long long. Mark strings for translation.
      	(setup_overview_form): Marked string for translation.
      	(setup_CPU_form), (setup_RAM_form), (setup_IDE_form),
      	(is_location), (nautilus_hardware_view_load_uri): Disable the
      	views other than the overview for now since they are not ready to
      	be seen.
      	(nautilus_hardware_view_drag_data_received): Get rid of the code
      	that makes the hardware view accept a URI list drag.
      
      	Fix bug 5405 (nautilus --check fails when using LC_ALL=sv_SE due
      	to missing entry in POTFILES.in).
      
      	* po/POTFILES.in: Added nautilus-glib-extensions.c.
      
      	Other changes.
      
      	* src/nautilus-signaller.h:
      	* src/nautilus-signaller.c: (nautilus_signaller_initialize_class),
      	(nautilus_signaller_get_current):
      	Change the NautilusSignaller class so that the interface calls the
      	object a GtkObject * and the details of the class are hidden.
      
      	* src/nautilus-property-browser.c: (emit_emblems_changed_signal):
      	* src/nautilus-search-bar-criterion.c:
      	(nautilus_search_bar_criterion_destroy),
      	(nautilus_search_bar_criterion_new_from_values):
      	* src/nautilus-window-menus.c:
      	(nautilus_window_initialize_go_menu):
      	* src/nautilus-window.c: (nautilus_send_history_list_changed):
      	Now that nautilus_signaller_get_current returns a GtkObject,
      	remove some unnecessary casts.
      
      	* components/html/glibwww-callbacks.c: (get_sock_info),
      	(glibwww_timer_register):
      	* components/tree/nautilus-tree-model.c:
      	(nautilus_tree_model_initialize):
      	* components/tree/nautilus-tree-view.c:
      	(nautilus_tree_view_initialize):
      	* libnautilus-extensions/nautilus-directory-async.c:
      	(async_job_start):
      	* libnautilus-extensions/nautilus-directory.c:
      	(nautilus_directory_notify_files_added),
      	(nautilus_directory_notify_files_removed),
      	(nautilus_directory_notify_files_moved):
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(nautilus_icon_factory_initialize):
      	* libnautilus-extensions/nautilus-list.c:
      	(nautilus_list_set_selection):
      	* libnautilus-extensions/nautilus-merged-directory.c:
      	(nautilus_merged_directory_initialize):
      	* libnautilus-extensions/nautilus-trash-directory.c:
      	(nautilus_trash_directory_initialize):
      	* src/file-manager/fm-properties-window.c:
      	(fm_properties_window_present):
      	Take advantage of the defaults in g_hash_table_new and use NULL,
      	NULL instead of g_direct_hash, g_direct_equal.
      f683ed79
  8. 31 Aug, 2000 1 commit
    • Rebecca Schulman's avatar
      Completed the rest of 2369 for the required milestone. · 8613742d
      Rebecca Schulman authored
      2000-08-31  Rebecca Schulman  <rebecka@eazel.com>
      	Completed the rest of 2369 for the required
      	milestone.
      
      	* check-FIXME.pl: Make the script a little
      	bit smarter about recognizing FIXMEs with
      	bug reports.
      
      	* src/nautilus-search-bar-criterion.c:
      	* src/nautilus-search-bar-criterion.h:
      	* src/nautilus-search-bar-criterion-private.h:
      	(nautilus_search_bar_criterion_destroy),
      	(nautilus_search_bar_criterion_new), (option_menu_callback),
      	(nautilus_search_bar_criterion_set_callback),
      	(nautilus_search_bar_criterion_new_from_values),
      	(nautilus_search_bar_criterion_next_new),
      	(nautilus_search_bar_criterion_first_new),
      	(nautilus_search_bar_criterion_get_location),
      	(get_next_default_search_criterion_type),
      	(nautilus_search_bar_criterion_show),
      	(nautilus_search_bar_criterion_hide),
      	(nautilus_search_bar_criterion_human_from_uri),
      	(nautilus_search_uri_get_first_criterion), (get_name_location_for),
      	(get_content_location_for), (get_file_type_location_for),
      	(get_size_location_for), (get_emblem_location_for),
      	(get_date_modified_location_for), (get_owner_location_for),
      	(make_emblem_value_menu), (emblems_changed_callback):
      	* libnautilus-extensions/Makefile.am:
      	* src/Makefile.am:
      	moved search bar criterion class out of
      	libnautilus-extensions and into /src
      	Added acceptance of the emblems changed signal, which
      	causes a redraw of an emblem criteria menu.
      
      	* libnautilus-extensions/nautilus-directory.c:
      	(nautilus_directory_destroy), (construct_private_metafile_vfs_uri),
      	(nautilus_directory_new):
      	Changed the name of metafile_vfs_uri function from
      	metafile_uri to reflect its return of a gnome vfs uri.
      	Check for the case where the metafile was not successfully
      	created when freeing.
      
      	* src/nautilus-complex-search-bar.c: (criterion_callback):
      	got rid of extraneous print statement.
      
      	* src/nautilus-property-browser.c: (remove_emblem),
      	(emblem_dialog_clicked), (emit_emblems_changed_signal):
      	Added the emission of signals that happen when the list of
      	emblems change so that we tell the search bar about it.
      
      	* src/nautilus-signaller.c: (nautilus_signaller_initialize_class):
      	* src/nautilus-signaller.h:
      	Added an "emblems changed" signal to the signaller's vocabulary,
      	since we need a global signal, so this seems to be the logical
      	object to attach it to.
      8613742d
  9. 11 Aug, 2000 1 commit
    • Maciej Stachowiak's avatar
      Made copyright headers consistent in style; also made sure to refer to · 175ac684
      Maciej Stachowiak authored
      	* src/nautilus-applicable-views.c,
      	src/nautilus-applicable-views.h, src/nautilus-application.c,
      	src/nautilus-application.h, src/nautilus-bookmark-list.c,
      	src/nautilus-bookmark-list.h, src/nautilus-bookmark-parsing.c,
      	src/nautilus-bookmark-parsing.h, src/nautilus-bookmarks-window.c,
      	src/nautilus-bookmarks-window.h,
      	src/nautilus-complex-search-bar.c,
      	src/nautilus-complex-search-bar.h, src/nautilus-desktop-window.c,
      	src/nautilus-desktop-window.h, src/nautilus-first-time-druid.c,
      	src/nautilus-first-time-druid.h, src/nautilus-history-frame.c,
      	src/nautilus-history-frame.h, src/nautilus-link-set-window.c,
      	src/nautilus-link-set-window.h, src/nautilus-location-bar.c,
      	src/nautilus-location-bar.h, src/nautilus-main.c,
      	src/nautilus-navigation-bar.c, src/nautilus-navigation-bar.h,
      	src/nautilus-property-browser.c, src/nautilus-property-browser.h,
      	src/nautilus-search-bar-private.h, src/nautilus-search-bar.c,
      	src/nautilus-search-bar.h, src/nautilus-self-check-functions.c,
      	src/nautilus-self-check-functions.h, src/nautilus-shell.c,
      	src/nautilus-shell.h, src/nautilus-sidebar-tabs.c,
      	src/nautilus-sidebar-tabs.h, src/nautilus-sidebar-title.c,
      	src/nautilus-sidebar-title.h, src/nautilus-sidebar.c,
      	src/nautilus-sidebar.h, src/nautilus-signaller.c,
      	src/nautilus-signaller.h, src/nautilus-simple-search-bar.c,
      	src/nautilus-simple-search-bar.h,
      	src/nautilus-switchable-navigation-bar.c,
      	src/nautilus-switchable-navigation-bar.h,
      	src/nautilus-switchable-search-bar.c,
      	src/nautilus-switchable-search-bar.h, src/nautilus-toolbar.c,
      	src/nautilus-toolbar.h, src/nautilus-view-frame-bonobo-control.c,
      	src/nautilus-view-frame-bonobo-embeddable.c,
      	src/nautilus-view-frame-corba.c,
      	src/nautilus-view-frame-nautilus-view.c,
      	src/nautilus-view-frame-private.h,
      	src/nautilus-view-frame.c,src/nautilus-view-frame.h,
      	src/nautilus-window-manage-views.c,
      	src/nautilus-window-manage-views.h, src/nautilus-window-menus.c,
      	src/nautilus-window-private.h, src/nautilus-window-toolbars.c,
      	src/nautilus-window.c, src/nautilus-window.h,
      	src/nautilus-zoom-control.c, src/nautilus-zoom-control.h,
      	src/nautilus-zoomable-frame-corba.c: Made copyright headers
      	consistent in style; also made sure to refer to Nautilus as
      	Nautilus, not "this library" or "The GNOME Library".
      175ac684
  10. 18 Feb, 2000 1 commit
  11. 09 Feb, 2000 1 commit