1. 23 Apr, 2018 3 commits
  2. 31 Mar, 2018 1 commit
  3. 26 Mar, 2018 1 commit
    • Rahul Verma's avatar
      application: Fix memory leak · c6cd3699
      Rahul Verma authored
      When displaying an error dialog box, a string that stores the error details, is not being freed. So use g_autofree instead.
      c6cd3699
  4. 24 Mar, 2018 1 commit
  5. 21 Mar, 2018 1 commit
  6. 18 Mar, 2018 1 commit
    • Ernestas Kulik's avatar
      general: Allow running in separate instance · df583c2e
      Ernestas Kulik authored
      When hacking on Nautilus, it is very inconvenient to have to close any
      running instance before running the built version. This commit enables
      running three different instances by changing the application ID.
      Beside the default “profile” is one crafted for stable flatpak
      releases and one for development. The stable flatpak profile adds an
      identifying mark to the about dialog to aid collecting information in
      bug reports. The development profile is that plus additional styling to
      help visually identify the development instance. It also will be used
      when generating Flatpak bundles with the help of CI.
      
      Generally, the implementation is slightly hacky to allow all the
      different workflows, spanning from regular installations to GNOME
      Builder flatpak builds, as each comes with its own quirks.
      df583c2e
  7. 01 Mar, 2018 1 commit
    • Ernestas Kulik's avatar
      general: don’t shadow variables · 6286e0a0
      Ernestas Kulik authored
      Shadowing variables is error-prone, since one might mean to refer to a
      variable that was declared earlier, but has the same name. Additionally,
      being more strict about variable scoping can help make the code more
      readable.
      6286e0a0
  8. 13 Feb, 2018 1 commit
  9. 09 Feb, 2018 2 commits
    • Ernestas Kulik's avatar
      general: reimplement image properties as an extension · 14ee0f1c
      Ernestas Kulik authored
      The image property page is already implemented using the extension API,
      but it’s not an extension and relies on a library that is not essential
      to Nautilus. This commit builds the image properties as an extension and
      introduces some minor refactoring to the code.
      14ee0f1c
    • Ernestas Kulik's avatar
      general: refactor extension library · 7e2605c6
      Ernestas Kulik authored
      The changes include:
      
        * adding a single-include header and deprecating
          nautilus-extension-types.h and direct inclusions of individual
          headers;
      
        * type definition simplifications - this causes some breakages in
          nautilus-file, because NautilusFile used to be typedefed to
          NautilusFileInfo, and that is no longer possible, so the interface
          implementation was moved to static functions and the public
          NautilusFile API provides thin wrappers for them to maintain
          compatibility;
      
        * documentation cleanups and reorganization;
      
        * general build rule and code cleanups: mostly g_auto* sprinkled
          around and style changes (sorry)
      7e2605c6
  10. 27 Jan, 2018 1 commit
  11. 16 Jan, 2018 1 commit
    • Ernestas Kulik's avatar
      general: only remember window size · f0df1fc5
      Ernestas Kulik authored
      Currently, Nautilus is able to save the last window position when it’s
      closed. That is broken in certain cases (#197 and multi-monitor setups
      in general) and therefore window placement is best left to the window
      manager.
      f0df1fc5
  12. 02 Jan, 2018 1 commit
  13. 05 Nov, 2017 1 commit
  14. 17 Aug, 2017 1 commit
  15. 26 Feb, 2017 1 commit
    • Daniel Boles's avatar
      application: Load Adwaita.css for Adwaita-dark · 78a15628
      Daniel Boles authored
      "Adwaita-dark" is supplied by gnome-themes-standard and has a distinct
      name to theme GTK+ 2. For GTK+ 3, this theme just imports gtk-contained-
      dark.css from the library, so it's _as if_ Adwaita was the system theme.
      
      But Nautilus only applied its Adwaita-specific CSS if the system theme
      name was exactly "Adwaita". So using "Adwaita-dark" meant we got Adwaita
      but without Nautilus' additions to it, even though they are applicable.
      
      Fix this by also loading Adwaita.css if the theme name is "Adwaita-dark"
      
      https://bugzilla.gnome.org/show_bug.cgi?id=779266
      78a15628
  16. 23 Feb, 2017 1 commit
  17. 09 Jan, 2017 1 commit
  18. 12 Nov, 2016 1 commit
  19. 11 Nov, 2016 2 commits
  20. 24 Oct, 2016 1 commit
  21. 16 Oct, 2016 1 commit
  22. 15 Oct, 2016 1 commit
  23. 22 Sep, 2016 4 commits
  24. 12 Sep, 2016 1 commit
  25. 29 Aug, 2016 1 commit
  26. 25 Jul, 2016 2 commits
  27. 24 Jun, 2016 2 commits
  28. 02 May, 2016 1 commit
  29. 26 Apr, 2016 1 commit
  30. 25 Apr, 2016 1 commit
    • Carlos Soriano Sánchez's avatar
      general: merge libnautilus-private to src · 7e24f1b2
      Carlos Soriano Sánchez authored
      And fix make distcheck.
      
      Although libnautilus-private seem self contained, it was actually
      depending on the files on src/ for dnd.
      Not only that, but files in libnautilus-private also were depending on
      dnd files, which you can guess it's wrong.
      
      Before the desktop split, this was working because the files were
      distributed, but now was a problem since we reestructured the code, and
      now nautilus being a library make distcheck stop working.
      
      First solution was try to fix this inter dependency of files, but at
      some point I realized that there was no real point on splitting some of
      those files, because for example, is perfectly fine for dnd to need to
      access the window functions, and it's perfectly fine for the widgets
      in the private library to need to access to all dnd functions.
      
      So seems to me the private library of nautilus is somehow an artificial
      split, which provides more problems than solutions.
      
      We needed libnautilus-private to have a private library that we could
      isolate from extensions, but I don't think it worth given the problems
      it provides, and also, this not so good logical split.
      Right now, since with the desktop split we created a libnautilus to be
      used by the desktop part of nautilus, extensions have access to all
      the API of nautilus. We will think in future how this can be handled if
      we want.
      
      So for now, merge the libnautilus-private into src, and let's rethink
      a better logic to split the code and the private parts of nautilus than
      what we had.
      
      Thanks a lot to Rafael Fonseca for helping in get this done.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=765543
      7e24f1b2
  31. 22 Apr, 2016 1 commit