1. 09 May, 2018 2 commits
    • Carlos Soriano Sánchez's avatar
      general: Don't allow launching binaries or programs in general · 3a22ed5b
      Carlos Soriano Sánchez authored
      For long we used to support that since the desktop was part of Nautilus.
      Also, back then we didn't have a Software app where you are expected to
      installs apps. Back then it was common for apps to be delivered in
      a tarball, nowadays that's out of question.
      
      Now that the desktop is long gone, launching binaries and desktop files
      from within Nautilus is not as useful. Not only that, but we are moving
      towards a more sandboxed system, and we should use the standard and
      system wide support for launching apps based on users choices.
      
      We also are not able to be secure enough to handle this, as we saw in
      the past we allowed untrusted binaries to be launched, and therefore
      we had a CVE (CVE-2017-14604) for Nautilus. We are not being audited
      (afaik) and we are not in a position that we can let this issues slip.
      
      With that altogether, this prevents launching binaries or programs from
      Nautilus.
      
      Closes: #184
      3a22ed5b
    • Carlos Soriano Sánchez's avatar
      83483358
  2. 07 May, 2018 4 commits
    • António Fernandes's avatar
      window: Use our own accelerators API for consistency · 8517d545
      António Fernandes authored
      It's just a wrapper for gtk_application_set_accels_for_action with
      the required type cast. Just a cosmetic change, no behavior change.
      8517d545
    • António Fernandes's avatar
      window: Allow dead_tilde key to trigger location entry · ab16292e
      António Fernandes authored
      The standalone "~" key ("asciitilde") works as a convenient shortcut
      to type home-relative paths into the location entry.
      
      However, some keyboard layouts don't have an standalone "~" key but
      rather a "dead tilde" key. This makes the existing shortcut unavaliable
      for some keyboard layouts.
      
      This is surprising for most people, because they have a tilde key and
      the Keyboard Shortcuts window advertises a shortcut for the tilde key.
      
      So, add the dead tilde key as an alternative shortcut.
      
      Note: Searching for tilded characters or the tilde character itself
      is still possible by revealing the search entry is explicitly.
      
      Fixes GNOME/nautilus#372
      ab16292e
    • António Fernandes's avatar
      operations-ui-manager: Always get dir item count · 47845327
      António Fernandes authored
      When comparing conflicting folders, we provide the item count for each.
      However, sometimes we do not have the directory item count.
      
      Make sure to request the item count before setting the size label.
      
      Fixes #269
      47845327
    • António Fernandes's avatar
      operations-ui-manager: Use better default labels · 328cec78
      António Fernandes authored
      We are showing "(null)" in the conflict dialog.
      Example: GNOME/nautilus#269
      
      Exposes the programming concept of NULL is wrong in itself, and in this
      context it may lead a person to think it means the folder is empty.
      
      Instead, get the strings with good default fallbacks.
      328cec78
  3. 04 May, 2018 1 commit
  4. 03 May, 2018 12 commits
  5. 02 May, 2018 3 commits
  6. 28 Apr, 2018 2 commits
  7. 26 Apr, 2018 1 commit
  8. 24 Apr, 2018 1 commit
  9. 23 Apr, 2018 12 commits
  10. 20 Apr, 2018 1 commit
    • Marco Trevisan's avatar
      window-slot: Clear pending_selection after freeing it · d1547407
      Marco Trevisan authored
      This might not be the case when handling archive files, in fact we were
      freeing the list and assigning it to a new value for non-archive files,
      but in case of archives the list was just freed and the invalid pointer
      kept around, potentially causing a later crash.
      d1547407
  11. 14 Apr, 2018 1 commit