1. 12 Dec, 2018 1 commit
  2. 14 Sep, 2018 1 commit
  3. 12 Sep, 2018 1 commit
  4. 28 Aug, 2018 1 commit
  5. 20 Jul, 2018 4 commits
  6. 19 Jul, 2018 2 commits
  7. 16 Jul, 2018 1 commit
  8. 18 May, 2018 4 commits
  9. 13 May, 2018 1 commit
  10. 04 Apr, 2018 1 commit
    • Alexandru Fazakas's avatar
      test: Add file-utilities unit test · 89e362ae
      Alexandru Fazakas authored
      File utilities operations need to be tested thoroughly everytime
      we make changes to make sure they're fine to use further.
      
      This patch introduces an unit test file for the
      nautilus_file_selection_equal.
      89e362ae
  11. 19 Mar, 2018 1 commit
    • Alexandru Fazakas's avatar
      general: Remove include guards in favor of pragma once · 95ecfc8e
      Alexandru Fazakas authored
      The traditional include guards are not as easy to handle
      and require extra thought into the names.
      
      Pragma once is an easier, more contributor friendly approach.
      
      Closes GNOME/nautilus#294
      
      general: Remove include guards in favor of pragma once
      
      The traditional include guards are not as easy to handle
      and require extra thought into the names.
      
      Pragma once is an easier, more contributor friendly approach.
      
      Closes GNOME/nautilus#294
      95ecfc8e
  12. 16 Mar, 2018 1 commit
  13. 01 Mar, 2018 1 commit
  14. 06 Jan, 2018 1 commit
  15. 05 Jan, 2018 2 commits
  16. 02 Jan, 2018 2 commits
    • Ernestas Kulik's avatar
      build: general cleanups · 983892a6
      Ernestas Kulik authored
      This commit does the following:
        * Canonicalize the style:
          * Use two-space indentations.
          * Un-Autotools-ify option names.
          * Don’t align arguments, simply increase indentation.
          * Don’t add a space before opening parenthesis in calls.
        * Remove unused variables.
        * Remove unused dependencies.
        * Remove config.h.meson.
        * Optimize dependencies.
        * Use disabler functionality for libselinux dependency, to save lines.
      983892a6
    • Ernestas Kulik's avatar
      general: remove desktop support · 74dd9c9f
      Ernestas Kulik authored
      74dd9c9f
  17. 23 Dec, 2017 1 commit
    • Ernestas Kulik's avatar
      file-utilities: rework common prefix computation · 61ac48bd
      Ernestas Kulik authored
      Currently, the process for getting the common prefix of a list of file
      names is a tad too greedy:
          1. Find the common prefix of all the strings.
          2. Strip the extension from the prefix.
          3. Strip trailing punctuation.
      
      Step 2 may strip dots if there’s trailing whitespace and step 3 may
      strip useful punctuation (e.g. parentheses). This commit reworks the
      process as such:
          1. Strip the extension from all the file names.
          2. Find the common prefix of all the strings.
          3. Trim trailing whitespace.
      
      Fixes #174.
      61ac48bd
  18. 17 Aug, 2017 1 commit
  19. 15 Aug, 2017 1 commit
  20. 22 Mar, 2017 1 commit
  21. 24 Feb, 2017 1 commit
  22. 23 Feb, 2017 2 commits
  23. 29 Aug, 2016 2 commits
    • Carlos Soriano Sánchez's avatar
      general: run uncrustify · 52d96054
      Carlos Soriano Sánchez authored
      And make the style of Nautilus the same for all files.
      Hopefully we can fix all the style issues we can find in the next days,
      so expect a little of movement on this.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=770564
      52d96054
    • Carlos Soriano Sánchez's avatar
      general: add uncrustify script · 4cafccd8
      Carlos Soriano Sánchez authored
      The current style of nautilus is rather poor and mixes at least 3
      different code styles.
      
      Specific issues that affect the most common contributors to Nautilus
      performance are:
      - tabs for multiline alignment.
      - mix of tabs and spaces.
      - errors on no braced one liners conditionals.
      - errors on non braced case statements with variable declarations.
      
      So I would say requirements for the style is to address the previous
      issues and also be a well known style. I don't want new contributors
      to see a new style completely different from C books authors.
      
      So far, I found Allman (aka BSD) style which seems the choice of most C
      books authors as far as I can see on internet, and it address the
      previous mentioned issues.
      
      Since uncrustify doesn't support the aligment of parameters we do for
      multiple stars "**", we also added a script made by Sebastian Wilmet
      to align those.
      
      As a matter of practicity I'm going to convert all Nautilus style to
      this one, and if the next person who contributes most on Nautilus has
      a different choice, please feel free to change it to whatever makes your
      performance and your contributors performance the best.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=770564
      4cafccd8
  24. 10 Jul, 2016 2 commits
    • Emmanuele Bassi's avatar
      tests: Fix build failure caused by C99 use · 9b674dc6
      Emmanuele Bassi authored
      Build failure in Continuous:
      
      ../../test/test-file-utilities-get-common-filename-prefix.c: In function
      'test_many_strings':
      ../../test/test-file-utilities-get-common-filename-prefix.c:366:9:
      error: 'for' loop initial declarations are only allowed in C99 or C11
      mode
               for (int i = 0; i < 500; ++i) {
      9b674dc6
    • Neil Herald's avatar
      files-view: change "New Folder /w Selection" to offer a name · ca0e00b6
      Neil Herald authored
      New Folder with Selection currently doesn't offer a folder name. It
      would be better if it suggested a folder name based on the files that
      are selected.
      
      With this change, it now looks for a common filename prefix of the
      selected files, and pre-populates the folder name entry with that. If no
      common prefix is found that is greater than 3 characters long, the
      folder name entry will be left blank.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=747907
      ca0e00b6
  25. 25 Apr, 2016 1 commit
    • Carlos Soriano Sánchez's avatar
      general: merge libnautilus-private to src · 7e24f1b2
      Carlos Soriano Sánchez authored
      And fix make distcheck.
      
      Although libnautilus-private seem self contained, it was actually
      depending on the files on src/ for dnd.
      Not only that, but files in libnautilus-private also were depending on
      dnd files, which you can guess it's wrong.
      
      Before the desktop split, this was working because the files were
      distributed, but now was a problem since we reestructured the code, and
      now nautilus being a library make distcheck stop working.
      
      First solution was try to fix this inter dependency of files, but at
      some point I realized that there was no real point on splitting some of
      those files, because for example, is perfectly fine for dnd to need to
      access the window functions, and it's perfectly fine for the widgets
      in the private library to need to access to all dnd functions.
      
      So seems to me the private library of nautilus is somehow an artificial
      split, which provides more problems than solutions.
      
      We needed libnautilus-private to have a private library that we could
      isolate from extensions, but I don't think it worth given the problems
      it provides, and also, this not so good logical split.
      Right now, since with the desktop split we created a libnautilus to be
      used by the desktop part of nautilus, extensions have access to all
      the API of nautilus. We will think in future how this can be handled if
      we want.
      
      So for now, merge the libnautilus-private into src, and let's rethink
      a better logic to split the code and the private parts of nautilus than
      what we had.
      
      Thanks a lot to Rafael Fonseca for helping in get this done.
      
      https://bugzilla.gnome.org/show_bug.cgi?id=765543
      7e24f1b2
  26. 22 Jul, 2015 1 commit
    • Carlos Soriano Sánchez's avatar
      search: done loading signal only if not restarting engine · ff6ccbaf
      Carlos Soriano Sánchez authored
      It was working as:
      - Search directory starts a new search
      - Search engine starts all search providers, each one in its
      own thread.
      - User changes query
      - Search engine stops all search providers
      - Searchs providers, since they are in its own thread, cancel
      in a unknown time.
      - Search directory starts a new search, even before all providers
      are finished.
      - Search engine is marked as need to restart.
      - Search providers finished.
      - Search engine emits finished signal, since all search providers
      now are stopped.
      - Clients doesn't have a way to know if the engine
      actually finished searching the current search, or the previous
      search that the client asked to stop. That might confuse clients
      if they ask for results.
      - Search engine restart the search providers without noticing the
      client, that thinks that the latest search it started was finished
      already.
      
      So to fix this confusion, only report that the engine actually finished
      if the engine is not going to restart the search providers.
      In this way a client can start a batch of consecutive searches without
      the risk of getting search finished signals from previous searches.
      Clients now will always get the search-finished signal of the
      latest search they started.
      ff6ccbaf
  27. 16 Jul, 2015 1 commit
    • Carlos Soriano Sánchez's avatar
      operations: implement new design · 192d2e2f
      Carlos Soriano Sánchez authored
      Now operations reside in the toolbar, in form of a button with
      a popover. In this way we avoid to have a nautilus window hanging
      around for it.
      When no nautilus window is open, the persistence handlers of nautilus
      are enough. This use a notification if the server supports it or
      a systray icon in case it doesn't.
      192d2e2f
  28. 23 May, 2015 1 commit