Skip to content
Snippets Groups Projects

search-engine-recent: don't ref/unref query added to self

Merged Marco Trevisan requested to merge 3v1n0/nautilus:recent-query-ref-removal into master
All threads resolved!

Since this is already part of the search engine struct, and given that we ref it, there's no point of reffing the query again.

Also not to create a mem-leak when we don't run it.

Edited by Marco Trevisan

Merge request reports

Checking pipeline status.

Approval is optional

Merged by avatar (Jan 6, 2025 1:41pm UTC)

Merge details

  • Changes merged into master with 4c6d4eea.
  • Did not delete the source branch.

Pipeline #34566 passed

Pipeline passed for 4c6d4eea on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User
  • Marco Trevisan added 1 commit

    added 1 commit

    • 140d27d7 - search-engine-recent: remove add hits idle on finalize

    Compare with previous version

  • Marco Trevisan resolved all discussions

    resolved all discussions

  • Ghost User resolved all discussions

    resolved all discussions

  • Ghost User
  • Marco Trevisan resolved all discussions

    resolved all discussions

  • Contributor

    Seems that I can’t rebase your branch, can you do it or enable the option for us to do so, if possible?

  • Marco Trevisan changed the description

    changed the description

  • Marco Trevisan added 4 commits

    added 4 commits

    • dd0e258d - 1 commit from branch GNOME:master
    • 9d16ff2e - search-engine-recent: don't ref/unref query added to self
    • 284c5a86 - search-engine-recent: fix memory leak on short-name result
    • 4c6d4eea - search-engine-recent: remove add hits idle on finalize

    Compare with previous version

  • Author Developer

    Done

  • merged

  • mentioned in issue #680 (closed)

  • Please register or sign in to reply
    Loading