Skip to content

Initial implementation of NautilusNetworkDirectory

António Fernandes requested to merge wip/antoniof/internal-place-file into main

This is a spin-off and prequel of !1406 (merged)

The NautilusNetworkDirectory class has been previously implemented, reviewed and iterated as part of !1406 (merged). But that MR grew too big, so let's try to merge this part first.

In addition to the implementation of NautilusNetworkDirectory previously included in !1406 (merged), this MR brings a novelty: NautilusInternalPlaceFile. This has two purposes:

  • Give basic file attributes, such as display name and type, to internal locations which are not known to GIO/GVfs (starred:///, x-network-view:///). It's similar to, but less specialized than, NautilusSearchDirectoryFile. This removes the need to add special cases for such locations all around.
  • Makes use of the nautilus_file_call_when_ready() mechanism to fix a UI freeze bug in the original implementation

I hope this is linear enough to make for an easy review. The largest commit is identical to the one previously reviewed in the !1406 (merged).

Merge request reports