Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • Files Files
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 400
    • Issues 400
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 60
    • Merge requests 60
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • FilesFiles
  • Merge requests
  • !1007

list-base: Set view longpress to GTK_PHASE_CAPTURE

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Corey Berla requested to merge wip/corey/gesture-fix into master Oct 08, 2022
  • Overview 3
  • Commits 1
  • Pipelines 2
  • Changes 1

There's an issue with how GtkGestureLongPress functions where if the gesture is in phase BUBBLE and another gesture in CAPTURE claims the sequence, the prior LongPress will emit a ::pressed event regardless. More specifically, our code doesn't work because the drag gesture in GtkListBase (which tracks if rubberband should be stopped) prevent events from being sent to our view long press gesture. This makes the background menu pop-up unexpectedly while dragging on a touchscreen.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/corey/gesture-fix