Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • Files Files
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 405
    • Issues 405
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 56
    • Merge requests 56
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • FilesFiles
  • Issues
  • #137

Crash after detaching a tab into a new window

This is a crash reported by @antoniof :

*I accidentaly found the steps to reproduce this crash:

  1. Launch nautilus
  2. Open new tab.
  3. Drag that tab to the headerbar to detach it into a new window.
  4. Close the new window.
  5. At this point any action that triggers a location change will crash nautilus.

The cause are the signal handlers to swap "Reload" and "Stop" in the popover menu of new tab's view, which the original window keeps around even after detaching the tab. When the new window is closed, it tries to remove the signal handler but it's the wrong window so the handler is not found, which is reported in the command line. Later, when the signal is emitted, it will try to update the menu of a view which doesn't exist anymore, crashing nautilus.*

This is from https://bugzilla.gnome.org/show_bug.cgi?id=781991#c1

I first tried to fix Nautilus code to handle this "detaching" use case, but it was more complex than I thought so I'm just proposing a patch that disables tab detaching, as that use case was not expected by Nautilus code (as revealed by the crash). 1.

Edited Nov 25, 2017 by Nelson Ben
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking