1. 29 Jul, 2021 1 commit
  2. 28 Jul, 2021 6 commits
  3. 13 Jul, 2021 1 commit
  4. 12 Jul, 2021 4 commits
  5. 11 Jul, 2021 7 commits
  6. 10 Jul, 2021 2 commits
  7. 09 Jul, 2021 6 commits
  8. 08 Jul, 2021 8 commits
    • António Fernandes's avatar
      files-view: Make override method private · a501aaf4
      António Fernandes authored
      Always call the parent polimorphic method instead.
      a501aaf4
    • António Fernandes's avatar
      view: Use view id macros instead of enum · 1a0096fe
      António Fernandes authored
      The slot.files-view-mode action takes hardcoded id values. This may
      break if the ids enumeration changes.
      
      Instead, let's define the values with a macro which we can stringify.
      While we are at it, drop the unused EMPTY id.
      1a0096fe
    • António Fernandes's avatar
      window-slot: Make back_or_forward() a slot method · e8147de9
      António Fernandes authored
      We define a NautilusWindow method in nauitlus-window-slot.c. That's
      just wrong.
      
      Also, there is no reason for this to be a NautilusWindow method,
      rather than a slot one.
      
      The only consumers are NautilusWindow and NautilusToolbar, and both
      have a pointer to the current slot, so let's make this a slot method.
      
      For convenience, also add a private NautilusWindow wrapper method.
      e8147de9
    • António Fernandes's avatar
      window-slot: Make type final · 96f989f3
      António Fernandes authored
      Last commit removed the only subclass because switching slot class is
      problematic, so we probably don't want to do it again.
      
      This partially reverts 0a512d00
      96f989f3
    • António Fernandes's avatar
      window-slot: Drop other-locations subclass · ad41d6f6
      António Fernandes authored
      The NautilusOtherLocationsWindowSlot subclass has been introduced along
      with its sibling NautilusDesktopWindowSlot.[0]
      
      However, the desktop one is now gone, and this is the only subclass.
      It does only 2 things differently from its parent class:
      
        * Creates a NautilusPlacesView instead of a NautilusFilesView
        * Disables the slot.files-view-mode-toggle and files-view-mode actions
      
      There is little reason not to handle both things in the parent class.
      Also, changing slots when going in and out of the Other Locations place
      throws away the navigation data; while this can be worked around by
      saving and restoring this data, this outweights any potential benefits
      of subclassing.
      
      This commit is equivalent to reverting [0], but due to code style and
      other changes, a clean revert was not possible.
      
      Effectively fixes #32
      
      [0] commit 5f295bd9
      ad41d6f6
    • Ernestas Kulik's avatar
      window-slot: Stop using flags parameter for history navigation · b8ab8514
      Ernestas Kulik authored
      The feature that allows opening a new window from the history popup menu
      by middle-clicking hasn’t been working for three years, since the flags
      parameter in nautilus_window_back_or_forward() is not honored. In some
      places it’s used inappropriately, so it’s better to just drop the code
      and rethink the approach if such a feature is desirable.
      b8ab8514
    • António Fernandes's avatar
      Revert "window, window-slot: Save and restore navigation history" · 9a86aa22
      António Fernandes authored
      This reverts commit 691f1cf1.
      
      It's a solid workaround, but we are going to fix the root issue.
      9a86aa22
    • Rodrigo Pedro's avatar
      toolbar: Prevent closing popover when "Show Hidden Files" is toggled · bf7b487e
      Rodrigo Pedro authored
      When the "Show Hidden Files" check button is toggled, the popover is closed,
      however, when the "Show Sidebar" check button is toggled, the popover stays
      opened. This is inconsistent and the popover should stay open in all cases.
      This happens because of a bug in the `nautilus_toolbar_is_menu_visible`
      function implementation, which is checking the visibility of the `view_button`
      popover instead of the `app_menu` popover. Let's check the visibility of the
      correct popover to fix this inconsistency.
      
      Fixes: #1827
      bf7b487e
  9. 05 Jul, 2021 1 commit
  10. 04 Jul, 2021 1 commit
  11. 02 Jul, 2021 2 commits
    • António Fernandes's avatar
      Revert "window: add a signal to receive active selection updates" · 1c88f37d
      António Fernandes authored
      This reverts commit 54d1ad25.
      
      This signal has been added because NautilusApplication needed to update
      the previewer when selection changes. It no longer does that, since the
      previous commit, so this signal is no longer needed.
      1c88f37d
    • António Fernandes's avatar
      application: Hand preview updating over to FilesView · ae67618b
      António Fernandes authored
      When the NautilusFilesView:selection property changes, this change is
      notified to the slot, the the window, then the application, though a
      chain of bindings and singals. The application class then calls a
      NautilusFilesView method to actually update the preview.
      
      The NautilusApplication class used to update the preview when the
      active window changes, but that's no longer the case after the changes
      in commit 0b7a7f95.
      
      This whole roadtrip to NautilusApplication and back is useless now, so
      let's handle it all in NautilusFilesView.
      ae67618b
  12. 01 Jul, 2021 1 commit