Comparison is always false because positions >= 1

Makes comparison redundant

(cherry picked from commit e451d208)

(cherry picked from commit e4988760)

Currently, the tooltip says 'Toggle view', which isn't clear.

Usability testers had difficulty finding out how to change between
list and grid view.

Change tooltip to say 'Show list' or 'Show grid', depending on which
view it can change to.

Fixes: #893

The pipeline status badge has a broken image and the coverage badge
shows just "unknown". This is because the pipeline image has been
renamed by GitLab and the coverage is not computed since the commit
a5a405d6. Let's fix the pipeline image filename and remove coverage
badge as it is useless.

(cherry picked from commit e8ace5ec)

We hide the pathbar background when the window so small that the
pathbar is no longer centered. This was introduced to make the
pathbar flat.

However, now that the pathbar is buttonized again, it doesn't make it
flat, so there is no point. The transformation is only a distraction.
Furthermore, it is prone to styling glitches.

So, give up on the transformation and always have a pathbar background,
effectively reverting commit 080400bd

Fixes: #907

Nautilus is supposed to clear items in the clipboard in case when
items moved by drag-and-drop were were present in the clipboard.

However, the item URI collision check algorithm compares moved (or copied)
items with themselves instead of clipboard contents, resulting in the
clipboard being cleared on every drag-and-drop operation.

Fix the algorithm to address this issue.

Closes: #1235

The hidden files can now be used as templates since commit 967b9d7c.

This change also caused that also hidden directories and their content
is offered in the "New Document" right click menu. This change was not
intentional and causes issues when for example git is used to manage the
templates as the while .git file tree is offered there.

The similar issue can happen also with some hidden files like .gitignore,
but there is not much we can do with it.

Let's ignore the hidden directories as a compromise.

Fixes: #1413

Ctrl+M and Ctrl+shift+M are used to create a link to, respectively,
a copied item or a selected item.

But they were not exposed in the Keyboard Shortcuts dialog.

Add them to the Editing section. Also move Undo/Redo to the General
section, to prevent the Editing section from making the dialog too tall

Related to GNOME/nautilus#1373

The current location menu in the pathbar has been introduced as an
alternative to the background context menu.

But we have been building them from separate resources. As a result,
we have have had menu items in one menu but missing in the other, and
the ordering of items and sections has been insonsistent.

To ensure consistency, build the current location menu from the same
resource as the the background context menu. This also introduces the
"Create Link" action to the current location menu, which was missing.

To be consistent with other menus.

This makes the background context menu consistent with the pathbar's
current location menu and improves discoverability.

Closes #1015

(cherry picked from commit 5ef6c3da)

(cherry picked from commit 3f1c5cf5)

(cherry picked from commit edcc92fd)

The view exports the background extensions and templates menu models for
consumption by the pathbar. They are exported as GMenu.

However, the consumer is not supposed to modify the menu, which is what
the GMenu API is for. Also, it needs to cast to GMenuModel everytime.

To make this clearer and cleaner, cast to GMenuModel at the point when
the GMenu API is not going to be used anymore.

We don't need to anymore. Also, we are leaking them.

Everytime there is a signal that the templates submenu or the extension
menu items may have changed, we rebuild the whole menu anew.

This is uncessary work and results in visible glitches, for instance
when thumbnails are still loading.

So, reset only the tumbnails submenu or extension submenu instead.

Fixes: #1068

We have been iterating on menu items to match a custom attribute, "id",
in order to programatically add items to submenus and sections.

But GtkBuilder can get us the submenus and sections by actual id.

So take advantage of that and use the GMenu/GMenuModel API in a more
direct fashion.

(cherry picked from commit 9770cc36)

Pipeline failed.

Cause: invalid URLs resulting from faulty select-copy-paste operation.

We've pinned to specific versions, because their
git master branches have API-breaking changes.

Instead, let's follow from the tracker[-miners]-2.3 branches, where 
the stable API is still maintained.

Marks 'Empty Trash' and 'Delete All' buttons as destructive actions
which have special appearance making them consistent with other
destructive actions.

Fixes #969

It’s been added to shared-mime-info alongside `x-content/unix-software`:
https://gitlab.freedesktop.org/xdg/shared-mime-info/merge_requests/22.

This tweaks the existing string, and adds a new string, to differentiate
the two, since `x-content/unix-software` typically refers to executables
on a USB stick, ready to run. `x-content/ostree-repository` typically
refers to flatpak apps or OS updates on a USB stick ready to install
from there onto your system.
Signed-off-by: Philip Withnall <withnall@endlessm.com>

The flatpak devel job uses .pre stage currently.

This seems to be the reason why pipelines are not triggered in some
cases according: https://gitlab.com/gitlab-org/gitlab/issues/198518.

Let's use the unused test stage instead to fix the pipeline and to make
the pipeline output nicer.

We consistently forget to update it when releasing.
The intention was good, but this is hard to maintain.

File creation mask should be honored when creating new files from
templates as it is when creating new folders, or dragging raw data. But
it is not because G_FILE_COPY_NONE flag is specified when creating new
files from templates. Let's use G_FILE_COPY_TARGET_DEFAULT_PERMS flag
to ensure that file creation mask is honored in this case as well.

Just note that this behavior is not wanted when copying in general
(although it is also honored by "cp" cmd in this case) as it might have
some unexpected consequences as discussed on:
https://bugzilla.gnome.org/show_bug.cgi?id=167102