1. 07 Feb, 2023 3 commits
    • António Fernandes's avatar
      ci: Prefer the json manifest · 9c9b51ad
      António Fernandes authored and Ondrej Holy's avatar Ondrej Holy committed
      This is what Builder uses.
      9c9b51ad
    • António Fernandes's avatar
      flatpak: Remove YAML manifest · 0f116a2d
      António Fernandes authored and Ondrej Holy's avatar Ondrej Holy committed
      It's been added expecting Builder would support it, such that we could
      drop the JSON manifest. 3b8f2386
      
      But it didn't happen so far gnome-builder#520
      
      Since then we have been maintaining both files in sync, which is a waste
      of effort at best, and a risk of the product of each manifest becoming
      different, at worst.
      
      Now that the CI uses the JSON manifest, we can just drop the YAML one.
      0f116a2d
    • Ondrej Holy's avatar
      flatpak: Use -Dbattery_detection=none for tracker-miners · e9308d4a
      Ondrej Holy authored
      The flatpak jobs are broken currently, because the tracker-miners project
      fails to build due to missing upower-glib depenedency. It is used to tweak
      the behavior when running on battery. It used to be automatically disabled
      until the following MR:
      !1121. I suppose
      it is safe to disable this functionality as our flatpak isn't meant for
      production. Let's explicitely disable that to fix our pipeline.
      
      
      (cherry picked from commit 1569af12)
      e9308d4a
  2. 06 Feb, 2023 1 commit
    • Ondrej Holy's avatar
      file-operations: Fix inverted g_assert condition · a8d8e2dd
      Ondrej Holy authored and Corey Berla's avatar Corey Berla committed
      The commit e2969a9c introduced an assertion
      statement to ensure that the `g_file_get_basename` returned non-NULL string.
      Unfortunately, the assertion has an inverted condition. This leads to crashes
      in the `get_unique_target_file` function for files that don't have the
      `edit-name` attribute set (i.e just a few GVfs backends). Let's fix the
      inverted condition.
      
      Fixes: #2825
      a8d8e2dd
  3. 24 Jan, 2023 1 commit
  4. 23 Jan, 2023 1 commit
  5. 20 Jan, 2023 1 commit
  6. 19 Jan, 2023 1 commit
  7. 13 Jan, 2023 1 commit
    • Athul Iddya's avatar
      grid-cell: Set tooltip values using text, not markup · 76aa1218
      Athul Iddya authored and António Fernandes's avatar António Fernandes committed
      Tooltips are not showing up for long file names that have Pango markup
      characters. This is happening because the cell widget label is set using
      `set_text`, but is retrieved in the `query-tooltip` signal handler using
      `get_label`. While `get_label` can return Pango markup, it is not
      guaranteed to return text with markup characters escaped. Avoid this
      problem by fetching the file name from label and setting tooltip using
      text.
      
      
      (cherry picked from commit 60bd0613)
      76aa1218
  8. 10 Jan, 2023 4 commits
  9. 08 Jan, 2023 3 commits
    • António Fernandes's avatar
      Release version 43.2 · 506477f4
      António Fernandes authored
      506477f4
    • António Fernandes's avatar
      grid-cell, name-cell: Don't add missing emblems · 049bfe97
      António Fernandes authored
      In version 42, we relied on GTK 3's support for GEmblemedIcon to draw
      emblems. It would implicitly skip any emblem name for which there was
      no available icon:
      
      gtk/gtkicontheme.c:
      ```
      emblem_info = gtk_icon_theme_lookup_by_gicon_for_scale (icon_theme, emblem, size / 2, scale, flags | GTK_ICON_LOOKUP_FORCE_SIZE);
      if (emblem_info)
        info->emblem_infos = g_slist_prepend (info->emblem_infos, emblem_info);
      ```
      
      But GTK 4 dropped support for GEmblemedIcon, so now we use one GtkImage
      for each emblem. But we don't skip name for which no icon is installed.
      Instead, GTK displays the missing image icon.
      
      Let's check whether the emblem icon is available in the current theme
      before creating a GtkImage.
      
      
      (cherry picked from commit c1da92ba)
      049bfe97
    • António Fernandes's avatar
      grid-cell: Show tooltip for ellipsized names · c0653d53
      António Fernandes authored
      The old canvas expanded filename over the next row when the item was
      selected. This is impossible to replicate in GtkGridView due to the
      next row getting drawn after (== on top of) the previous one.
      
      This is perceived as a feature regression. So, let's aleviate it
      using tooltips when the filename is ellipsized.
      
      
      (cherry picked from commit beeb2da9)
      c0653d53
  10. 06 Jan, 2023 24 commits