GitLab

António Fernandes authored Jul 11, 2021 and António Fernandes committed Jul 11, 2021

There are a few non-braced single-statement in the final cases, which
have  gone unnoticed until detected by a recent uncrustify update.

Let's add the missing braces around single-statements even if it's the
last case.

Make use of GLib's new g_clear_signal_handler() function to simplify nautilus'
signal handler disconnection and reduce unneccessary code.

Fixes: #1522

Ondrej Holy authored Feb 13, 2020 and António Fernandes committed Apr 05, 2020

There are some style issue since the last run. Let's run it again
before enabling style-check CI job.

Vilhelm Prytz authored Mar 29, 2020 and António Fernandes committed Mar 29, 2020

Comparison is always false because positions >= 1

Makes comparison redundant

gdk/gdkprivate.h is no longer a thing in GTK+ 4 and doesn’t seem to be
at all required.

Shadowing variables is error-prone, since one might mean to refer to a
variable that was declared earlier, but has the same name. Additionally,
being more strict about variable scoping can help make the code more
readable.

Additionally, this commit makes some unused public functions static.

https://bugzilla.gnome.org/show_bug.cgi?id=770564

And make the style of Nautilus the same for all files.
Hopefully we can fix all the style issues we can find in the next days,
so expect a little of movement on this.

https://bugzilla.gnome.org/show_bug.cgi?id=770564

AtkComponentIface's {add,remove}_focus_handler should not be overridden,
since ATK 2.9.4, as atk_component_{add,remove}_focus_handler() are
deprecated.

This commit removes deprecated virtual function overrides.

https://bugzilla.gnome.org/show_bug.cgi?id=762236

Some GdkDisplay operations have been deprecated in GDK 3.20.

This commit replaces the deprecated code in eel_canvas_item_grab() and
eel_canvas_item_ungrab() functions with new GdkSeat operations.

https://bugzilla.gnome.org/show_bug.cgi?id=762235

Vim and emacs modelines are used to specify some of the code style in the code.
However, this is misleading and poorly supported since nautilus had a mix of
code style for some time.
Also, the mode lines doesn't specify the whole code style, so we will need to
use a different tool as well to specify the whole code style.
For that, we can just use a different tool for everything.

So remove the mode lines, and in a short future we will reestyle the nautilus
code to have a single code style, and use a tool like editorconfig to specify
the whole code style.

This seems no longer necessary. It looks like it was done to avoid
flashing when redrawing, but probably this was fixed sometime in the
past, so a transparent background in a widget doesn't flash anymore.

https://bugzilla.gnome.org/show_bug.cgi?id=761965

We need to not modify the cairo_t when we propagate up to the parent class
as this affects where GtkLayout draws the child widgets.

https://bugzilla.gnome.org/show_bug.cgi?id=705464

ignore the new current item just because the mouse is down. It is
later used for right click.

Fixes bgo #704289.

Code here is not doing what the comment (and the symmetric part in
the RELEASE case) says.

https://bugzilla.gnome.org/show_bug.cgi?id=688281

https://bugzilla.gnome.org/show_bug.cgi?id=692234

Removes tons of boilerplate code not needed anymore.

Since we don't ever call gdk_threads_init()

Use the function equivalents.

Clean up a11y code and make sure inheritance for
EelCanvasAccessible->NautilusIconContainerAccessible and for
EelCanvasItemAccessible->NautilusIconCanvasItemAccessible work properly.
This makes the ATK state machinery in EelCanvasItemAccessible work
again, which fixes

https://bugzilla.gnome.org/show_bug.cgi?id=677509

Nelson Ben authored Mar 29, 2012 and Nelson Ben committed Apr 04, 2012

Ignore button press/release events for mouse buttons greater
than 5 so allowing forward and backward mouse buttons to work
over icons.

Part of bug 660006
Signed-off-by: Nelson Benitez Leon <nbenitezl@gmail.com>

Carlos Garnacho authored Jan 12, 2012 and Cosimo Cecchi committed Jan 16, 2012

Not queueing resizes may play oddly with the size request caches in
GTK+, resulting in gtk_widget_get_preferred_width/height returning
0 even after the canvas was populated.

https://bugzilla.gnome.org/show_bug.cgi?id=667831

Mike Gorse authored Sep 16, 2011 and Cosimo Cecchi committed Sep 19, 2011

The code to derive the EelCanvasAccessible class no longer works as of
gtk+ 3.1.9.  Currently the recommended behavior is to derive from
GtkAccessible.

Also, canvas items should send object:state-changed:selected events when
selected and unselected; otherwise AT-SPI will not update its cache.

https://bugzilla.gnome.org/show_bug.cgi?id=650897

GCC 4.6 introduced a new warning about variables declared and
initialized, but not really used in the function body. Remove all of
these occurrences to build cleanly.

$ pkg-config --cflags cairo-gobject
-pthread -I/src/build/jhbuild/include/cairo
$ ls /src/build/jhbuild/include/cairo/cairo-gobject.h
/src/build/jhbuild/include/cairo/cairo-gobject.h

That's just confusing.

This implies adding a 'destroy' signal to EelCanvasItem, with similar
semantics to gtk_object_destroy()