1. 07 Apr, 2000 5 commits
    • Andy Hertzfeld's avatar
      made configuration update make HTTP request and check errors; also added · fc19e85b
      Andy Hertzfeld authored
      
      
      	made configuration update make HTTP request and check errors; also
      	added stub overview page and minor cleanups
      fc19e85b
    • Pavel Cisler's avatar
      More file operation stuff. · 930655a1
      Pavel Cisler authored
      
      
      2000-04-06  Pavel Cisler <pavel@eazel.com>
      	More file operation stuff.
      930655a1
    • Andy Hertzfeld's avatar
      more work to polish registration and substantially implement configuration · 4c0591ba
      Andy Hertzfeld authored
      
             more work to polish registration and substantially implement
             configuration uploading, plus misc cleanups
      4c0591ba
    • John Sullivan's avatar
      Finished task 376 (Resolve list-view single-click behavior) · cb19a969
      John Sullivan authored
      	* libnautilus/nautilus-gdk-extensions.h:
      	#defines for colors NAUTILUS_RGB_COLOR_RED, _GREEN,
      	_BLUE, _WHITE, and _BLACK.
      	* libnautilus/nautilus-gdk-extensions.c:
      	(nautilus_parse_rgb_with_white_default): Replaced
      	hard-wired numbers with these #defines.
      
      	* libnautilus/nautilus-list.h,
      	* libnautilus/nautilus-list.c:
      	added enum entry for NAUTILUS_CELL_LINK_TEXT;
      	(nautilus_list_mark_cell_as_link): New functions, converts
      	an ordinary text cell into a link-text cell.
      	(nautilus_list_button_release): Only activate link-text
      	cells on single click; other cells select as in other lists.
      	(draw_row): draw link-text cells with blue text and an
      	underline, so they look like typical web links.
      	(nautilus_list_set_cell_contents): Convert link-text cell
      	back to ordinary text cell before cleaning up old
      	contents so parent function will do the right thing.
      
      	* src/file-manager/fm-list-view.c:
      	(add_to_list): mark file name cell as link-text cell.
      	(remove_from_list): New function, extracted from...
      	(fm_list_view_file_changed): Followed Darin's advice on
      	how to simultaneously clarify this code and fix a
      	storage leak.
      
      	For Darin, fixed a typo that caused every file to be
      	displayed as if it were a directory.
      
      	* src/ntl-uri-map.c:
      	(my_notify_when_ready): Added two missing "== 0"s.
      cb19a969
    • Maciej Stachowiak's avatar
      Add a boolean field have_pending_uris_selected to distinguish the case · c564c602
      Maciej Stachowiak authored
      	* src/file-manager/fm-directory-view.c
      	(notify_selection_change_cb, display_pending_files): Add a boolean
      	field have_pending_uris_selected to distinguish the case where we
      	have _no_ pending selection from the case where we have an empty
      	one (in both cases, the pending_uris_selected field should be
      	NULL).
      c564c602
  2. 06 Apr, 2000 6 commits
    • Darin Adler's avatar
      Added the hooks needed to make metafile reading asynchronous. · 1ae3a242
      Darin Adler authored
      	Next I'll change the actual metafile access to work that way.
      
      	* libnautilus/nautilus-directory.h:
      	* libnautilus/nautilus-directory.c:
      	(nautilus_directory_metadata_call_when_ready): Added function
      	that requests a read of some metadata and calls back when the
      	data is ready.
      
      	* src/ntl-app.c: (nautilus_app_startup): Got rid of call to
      	nautilus_navinfo_init.
      
      	* src/ntl-types.h: Moved the NautilusNavigationInfo struct
      	and related defines to ntl-uri-map.h.
      
      	* src/ntl-uri-map.h:
      	* src/ntl-uri-map.c:
      	Reformatted and changed the names of many functions.
      	Added code to use the new metadata callback.
      
      	* src/ntl-index-panel.c:
      	* src/ntl-main.c:
      	* src/ntl-view.h:
      	* src/ntl-window-msgs.c:
      	* src/ntl-window.c:
      	* src/ntl-window.h:
      	Had to change includes a bit because of my changes to what
      	header files are including.
      
      	* src/ntl-window-msgs.c: (nautilus_window_update_state):
      	* src/ntl-window.h:
      	Use the new nautilus_navigation_info_cancel call instead of
      	reaching right in to cancel the underlying call.
      
      	* src/ntl-view-private.h:
      	Reformatting.
      1ae3a242
    • Darin Adler's avatar
      Fixed code that was trying to disconnect the handler from the new · 50206e4a
      Darin Adler authored
      	* libnautilus/nautilus-directory-background.c:
      	(nautilus_connect_background_to_directory_metadata):
      	Fixed code that was trying to disconnect the handler from the
      	new directory, not the old one.
      50206e4a
    • John Sullivan's avatar
      Only call nautilus_file_unref if the file isn't gone. This cures some · 304eeb46
      John Sullivan authored
      	* src/file-manager/fm-list-view.c:
      	(fm_list_view_file_changed): Only call nautilus_file_unref if
      	the file isn't gone. This cures some GTK-CRITICALS I ran into.
      
      	* src/file-manager/fm-properties-window.c:
      	(name_field_update): Renamed to name_field_update_to_match_file;
      	handle case where file name was changed elsewhere.
      	(create_properties_window): Hook up name_field_update_to_match_file
      	to get called when file changes externally.
      	(remove_properties_window_from_hash_table): New function.
      	(fm_properties_window_get_or_create): Use hash table so there's
      	only one Properties window per file. This was intended to be the
      	design but we forgot to implement it earlier.
      304eeb46
    • Andy Hertzfeld's avatar
      made registration invoke the service cgi and give appropriate error · ea34d463
      Andy Hertzfeld authored
      
              made registration invoke the service cgi and give appropriate error
      	feedback or move on to the configuration step.  Made it disable the
      	registration button unless something is typed into each of the 3 fields
      ea34d463
    • John Sullivan's avatar
      Fixed bug 394 (clicking Home button segfaults) · af03941b
      John Sullivan authored
      	* src/ntl-window-msgs.c: (nautilus_window_update_internals):
      	Don't update Back list when the location hasn't actually
      	changed, since (A) it would be silly and (B) the code that
      	sets up last_location_bookmark and current_location_bookmark
      	doesn't work right if you do.
      af03941b
    • John Sullivan's avatar
      Some cleanups from the file-renaming checkin I did · 5f2f9cb9
      John Sullivan authored
      	yesterday. The largest change was making NautilusDirectory
      	send "files-changed" signal instead of "files-removed"
      	signal when a file is removed. That way	interested callers
      	need register only for one signal. The callers can use
      	nautilus_file_is_gone () to test whether the file was removed.
      
      	* libnautilus/nautilus-directory-private.h:
      	(nautilus_directory_files_removed): Removed function.
      	* libnautilus/nautilus-directory.h:
      	(files_removed): Removed signal definition, updated comments.
      	* libnautilus/nautilus-directory.c:
      	Removed FILES_REMOVED signal enum entry;
      	(nautilus_directory_initialize_class): Removed FILES_REMOVED
      	signal creation.
      	(nautilus_directory_files_removed): Removed function.
      	* libnautilus/nautilus-file.c:
      	(get_file_for_parent_directory): New private function.
      	(nautilus_file_can_rename): This function was quite broken in
      	its initial check-in. It worked only on a random basis. Now it
      	works quite a bit better. It should only return FALSE if it's
      	darn well sure that the user can't rename the file; it returns
      	TRUE even if it isn't sure, so clients must handle failed
      	renames (which they would have to anyway).
      	(nautilus_file_delete): Call nautilus_file_changed instead of
      	nautilus_directory_files_removed when file is deleted.
      
      	* src/file-manager/fm-directory-view.h:
      	(remove_file): Remove signal definition, update comments.
      	* src/file-manager/fm-directory-view.c:
      	remove REMOVE_FILE signal enum entry;
      	remove files_removed_handler_id and pending_files_removed from
      	Details struct;
      	(fm_directory_view_initialize_class): remove REMOVE_FILE signal
      	initialization
      	(display_pending_files): remove "removed" case; made "changed"
      	case handle updating uri table; made "changed" case send signal
      	even if file is gone.
      	(files_removed_cb): Removed function.
      	(fm_directory_view_load_uri): removed connection to "files_removed"
      	signal
      	(disconnect_model_handlers): removed disconnect of files_removed_handler.
      
      	* src/file-manager/fm-icon-view.c:
      	(fm_icon_view_remove_file): Removed function.
      	(fm_icon_view_initialize_class): Remove remove_file signal handler override.
      	(fm_icon_view_file_changed): check if file is gone and do what
      	fm_icon_view_remove_file used to do if so.
      	* src/file-manager/fm-list-view.c:
      	(fm_list_view_remove_file): Removed function.
      	(fm_list_view_initialize_class): Remove remove_file signal handler override.
      	(fm_list_view_file_changed): check if file is gone and do what
      	fm_list_view_remove_file used to do if so.
      
      	* src/file-manager/fm-properties-window.c:
      	(properties_window_file_changed_callback): Don't update the window title
      	if you just nuked the window -- Doh! Now the Properties window will
      	vanish silently if the file is deleted.
      5f2f9cb9
  3. 05 Apr, 2000 11 commits
    • Darin Adler's avatar
      Improved the background handling code so more is shared. · e4d81832
      Darin Adler authored
      	There's even more we could do in this direction.
      
      	* components/music/nautilus-music-view.c:
      	(nautilus_music_view_initialize): Got rid of redundant background
      	color initialization.
      	(nautilus_music_view_realize): Got rid of background color
      	initialization.
      	(nautilus_music_view_update_from_uri): Changed background color
      	handling to use new nautilus_directory_background calls.
      	(nautilus_music_view_background_changed): Not needed any more.
      
      	* components/notes/ntl-notes.c:
      	Did some cleanup and reformatting.
      
      	* libnautilus/Makefile.am:
      	* libnautilus/nautilus-directory-background.c:
      	* libnautilus/nautilus-directory-background.h:
      	Created a new file with functions that manage the background for
      	a window connected with a particular directory. Later we might
      	generalize it further to work for windows that are connected to
      	any URI, not just a directory.
      
      	* libnautilus/nautilus-directory.c:
      	* libnautilus/nautilus-directory.h:
      	Added a new "metdata_changed" signal so that the background can
      	be updated if the underlying data changes.
      	(nautilus_directory_initialize_class): Create the new signal.
      	(nautilus_directory_ref), (nautilus_directory_unref): Made these
      	functions quietly do nothing for NULL. This simplifies life for
      	callers.
      	(nautilus_directory_set_metadata): Emit the "metadata_changed"
      	signal.
      
      	* libnautilus/nautilus-file.c:
      	(nautilus_file_ref), (nautilus_file_unref): Made these
      	functions quietly do nothing for NULL. This simplifies life for
      	callers.
      
      	* libnautilus/nautilus-metadata.h:
      	Renamed all the constants to be consistent. Got rid of separate
      	constants for the icon view and list view backgrounds. Changed
      	some of the underlying XML tags as well.
      
      	* libnautilus/nautilus-icon-factory.c:
      	(nautilus_icon_factory_get_icon_for_file):
      	* src/nautilus-index-title.c: (nautilus_index_title_update_info):
      	* src/ntl-index-panel: (nautilus_index_panel_update_info),
      	(receive_dropped_uri_list),
      	(nautilus_index_panel_background_changed):
      	* src/ntl-uri-map.c: (set_initial_content_iid),
      	(add_components_from_metadata):
      	* src/ntl-window-msgs.c: (view_menu_switch_views_cb):
      	* src/file-manager/fm-icon-view.c: (add_icon_if_already_positioned),
      	(fm_icon_view_begin_loading), (fm_icon_view_set_zoom_level),
      	(fm_icon_view_icon_changed_callback):
      	* src/file-manager/fm-list-view.c: (fm_list_view_begin_loading),
      	(fm_list_view_set_zoom_level), (fm_list_view_sort_items):
      	Updated uses of metadata constants to use the new names.
      
      	* src/ntl-index-panel: (nautilus_index_panel_destroy),
      	(nautilus_index_panel_update_info):
      	* src/ntl-uri-map.c: (add_components_from_metadata):
      	* src/file-manager/fm-directory-view.c:
      	(fm_directory_view_destroy), (fm_directory_view_load_uri):
      	Used new nautilus_directory_unref to simplify code.
      
      	* src/ntl-uri-map.c: (set_initial_content_iid):
      	* src/ntl-window-msgs.c: (view_menu_switch_views_cb):
      	Added missing nautilus_directory_unref (storage leak).
      
      	* src/file-manager/fm-icon-view.c: (create_icon_container),
      	(fm_icon_view_background_changed_callback): Removed "changed"
      	signal handler on NautilusBackground since that's now handled
      	by the new nautilus_directory_background calls instead.
      	(fm_icon_view_begin_loading): Used nautilus_directory_background
      	to replace background customization code.
      
      	* src/file-manager/fm-icon-view.c: (fm_icon_view_get_zoom_level):
      	Fixed a bug where it would try to use view as an FMIconView after
      	the FM_IS_ICON_VIEW check failed.
      
      	* src/file-manager/fm-list-view.c: (create_list),
      	(fm_list_view_background_changed_callback): Removed "changed"
      	signal handler on NautilusBackground since that's now handled
      	by the new nautilus_directory_background calls instead.
      	(fm_list_view_begin_loading): Used nautilus_directory_background
      	to replace background customization code.
      e4d81832
    • John Sullivan's avatar
      Fixed bug in Ramiro's recent checkin that broke booting · c7c50ad5
      John Sullivan authored
      	if the icon theme had never been set.
      
      	* libnautilus/nautilus-icon-factory.c:
      	(nautilus_icon_factory_initialize_class),
      	(nautilus_get_current_icon_factory): Moved theme initialization
      	from the former to the latter, because theme needs to be non-NULL
      	before initialize_class is called.
      c7c50ad5
    • Darin Adler's avatar
      Removed some unnecessary \n from g_errors. · 459883de
      Darin Adler authored
      	* components/services/startup/eazel-register.c:
      	(add_package_info):
      	* libnautilus/nautilus-file-utilities.c:
      	(nautilus_user_top_directory):
      	* libnautilus/nautilus-global_preferences.c:
      	(global_preferences_get_dialog):
      	* libnautilus/nautilus-icon-factory.c:
      	(nautilus_icon_factory_get_thumbnail_uri):
      	Removed unnecessary \n characters from g_warning, g_error, and
      	g_message calls.
      
      	* components/html/ntl-web-browser.c (browser_url_load_done):
      	Ettore says we should stop calling gtk_html_private_calc_scrollbars
      	and if it causes any problems then it's just a bug in GtkHTML
      	that should be fixed,.
      
      	* src/ntl-window-msgs.c:
      	Reformatted the code as a first step for some changes
      	that will make the state machine easier to understand.
      459883de
    • Darin Adler's avatar
      Removed some unnecessary \n from g_errors. · 4114cee0
      Darin Adler authored
      4114cee0
    • Ramiro Estrugo's avatar
      Preferences work. Make preference registration implicit. Update code that · ee95ca88
      Ramiro Estrugo authored
      required preferences to be explicitly registered before using them.
      ee95ca88
    • Andy Hertzfeld's avatar
      made the register command make an http request to the service · c34c6f30
      Andy Hertzfeld authored
      
             made the register command make an http request to the service
      c34c6f30
    • Maciej Stachowiak's avatar
      Make selection persistent across content view changes (task 105). · 491e5af1
      Maciej Stachowiak authored
      	* src/file-manager/fm-directory-view.c,
      	src/file-manager/fm-directory-view.h
      	(fm_directory_view_set_selection): New function.
      	(set_selection): New virtual method that must by implemented by
      	subclasses.
      	(add_nautilus_file_to_uri_map, remove_nautilus_file_from_uri_map,
      	free_file_by_uri_map_entry, free_file_by_uri_map): New functions
      	to manage a hash table mapping from uri strings to NautilusFile
      	objects.
      	(notify_selection_change_cb): New function; on a selection change
      	notification, either set the selection immediately if the view has
      	completed loading, or establish it as pending.
      	(display_pending_files): Maintain the uri -> file hash table on
      	notifications from the model; do any pending selections required
      	when loading completes.
      
      	* src/file-manager/fm-list-view.c (fm_list_view_set_selection):
      	New function to implement `set_selection' virtual method.
      
      	* src/file-manager/fm-icon-view.c (fm_icon_view_set_selection):
      	New function to implement `set_selection' virtual method.
      
      	* libnautilus/nautilus-list.c (nautilus_list_set_selection): New
      	function: set the selection to a specified set of rows.
      
      	* libnautilus/nautilus-icon-container.c,
      	libnautilus/nautilus-icon-container.h
      	(nautilus_icon_container_set_selection): New function: set the
      	selection to a specified set of icons.
      491e5af1
    • Andy Hertzfeld's avatar
      misc small changes to the service registration form · 4dfef36f
      Andy Hertzfeld authored
      
            misc small changes to the service registration form
      4dfef36f
    • Ramiro Estrugo's avatar
      Fix cast for stricter -Werror compliance. · f21899ed
      Ramiro Estrugo authored
      f21899ed
    • Darin Adler's avatar
      Finished task 54 (Set background image by drag/drop). · cd9618f0
      Darin Adler authored
      	Fixed bug 346 (Bad icon positions when you change user level).
      	Fixed bug 372 (Better icons for common file types).
      
      	* libnautilus/nautilus-background-canvas-group.c:
      	(nautilus_background_canvas_group_draw): Got rid of the colormap
      	which is not needed now that we use gtk_rgb instead of gtk_color
      	calls. Passed in the corner of the canvas as a parameter to
      	nautilus_background_draw so it knows where the origin of any
      	repeating pattern should be.
      	* libnautilus/nautilus-background.h:
      	* libnautilus/nautilus-background.c: (nautilus_background_draw):
      	Added parameters to determine where the origin of any repeating
      	pattern should be. Removed colormap parameter (see above).
      	(nautilus_background_draw_flat_box): Passed in origin parameters
      	in call to nautilus_background_draw.
      	* libnautilus/nautilus-gdk-extensions.h:
      	* libnautilus/nautilus-gdk-extensions.c:
      	(nautilus_fill_rectangle_with_gradient): Removed colormap
      	parameter (see above).
      	* libnautilus/nautilus-gdk-pixbuf-extensions.c:
      	(nautilus_gdk_pixbuf_render_to_drawable_tiled): Fixed the tiling
      	so it will use the dither parameters to set the origin of the
      	tiles as well.
      
      	* libnautilus/nautilus-icon-dnd.c: (receive_dropped_tile_image),
      	(nautilus_icon_container_receive_dropped_icons): Added code so that
      	dropping an image file on the window with the shift key held down
      	will customize the background tile image.
      
      	* libnautilus/nautilus-icon-factory.c: (make_full_icon_path),
      	(get_themed_icon_file_path): Fixed two bugs that prevented
      	MIME-type-based icons from working correctly. First, got rid of
      	code that tried to prepend the theme name and "nautilus/" to the
      	beginning of a full path. Then made sure that it tries the file
      	name without adding a suffix before it starts trying out suffixes.
      
      	* libnautilus/nautilus-icon-grid.c: (nautilus_icon_grid_clear):
      	Fixed bug where clearing the grid was resetting the visible width.
      
      	* components/sample/Makefile.am:
      	* components/services/startup/Makefile.am:
      	Turned on -Werror for these two directories.
      	* components/sample/nautilus-sample-content-view.h:
      	* components/sample/nautilus-sample-content-view.c:
      	(nautilus_sample_content_view_destroy), (bonobo_sample_callback):
      	Fixed warnings and did some small cleanup.
      cd9618f0
    • John Sullivan's avatar
      Renaming a file from its Set Properties dialog now works, though · dc703c8b
      John Sullivan authored
      	there are various odds and ends I still need to clean up.
      	It turned out (surprise!) that there was a lot of
      	underpinnings work involved in implementing this feature.
      	Fortunately most of it will be shared by rename-in-place.
      
      	* libnautilus/nautilus-directory-private.h:
      	add #define for METADATA_NODE_NAME_FOR_FILE_NAME
      	* libnautilus/nautilus-directory.c:
      	(nautilus_directory_get_file_metadata_node): Use
      	METADATA_NODE_NAME_FOR_FILE_NAME #define
      	(nautilus_directory_set_file_metadata): Use g_return_val_if_fail
      	to prevent callers from changing the file name this way, since
      	that wouldn't work right.
      
      	* libnautilus/nautilus-file.h:
      	* libnautilus/nautilus-file.c:
      	(nautilus_file_can_rename): New function, returns TRUE if the
      	user has write permission for this file.
      	(nautilus_file_rename): New function, uses gnome_vfs_move to
      	try to rename the file, updating metadata as appropriate.
      	Returns the GnomeVFSResult from gnome_vfs_move.
      
      	* libnautilus/nautilus-list.c
      	(row_selected): Renamed this formerly private function to
      	nautilus_list_is_row_selected and made it check its parameters
      	more carefully.
      	* libnautilus/nautilus-list.h:
      	(nautilus_list_is_row_selected): Made this public.
      
      	* src/file-manager/fm-error-reporting.c,
      	* src/file-manager/fm-error-reporting.h: New files, home for
      	UI code to display user error messages and such. It's initial
      	occupant is:
      	(fm_report_error_renaming_file): New function, puts up a non-modal
      	alert reporting the renaming failure.
      	* src/file-manager/Makefile.am: Add these two new files to the build.
      
      	* src/file-manager/fm-directory-view.c:
      	(bonobo_menu_open_properties_window_cb): New function, opens a
      	Properties window for each selected item using the Bonobo callback API.
      	(fm_directory_view_real_merge_menus): Include Set Properties item in
      	File menu, and rearrange other items a little.
      	(fm_directory_view_real_update_menus): Update sensitivity of Set
      	Properties menu item.
      
      	* src/file-manager/fm-list-view.c:
      	(add_to_list): Return the new row index.
      	(fm_list_view_file_changed): Remove and reinsert the changed file; this
      	not only does less sorting but also recomputes all the text so name
      	changes will be displayed.
      
      	* src/file-manager/fm-properties-window.c:
      	(get_pixmap_and_mask_for_properties_window),
      	(update_properties_window_icon),
      	(create_pixmap_widget_for_file),
      	(name_field_done_editing),
      	(name_field_update),
      	(update_properties_window_title),
      	(properties_window_file_changed_callback):
      	New functions used to wire up the new editable name field
      	and new icon pixmap widget in the properties window.
      	(create_properties_window): Added notebook tabs, first
      	one is Basic and currently contains icon & name; second
      	is Emblems and has all those checkboxes. Use all the
      	new functions to create and wire up things so that name
      	changes & icon changes are propagated and reflected correctly.
      
      	* src/nautilus-bookmarks-window.c:
      	(create_bookmarks_window): Removed a bunch of unnecessary
      	and leak-causing gtk_widget_refs that I happened to notice
      	in here. I left these behind when modifying code originally
      	created by glade, where the refs are necessary.
      dc703c8b
  4. 04 Apr, 2000 5 commits
    • Andy Hertzfeld's avatar
      more work on the registration and configuration forms in the service · 2f576631
      Andy Hertzfeld authored
      
             more work on the registration and configuration forms in the service
             component
      2f576631
    • Andy Hertzfeld's avatar
      fixed bug by only allocating uri for actual_uri if it's non-null; plus · cd18bb0b
      Andy Hertzfeld authored
      
              fixed bug by only allocating uri for actual_uri if it's non-null; plus
      	lots more work on the service registration form.
      cd18bb0b
    • Andy Hertzfeld's avatar
      more work on the service component · 3c38b149
      Andy Hertzfeld authored
      
             more work on the service component
      3c38b149
    • Andy Hertzfeld's avatar
      added configuration inventory routines to the nascent service component · b258d638
      Andy Hertzfeld authored
      
             added configuration inventory routines to the nascent service component
      b258d638
    • Darin Adler's avatar
      First cut at tiled background images. · 276a5a10
      Darin Adler authored
      
      	First cut at tiled background images.
      
      	There's no UI for setting them yet, they are only in
      	the icon view, and they don't work properly with scrolling yet.
      
      	* libnautilus/Makefile.am:
      	* libnautilus/nautilus-gdk-extensions.c:
      	* libnautilus/nautilus-gdk-extensions.h:
      	* libnautilus/nautilus-gdk-pixbuf-extensions.c:
      	* libnautilus/nautilus-gdk-pixbuf-extensions.h:
      	Split the GdkPixbuf stuff into its own file.
      
      	* libnautilus/nautilus-background.c:
      	(nautilus_background_destroy): Fixed a bunch of leaks
      	and added new code to stop pixbuf loading.
      	(nautilus_background_draw): Added call to draw tiled
      	background image. Converted gradients to use gdk_rgb
      	instead of gdk_color.
      	(nautilus_background_get_tile_image_uri): Implemented.
      	(nautilus_background_set_color): Added short-circuit
      	for background image case.
      	(load_image_callback),
      	(nautilus_background_set_tile_image_uri): Implemented.
      	Include code to	load in the tiled image when its URI is set.
      	(nautilus_background_receive_dropped_color): Set the
      	tile image to NULL when a color is dropped.
      
      	* libnautilus/nautilus-gdk-extensions.c:
      	* libnautilus/nautilus-gdk-extensions.h:
      	(nautilus_fill_rectangle_with_color),
      	(nautilus_fill_rectangle_with_color),
      	(nautilus_interpolate_color): Changed from gdk_color
      	to gdk_rgb.
      	(nautilus_parse_rgb_with_white_default): Added function
      	for gdk_rgb similar to what we already have for gdk_color.
      
      	* libnautilus/nautilus-icon-canvas-item.c:
      	* libnautilus/nautilus-icon-container.c:
      	* libnautilus/nautilus-list.c:
      	Use gdk-pixbuf extensions in new location.
      
      	* libnautilus/nautilus-metadata.h:
      	Added metadata keys for background images.
      
      	* src/ntl-view.c:
      	Added lots of stronger checks for NAUTILUS_IS_VIEW since
      	this is where we run into trouble with a bug I ran into.
      
      	* src/file-manager/icon-view.c: Added code to handle
      	the new background images.
      	(create_icon_container): Keep around the handler ID when
      	connecting to the "changed" message of the background so
      	we can block the handler as needed.
      	(fm_icon_view_begin_loading): Load the background image
      	as well as the background color. We need to block the
      	background changed signal handler so we don't get
      	confused while the color but not the image is set up.
      	(fm_icon_view_background_changed_callback): Save the
      	background image URI as well as the background color in
      	the metadata.
      276a5a10
  5. 03 Apr, 2000 2 commits
    • Darin Adler's avatar
      Fix the build. Changes in GtkHtml and Bonobo required us · 2fe15f16
      Darin Adler authored
      	to catch up.
      
      	* libnautilus/ntl-meta-view-frame.h:
      	* libnautilus/ntl-meta-view-frame.c:
      	Rewrote to use the new property bag. This requires us to
      	store our own properties, since the bag no longer provides
      	any storage.
      	(nautilus_meta_view_frame_initialize): Set up the label.
      	(nautilus_meta_view_frame_new_from_bonobo_control): Make it
      	actually take a BonoboControl instead of a BonoboObject and
      	make it set up the property bag.
      	(nautilus_meta_view_destroy): Free the label.
      	(autilus_meta_view_frame_set_label): Just set the label.
      	The property bag simply uses our stored label.
      
      	* components/html/ntl-web-browser.c (browser_url_load_gone):
      	Changed call to match name in new version of GtkHtml.
      	Unfortunately, the new name makes it clear the call is
      	intended to be private.
      
      	* components/rpmview/.cvsignore: Ignore the actual binary,
      	not nautilus-music-view.
      	* components/rpmview/Makefile.am: Turned on -Werror.
      	* components/music/Makefile.am: Turned on -Werror.
      	* components/rpmview/nautilus-rpm-view.c: Fixed warnings.
      2fe15f16
    • Andy Hertzfeld's avatar
      first cut at rpm view component · 2ee8f838
      Andy Hertzfeld authored
      
              first cut at rpm view component
      2ee8f838
  6. 02 Apr, 2000 3 commits
  7. 01 Apr, 2000 1 commit
  8. 31 Mar, 2000 4 commits
    • Pavel Cisler's avatar
      Disable copy as a drag&drop operation for now. The current copy engine · 227b517d
      Pavel Cisler authored
      
      
      2000-03-31  Pavel Cisler  <pavel@eazel.com>
      
      	Disable copy as a drag&drop operation for now. The current
      	copy engine doesn't handle conflicts properly yet and can
      	erase your files.
      227b517d
    • Darin Adler's avatar
      Fixed a bug that Pavel reported where he got a crash in · a1f24785
      Darin Adler authored
      	nautilus_directory_monitor_files_unref when he pushed the
      	"Up" button.
      
      	* libnautilus/nautilus-glib-extensions.c:
      	* libnautilus/nautilus-glib-extensions.h:
      	(nautilus_g_strv_find): Renamed the existing function
      	nautilus_g_strfindv to be more consistent with the rest
      	of glib, even though it's less consistent with the other
      	strv functions.
      	(nautilus_g_list_safe_for_each): Added an alternate
      	version of g_list_foreach that works even when the current
      	item is removed from the list inside the function.
      
      	* libnautilus/nautilus-gtk-extensions.c:
      	(nautilus_gtk_object_list_unref): Use the new safe version
      	of g_list_foreach so this works even on lists where the
      	objects remove themselves in their destroy/finalize methods.
      	This is the change that fixes the bug.
      
      	* src/nautilus-bookmark-list.c:
      	(nautilus_bookmark_list_load_file): Replaced some explicit
      	code with a call to nautilus_gtk_object_list_free.
      
      	* src/nautilus-index-title.c:
      	(nautilus_index_title_update_icon): Fixed a bug that would
      	prevent you from viewing the root level. The current version
      	of nautilus_file_get returns NULL for the root.
      
      	* src/nautilus-window-menus.c:
      	(clear_appended_bookmark_items): Replaced some explicit
      	code with a call to nautilus_g_list_free_deep.
      
      	* src/file-manager/fm-icon-text-window.c:
      	(synch_menus_with_preference): Updated to use the
      	nautilus_g_strv_find call by its new name.
      
      	* libnautilus/nautilus-file.c:
      	(nautilus_file_set_keywords): Did some minor tweaks to
      	simplify the no-keywords case.
      a1f24785
    • John Sullivan's avatar
      Show icon emblems in list view. · 16acc134
      John Sullivan authored
      16acc134
    • Darin Adler's avatar
      Finished task 62 (Set custom icon by drag/drop on index panel) · 1fb5a14a
      Darin Adler authored
      	and fixed some problems from my earlier check-ins today.
      
      	* libnautilus/nautilus-directory.c:
      	(nautilus_directory_monitor_files_ref):
      	Fixed a bad assert from my last check-in.
      
      	* src/file-manager/fm-list-view.c: (add_to_list):
      	The list view had the same missing ref that I fixed for icon
      	view in my last check-in.
      
      	* src/nautilus-index-title.c: (release_file),
      	(nautilus_index_title_destroy),
      	(nautilus_index_title_update_icon),
      	(nautilus_index_title_update_label),
      	(nautilus_index_title_update_info),
      	(nautilus_index_title_set_uri): Changed to hold around the
      	NautilusFile object and connect to its "changed" message to update
      	the file information. This causes the icon to get updated right
      	away when the custom icon is changed.
      
      	* libnautilus/nautilus-directory-private.h:
      	* libnautilus/nautilus-directory.c:
      	* libnautilus/nautilus-file-private.h:
      	* libnautilus/nautilus-file.c:
      	* libnautilus/nautilus-file.h:
      	Converted NautilusFile to be a GtkObject instead of a plain struct,
      	so it can have a "changed" signal. We still recommend using the
      	"files_changed" signal on the directory to avoid the overhead
      	of a signal connection for each file.
      
      	* libnautilus/nautilus-gtk-extensions.c:
      	* libnautilus/nautilus-gtk-extensions.h:
      	(nautilus_gtk_object_list_ref), (nautilus_gtk_object_list_unref),
      	(nautilus_gtk_object_list_free): Added some functions to be used
      	with a list of GtkObjects.
      
      	* libnautilus/nautilus-icon-factory.c:
      	(nautilus_icon_factory_get_icon_name_for_file):
      	Had to change the name of nautilus_file_get_type to avoid conflict
      	with the GtkObject standard get_type routine.
      1fb5a14a
  9. 30 Mar, 2000 3 commits
    • Darin Adler's avatar
      Added missing ref that caused very bad things to happen now that the file · e5c04283
      Darin Adler authored
      	* src/file-manager/fm-icon-view.c: (add_icon_if_already_positioned),
      	(add_icon_at_free_position): Added missing ref that caused very bad
      	things to happen now that the file ref. counts are working.
      
      	* components/music/nautilus-music-view.c:
      	Did a bunch of cleanup and fixed some memory trashing bugs where
      	the result of g_basename was passed to g_free.
      e5c04283
    • Darin Adler's avatar
      Added convenience functions so people don't have to be constantly reminded · 4c8d9b0b
      Darin Adler authored
      	* libnautilus/nautilus-directory.c:
      	* libnautilus/nautilus-directory.h:
      	(nautilus_directory_ref), (nautilus_directory_unref):
      	Added convenience functions so people don't have to be constantly
      	reminded that a NautilusDirectory is a a GtkObject.
      
      	* libnautilus/nautilus-directory.c: (nautilus_directory_destroy):
      	Fixed a problem where the pending files callback might fire after
      	the NautilusDirectory is gone.
      
      	* libnautilus/nautilus-directory.c:
      	(nautilus_directory_destroy),
      	(nautilus_directory_monitor_files_ref),
      	(nautilus_directory_monitor_files_unref),
      	(dequeue_pending_idle_callback), (nautilus_directory_new_file):
      	* libnautilus/nautilus-file-private.h:
      	* libnautilus/nautilus-file.c:
      	(nautilus_file_get), (nautilus_file_ref), (nautilus_file_unref),
      	(nautilus_file_free), (nautilus_file_delete):
      	To prepare for changing NautilusFile to a GtkObject, made it use
      	ref counts in a way that is standard. Now the directory keeps a
      	list of the files, but only keeps a ref to the files if it is
      	monitoring them.
      
      	* src/file-manager/fm-directory-view.c: Tiny formatting tweak.
      4c8d9b0b
    • Andy Hertzfeld's avatar
      made the selection rectangle have a semi transparent light blue fill · f95b9532
      Andy Hertzfeld authored
      
              made the selection rectangle have a semi transparent light blue fill
      	color; also tweaked the selection darkening to be a little lighter
      f95b9532