1. 09 Feb, 2001 1 commit
    • Gene Z. Ragan's avatar
      Fixed bug 6453, Gnome VFS_CRITICAL received when dragging nautilus link · fbd62e61
      Gene Z. Ragan authored
      2001-02-09  Gene Z. Ragan  <gzr@eazel.com>
      
      	Fixed bug 6453, Gnome VFS_CRITICAL received when dragging
      	nautilus link icons over each other.
      
      	* libnautilus-extensions/nautilus-drag.c:
      	(nautilus_drag_default_drop_action_for_icons):
      
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(nautilus_icon_container_dropped_icon_feedback),
      	(nautilus_icon_dnd_end_drag):
      fbd62e61
  2. 01 Feb, 2001 1 commit
    • Pavel Cisler's avatar
      reviewed by: Gene Ragan <gzr@eazel.com> · 8e014624
      Pavel Cisler authored
      2001-02-01  Pavel Cisler  <pavel@eazel.com>
      
      	reviewed by: Gene Ragan <gzr@eazel.com>
      
      	Fix 6152 (Dragging a file to the trash will bring up a replace
      		  dialog)
      	Fix 5387 (Dragging a file within Trash gives "already exists"
      		 error)
      
      	* libnautilus-extensions/nautilus-drag.c:
      	* libnautilus-extensions/nautilus-drag.h:
      	(nautilus_drag_items_local), (nautilus_drag_items_in_trash):
      	Add more convenience calls for Trash handling.
      
      	* libnautilus-extensions/nautilus-file-utilities.h:
      	* libnautilus-extensions/nautilus-file-utilities.c:
      	(nautilus_uri_is_in_trash):
      	New convenience call for Trash handling.
      
      	* libnautilus-extensions/nautilus-file.c:
      	(nautilus_file_is_in_trash):
      	Use the new nautilus_uri_is_in_trash call.
      
      	* libnautilus-extensions/nautilus-file-operations.c:
      	(nautilus_file_operations_copy_move):
      	Handle the case where a file is dragged into a Trash window or
      	onto a Trash icon as if the "Move to Trash" command was issued -
      	if there is a name conflict with a pre-existing file in the Trash,
      	use a new unique name for the new file.
      
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(nautilus_icon_container_selection_items_local):
      	Handle files in the Trash properly - doing a parent match with
      	the container URI fails for these, special case Trash handling.
      8e014624
  3. 29 Jan, 2001 1 commit
    • John Sullivan's avatar
      reviewed by: Darin Adler <darin@eazel.com> · 5e384e1b
      John Sullivan authored
      	Fixed bug 4427 (Should not execute text files by default).
      
      	Now it asks whether to run or display executable text files.
      	Advanced users can set a new preference.
      
      	* libnautilus-extensions/nautilus-stock-dialogs.h:
      	* libnautilus-extensions/nautilus-stock-dialogs.c:
      	(create_message_box): New bottleneck function, contains former
      	guts of show_message_box but doesn't call gtk_widget_show.
      	(show_message_box): Now just a simple wrapper for
      	calling create_message_box and showing the result.
      	(nautilus_show_info_dialog), (nautilus_show_warning_dialog),
      	(nautilus_show_error_dialog), (nautilus_show_yes_no_dialog),
      	(nautilus_show_error_dialog_with_details):
      	Renamed to add verb "show" to names.
      	(nautilus_run_simple_dialog): Renamed to add verb "run" to name.
      	(nautilus_create_question_dialog): New public function, does
      	not show the dialog yet so caller can add more buttons or
      	whatever before showing.
      
      	* libnautilus-extensions/nautilus-global-preferences.h:
      	* libnautilus-extensions/nautilus-global-preferences.c:
      	(global_preferences_install_descriptions),
      	(global_preferences_install_defaults),
      	(global_preferences_install_visibility),
      	(global_preferences_create_dialog): Add new preference for
      	what to do when an executable text file is activated. It
      	defaults to "Ask" and is visible only at Advanced level.
      
      	* libnautilus-extensions/nautilus-file-private.h:
      	* libnautilus-extensions/nautilus-file.h: Moved
      	nautilus_file_contains_text into public header.
      
      	* src/file-manager/fm-directory-view.c:
      	(get_executable_text_file_action): New function, uses preference
      	and dialog (if necessary) to determine how to handle activating
      	an executable text file.
      	(activate_callback): Now handles executable text files specially
      	by using get_executable_text_file_action. Restructured the control
      	flow a little.
      
      	* components/music/nautilus-music-view.c: (set_album_cover),
      	(play_current_file), (nautilus_music_view_update):
      	* components/rpmview/nautilus-rpm-view-install.c:
      	(nautilus_rpm_view_install_done):
      	* components/services/summary/nautilus-view/nautilus-summary-dialogs.c:
      	(nautilus_summary_login_failure_dialog),
      	(generate_error_dialog):
      	* components/text/nautilus-text-view.c: (file_read_callback):
      	* libnautilus-extensions/nautilus-file-operations.c:
      	(confirm_empty_trash),
      	(handle_transfer_vfs_error), (handle_transfer_overwrite),
      	(nautilus_file_operations_copy_move),
      	(handle_new_folder_vfs_error),
      	(nautilus_file_operations_move_to_trash):
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(confirm_switch_to_manual_layout):
      	* libnautilus-extensions/nautilus-program-chooser.c:
      	(nautilus_program_chooser_show_no_choices_message):
      	* libnautilus-extensions/nautilus-program-choosing.c:
      	(nautilus_launch_application):
      	* libnautilus-extensions/nautilus-volume-monitor.c:
      	(display_mount_status):
      	* src/file-manager/fm-desktop-icon-view.c:
      	(icon_view_create_nautilus_links):
      	* src/file-manager/fm-directory-view.c:
      	(fm_directory_view_confirm_multiple_windows),
      	(real_file_limit_reached), (fm_directory_view_confirm_deletion),
      	(confirm_delete_from_trash), (report_broken_symbolic_link),
      	* src/file-manager/fm-error-reporting.c:
      	(fm_report_error_renaming_file), (fm_report_error_setting_group),
      	(fm_report_error_setting_owner),
      	(fm_report_error_setting_permissions):
      	* src/file-manager/fm-properties-window.c: (set_custom_image):
      	* src/file-manager/fm-search-list-view.c: (load_location_callback),
      	(load_error_callback), (display_indexed_search_problems_dialog),
      	(real_file_limit_reached):
      	* src/file-manager/nautilus-indexing-info.c:
      	(update_file_index_callback),
      	(show_search_service_not_available_dialog):
      	* src/nautilus-application.c: (check_required_directories),
      	(nautilus_application_startup):
      	* src/nautilus-location-bar.c: (drag_data_received_callback):
      	* src/nautilus-property-browser.c: (remove_pattern),
      	(remove_emblem), (emblem_image_file_changed),
      	(add_pattern_to_browser), (add_color_to_browser),
      	(emblem_dialog_clicked):
      	* src/nautilus-sidebar.c: (receive_dropped_uri_list):
      	* src/nautilus-theme-selector.c: (add_theme_to_icons),
      	(theme_select_row_callback):
      	* src/nautilus-window-manage-views.c: (handle_unreadable_location),
      	(report_content_view_failure_to_user_internal),
      	(report_sidebar_panel_failure_to_user),
      	(nautilus_window_end_location_change_callback):
      	* src/nautilus-window-menus.c: (forget_history_if_confirmed),
      	(show_bogus_bookmark_window): Updated for dialog API name changes.
      
      	* libnautilus-extensions/nautilus-file.c: (get_description):
      	Lucky Aaron gets missing mime description complaints now.
      5e384e1b
  4. 27 Jan, 2001 1 commit
    • Andy Hertzfeld's avatar
      fixed bug 5750, accepting drops by folders quirky at zoom levels below · 3968d02a
      Andy Hertzfeld authored
      
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(nautilus_icon_container_item_at):
      	fixed bug 5750, accepting drops by folders quirky at zoom levels
      	below 100%. The problem was that nautilus_icon_container_item_at
      	was constructing a single pixel rectangle for hit-testing, that
      	sometimes turned into a zero pixel rectangle when scaled down,
      	depending on how things rounded off.  Fixed by using the
      	canvas scale factor when building the rectangle, ensuring that
      	it never becomes empty.
      3968d02a
  5. 12 Jan, 2001 1 commit
    • John Sullivan's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · e26bd56e
      John Sullivan authored
      	Fixed bug 2068 (Dragging icons adjusts scroll area in a way
      	that causes immediate scrolling)
      
      	Fixed bug 3402 (Dragging singleton icon to edge of window in
      	manual layout mode puts it back at top-left)
      
      	Fixed bug 3405 (Dropping an icon into empty manual-layout
      	window always puts it at top-left)
      
      	Fixed bug 3570 (Relayout glitch after removing an item from
      	a view)
      
      	I had earlier started to fix these by trying to save and
      	restore the scroll position per directory. But this path
      	turned evil, and I gave up on it. There is still some
      	partly-implemented work from my start in the evil direction,
      	which I will remove in my next checkin.
      
      	The new fix was to always include the visible white space
      	when recomputing the icon container's scroll region, unless
      	a caller has specifically requested not to.
      
      	* libnautilus-extensions/nautilus-icon-container.h:
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(nautilus_icon_container_reset_scroll_region): New function,
      	sets a flag in the details struct that's respected in the
      	next scroll region update.
      	(reset_scroll_region_if_not_empty): New helper function,
      	calls _reset_scroll_region unless container is empty.
      	(nautilus_icon_container_update_scroll_region_include_visible_area):
      	Removed this function; its equivalent is to call reset_scroll_region
      	before calling update_scroll_region.
      	(nautilus_icon_container_update_scroll_region): Now that the
      	_include_visible_area variant is gone, merged the local function
      	update_scroll_region with this public one. It decides whether to
      	include the visible area or not based on the flag set by
      	_reset_scroll_region (also, it never includes the visible area
      	if the container is empty).
      	(nautilus_icon_container_set_auto_layout): Reset the scroll region
      	when changing the auto_layout state.
      	(nautilus_icon_container_sort): reset the scroll region before
      	sorting.
      
      	* libnautilus-extensions/nautilus-icon-dnd.c: (handle_local_move):
      	Call nautilus_icon_container_update_scroll_region instead of
      	_update_scroll_region_include_visible_area, which no longer exists.
      
      	* libnautilus-extensions/nautilus-icon-private.h: Store flag for
      	resetting scroll region in details; eliminate prototype for
      	nautilus_icon_container_update_scroll_region_include_visible_area.
      
      	* src/file-manager/fm-directory-view.h:
      	* src/file-manager/fm-directory-view.c:
      	(fm_directory_view_initialize_class), (done_loading),
      	(fm_directory_view_begin_loading), (fm_directory_view_end_loading):
      	Added end_loading signal that's sent when a directory is finished
      	loading, parallel to existing begin_loading signal.
      
      	* src/file-manager/fm-icon-view.c:
      	(fm_icon_view_add_file): Reset the scroll region for the first
      	icon added when loading a directory.
      	(fm_icon_view_begin_loading), (fm_icon_view_end_loading):
      	Remember that we're loading, so	fm_icon_view_add_file can test correctly.
      	(set_sort_criterion_by_id): Bail out early if state hasn't changed.
      	(switch_to_manual_layout): Bail out early if state hasn't changed.
      	Also, reset scroll region before switching to manual layout.
      	(fm_icon_view_initialize_class): Attach fm_icon_view_end_loading to
      	virtual function slot.
      e26bd56e
  6. 25 Dec, 2000 1 commit
    • Gene Z. Ragan's avatar
      Started work on volume black list. Added proc and boot to list. Need to · a57481aa
      Gene Z. Ragan authored
      2000-12-25  Gene Z. Ragan  <gzr@eazel.com>
      
      	* src/file-manager/fm-desktop-icon-view.c:
      	(fm_desktop_icon_view_destroy), (free_volume_black_list),
      	(volume_in_black_list), (create_mount_link),
      	(startup_create_mount_links), (fm_desktop_icon_view_initialize),
      	(volume_mounted_callback):
      	Started work on volume black list.  Added proc and boot to
      	list.  Need to figure out a way to expose this to the UI
      	so it is easy for the user to specify what mounts they
      	wnat dispalyed on the desktop.
      
      	* libnautilus-extensions/nautilus-drag.c: (add_one_url_list),
      	(add_one_path_list), (nautilus_drag_drag_data_get):
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	Work on supporting drags form Nautilus into the attachments
      	frame of Netscape mail.
      a57481aa
  7. 23 Dec, 2000 1 commit
    • Gene Z. Ragan's avatar
      reviewed by: Pavel Cisler<pavel@eazel.com> · b72191a5
      Gene Z. Ragan authored
      2000-12-23  Gene Z. Ragan  <gzr@eazel.com>
      
      	reviewed by: Pavel Cisler<pavel@eazel.com>
      
      	Fixed bug 4158, dropping a file onto gnome-terminal
      	doesn't insert a path name.
      
      	* libnautilus-extensions/nautilus-drag.c: (add_one_path_list),
      	(nautilus_drag_drag_data_get):
      	Return a list a text paths.
      
      	* libnautilus-extensions/nautilus-drag.h:
      	Add new type and data type for "text/uri"
      b72191a5
  8. 08 Dec, 2000 1 commit
    • Rebecca Schulman's avatar
      Bug numbers for the FIXMEs in libnautilus-extensions. · d160849c
      Rebecca Schulman authored
      2000-12-07  Rebecca Schulman  <rebecka@eazel.com>
              Bug numbers for the FIXMEs in libnautilus-extensions.
      
      	* libnautilus-extensions/nautilus-customization-data.c:
      	(format_name_for_display):
      	* libnautilus-extensions/nautilus-directory-async.c:
      	(dequeue_pending_idle_callback), (cancel_loading_attributes),
      	(nautilus_directory_cancel_loading_file_attributes):
      	* libnautilus-extensions/nautilus-directory.c:
      	(nautilus_directory_handle_directory_moved),
      	(nautilus_directory_notify_files_moved),
      	(nautilus_self_check_directory):
      	* libnautilus-extensions/nautilus-file-utilities.c:
      	(nautilus_make_uri_canonical),
      	(pthread_nautilus_read_file_thread_entry),
      	(pthread_nautilus_read_file_async), (nautilus_read_file_cancel),
      	(nautilus_self_check_file_utilities):
      	* libnautilus-extensions/nautilus-file.c: (get_description),
      	(nautilus_file_forget_attributes_internal):
      	* libnautilus-extensions/nautilus-gdk-extensions.c:
      	* libnautilus-extensions/nautilus-gdk-pixbuf-extensions.c:
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(nautilus_icon_container_start_renaming_selected_item):
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(receive_dropped_uri_list):
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	* libnautilus-extensions/nautilus-label.c:
      	(nautilus_label_size_allocate), (label_recompute_line_geometries):
      	* libnautilus-extensions/nautilus-merged-directory.c:
      	(nautilus_merged_directory_add_real_directory):
      	* libnautilus-extensions/nautilus-mime-actions.c:
      	(nautilus_mime_get_default_application_for_file_internal):
      	* libnautilus-extensions/nautilus-scalable-font.c:
      	(nautilus_text_layout_paint):
      	* libnautilus-extensions/nautilus-search-uri.c:
      	(nautilus_self_check_search_uri):
      	* libnautilus-extensions/nautilus-string.c:
      	* libnautilus-extensions/nautilus-undo-signal-handlers.c:
      	(editable_key_press_event), (nautilus_undo_editable_set_undo_key):
      d160849c
  9. 07 Dec, 2000 1 commit
    • Darin Adler's avatar
      reviewed by: John Sullivan <sullivan@eazel.com> · ca6e9f3b
      Darin Adler authored
      	Fixed bug 3245 (When an empty folder is visited, the throbbing
      	never stops), bug 2540 (Hook up done_loading signal in
      	NautilusMergedDirectory?), and bug 3067 (throbber doesn't start
      	again if you do a new "underway" call after load is complete).
      
      	* src/file-manager/fm-directory-view.c: (queue_pending_files):
      	Get rid of code that uses nautilus_directory_are_all_files_seen
      	to notice we are done loading.
      	(done_loading_callback): Use done_loading signal to notice we
      	are done loading.
      	(finish_loading_uri): Connect to the done_loading signal.
      	(disconnect_model_handlers): Disconnect from the done_loading
      	signal.
      
      	* libnautilus-extensions/nautilus-merged-directory.c:
      	(done_loading_callback),
      	(nautilus_merged_directory_add_real_directory),
      	(nautilus_merged_directory_remove_real_directory): Add code to
      	track all the trash directories and emit done_loading signals
      	once all of them are done loading.
      
      	* src/nautilus-window-manage-views.c: (change_state): Turn the
      	stop and the throbber back on when a view re-marks itself
      	underway.
      
      	* libnautilus-extensions/nautilus-drag.c:
      	(nautilus_drag_file_receive_dropped_keyword): Fix storage leak by
      	doing a free_deep on the list of keywords.
      
      	* libnautilus-extensions/nautilus-file-operations.h:
      	* libnautilus-extensions/nautilus-file-operations.c:
      	Get rid of excess includes.
      
      	* libnautilus-extensions/nautilus-icon-dnd.c: Get rid of unused
      	ERASE_KEYWORD constant.
      
      	* src/nautilus-window.c: (nautilus_window_constructed): Fix a
      	typo in a comment.
      ca6e9f3b
  10. 01 Dec, 2000 1 commit
    • Pavel Cisler's avatar
      reviewed by: Darin Adler <darin@eazel.com> · 86aeacbb
      Pavel Cisler authored
      2000-12-01  Pavel Cisler <pavel@eazel.com>
      
      	reviewed by: Darin Adler <darin@eazel.com>
      
      	* libnautilus-extensions/nautilus-file-operations.c:
      	(progress_dialog_set_to_from_item_text), (handle_xfer_ok),
      	(handle_xfer_vfs_error), (handle_xfer_overwrite), (get_link_name),
      	(nautilus_file_operations_copy_move),
      	(nautilus_file_operations_new_folder),
      	(nautilus_file_operations_move_to_trash),
      	(nautilus_file_operations_delete), (do_empty_trash):
      
      	Fixed 3392 - Messages in nautilus-file-operations hard to localize.
      
      	Replaced all the cases that did "clever" string composition from
      	parts depending on the specific file operation with full texts of
      	the respective error alerts and progress dialog label texts and
      	titles.
      	Changed action_verb to action_label.
      	Got rid of progress_dialog_set_files_done_text because the the
      	"Files copied:" etc. label is no longer composed.
      	Added switch statements in handle_xfer_vfs_error that choose the
      	right error text based on the xfer operation kind.
      
      	Fixed 3139 - Add comments to all the localizable strings to make them
      	easier to localize.
      
      	* libnautilus-extensions/nautilus-file-operations.c:
      	(icon_position_iterator_new),
      	* libnautilus-extensions/nautilus-file-operations.h:
      	(nautilus_file_operations_copy_move),
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(nautilus_icon_container_get_icon_locations),
      	(nautilus_icon_container_get_selected_icon_locations):
      	* libnautilus-extensions/nautilus-icon-container.h:
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(handle_nonlocal_move), (nautilus_icon_container_find_drop_target):
      	* libnautilus-extensions/nautilus-icon-private.h:
      	* src/file-manager/fm-directory-view.c:
      	(fm_directory_view_initialize_class), (duplicate_callback),
      	(fm_directory_view_create_links_for_files), (offset_drop_points),
      	(fm_directory_view_duplicate_selection),
      	(fm_directory_get_selected_icon_locations),
      	(fm_directory_view_move_copy_items):
      	* src/file-manager/fm-directory-view.h:
      	* src/file-manager/fm-icon-view.c:
      	(fm_icon_view_get_selected_icon_locations),
      	(fm_icon_view_set_selection), (fm_icon_view_initialize_class),
      	(icon_view_move_copy_items):
      	* src/file-manager/fm-list-view.c: (fm_list_view_initialize_class),
      	(fm_list_view_get_selected_icon_locations),
      	(fm_list_view_sort_items):
      
      	Fixed 2817 - when you duplicate a file, it doesn't end up in the correct
      	position.
      
      	Redid the icon position array to use GArray instead of a simple vector of
      	GdkPoints. GArray contains the count of all the contained points
      	which is now needed.
      	Added new calls to get the icon locations of selected icons and
      	of a list of NautilusIcon objects.
      	Passed the list of icon locations to the duplicate method.
      	Added a default signal handler that returns the list of
      	icon locations of selected icons.
      	Added code to fm_directory_view_duplicate_selection that
      	offsets the new duplicates to the left and bottom of the
      	original item.
      86aeacbb
  11. 27 Nov, 2000 1 commit
    • Darin Adler's avatar
      Remove two different FIXMEs about using gtk_object_destroy instead of · fd22f6d3
      Darin Adler authored
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(hide_rename_widget):
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(create_selection_shadow):
      	Remove two different FIXMEs about using gtk_object_destroy instead
      	of gtk_object_unref. It turns out that for widgets, destroy is the
      	right way to let go.
      fd22f6d3
  12. 21 Nov, 2000 1 commit
    • Maciej Stachowiak's avatar
      reviewed by: Pavel Cisler <pavel@eazel.com> · c82012c9
      Maciej Stachowiak authored
      	Fix bugs 2943 (Dragging icons between windows or to the desktop
      	triggers scrolling), 4786 (Need to remove tree view auto-expand
      	feature for 1.0) and 4476 (weird horizontal autoscroll
      	behavior). Auto-scroll now has a consistent 750 ms startup delay,
      	and the tree auto-expand is off.
      
      	* libnautilus-extensions/nautilus-drag.h,
      	libnautilus-extensions/nautilus-drag.c:
      	(nautilus_drag_autoscroll_in_scroll_region,
      	nautilus_drag_autoscroll_start, nautilus_drag_autoscroll_stop):
      	New convenience functions that factor out common code formerly in
      	the tree, list and icon view DnD code. This fixes the mistakes
      	common to all three of those views, where the auto-scroll initial
      	delay was measured from the start of dragging overall, not from
      	entering the scroll region.
      
      	* libnautilus-extensions/nautilus-icon-private.h,
      	libnautilus-extensions/nautilus-icon-dnd.c
      	(auto_scroll_timeout_callback, set_up_auto_scroll_if_needed,
      	stop_auto_scroll): Use the above calls. Also, correct a `<'
      	vs. `>' mistake that made the auto-scroll delay never take effect.
      
      	* libnautilus-extensions/nautilus-list.c
      	(auto_scroll_timeout_callback, nautilus_list_start_auto_scroll,
      	nautilus_list_stop_auto_scroll): Use the above calls. Also,
      	correct a `<' vs. `>' mistake that made the auto-scroll delay
      	never take effect.
      
      	* components/tree/nautilus-tree-view-dnd.c:
      	(nautilus_tree_view_drag_leave, nautilus_tree_view_drag_motion,
      	collapse_time_callback, nautilus_tree_view_expand_node,
      	nautilus_tree_view_is_tree_node_expanded, nautilus_dump_info
      	expand_hack_unref, expand_hack_new, expand_time_callback,
      	nautilus_tree_view_expand_maybe_later): Remove bunches of code to
      	disable auto-expand.
      
      	(ready_to_start_scrolling, auto_scroll_timeout_callback),
      	(nautilus_tree_view_start_auto_scroll),
      	(nautilus_tree_view_stop_auto_scroll),
      	(nautilus_tree_view_drag_destroy): Use new common auto-scroll
      	code. I also made it possible to add an extra auto-scroll delay
      	for horizontal auto-scroll, but now that the startup delay has
      	been fixed, it seems almost impossible to trigger horizontal
      	auto-scroll accidentally, so I consider 4476 fixed.
      
      	* components/adapter/bonobo-stream-vfs.c: (vfs_get_info,
      	vfs_set_info, vfs_write, vfs_read, vfs_copy_to, vfs_destroy,
      	bonobo_stream_vfs_open): Added FIXME bug numbers.
      	* components/adapter/nautilus-adapter-control-embed-strategy.c:
      	(activate_uri_callback): Added FIXME bug numbers.
      	* components/adapter/nautilus-adapter.c: (nautilus_adapter_new):
      	Added FIXME bug numbers.
      c82012c9
  13. 09 Nov, 2000 2 commits
    • Gene Z. Ragan's avatar
      Fixed bug 3776, Crash when trying to drag URL .desktop file to desktop · f9909070
      Gene Z. Ragan authored
      2000-11-09  Gene Z. Ragan  <gzr@eazel.com>
      
      	Fixed bug 3776, Crash when trying to drag URL .desktop
      	file to desktop
      
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(receive_dropped_uri_list):
      	Bail out is URI list is NULL
      
      	* src/file-manager/fm-desktop-icon-view.c:
      	(icon_view_create_nautilus_links):
      	Handle special cases. Create a NautilusLink in cases
      	that a GnomeVFS symbolic link will not work.
      f9909070
    • Andy Hertzfeld's avatar
      fixed bug 3215 and 3723, bad feedback during emblem dropping, by rejecting · 0550acb3
      Andy Hertzfeld authored
      
      
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(nautilus_icon_container_find_drop_target),
      	(nautilus_icon_container_get_drop_action):
      	fixed bug 3215 and 3723, bad feedback during emblem dropping,
      	by rejecting the drop if we're not over an icon.  Also, made it
      	reject the drop for colors and backgrounds if we're not over
      	the background.  I also fixed a memory leak in get_drop_action.
      0550acb3
  14. 12 Oct, 2000 2 commits
    • Pavel Cisler's avatar
      Fix a bug where the drag&drop selection shadow would sometimes run away · 84e616b7
      Pavel Cisler authored
      2000-10-12  Pavel Cisler <pavel@eazel.com>
      
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(nautilus_icon_container_scroll):
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(nautilus_icon_container_position_shadow),
      	(auto_scroll_timeout_callback), (handle_local_move):
      	* libnautilus-extensions/nautilus-icon-private.h:
      	Fix a bug where the drag&drop selection shadow would sometimes
      	run away from the dragged icons. This is kind-of related to 3406
      	that I fixed earlier today. The problem happened when
      	an autoscroll didn't actually happen because the adjustment
      	values got clamped but the adjustment delta did get applied to
      	the initial cached drag start location.
      	Made nautilus_icon_container_scroll return a boolean determining
      	if a scroll actually happened.
      84e616b7
    • Pavel Cisler's avatar
      Fix 3406 - Dropped icon doesn't go where you dropped it. There was a lot · 9f207d78
      Pavel Cisler authored
      2000-10-11  Pavel Cisler  <pavel@eazel.com>
      
      	* libnautilus-extensions/nautilus-icon-dnd.c: (get_container_uri),
      	(receive_dropped_uri_list),
      	(handle_local_move), (handle_nonlocal_move),
      	(nautilus_icon_container_receive_dropped_icons),
      	(nautilus_icon_dnd_end_drag):
      	Fix 3406 - Dropped icon doesn't go where you dropped it.
      	There was a lot of confused code that calculated the drop location.
      
      	* libnautilus-extensions/nautilus-icon-dnd.c: (auto_scroll_timeout_callback):
      	Peformance improvement: only cause an auto-scroll update if the auto-scroll
      	delta is non-zero.
      
      	* libnautilus-extensions/nautilus-drag.c:
      	(nautilus_drag_autoscroll_calculate_delta):
      	Fix some white space.
      9f207d78
  15. 06 Oct, 2000 1 commit
    • Gene Z. Ragan's avatar
      Fixed bug 2212, Not able to drag icons from the panel. · ce097b2d
      Gene Z. Ragan authored
      2000-10-06  Gene Z. Ragan  <gzr@eazel.com>
      
      	Fixed bug 2212, Not able to drag icons from the panel.
      
      	* libnautilus-extensions/nautilus-icon-container.c:
      	* libnautilus-extensions/nautilus-icon-container.h:
      	(button_release_event), (nautilus_icon_container_initialize_class):
      	Add a new signal to create symbolic links
      
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(drag_data_received_callback), (receive_dropped_uri_list),
      	(nautilus_icon_container_get_drop_action), (drag_motion_callback):
      	Handle URI drags.
      
      	* src/file-manager/fm-desktop-icon-view.c:
      	(fm_desktop_icon_view_initialize), (create_link_callback),
      	(icon_view_create_nautilus_links):
      	Callbacks to handle the create_nautilus_links signal.  Create
      	links from the data passed in the list using gnome-vfs async
      	callback.
      
      	* libnautilus-extensions/nautilus-program-choosing.c:
      	(nautilus_launch_application_from_command):
      	Quoted the command string in addition to the parameter.
      ce097b2d
  16. 02 Oct, 2000 2 commits
    • John Sullivan's avatar
      Fixed the worst part of bug 2068 (dragging icon causes · ec054c80
      John Sullivan authored
      	immediate update of scroll area). Some related bugs
      	remain, which I'll write up separately
      
      	* libnautilus-extensions/nautilus-gnome-extensions.h:
      	* libnautilus-extensions/nautilus-gnome-extensions.c:
      	(nautilus_gnome_canvas_set_scroll_region_include_visible_area):
      	New function, sets scroll region to given parameters,
      	also forcing visible area to be included.
      
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(update_scroll_region): New function, extracted from
      	nautilus_icon_container_update_scroll_region, now takes
      	boolean for whether to include the visible area.
      	(nautilus_icon_container_update_scroll_region): Now calls
      	update_scroll_region.
      	(nautilus_icon_container_update_scroll_region_include_visible_area):
      	New function, calls update_scroll_region.
      	(size_allocate): Do no work if allocation hasn't changed. This
      	didn't help with bug 2068 but is a worthwhile optimization.
      
      	* libnautilus-extensions/nautilus-icon-private.h:
      	Prototype for nautilus_icon_container_update_scroll_region_
      	include_visible_area
      
      	* libnautilus-extensions/nautilus-icon-dnd.c: (handle_local_move):
      	call ..._include_visible_area when updating scroll region after
      	drag & drop, instead of just ..._update_scroll_region, so no
      	origin-shifting occurs.
      ec054c80
    • John Sullivan's avatar
      Made the "switch to manual layout" dialog be a nautilus_yes_no_dialog · 7a51cba1
      John Sullivan authored
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(confirm_switch_to_manual_layout): Made the
      	"switch to manual layout" dialog be a
      	nautilus_yes_no_dialog instead of the uglier
      	nautilus_simple_dialog.
      7a51cba1
  17. 28 Sep, 2000 2 commits
    • Rebecca Schulman's avatar
      Fixed bug 3231, which crashed nautilus when file dialogs were closed · b6fb4af2
      Rebecca Schulman authored
      2000-09-28  Rebecca Schulman  <rebecka@eazel.com>
              Fixed bug 3231, which crashed nautilus when file dialogs
      	were closed without choosing an option.  Added a parameter
      	to nautilus_simple_dialog to allow the close button to be ignored
      
      	* libnautilus-extensions/nautilus-file-operations.c:
      	(handle_xfer_vfs_error), (handle_xfer_overwrite),
      	(nautilus_file_operations_copy_move),
      	(nautilus_file_operations_move_to_trash):
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(confirm_switch_to_manual_layout):
      	* src/nautilus-location-bar.c: (drag_data_received_callback):
      	Switched dialogs which really should receive a response from
      	the user to use dialog boxes which ignore the close box
      
      	* libnautilus-extensions/nautilus-stock-dialogs.c:
      	* libnautilus-extensions/nautilus-stock-dialogs.h:
      	(delete_event_callback), (nautilus_simple_dialog):
      	Made the dialog ignore delete events.
      b6fb4af2
    • Darin Adler's avatar
      Bonobo objects own themselves, so we should not do a ref/sink on them. · b1943a3c
      Darin Adler authored
      	* libnautilus-extensions/nautilus-undo-context.c:
      	(nautilus_undo_context_new): Bonobo objects own themselves, so we
      	should not do a ref/sink on them.
      	* libnautilus-extensions/nautilus-undo-manager.c:
      	(nautilus_undo_manager_new): Bonobo objects own themselves, so we
      	should not do a ref/sink on them.
      	* src/nautilus-application.c: (nautilus_application_initialize):
      	Move global preferences initialization to main with other
      	initialize calls.
      	(nautilus_application_new): Bonobo objects own themselves, so we
      	should not do a ref/sink on them.
      	(nautilus_application_destroy): Unref the undo manager to fix a
      	leak.
      	* src/nautilus-main.c: (main): Move global preferences
      	initialization to main with other initialize calls.
      
      	* nautilus.spec.in: Added "-k" to build commands so we get more
      	information about what failed when failing to build via
      	RPM. Failures are still failures, we just see more of what's
      	failing.
      
      	* components/help/converters/gnome-db2html2/sect-elements.c:
      	(sect_entry_end_element):
      	* components/help/converters/gnome-db2html2/toc-elements.c:
      	(toc_title_start_element):
      	* components/image-viewer/nautilus-image-view.c:
      	(init_server_factory):
      	* components/rpmview/nautilus-rpm-view-install.c:
      	(nautilus_rpm_view_install_package_callback),
      	(nautilus_rpm_view_uninstall_package_callback):
      	* components/services/install/command-line/eazel-alt-install-corba.
      	c: (main):
      	* components/services/install/command-line/eazel-alt-install.c:
      	(main):
      	* components/services/install/command-line/eazel-install.c:
      	(generate_new_package_list), (fetch_remote_package_list), (main):
      	* components/services/install/command-line/eazel-package-query.c:
      	(main):
      	* components/services/install/command-line/eazel-revert.c: (main):
      	* components/services/install/command-line/eazel-uninstall.c:
      	(main):
      	* components/services/install/lib/eazel-install-object.c:
      	(eazel_install_fetch_remote_package_list):
      	* components/services/install/lib/eazel-install-protocols.c:
      	(eazel_install_fetch_file), (eazel_install_fetch_package):
      	* components/services/install/lib/eazel-install-rpm-glue.c:
      	(install_new_packages), (eazel_install_download_packages),
      	(uninstall_packages), (eazel_install_start_transaction),
      	(eazel_install_add_to_rpm_set),
      	(eazel_install_check_if_related_package):
      	* components/services/install/nautilus-view/nautilus-service-instal
      	l-view.c: (nautilus_service_install_preflight_check):
      	* components/services/install/nautilus-view/nautilus-service-instal
      	l.c: (nautilus_service_install_view_install_package_callback),
      	(nautilus_service_install_view_uninstall_package_callback):
      	* components/services/install/server/main.c: (main):
      	* components/services/summary/nautilus-view/nautilus-summary-view.c
      	: (generate_startup_form), (generate_summary_form),
      	(generate_service_entry_row):
      	* components/services/time/command-line/main.c: (main):
      	* components/services/time/service/main.c: (main):
      	* components/services/trilobite/libtrilobite/trilobite-core-utils.c
      	: (trilobite_init):
      	* components/services/trilobite/libtrilobite/trilobite-root-client.
      	c: (trilobite_root_client_initialize):
      	* components/services/trilobite/libtrilobite/trilobite-service-pass
      	wordquery.c: (trilobite_passwordquery_initialize):
      	* components/services/trilobite/libtrilobite/trilobite-service.c:
      	(trilobite_service_initialize):
      	* components/services/trilobite/sample/command-line/main.c: (main):
      	* components/services/trilobite/sample/service/main.c: (main):
      	* components/shell/shell.c:
      	* components/tree/nautilus-tree-model.c:
      	(nautilus_tree_model_monitor_add),
      	(nautilus_tree_model_root_node_file_monitor):
      	* components/tree/nautilus-tree-view.c:
      	* libnautilus-extensions/nautilus-directory-async.c:
      	(get_filter_options_for_directory_count):
      	* libnautilus-extensions/nautilus-file-utilities.c:
      	(nautilus_uri_is_local_scheme), (nautilus_handle_trailing_slashes):
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(drag_data_received_callback):
      	* libnautilus-extensions/nautilus-icon-text-item.c: (iti_event):
      	* libnautilus-extensions/nautilus-list.c:
      	(nautilus_list_ensure_drag_data), (nautilus_list_get_drop_action),
      	(nautilus_list_drag_data_received):
      	* libnautilus-extensions/nautilus-scalable-font.c:
      	(initialize_global_stuff_if_needed):
      	* libnautilus-extensions/nautilus-undo-signal-handlers.c:
      	(editable_register_edit_undo):
      	* src/file-manager/fm-icon-view.c:
      	(context_menu_layout_radio_item_callback):
      	* src/file-manager/nautilus-indexing-info.c:
      	(update_progress_display):
      	* src/nautilus-switchable-search-bar.c:
      	(nautilus_switchable_search_bar_set_mode):
      	Got rid of all uses of == TRUE and != TRUE, since they are dangerous.
      	Got rid of all uses of == FALSE and != FALSE, since they lead to use
      	of == TRUE and != TRUE.
      b1943a3c
  18. 21 Sep, 2000 1 commit
    • Andy Hertzfeld's avatar
      fixed bugs 3084, 3119, 3134, icon stretch handles are not drawn in the · 38839aa8
      Andy Hertzfeld authored
      
      	fixed bugs 3084, 3119, 3134, icon stretch handles are not drawn
      	in the right place or hit-tested properly, by removing some
      	bogus offsets.
      
      	fixed bugs 764 and 2626, icon stretching is way too slow, by only
      	doing the relayout and update position when the stretching is
      	finished, instead of doing it every time the mouse moves during
      	the stretch.  Also, made it relayout if necessary after stretching
      	is finished, like it was intending to do.
      38839aa8
  19. 18 Sep, 2000 1 commit
    • Gene Z. Ragan's avatar
      Fixed bug 3017, should not be able to copy desktop items · 14bc29ad
      Gene Z. Ragan authored
      2000-09-18  Gene Z. Ragan  <gzr@eazel.com>
      
      	Fixed bug 3017, should not be able to copy desktop items
      
      	Check for special desktop link types when specifying
      	drag and drop actions.
      
      	Disable Duplicate menu item.
      
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(selection_includes_special_link),
      	(nautilus_icon_container_receive_dropped_icons):
      	* src/file-manager/fm-directory-view.c:
      	(fm_directory_link_type_in_selection), (special_link_in_selection),
      	(fm_directory_view_real_create_selection_context_menu_items):
      	* src/file-manager/fm-directory-view.h:
      	* src/file-manager/fm-icon-view.c:
      	(fm_icon_view_create_selection_context_menu_items):
      14bc29ad
  20. 15 Sep, 2000 1 commit
    • Darin Adler's avatar
      Fixed bug 3079 (Cannot copy or link files or folders with current · 4618c73b
      Darin Adler authored
      	build). This was just an || where there should be a &&.
      
      	Also took another crack at making the tinderbox succeed.
      
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(selection_includes_trash): Change || to &&. Oops.
      
      	* nautilus.spec.in: Removed unused directories.
      	* po/POTFILES.in: Removed unused files.
      
      	* libnautilus-extensions/nautilus-drag.c:
      	(nautilus_drag_drop_action_ask): Formatting tweak.
      4618c73b
  21. 13 Sep, 2000 1 commit
    • Darin Adler's avatar
      Fixed bugs in Nautilus link management, some other minor problems · a6a23a70
      Darin Adler authored
      	I encountered along the way, and did the first cut at a state
      	machine for NautilusViewFrame based on Maciej's design that can
      	mostly replace the super-complicated one for NautilusWindow.
      
      	* README: We no longer can use the ORBit that comes with HC1.2
      	with cvs HEAD, since warnings have been fixed in the code
      	generated by the newer ORBit, so fix that line in the README.
      
      	* libnautilus-extensions/nautilus-directory.c:
      	(nautilus_directory_new): Use the new nautilus_uri_is_trash
      	function to avoid hard-coding incorrect checks for "trash:".
      	(nautilus_directory_copy_move_metadata_key): Make simple fix for
      	empty metadata. This code gets replaced soon anyway.
      	* libnautilus-extensions/nautilus-drag.c:
      	(nautilus_drag_can_accept_item): Simplify code to get rid of
      	illegal sync. I/O. It's OK to assume all NautilusLink objects
      	point to directories for now, and if we make a change to do
      	something fancier later, we have to do it with async.
      	...
      a6a23a70
  22. 12 Sep, 2000 2 commits
    • Gene Z. Ragan's avatar
      Fixed bug 2992, Should not be able to context drag Trash to link or · 1dc711f7
      Gene Z. Ragan authored
      2000-09-12  Gene Z. Ragan  <gzr@eazel.com>
      
      	Fixed bug 2992, Should not be able to context drag
      	Trash to link or duplicate
      
      	* libnautilus-extensions/nautilus-icon-container.c:
      	* libnautilus-extensions/nautilus-icon-container.h:
      	(nautilus_icon_container_trash_link_is_in_selection):
      	Renamed function and pass in NautilusIconContainer
      	that selection is retrieved from.
      
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(nautilus_icon_container_receive_dropped_icons):
      	Check and see if any special cases are in the
      	selection.  For now, this is only the Trash link.
      
      	* src/file-manager/fm-directory-view.c:
      	(fm_directory_trash_link_in_selection):
      	Changed function internal to call
      	nautilus_icon_container_trash_link_is_in_selection
      1dc711f7
    • Pavel Cisler's avatar
      Work in progress on saving drop locations during a copy/move operation. · e8d3b459
      Pavel Cisler authored
      2000-09-11  Pavel Cisler  <pavel@eazel.com>
      
      	* libnautilus-extensions/nautilus-directory-notify.h:
      	* libnautilus-extensions/nautilus-directory.c:
      	* libnautilus-extensions/nautilus-file-changes-queue.c:
      	* libnautilus-extensions/nautilus-file-changes-queue.h:
      	* libnautilus-extensions/nautilus-file-operations.c:
      	(icon_position_iterator_new), (icon_position_iterator_free),
      	(create_xfer_dialog), (handle_xfer_vfs_error),
      	(apply_one_position), (sync_xfer_callback),
      	(nautilus_file_operations_copy_move),
      	(nautilus_file_changes_queue_schedule_position_setting),
      	(position_setting_list_free),
      	(nautilus_directory_set_icon_position),
      	(nautilus_directory_schedule_metadata_copy),
      	(nautilus_directory_schedule_metadata_move),
      	(nautilus_file_changes_consume_changes),
      	(nautilus_directory_schedule_position_setting):
      
      	Work in progress on saving drop locations during a copy/move operation.
      	Add a new NautilusFileChangesQueue element type to...
      e8d3b459
  23. 11 Sep, 2000 1 commit
  24. 09 Sep, 2000 1 commit
    • Mathieu Lacage's avatar
      port to new shared function. port to new shared function. add a new · ef2bbd05
      Mathieu Lacage authored
      2000-09-09  Mathieu Lacage  <mathieu@eazel.com>
      
      	* components/tree/nautilus-tree-view.c: port to new
      	shared function.
      	* libnautilus-extensions/nautilus-icon-dnd.c: port to
      	new shared function.
      	* libnautilus-extensions/nautilus-drag.c:
      	(nautilus_drag_autoscroll_calculate_delta),
      	(nautilus_drag_file_receive_dropped_keyword): add a new
      	fucntion to be shared.
      	* libnautilus-extensions/nautilus-drag.h: add prototype
      	* libnautilus-extensions/nautilus-list.c:
      	(nautilus_list_get_drop_action),
      	(nautilus_list_receive_dropped_icons),
      	(nautilus_list_receive_dropped_keyword),
      	(nautilus_list_drag_data_received):
      	use the above function and add support to the list view
      	for many new drop types. Need to fix bug 2485 properly
      	to get 2874 fully implemented.
      ef2bbd05
  25. 08 Sep, 2000 2 commits
  26. 07 Sep, 2000 2 commits
    • Mathieu Lacage's avatar
      add support for NautilusDragInfo. add new scroll calculation fucntion. · ec647092
      Mathieu Lacage authored
      2000-09-07  Mathieu Lacage  <mathieu@eazel.com>
      
      	* components/tree/nautilus-tree-view.c: add support for NautilusDragInfo.
      	* libnautilus-extensions/nautilus-drag.c: add new scroll calculation fucntion.
      	(nautilus_drag_autoscroll_calculate_delta):
      	* libnautilus-extensions/nautilus-drag.h: add decalrtion of scroll function
      	plus bits and pieces of constants used everywhere.
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(auto_scroll_timeout_callback): move this to the shared version of the scroll
      	* libnautilus-extensions/nautilus-list.c: implement auto scrolling.
      	(nautilus_list_drag_leave), (nautilus_list_real_scroll),
      	(auto_scroll_timeout_callback), (nautilus_list_start_auto_scroll),
      	(nautilus_list_stop_auto_scroll), (nautilus_list_drag_motion):
      ec647092
    • Mathieu Lacage's avatar
      First work toward bug 2353, fixes bug 2570, 1289 · 0f1d07d9
      Mathieu Lacage authored
      2000-09-07  Mathieu Lacage  <mathieu@eazel.com>
      
      	First work toward bug 2353, fixes bug 2570, 1289
      
      	* components/tree/nautilus-tree-view.c: fix a dnd bug in
      	gtk_drag_dest_set.
      	* libnautilus-extensions/nautilus-drag.c: (nautilus_drag_init):
      	initialize the new field drop_occured to FALSE.
      	* libnautilus-extensions/nautilus-drag.h: new field drop_occured.
      	* libnautilus-extensions/nautilus-icon-dnd.c: use the new field
      	and make it behave slightly more sanely by doing actual actions
      	in data_received instead of drag_drop. This is the only way to avoid
      	race conditions. (drag_data_received_callback), (drag_motion_callback),
      	(drag_drop_callback)
      	* libnautilus-extensions/nautilus-list.c:
      	(nautilus_list_initialize_class), (nautilus_list_dnd_initialize),
      	(nautilus_list_initialize), (nautilus_list_drag_start),
      	(nautilus_list_ensure_drag_data), (nautilus_list_drag_begin),
      	(nautilus_list_drag_end), (nautilus_list_drag_leave),
      	(nautilus_list_find_drop_target), (nautilus_list_get_drop_action),
      	(nautilus_list_drag_motion), (nautilus_list_drag_drop),
      	(nautilus_list_drag_data_received):
      	add support for the drop_occured field, fix the same bug as in tree view
      	and make it behave slightly more sanely as in icon view.
      	The tree view now needs some work to catch up with all those changes.
      	* src/file-manager/fm-list-view.c: (fm_list_handle_dropped_icons):
      	space.
      0f1d07d9
  27. 28 Aug, 2000 1 commit
    • John Sullivan's avatar
      Added more bug numbers to FIXMEs. 94 to go. · 8bc0bad7
      John Sullivan authored
      	* libnautilus-extensions/nautilus-icon-canvas-item.c: (map_pixbuf),
      	(draw_label_text_aa), (nautilus_icon_canvas_item_event):
      	* libnautilus-extensions/nautilus-icon-container.c: (icon_free),
      	(get_all_icon_bounds), (lay_down_icons_tblr), (lay_down_icons),
      	(nautilus_icon_container_move_icon), (stop_rubberbanding),
      	(destroy), (hide_rename_widget):
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(nautilus_icon_container_dropped_icon_feedback),
      	(receive_dropped_keyword), (auto_scroll_timeout_callback),
      	(nautilus_icon_container_find_drop_target),
      	(nautilus_icon_dnd_update_drop_target), (nautilus_icon_dnd_fini):
      	* libnautilus-extensions/nautilus-link-set.c: (link_set_path_name),
      	(expand_uri):
      	* libnautilus-extensions/nautilus-link.c:
      	(nautilus_link_get_root_property),
      	(nautilus_link_get_additional_text), (make_local_path),
      	(nautilus_link_get_image_uri), (nautilus_link_get_link_uri),
      	(nautilus_link_get_link_type):
      	* src/nautilus-sidebar-title.c:
      	(nautilus_sidebar_title_select_text_color), (update_font),
      	(update_title), (update_more_info), (update_emblems),
      	(update_notes):
      8bc0bad7
  28. 23 Aug, 2000 2 commits
    • John Sullivan's avatar
      Checked in this patch from Ken Kocienda, which fixes · 16d1c8c7
      John Sullivan authored
      	bug 390 (wrong magic number used when computing alpha
      	threshhold). Thanks Ken!
      
      	* libnautilus-extensions/nautilus-gdk-pixbuf-extensions.h:
      	New #define for NAUTILUS_STANDARD_ALPHA_THRESHHOLD
      
      	* components/music/nautilus-music-view.c:
      	(nautilus_music_view_update_from_uri):
      	* libnautilus-extensions/nautilus-bookmark.c:
      	(nautilus_bookmark_get_pixmap_and_mask):
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(nautilus_icon_dnd_begin_drag):
      	* libnautilus-extensions/nautilus-icon-factory.c:
      	(nautilus_icon_factory_get_pixmap_and_mask_for_file):
      	* libnautilus-extensions/nautilus-list-column-title.c:
      	(load_up_indicator):
      	* libnautilus-extensions/nautilus-list.c: (draw_cell):
      	* src/file-manager/fm-properties-window.c:
      	(get_pixmap_and_mask_for_properties_window),
      	(create_image_widget_for_emblem):
      	* src/nautilus-bookmarks-window.c:
      	* src/nautilus-complex-search-bar.c:
      	(load_find_them_pixmap_widget):
      	* src/nautilus-property-browser.c: (set_emblem_...
      16d1c8c7
    • Gene Z. Ragan's avatar
      Work in progress to support dragging onto NautilusLink files. Dragging on · 3184fe2b
      Gene Z. Ragan authored
      2000-08-22  Gene Z. Ragan  <gzr@eazel.com>
      
      	Work in progress to support dragging onto
      	NautilusLink files.  Dragging on the trash
      	still does not work.
      
      	* libnautilus-extensions/nautilus-icon-container.c:
      	* libnautilus-extensions/nautilus-icon-container.h:
      	(nautilus_icon_container_initialize_class),
      	(nautilus_icon_container_get_icon_uri),
      	(nautilus_icon_container_get_icon_drop_target_uri):
      	New signal to return the target URI of a drag target.
      	This was done to support dragging onto NautilyusLink files.
      
      	* libnautilus-extensions/nautilus-drag.c:
      	(nautilus_drag_can_accept_item):
      	Add call to nautilus_icon_container_get_icon_drop_target_uri
      	and remove call to nautilus_icon_container_get_icon_uri
      
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	* libnautilus-extensions/nautilus-icon-private.h:
      	(nautilus_icon_container_find_drop_target):
      	Some code cleanup to fix a leak.
      
      	* libnautilus-extensions/nautilus-link.c:
      	* libnautilus-extensions/nautilus-link.h:
      	(nautilus_link_can_accept_drag):
      	New function that currently return TRUE for all links.
      
      	* src/file-manager/fm-icon-view.c: (get_icon_uri_callback),
      	(get_icon_drop_target_uri_callback), (create_icon_container):
      	Connect to new signal and add implementation.
      3184fe2b
  29. 17 Aug, 2000 2 commits
    • Andy Hertzfeld's avatar
      implemented task 2078, we need a better drag and drop based way to delete · bdb1a8e7
      Andy Hertzfeld authored
      
      	implemented task 2078, we need a better drag and drop based way
      	to delete emblems, by adding a special "erase" emblem and adding
      	code to special-case it to delete the emblems.
      bdb1a8e7
    • Gene Z. Ragan's avatar
      Fixed bug 2197, moving a file to trash while in renaming mode leaves · 56de1e56
      Gene Z. Ragan authored
      2000-08-16  Gene Z. Ragan  <gzr@eazel.com>
      
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(icon_toggle_selected), (icon_destroy),
      	(nautilus_icon_container_remove):
      	Fixed bug 2197, moving a file to trash while in renaming mode
      	leaves renaiming item behind.
      	Call end_renaming_mode in nautilus_icon_container_remove.
      
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(nautilus_icon_container_free_drag_data):
      	Changed gtk_object_unref call to gtk_object_destroy to
      	fix a crash.  Hopefully this didn't
      	introduce a memory leak.
      56de1e56
  30. 16 Aug, 2000 1 commit
    • Darin Adler's avatar
      More of the implementation of all the trash functions. About 1/3 done now. · 95b6ad0c
      Darin Adler authored
      	* libnautilus-extensions/nautilus-trash-directory.c:
      	(nautilus_trash_directory_initialize), (trash_destroy),
      	(callback_hash), (callback_equal), (trash_contains_file),
      	(call_when_ready_state_destroy),
      	(call_when_ready_state_check_done), (directory_ready_callback),
      	(trash_call_when_ready), (trash_cancel_callback),
      	(trash_files_callback), (trash_file_monitor_add),
      	(trash_file_monitor_remove), (trash_are_all_files_seen),
      	(trash_is_not_empty): More of the implementation of all the
      	trash functions. About 1/3 done now.
      
      	* libnautilus-extensions/nautilus-icon-dnd.c:
      	(nautilus_icon_container_free_drag_data):
      	Use gtk_object_unref so it really gets rid of the object
      	instead of gtk_object_destroy that doesn't free it.
      
      	* libnautilus-extensions/nautilus-list.c: Reformatting.
      
      	* libnautilus/nautilus-zoomable.c:
      	(impl_Nautilus_Zoomable_zoom_out),
      	(impl_Nautilus_Zoomable_zoom_to_fit),
      	(impl_Nautilus_Zoomable__destroy),
      	(impl_Nautilus_Zoomable__create),
      	(nautilus_zoomable_initialize_class):
      	Clean out some old cruft. More cleanup needed.
      
      	* src/file-manager/fm-directory-view.c:
      	(text_attribute_names_changed_callback),
      	(embedded_text_policy_changed_callback),
      	(image_display_policy_changed_callback),
      	(directory_view_font_family_changed_callback),
      	(click_policy_changed_callback),
      	(anti_aliased_mode_changed_callback),
      	(fm_directory_view_bump_zoom_level),
      	(fm_directory_view_zoom_to_level),
      	(fm_directory_view_restore_default_zoom_level),
      	(fm_directory_view_can_zoom_in), (fm_directory_view_can_zoom_out),
      	(fm_directory_view_get_background_widget),
      	(fm_directory_view_get_selection): Use NAUTILUS_CALL_VIRTUAL.
      	(fm_directory_can_move_to_trash): Fix handling of NULL directory.
      	(new_folder_rename_later),
      	(fm_directory_view_get_emblem_names_to_exclude),
      	(fm_directory_view_merge_menus), (fm_directory_view_select_all),
      	(fm_directory_view_set_selection),
      	(fm_directory_view_supports_properties),
      	(fm_directory_view_update_menus): Use NAUTILUS_CALL_VIRTUAL.
      	(fm_directory_view_get_uri): Handle NULL directory.
      
      	* src/file-manager/fm-icon-view.c:
      	(fm_icon_view_get_directory_sort_by),
      	(fm_icon_view_set_directory_sort_by),
      	(fm_icon_view_get_directory_sort_reversed),
      	(fm_icon_view_set_directory_sort_reversed),
      	(fm_icon_view_get_directory_auto_layout),
      	(fm_icon_view_set_directory_auto_layout):
      	Use NAUTILUS_CALL_VIRTUAL.
      
      	* src/file-manager/fm-list-view.c: (fm_list_view_adding_file),
      	(fm_list_view_removing_file), (fm_list_view_file_still_belongs),
      	(get_number_of_columns), (get_link_column),
      	(get_default_sort_attribute), (get_column_specification):
      	Use NAUTILUS_CALL_VIRTUAL.
      
      	* src/nautilus-navigation-bar.c:
      	(nautilus_navigation_bar_get_location),
      	(nautilus_navigation_bar_set_location):
      	Use NAUTILUS_CALL_VIRTUAL.
      
      	* src/nautilus-view-frame-corba.c:
      	(impl_Nautilus_ViewFrame__destroy):
      	* src/nautilus-zoomable-frame-corba.c:
      	(impl_Nautilus_ZoomableFrame__destroy),
      	(impl_Nautilus_ZoomableFrame__create):
      	Remove some unused code.
      95b6ad0c
  31. 07 Aug, 2000 1 commit
    • John Sullivan's avatar
      Fixed bug 1422 (dropping an icon at the edge doesn't update · 45bdc495
      John Sullivan authored
      	the scrollable area)
      
      	Start of bug 1969 (search controls need to adjust sensitivity
      	appropriately)
      
      	* libnautilus-extensions/nautilus-icon-container.c:
      	(nautilus_icon_container_update_scroll_region): Renamed from
      	"update_scroll_region" since it's now in a header file.
      	(relayout), (nautilus_icon_container_clear): Updated for name change.
      	(nautilus_icon_container_move_icon): Added FIXME about how
      	update_scroll_region is handled at different levels at Darin's
      	request.
      	* libnautilus-extensions/nautilus-icon-private.h:
      	Put prototype for nautilus_icon_container_update_scroll_region
      	here so it could be called from drag-and-drop code.
      	* libnautilus-extensions/nautilus-icon-dnd.c: (handle_local_move):
      	Update scroll region after drag.
      
      	* src/nautilus-complex-search-bar.c:
      	(update_options_buttons_state): New function, updates the sensitivity
      	of "Fewer Choices" button based on number of displayed criteria. Later
      	it will also handle "More Choices" button and perhaps others.
      	(nautilus_complex_search_bar_initialize):
      	Call update_options_button_state after creating button widgets.
      	(more_options_callback), (fewer_options_callback): Call
      	update_options_button_state when number of criteria changes.
      45bdc495